From nobody Sun Jun 14 23:00:24 2026 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F4BC3191BB for ; Mon, 6 Apr 2026 23:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519272; cv=none; b=rqszImM+OMu8wDjYLRTF9gX3AIoaMAtdFBu0uT0UxdcDXfkrT8YLFG/YmPznEMEOimSJLRWbAwTqgLfPAErw1rEVTPtaz5xqOGu+tbIojw3RaFJMTPyPmnkv4VDvYUlsTg8T5K/ue39PvawDOXBqkgo9chLKLixIPuhjHxwm+Iw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519272; c=relaxed/simple; bh=ZrPPXo/ApIPPC+cqw2mGR6rvX9gdyDuvfG7CLYkJ1v4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kOKEz6V05hNLFFCoO4U6GtWY1TkMQcOkCKmY7M7F1X7b0kXYNaXpegqb6z/zIQhoH6j4xM9io12N1YcwhiHRnI/Q+64tuLuleZ0MqDn0RpUIQMmfrVjNPBMb3J/hDLbLXMAObK1+gs55RRDyKOhmJTZv2wkk2dr2hffnlwem5kw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cTDPZoNm; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cTDPZoNm" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-7947cf097c1so40250247b3.2 for ; Mon, 06 Apr 2026 16:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775519270; x=1776124070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fGFKokrs+E6BpbQjbbjTYkzD/AIdw/D6owYfFXIKI2o=; b=cTDPZoNmtqr9WrAG9foxM27jbmQx9Vh+nwkcUqlkzjUAR/G+ti9qXFG3m5d4zdQHBD pCAR5ouLtM37o8zB+wvmR7DNyVR+0ytFRXCAGswOa4S+5b9gIrzsBj8xfxsnHd65slii PA52aouF2nLPxewK8qzLeA8FdD6n8LmTW3rUZxOmCq0wLxwDlehmNnjo1a2VVv00p5Gf COY/Cy0LBPIoBlOodlq8cOFZ25HI4/oqhkjITb7NEsmDCA5bnQiwJVLNt/bwASj+3Jvs b6jE+KvryQBVmdzq8XHelXIfT5JiB/NC6r5nND2/GXp+0634SKuSDZAFvx6oDg6orusx RhcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775519270; x=1776124070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fGFKokrs+E6BpbQjbbjTYkzD/AIdw/D6owYfFXIKI2o=; b=SltFTQZlM+6WJ2mClqizLuu+8y06DFp6jy3AXnh12Sv1/kmeE4I0eHSFRYmvdQPEIC wCr9QiTU0jOqpK167wWTcsPcylowJu7sZ9rD7uQ/+w1VwHdUv9l+D0dkkFdHGxI6IfiQ m3MCjSps5QZ9bSbDo5ACrH3C5itytCK5r+l8/PDIV/AQnlX1TAVDBp3muJGPtksyKdoQ q929jxl3PXbh5/ocQ7wQKp4nKY8rScygSD68bOP0ti0Csv8+vVA5xo9+vqR/YzD+iH+N K/DFxRnxigRzrdXl9o3kLPgaZTE0D/y97iVu2ruRI4VXUSdrdw9bMQNyjyvVrP33bWHo Y/dQ== X-Forwarded-Encrypted: i=1; AJvYcCUnPPlNi+dwL3ZMTUMSK1E4woCpqqCXyIaLgRCfsTFHDBngx/iCGWUtB6b9Z/0qCmVMf47uWTdJBWQ3tL4=@vger.kernel.org X-Gm-Message-State: AOJu0YzSzEui119reb2nlbJHeQDof/jfN/WvUtf1ws902Wo8mNy+tQcY WIhxtseYpmZIgmnoz0t2TjOmkvMJwHYmI9u7pYA6xRwgJyudapJha6Kd X-Gm-Gg: AeBDievSc+s0209y5o/49by6uyS2g8RUnOmgMoKKkyt8yY3wAeheJvzHgpy2RBJORKD jgM4T1R5yKELLQczj+/10KxZFyWPI2JeNhFfGCvPdj/wiGH3ubI56FlGs05J5gzokawt7Q6cC/c AP1FopyjKCszJ7fskJ4u+rlwf5eXjsWCrbsXRn6RTGHcwKJ2ufWwxni7bXNEaaMVZSJXHmoi/mq 0PatSr5sunjGPdQJbUpD2Rca9Y0M2KX+7B7SCLLZIawnA2MdyOznyZe/qInVZSB/DEuqbil0O8C m944GPJ3Pie0cPSbbZVJxUtErOKp8GvbCPLaLSQkKsc7dDjdJIX+NKXsOyTa/b/JCX56OOfoPCu x3EQnce68UjFejiAfkCmA1ErXdpjlLu7z0t7mUfQ113O3fUS6dQ2vHu9C9vNUOACAwrvDY+/MdS sNARYJprP+5KrgKuBYVdXqYnjcDhCp4dtjFsY/Hf9emKY00aDynAJwWLI8gEDS X-Received: by 2002:a05:690c:9:b0:79a:b983:b44f with SMTP id 00721157ae682-7a4d31e86d5mr152606447b3.5.1775519270045; Mon, 06 Apr 2026 16:47:50 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a36e42ff31sm59350177b3.6.2026.04.06.16.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:47:49 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 1/4] wifi: mt76: mt7915: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 19:47:36 -0400 Message-ID: <20260406234739.29926-2-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234739.29926-1-joshuaklinesmith@gmail.com> References: <20260406234739.29926-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chips= ets") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/= wireless/mediatek/mt76/mt7915/mac.c index 1c0d310146..946d2bd0d9 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c @@ -221,7 +221,7 @@ static void mt7915_mac_sta_poll(struct mt7915_dev *dev) rssi[0] =3D to_rssi(GENMASK(7, 0), val); rssi[1] =3D to_rssi(GENMASK(15, 8), val); rssi[2] =3D to_rssi(GENMASK(23, 16), val); - rssi[3] =3D to_rssi(GENMASK(31, 14), val); + rssi[3] =3D to_rssi(GENMASK(31, 24), val); =20 msta->ack_signal =3D mt76_rx_signal(msta->vif->phy->mt76->antenna_mask, rssi); --=20 2.43.0 From nobody Sun Jun 14 23:00:24 2026 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF61D39FCA9 for ; Mon, 6 Apr 2026 23:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519273; cv=none; b=mzXT051xeg97xHjJcq50WCxuojOAc55vWhum/teoKCP6X2QlK4shDM9LsVpq3sBpua2bJydfQwxKHTYTnQ4tIXHmJRZ0uODv9yLzKmwjqHXbnZ5i2PBgi9v68H8JAkpHfM+iWrk0TyUq0YQeqteMTKa3c/q3Dht4qZxbrN0xAhA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519273; c=relaxed/simple; bh=TAPzuaW5AlDW+othVr5o2bBlmoV+im03JSrJdzDaQdQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T+UhxWC1VTPOdOrgn/CJr1mcn8RipaE3s/zYfKf9RHizU5kGMxZcshlUAhRRcswKQ3stXgOE3ULfP5idZPvv8PO/SdFHCzcYi/p6hQ9WTgOJay01y334YvUnHif8MQgFyDb/nCq1l6g+11GIOb7nz/bu1ZDIDXAhUsWnWD0hla4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LFrRhbD3; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFrRhbD3" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-79a535e7c00so44659887b3.3 for ; Mon, 06 Apr 2026 16:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775519271; x=1776124071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=daA/SDL/He3KnWtFLBF284CvHqGYJ/f/DA6iaNDSago=; b=LFrRhbD3p0hKZVKABNG0HVt4/RyIlg+r6iXfBw9k74L81a0bXfkQ0Pbz4CSUZVzeSJ cgEBBtfjOLj3nuDI3aV48LUylGLOZuDzZyDuXBt9rOmRsWQYt03P1vHKsdWdiEZTI4i5 jN7JGH9Qr3V3+M8yJSzEQZ/nmzw+itHgEBKsaDqPsqSd+JFCRwbX9EJeNJ6R/dqQeh49 hOgeer5KEmXgVF/sT3hiVbfUbTq7VsSzlkkAXwpRRrOgNUUOs0rTXTlD8owdtq96NflY xSNWNO88nO39lmYb/3YoDg2+26fq8+bfmVCBLxYeGOkxRjXsZGABl0y5o3CnI6uWkAsC K9ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775519271; x=1776124071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=daA/SDL/He3KnWtFLBF284CvHqGYJ/f/DA6iaNDSago=; b=qielbysWqw0PH4eW6K2kIAkCkozw/6zzIUKw7NCQ5/9got/II/pi2tquOVxrFiWs6l 4xvt3CyH0YNQ7boik3MZhA3mVFSlsYNLBakQcSolRDSEKU2qeoLnzMm42iYmrqB425LP YxMb27zx4YT3CxKx9o/oHKWDJ9lCLxVXLT+hVNdgSLDNsh19HjiDukAIh/8GgPIy3b00 ofWS6Steu1yuo00u1ETkPn/kSFbczLsUVYiqF8xWj9w3WhJ/avzHETODf/6hE11a9pJn loEDO3TWFGznyTYNx62yMfryQu/p1TsbPOX6Mylhq/Z0XbmyeHtI9vnelKLSZUO2JeNq C97w== X-Forwarded-Encrypted: i=1; AJvYcCWhRIVTDXV3NiOx4f0ycv9Dm+oGojVFFC3XeB1R7u9WIw9Gxs0GWGCZtobgMHF4fml1tDslr/YVze2l7Ek=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3QkDGXAolZUd2ANrIga7DHzKrSO2h4ZGiCh8xauEZEh3jQ7LZ rfbscAgN921MT9VhUFF5FGPLSlxtYMAM3Z1isQgB/u/iYWKCYeTLUZej X-Gm-Gg: AeBDietb5HVWznve+WtgqxyNG6KAXV8zNxnS1TfaXcwxPzcX46i1QWAeYfTcwS0r/VZ FDcL025ggW7ua9Fq64FXHmN82XI8/eqJsNJI2/EBzV3j4mGYKs/F92MeRTz/FbFU3q0oQEZNBkk NWv2OiBt8TfIbNZ8dmX9lSZ8mQoMTpkiO4EI9qfnNY/KjKpKDWIiiWt8p0mD1U+/salPzeCujsC PJnxkSjgS9SSxOyIp9vmpG23BrXgE6GaXAQ5Fo5hgywqDtEdhpNyS7bI02bdOE+GVZtoWlrsQYz IGbBPN3fb5qUCo79M63WsWwicG4TehXHDldj2ZhQgMkTWbAcodBZkOyLp7IsfWD9uxrAAG1RKV4 CmaEHWhAU5IULkDG264KAuhCObgxmLDiokeOosDU4JArjtLyoanjaH9kVk2wHDzioBMEqK2x5PA Ag+c1gSO6YEHM/t4Q+hBH8FknHnjr5j4TgIlEq596vjQGALkNtBLr35J6Y2K/O X-Received: by 2002:a05:690c:498f:b0:7aa:451d:bf9f with SMTP id 00721157ae682-7aa451dc2c2mr16718657b3.5.1775519270856; Mon, 06 Apr 2026 16:47:50 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a36e42ff31sm59350177b3.6.2026.04.06.16.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:47:50 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 2/4] wifi: mt76: mt7996: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 19:47:37 -0400 Message-ID: <20260406234739.29926-3-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234739.29926-1-joshuaklinesmith@gmail.com> References: <20260406234739.29926-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (= 802.11be) devices") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7996/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c b/drivers/net/= wireless/mediatek/mt76/mt7996/mac.c index ca2305ea7c..ab47118fb1 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c @@ -205,7 +205,7 @@ static void mt7996_mac_sta_poll(struct mt7996_dev *dev) rssi[0] =3D to_rssi(GENMASK(7, 0), val); rssi[1] =3D to_rssi(GENMASK(15, 8), val); rssi[2] =3D to_rssi(GENMASK(23, 16), val); - rssi[3] =3D to_rssi(GENMASK(31, 14), val); + rssi[3] =3D to_rssi(GENMASK(31, 24), val); =20 mlink =3D rcu_dereference(msta->vif->mt76.link[wcid->link_id]); if (mlink) { --=20 2.43.0 From nobody Sun Jun 14 23:00:24 2026 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C2773A2540 for ; Mon, 6 Apr 2026 23:47:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519274; cv=none; b=lOKvN8YCta1yV7beeeRAGDsdxCy73dk9VnmqVnogKIYaVmiPndnnlCW/7xGc6dtKONalLduyX7v0g8LhvAnTtaNQLnxdpk3CCWGacqImLTOnUkLAlEDlfkcQ+EKHCtNmE4qn76rux+ZMIu1Vf0EHE7bpZGN7OXceR7ZrsScTnX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519274; c=relaxed/simple; bh=jcpF1sZHHWf1OwVn8dXWeZm3vgEO/wJOncyayRAHT1Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a9ZCG8zfthy/LpaXaKezHRRrq7WtcPjw9jBZz+CCCGt9dq6rk4QC1iqp9y6hByb83eGWYJIcUdtEuksFZnOw3TJr4AxI3jarzS91PEB3ogLdON/WAU0WogK/9FSfTRrXuSiMoenhRZsVEXrHzyXpA2faoCn1VK0YmSVN44D7pDw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RUp2rByL; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RUp2rByL" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-7947cf097c1so40250497b3.2 for ; Mon, 06 Apr 2026 16:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775519272; x=1776124072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YxwuaqOVriBYwsFBn6+xbKIu8945UDO3QfFnEekL/38=; b=RUp2rByL4R8G3w/V5XAQ0swoRqwik/amTIZppvp1RKdPgIO6tf1OnaKByMLKvgK7Zj h8vOmmv0ewhDiu1LDe3Nn4uMuhdYEcT+Ob++vkHqlpRCi0oHGTj31YpgxcWxFXqsSYn5 3rZ16Z4FCUX2tHsEQvx888r5yrHwTTO1pIuqkjXHAZdplhhHtHv6WgmhDLEIRH42yyM4 ROzesdenmvnCPCHXIt6R+dpPR+atugmizWz2E/D6+JEjwJT6A1PyDCMt8SLNoPI4GmM3 6eRCR/6ytYkqeijYDUcEx+7FP1fsaPDmhMbASd3gJ0WYiiAldam+AOnDu+87F0aXEFnG n1TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775519272; x=1776124072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YxwuaqOVriBYwsFBn6+xbKIu8945UDO3QfFnEekL/38=; b=AR3Bk4W/3lsRhc2Xxpy2YzxSVK0s2QkT6RHnUhXTs3/eeHYRV8ePBzyGQhTbUOyca9 JzVnsB7eIaJjzdfSVc4ihCiffzgDks/xid/hSF/dmvWeEI4w1G2GrEJYmv2KKPVqvcKD bGfiD47pvha91Bz7/qMzynhbI5kezMRz76yHINCfWLJL8u7t+WMSsKsuQ3lqLEMU7g2A p7jOwVSs5jMAjTO0vVa5M7PLgYwZIo9G7Y76cIv1VoRAn45GGGf6HiCotVN2ZFMSe8RW dFgWLW6+M2pUATYzp0aO9SObJoF6edBwghrul4F4dpiYfok4I18KRdT+JsyzVVeSTL56 EtHw== X-Forwarded-Encrypted: i=1; AJvYcCXXky9aGEoy8fgmEvM1YSN2kEzF/sAT+k87tR+5OHP5br+RDylpjOVIPhYXhHbWHo07FnugtGr/Gu+b0BY=@vger.kernel.org X-Gm-Message-State: AOJu0YzlRIl/Ux1gHjedz3jvIycSk+xTYa1uRGRH0An4JvemRTxAdgIm 6BPuSksjWGZN5v0qcH7SgKf2uXlJvWdTyYqycep8Y+qJJ3bAQrjirel9 X-Gm-Gg: AeBDiesEziADf4qQLyp5alEv/U4JMka4BkEuT4fa9sUr8vnW1uCIDdLmdfkNLq6mexy BPda6CrzV59BFas4Qk2GUPCk7n9atU1DduB+L/LSPBge2f+dOaTfcnS7KSPm/ScazPVKzQM0KqU Xpppaug9l/ozw5yF4/E+azCPtVS+thEAy5DLI9dT/hI9treNnfNzmR7F1jNvle30Jkg7Jw9V6Dc MuDnX0gbyfeiIm7+3yp8/nH4Gv/9MzHoIaQfMV94BPqUOW8iUn7Yv2A/tshxNBFawL3xDDq6S42 Ch9IrZjUcf4KB25EnodeeOKL2wIRcj7puuF6jZEqCreV+ADSZAeFxT+lHlp0E6j8cZLI9yUTW7Y nDWvmrf7W/cIkgzwLJ6bvypTNB7rG/yJrZzyO5uoVIv1XK5NpjDkFCKT2KA6qRpLXJ/jGgE5iov RrtgkgIpae1k2POWS8r2KpuZDZfUXKsiqWeD/b4gFDHEuRMFEscnuPATvncjw8 X-Received: by 2002:a05:690c:e3e8:b0:79a:ac83:ac84 with SMTP id 00721157ae682-7a4d5d5aeb7mr151996137b3.41.1775519272091; Mon, 06 Apr 2026 16:47:52 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a36e42ff31sm59350177b3.6.2026.04.06.16.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:47:51 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 3/4] wifi: mt76: mt7921: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 19:47:38 -0400 Message-ID: <20260406234739.29926-4-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234739.29926-1-joshuaklinesmith@gmail.com> References: <20260406234739.29926-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: 163f4d22c118 ("mt76: mt7921: add MAC support") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/= wireless/mediatek/mt76/mt7921/mac.c index bce26389ab..7a46b50171 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c @@ -155,7 +155,7 @@ static void mt7921_mac_sta_poll(struct mt792x_dev *dev) rssi[0] =3D to_rssi(GENMASK(7, 0), val); rssi[1] =3D to_rssi(GENMASK(15, 8), val); rssi[2] =3D to_rssi(GENMASK(23, 16), val); - rssi[3] =3D to_rssi(GENMASK(31, 14), val); + rssi[3] =3D to_rssi(GENMASK(31, 24), val); =20 mlink->ack_signal =3D mt76_rx_signal(msta->vif->phy->mt76->antenna_mask, rssi); --=20 2.43.0 From nobody Sun Jun 14 23:00:24 2026 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 726CE3A1687 for ; Mon, 6 Apr 2026 23:47:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519275; cv=none; b=P8MB5priopmofln1HNOtzsUO/ApftN7JxCkuRCc/UL54mM9bH8t9cf0XbRb4vwyzIa07BP3ayQzmoxhX2w593VffXbxctR43crB5cJyJXDByiBqZTOMpUGENiH/zWRy5RLbHl/gfFx1gLR25J7R5mFalKWUKGXdN8pesxatiTlk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519275; c=relaxed/simple; bh=ypYe838aBMkoRP5LrhnDA0C7q+59eJdK7nUE9OS0I+c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZwL+rZuJ9TPTPFlTwrNQaQTznH0Tf9PBz2gU6GwMALEajK/1/JLANqvaxQbPDExQ4korHrxPGbAR3i49psUgVZfb3umwfMBxuEsZh/8m9ZyZD1yX84rJJ6aBcmMjqAsn4myov+9YgMDIF+YiD7aCY/YSVlrCpisySsL+/ZsTlAI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WIhHXCIk; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WIhHXCIk" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-7991db3dc98so46956967b3.0 for ; Mon, 06 Apr 2026 16:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775519273; x=1776124073; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8KdrZYGFBLENkuuWfE8lxm9EDeQduu0FD0OZSAlkc/o=; b=WIhHXCIk2e7SGemfPLwSnwlbK46OFp561NMIx8VZunNfeHMvk7YzVnfXMQtfzkom1F c6DsqrNHVH0/w4wW9YdJauZNw7dMnu0LqgAxjVIr2yyji5t+xdrkjBg9dxdO2oLnWTMD vt+EAxE+VOCrCTLj8BAAG50e+8WMvZSY6o8+z2sudFs+PCPY517Wn88hUZ/mD3eA34xR VW55YMEv5msNz8LUP4dw6afKq7eHKpNb759AdOzwDMTxXsROzPDDLnGYlCxtA1vtHOgf uI+4nflQUbso8Xnrk2bHNPM0816a0US5gi3lOh3m444EWM6ohgGsvgmk75eTXXMiLe1e vY6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775519273; x=1776124073; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8KdrZYGFBLENkuuWfE8lxm9EDeQduu0FD0OZSAlkc/o=; b=WmqOqHq6L1e4TSPSIw7EBXix012mA2BRKj6MPCGCNTIHFAA6Yg5ol2P24j6AFAh+Xt zY3i8R4AjGVVs+AUEc1HsItGrepAm7txOmsR2rAozrDwkXZNBFyiatHP9m1Xaffi0qmW 9Vi14pz93mC8YPV+P7CtuqXNWHACttgrY6FN0eHUpxhvsMippP7h+YFTXr6+xHjWHoNG 6A9mJPftuDjI5w4c9zUTZvCqW6N+EcVcPlPhLEEvt0QbVEKwp/8PmqB/mGfObTu/B7Pb 5r2ULuQ2tqAg586fEvXOFL1ypmuSEVPyir+boVkdDtK+G+4ZzMRZxBxkE/KmFYLDvUOM r63w== X-Forwarded-Encrypted: i=1; AJvYcCX0kBt8ip+KccL5A89Y6lcsYoIjvfjmkjBKvlfIMKBVLT0n5yOLYxhYEAsdWnW04ytUTEVhifIIIyrQpo4=@vger.kernel.org X-Gm-Message-State: AOJu0YwvyKY0YDmkh6R7/y60+sBbrwWI+W11ob1ec+AE0I/ZAt5eK/Kc KP/s7COUxwZNodu8sHgGwKoKZB4wCsPNb8GUcFdgWT7L7aJhI31VrXxA X-Gm-Gg: AeBDieveeyZ17BJD18KOjZXT1o30o8jAibRYFTqPhOXxNt4KuJfWNp9GQkYVBskCaVS iRz15GMU9afRFEo/XxD+IrNQVomkUlOsjD6beCxAT5O13UzqU2lhWf+yyQjJ4vFPH1KOhR3oiBD Kb1KJ/6I4X0/FcPQ0L9va2kzRXVX5iNL+/eaJZcbmyCXCGD7RUBa7+vjBvIWRMJs/yjZQe43Dyr 6Z8oX2/7Yis+Rc7+jjdUP7wq7Ri8Kc+so7DNCsBIfGOYlPgDVYiLIjFbCwx4uZmmF2YAysfizSS QttKzWbGsccCz8+nr8M0s4PzOtkEvog4DciStEw/N5rFIm8GkcSRA9SXQRzCV8WnLIULYYRd9ia 3FfamkWNXTh8l0JJAHoeHtlibATEMo3XZMJYmeziz48oby1IqjiyDTsDAimTM3V8g1OEeLHFd8A SkJac1We8XGEUCWOgxc0ZZ73sHnReDchUjLn14+DQJP93cGP79W5wh4/xIv9pu X-Received: by 2002:a05:690c:e04f:b0:79a:c93f:4acb with SMTP id 00721157ae682-7a4d6449755mr121970347b3.54.1775519273502; Mon, 06 Apr 2026 16:47:53 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a36e42ff31sm59350177b3.6.2026.04.06.16.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:47:53 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 4/4] wifi: mt76: mt7925: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 19:47:39 -0400 Message-ID: <20260406234739.29926-5-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234739.29926-1-joshuaklinesmith@gmail.com> References: <20260406234739.29926-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: c948b5da6bbe ("wifi: mt76: mt7925: add Mediatek Wi-Fi7 driver for mt= 7925 chips") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7925/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mac.c b/drivers/net/= wireless/mediatek/mt76/mt7925/mac.c index 6334019249..85e91ca84f 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7925/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mac.c @@ -144,7 +144,7 @@ static void mt7925_mac_sta_poll(struct mt792x_dev *dev) rssi[0] =3D to_rssi(GENMASK(7, 0), val); rssi[1] =3D to_rssi(GENMASK(15, 8), val); rssi[2] =3D to_rssi(GENMASK(23, 16), val); - rssi[3] =3D to_rssi(GENMASK(31, 14), val); + rssi[3] =3D to_rssi(GENMASK(31, 24), val); =20 mlink->ack_signal =3D mt76_rx_signal(msta->vif->phy->mt76->antenna_mask, rssi); --=20 2.43.0