From nobody Sun Jun 14 22:59:53 2026 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA923331204 for ; Mon, 6 Apr 2026 23:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775518993; cv=none; b=vGEWWcI2AchjBu9EuhKCu3MM316hHbSEw3q2Z4+wpEYpICVZXuBIoISDEYuXMVJKM3Jcgu/F/qpwOwff48du4sPMQDgb5hBdFTMDXKqA09EoH2BT0SAS7zh7sIo68u3w5fKwM8atuYzU0fELXlEwtGCl0UJfjgkICe9XJzP2azE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775518993; c=relaxed/simple; bh=5AFQSaFmab0W60GDHchwkX6lsxFVStzDQSBUV0l8xYw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QOJIxm6MipBg5y3hL+aBYvKizw7SqnAC9QEPfCKcJJngRsatP798ZnpMvBhEFlBYpbmYk/eCVhRzRxGUlXbSyiV7fb6XM6p8W+ybh/rya1Dr91Vk+280jZpZBjCWRuwVrOcT5Ne/V9VbCEdynsowyS7XWxqzHZcJtddVhoKx+14= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MNJkitIb; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MNJkitIb" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-79d991c7b6aso39011607b3.2 for ; Mon, 06 Apr 2026 16:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775518991; x=1776123791; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XhhW2JtmFLuaeAr//pW9N+0QVOgFVlmDgosFHmJ4lDI=; b=MNJkitIbQPwTE7KE87sBkEbywAsqEbNN4ixjlHRGqEI7SoFYtl0PUmwAgXmX8L1L/3 gEPvr0Ep9MwyQkLSHkIELkdw76xcIDDqBpIYZDwawOAwq7NGtjL35Ls/pDPSBcY/yNe5 gxo0YVaQky2i3tQir7lOhdfR/psTbRe4O6N0mbbGcr/X+eSvJR0NZZKIgKt2o6uko6UJ 3Matr5juqyhcBP6ExBmOF/fEj0sUZSxgy6y+qCIDdCmUUS8gqy4Vbf2gnDBTFGZEklRr /DuIEtcVjYOAae+b/Pv2mu1Ha6gn++5WB3vAsFaTVnp7JfwwizySNPBh2JteF/qY5/ad ORgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775518991; x=1776123791; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XhhW2JtmFLuaeAr//pW9N+0QVOgFVlmDgosFHmJ4lDI=; b=sj3RtF0NIoUNWd1cw86JEttTpV59FrME52c6O2nkH9shypjukuhezeB8dQJheRCJhl jtx9WDF5PmHAO+vw+yyHBcCaRolpPnVpKU1/UwWrSU2v8jnhqoHp1+Q1uIZhptifpYin J900P3RjV2oB9c1fdDlKUgMdPKcZvQkwdMlnpayZXzrl1aODktrT5RSuLh7CrBacDMnu WScWn7GzkD+4uYIrC+otncWHjZ/0YwC0DpUm+ZMepMtMLGGUkLw+lJj10P2/G+Thd9qq bGqrBgCd6KtAx48qumwwMqhWfOdyZ+jexz8FGrYB5PXDfRUjsHK9N5LOWFAKhPumGWJ1 5rzQ== X-Forwarded-Encrypted: i=1; AJvYcCUzwAG3yA68j2bugxns5ELzJuMNrd2OLIn/oW5O9UCTzLOdFLaVz0cdnoAzji4NKG925C1Fajps8ci9fv8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywg8onwtp1yG/vkmfZ0CXytexQ4FFpvbH1F2x1aIWfzye+9NOrC 12tiGpIBwADP5BMytdQif7/IFcpUOZlEOdQQH131AIRWZPCrzrDjZC9R X-Gm-Gg: AeBDieudOB60kQiCwpeGeD3OFj9LLQHkmr0C+Rkf7D0RhjdAR2xsGPOmacuPxvvXDll M06jRhgCQSu2Zy9OIMpSpr2VaA44ZBo9mK5OsEW51fNkTucGr5h2JQcIErOli5QoL6C9uStRNI3 p/im1u11gVobZAiEACftvvVaQIp7DJRvMpU8tAOiv4Nl03o+OnjiUOWO/ki5x3gh3YGV5bQXOfl CYX8yYW7lyfYCQ6T2o9vWEI0++NAQG2s8q58H8NqSIX+FoM6ieBujYwIap8fBcosuB8UmIRdPSL CWzIyzMtNsnQBVYCDf34uIJok1TM9X+Oa2O0E2BO+e1tcMzhfl7EKJNgqpaT+2Cn4788seLv6Ue rjYopSE02L+ENL/z6uktOmLeUx7kSBu4ml+/O4vUIH5dOyZyA4vu1EcFe2NOVjnLtHaitQHAOaL rWXCZOdIM6NnHu8/dXXXUyEqLGus7qRpqBTE9PQkvjJsfbvrt4HEIWknIQOm3o X-Received: by 2002:a05:690c:e3ef:b0:79d:bb7:54da with SMTP id 00721157ae682-7a4d5d540bbmr156205827b3.41.1775518990749; Mon, 06 Apr 2026 16:43:10 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a370df16aasm59144037b3.40.2026.04.06.16.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:43:10 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 1/2] wifi: mt76: mt7915: clear cipher state on key removal for WED offload Date: Mon, 6 Apr 2026 19:42:03 -0400 Message-ID: <20260406234205.29857-2-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234205.29857-1-joshuaklinesmith@gmail.com> References: <20260406234205.29857-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When switching from WPA-PSK/SAE to open/no encryption, the DISABLE_KEY path never resets mvif->mt76.cipher back to zero. The stale cipher value is sent to the WA firmware via BSS_INFO updates, causing the firmware to keep the protection bit set on WED-offloaded packets. The hardware then drops all plaintext frames, resulting in zero throughput. Reset mvif->mt76.cipher to zero and notify the firmware via mt7915_mcu_add_bss_info() when the last group key is removed. Fixes: 3fd2dbd6a1d3 ("mt76: mt7915: update bss_info with cipher after setti= ng the group key") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7915/main.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net= /wireless/mediatek/mt76/mt7915/main.c index fe0639c14b..8d32729a58 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c @@ -414,7 +414,11 @@ static int mt7915_set_key(struct ieee80211_hw *hw, enu= m set_key_cmd cmd, } else { if (idx =3D=3D *wcid_keyidx) *wcid_keyidx =3D -1; - goto out; + + if (!sta && mvif->mt76.cipher) { + mvif->mt76.cipher =3D 0; + mt7915_mcu_add_bss_info(phy, vif, true); + } } =20 mt76_wcid_key_setup(&dev->mt76, wcid, key); @@ -486,10 +490,6 @@ static int mt7915_config(struct ieee80211_hw *hw, int = radio_idx, if (!enabled) { rxfilter |=3D MT_WF_RFCR_DROP_OTHER_UC; dev->monitor_mask &=3D ~BIT(band); - } else { - rxfilter &=3D ~MT_WF_RFCR_DROP_OTHER_UC; - dev->monitor_mask |=3D BIT(band); - } =20 mt76_rmw_field(dev, MT_DMA_DCR0(band), MT_DMA_DCR0_RXD_G5_EN, enabled); @@ -1166,10 +1166,6 @@ static void mt7915_sta_statistics(struct ieee80211_h= w *hw, if (txrate->legacy || txrate->flags) { if (txrate->legacy) { sinfo->txrate.legacy =3D txrate->legacy; - } else { - sinfo->txrate.mcs =3D txrate->mcs; - sinfo->txrate.nss =3D txrate->nss; - sinfo->txrate.bw =3D txrate->bw; sinfo->txrate.he_gi =3D txrate->he_gi; sinfo->txrate.he_dcm =3D txrate->he_dcm; sinfo->txrate.he_ru_alloc =3D txrate->he_ru_alloc; --=20 2.43.0 From nobody Sun Jun 14 22:59:53 2026 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA7A539FCDC for ; Mon, 6 Apr 2026 23:43:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775518994; cv=none; b=GR7UdMCxIayjFxm39r1bpmTccctFYTOFsRHi7Idzx5Oooc0wPzwJ+h5FDZXbDAB3scnI5jtHF1PVII3BDYwJ+eNu52UHPpvJbVft5HS9lXP0DX47GLoSfRPr0t+1Px5n1TQ7m/vMl+GchGK7TuZZwcNZSXuAMsrI/7H9kDQcI/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775518994; c=relaxed/simple; bh=ES5Wx77hnfPJwf+p4gTlHwl/GrAofS3FOUzFe1CqPcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dkoQpHpeAN9HhF+3NfW/srWgOab9qxRL20rW6K/2Z9/tNa8NE2s1hbqTSRUZl9XNyI24rcWVX/k80gSed+MXD19J4lmCJl9mQosiuujurm54pN5SxTnorzG1J8Qg/fUxSBDkVY5RinsLgrf1wfk06Y0jbBUC+nfs/SDOrFMEAQE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cuIR1AHV; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cuIR1AHV" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-79c20063a32so45958927b3.1 for ; Mon, 06 Apr 2026 16:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775518992; x=1776123792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gKiu2zHNYp38GBjq5TVo1PRhtRMef2XaxqRl1STw6Cw=; b=cuIR1AHV7jlKoDPYpneaTLQVxL/7yusEX+r4MM3kixSEpq5wgjjQLsxr1W3JrvbrwO G5KG7vNVIbEsGsDgkBU4sst1EkOiwWck9QB37LRh28iI99P2eoh35Q5jzIEs05kjxJCD ORaIsRXMifN3nwdYGcvowX4ijuvgO2EPNbaHqlEt1Z6Z2mB5HsgmqJh8I6iAtpvBaSF1 wIqbuF8oxl1KGPP4vooHxl08G5//R5M1AHvjPhU70GBELcF0dG6ot2T7Skds5YS5gq7A dRhQVllNapnvjIBZVurVLts/MLHNp9fAT/KgIT1OY5Y3djZZcnt8UW0ovZRoJOtWgYxj 5NJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775518992; x=1776123792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gKiu2zHNYp38GBjq5TVo1PRhtRMef2XaxqRl1STw6Cw=; b=TwKpSDvzv3iGWwqeCQ0WfMO9hHNd8pXQE1bKQJMgFz6HLQQ130L+TRp68pO6F70vp4 M4A1j/IWSG+HrMCfEkteLrCqvoVxoTwz2xkykoO2mM/+z3Fo5I7//y3j4Woqgr8dboTd 2k5Zu1W5W8DvVe6jQRp02dswcF1W0qrD4uZwCEQwSgTqooIKvjQrMf2HEanqdmoWwHBo zOushyHB5TVALztG+3AfcT8DH6maYtSkBVNio76dXf8wGNfkrKjAJWSo8vmpcm1QPNf7 +xtUipFjMytkMiTEJtB0kicuuMUmA/koJXHTLv2A9yu4r4xEAxeqwSOCiGNFhk0TZ9JV +kcQ== X-Forwarded-Encrypted: i=1; AJvYcCUBma6D7bLOXIRnjx87PD9ZejGNxzOVXz/H7/kXqrO7A5JlSCZd8gTf9P7H4NfAJhR4wkOfazJMLgnkffY=@vger.kernel.org X-Gm-Message-State: AOJu0YzvCnrEmX5E8aUCWDQt4bbczZSO5eRmPheZDuiuITV4ynKjw/gw 9QW1lL/II5GEGyh0gj6tHsdniY0tA3MOMXUa8Cv0M9kbfJzJOxMKVEZT X-Gm-Gg: AeBDietkMP0eDA60kYqZgl4xlsyvF/AR69DOUo1knVO8R4wjy1xWuoASWPcvNnZ7EhH qi3LktYaCxeMXtIdflMM3KnGpWIMU7KmmufG9Cfi1PFn9avq8bH3aFpIlwbtbCfNqNvoacdunKI GodVMd/5UGO14XKO219ygUAzIN0OaUVivoQksaXg9ROXT4KT3+yxyMdvt0qNFraHvQHFAV1o5Zj tu6VHG2AP0ryjV2nfqWBrTmQJTeFDDZxTQOu0ekL81Xy/zV5Wa9EekFQCiYzngf/niHhReyEOjo 8Y5xZDwxb7p0q84+yWyM/RrdghVn4F3FS3m/96hSq6vPsadnbzvRgD2652ZnHwaXs3qn+zKr85S p2GBb5u6gkgKP2fBbrO+hQCfBzWcNOAoN63u3RSq9mJokYJu0QFQu4Jzw31Dr+If3AgwFcIPDil VMWvUypv8YrKDKR9LCFUjBMA5iMuf35NKmlvQE7Y7WOUguf5HpQ4MfBvrcYoO8 X-Received: by 2002:a05:690c:9c0a:b0:79a:b409:b5e0 with SMTP id 00721157ae682-7a3b8501632mr147407187b3.0.1775518991760; Mon, 06 Apr 2026 16:43:11 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a370df16aasm59144037b3.40.2026.04.06.16.43.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:43:11 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 2/2] wifi: mt76: mt7996: clear cipher state on key removal for WED offload Date: Mon, 6 Apr 2026 19:42:04 -0400 Message-ID: <20260406234205.29857-3-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234205.29857-1-joshuaklinesmith@gmail.com> References: <20260406234205.29857-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Same issue as mt7915: link->mt76.cipher is set on key installation but never cleared on removal. The WA firmware retains the stale cipher in BSS_INFO, sets the protection bit on WED-offloaded frames, and drops all plaintext traffic when encryption is switched to open/none. Reset link->mt76.cipher to zero and call mt7996_mcu_add_bss_info() when the last group key is removed. Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (= 802.11be) devices") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7996/main.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/main.c b/drivers/net= /wireless/mediatek/mt76/mt7996/main.c index 84f731b387..bf5fda6925 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/main.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/main.c @@ -235,6 +235,21 @@ mt7996_set_hw_key(struct ieee80211_hw *hw, enum set_ke= y_cmd cmd, } else { if (idx =3D=3D *wcid_keyidx) *wcid_keyidx =3D -1; + + if (!sta && link->mt76.cipher) { + struct ieee80211_bss_conf *lc; + + lc =3D link_conf_dereference_protected(vif, + link_id); + if (!lc) + lc =3D &vif->bss_conf; + + link->mt76.cipher =3D 0; + mt7996_mcu_add_bss_info(link->phy, vif, lc, + &link->mt76, + msta_link, true); + } + continue; } =20 --=20 2.43.0