From nobody Tue Apr 7 07:50:44 2026 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3220D3314C2 for ; Mon, 6 Apr 2026 23:40:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775518808; cv=none; b=qQ6OEkGZcCYkPDJcOO4+/jJpcevrtQOs+40BxpHoNbIk1zRIeTxwCcDLsCxuV5ksrnSd50U6TnYl+aPA/8UGw1RwcRnS2kbdA1VFIFqZKnv6GOpn8W4OKoHkUNBv5R7T6LB3CZauE4U3zLd3gJ9X6LaAUkJSS7BJ0BUziaeZSDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775518808; c=relaxed/simple; bh=CWIkWtwpJeb4vHJFfC4PCEjDUMuaeBaM7uMpBBqmiGY=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=GtZFWADomT4g1cGWpJYWRMigydWN1iYiBGDtVkHHvrj18MXtdUF+qCgzW2vC2cMTPGmjv4TbLAr/3wQyCf3okJExn/Ui8gRS6KzxI/lDy+2gYFKrD8VP7wVbZFOFY26MNIlQf/POu3k58il/1w6D3WFTDESXEHsOznL3ISXeg4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=SKPywtaB; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--hramamurthy.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SKPywtaB" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2b2523e0299so113620925ad.3 for ; Mon, 06 Apr 2026 16:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775518806; x=1776123606; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=0BUO3CLc2gtSy2zH66hbdhPx8499IHw5WXw0lt20Nxg=; b=SKPywtaBp6QzXd60WcRm1nU40jxnxmNMlkpbwqS75hupo+Pnv/4PVrL+yOm0S4POb3 9jgMu1iDjlltZJO7RR4P67zpLCY/tFJUwxasPuZqH06OF65LpgybTe7uPTBMb2Bg4P8J yaMxaFWndOtZJiJNie928trflEySwNFwDYOhLGXzT0+H39qnhdmJQ9BcZUn51jRsFB/Z ZVNBsWzc94YIEgLainccW+KlIU8PFH3SVXlIO+QpIDBb76RFAiF5Evp8tKFI7BUlSjg/ JDsdDk+V9/0OvgEi6Lj1j925nmLdvyPMYOqsTVsunvU+02pkwxgldGEdD2G2ayuZukM+ P+eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775518806; x=1776123606; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0BUO3CLc2gtSy2zH66hbdhPx8499IHw5WXw0lt20Nxg=; b=ZoQ/Bacyg3rdkc5t8qpbdzZ6sBBrnlmipePp0FZ0ccN/0aH6LHYijUDvTDs7s2ls17 L6difHwe/EeIjHC0LO3WIKpzCib0ndscr8MNwWtlRHKv4SGRM+JOxCf4mCJofCQwU0/4 T3Yw4q0XpYKeGh0s1OWtMD86IV0hxeann6T3nbJBLTpHKRT933LNPcuGxK35FhPX8mrM dHyofzou6ZJm/KYcjUorksz7MXPCIc89/AY2RJ1JVL+lamVTBFdjUADvAl81DqiGLXZu 335scuD47Qfhg4kYM5Ou4K26HOwWWicFCUztJGMQ3smxdvlNLuYeuyE2QaTNHCCZWTc7 86pA== X-Forwarded-Encrypted: i=1; AJvYcCX+Od2MTrt2AwsIzEJNuoKCrNdME4zwC2TQbh4YkJ//QxQEVialrn+k4xTg5VxvDFRnP5WIOe0KKOiTRlQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmyn6X+5ZkjAff+KZKQ0hlDiLtrIseG/lVW3XKLjVo/mSC+NFt 3NQ2K866y+XBA6Mq5L3LG3ftnlzs4paz3qw5V29olbxkMjIQyLK3d14SF2p+WYNaqNBelqu8BJq ncv2LrBV813VILX2vNqog9L6dlw== X-Received: from pgbdp9.prod.google.com ([2002:a05:6a02:f09:b0:c73:bb62:5551]) (user=hramamurthy job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a20:b114:b0:39f:3559:7501 with SMTP id adf61e73a8af0-39f35597682mr9949018637.41.1775518806372; Mon, 06 Apr 2026 16:40:06 -0700 (PDT) Date: Mon, 6 Apr 2026 23:40:00 +0000 In-Reply-To: <20260406234002.3610542-1-hramamurthy@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260406234002.3610542-1-hramamurthy@google.com> X-Mailer: git-send-email 2.53.0.1213.gd9a14994de-goog Message-ID: <20260406234002.3610542-2-hramamurthy@google.com> Subject: [PATCH net-next v4 1/3] gve: skip error logging for retryable AdminQ commands From: Harshitha Ramamurthy To: netdev@vger.kernel.org Cc: joshwash@google.com, hramamurthy@google.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, willemb@google.com, nktgrg@google.com, jfraker@google.com, ziweixiao@google.com, maolson@google.com, thostet@google.com, jordanrhee@google.com, jefrogers@google.com, alok.a.tiwari@oracle.com, yyd@google.com, jacob.e.keller@intel.com, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jordan Rhee AdminQ commands may return -EAGAIN under certain transient conditions. These commands are intended to be retried by the driver, so logging a formal error to the system log is misleading and creates unnecessary noise. Modify the logging logic to skip the error message when the result is -EAGAIN, and move logging to dev_err_ratelimited() to avoid spamming the log. Reviewed-by: Joshua Washington Signed-off-by: Jordan Rhee Signed-off-by: Harshitha Ramamurthy --- Changes in v4: - call out change to dev_err_ratelimited() in the commit message (Jacob Kel= ler) - remove extra print when adminQ status is GVE_ADMINQ_COMMAND_UNSET (Jacob = Keller) --- drivers/net/ethernet/google/gve/gve_adminq.c | 27 +++++++++++++++----- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/google/gve/gve_adminq.c b/drivers/net/eth= ernet/google/gve/gve_adminq.c index 08587bf40ed4..a65b14835aa0 100644 --- a/drivers/net/ethernet/google/gve/gve_adminq.c +++ b/drivers/net/ethernet/google/gve/gve_adminq.c @@ -416,16 +416,10 @@ static bool gve_adminq_wait_for_cmd(struct gve_priv *= priv, u32 prod_cnt) =20 static int gve_adminq_parse_err(struct gve_priv *priv, u32 status) { - if (status !=3D GVE_ADMINQ_COMMAND_PASSED && - status !=3D GVE_ADMINQ_COMMAND_UNSET) { - dev_err(&priv->pdev->dev, "AQ command failed with status %d\n", status); - priv->adminq_cmd_fail++; - } switch (status) { case GVE_ADMINQ_COMMAND_PASSED: return 0; case GVE_ADMINQ_COMMAND_UNSET: - dev_err(&priv->pdev->dev, "parse_aq_err: err and status both unset, this= should not be possible.\n"); return -EINVAL; case GVE_ADMINQ_COMMAND_ERROR_ABORTED: case GVE_ADMINQ_COMMAND_ERROR_CANCELLED: @@ -455,6 +449,16 @@ static int gve_adminq_parse_err(struct gve_priv *priv,= u32 status) } } =20 +static bool gve_adminq_is_retryable(enum gve_adminq_opcodes opcode) +{ + switch (opcode) { + case GVE_ADMINQ_REPORT_NIC_TIMESTAMP: + return true; + default: + return false; + } +} + /* Flushes all AQ commands currently queued and waits for them to complete. * If there are failures, it will return the first error. */ @@ -482,9 +486,18 @@ static int gve_adminq_kick_and_wait(struct gve_priv *p= riv) cmd =3D &priv->adminq[i & priv->adminq_mask]; status =3D be32_to_cpu(READ_ONCE(cmd->status)); err =3D gve_adminq_parse_err(priv, status); - if (err) + if (err) { + enum gve_adminq_opcodes opcode =3D + be32_to_cpu(READ_ONCE(cmd->opcode)); + priv->adminq_cmd_fail++; + if (!gve_adminq_is_retryable(opcode) || err !=3D -EAGAIN) + dev_err_ratelimited(&priv->pdev->dev, + "AQ command %d failed with status %d\n", + opcode, status); + // Return the first error if we failed. return err; + } } =20 return 0; --=20 2.53.0.1213.gd9a14994de-goog