From nobody Sun Jun 14 23:00:24 2026 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8915358363 for ; Mon, 6 Apr 2026 22:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775513656; cv=none; b=Dglw8KQpaaWxi3R60ZpyYb+5NFv64icwvTA8Ne1rieKlpqVEcieEnP/fN8o5D6FI7dibKl4ADhGEvSFr5L40EERxX9QFaKvvgxm/38Oc8aX5Fl3NvM99UJbAwP87r7WIbPryDNrxES8MKaNsDUCM3ATkTvmNtsXxck0eW5Hh0mc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775513656; c=relaxed/simple; bh=IyzDmVjeEnRf6+N6CScLBbeU8C6QP2hQxk/cAXQX89Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ta9zJBtRsnzzeqywhufjM0hLImBbcZ0ThbFlDVcZgsfiSag4uYL4skRUraCKoD8QtwUJNMxGgwaadPQWKYIFWD2hh76QruZD4vbrCUeSY72rMOoY/lr28egnPZgTONY/1YMLEyH6a0oW7kwP7PwSdy9qaAq9CxmWD8OGlHE8+Cc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZV4pVMBm; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZV4pVMBm" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5a0fc5e2c59so4424465e87.1 for ; Mon, 06 Apr 2026 15:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775513653; x=1776118453; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Xs65Y7SOJhiSPJ4nfKCjyK6aCu/upRFc7BfzdjxKzvk=; b=ZV4pVMBmyYyxuw/yPJkvYEcTcatoNC0Ujmh0cNVTEAtk1Lf1ckIN4y0DLwTHXIcN4o cxwVa/6rqOF8H3LyDLoYCPluFFipkmuSCABlS9T9hGwcvLZI/59TEyDTAs3D/xcIKlZy 9OTzkVZMTby0KBN2YL7a9O4ys3PoQ3MC0g55qp5tOyiT+bJtpXU4Zzng78tl7no+foZ3 V5R/mABbvuie15KNc0Fkkz1+C5ZYSYywWyTDu/yq7VfIBfR460s3c9mUNKzco39yAihN 95+Nl6iNmpJAF6hhBQMbL5w4HlYLZ+Hh7zcMNCHubRfHTElmXScadrMPlgIP4ymuCU/i eHlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775513653; x=1776118453; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xs65Y7SOJhiSPJ4nfKCjyK6aCu/upRFc7BfzdjxKzvk=; b=HnHLVVyF9/qAJfzherZ/ee30+Aqzd92kCVETkd9OryYL3jneerSboFrixlNNIJkK7z rFIv41kij8mPQ6TZvfEHmjiXSQ9SIyDyerxq3LuTbi24rcfaX1dcPtUr6RrFtnEro5QS Mtpa1oF/MowcUXzM/rQGrYCLajyujfTb5E/yupn2dpRGj9deNwiYJd36YKKInnQYTE7R aSZoU9gzDA19Tok2CpixbY+T2ooK+KREUp8ZZFSRiVyB3BLVGvnTTmQCuMCTonT36fSm 8Kixm0cm31fqS5b4vHAE5cEetRaGEyiuesc+MFJUu6AyFc7fYk5VYlm4nAB1J6oQtycg s0tQ== X-Forwarded-Encrypted: i=1; AJvYcCVaSDPbr8gQMjnRYSYDAFQygAJ2NXbyFD/mAy9z7WpvAggv7g0ILSvAAqJxoe4l2CO4JJHjjK37X6cb8zc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywr3L83ToC1kL2DOubVxV7BDXsxHe2XrQwQjjTTK0ksPCXIfb8U yyR5ceIvyJ2oFCVk2AUEsDFA335sh60CUCIGnDDH8f3Z5U0iQZoht5mC X-Gm-Gg: AeBDietjliSranOtrdKARIUAdNmTWwvDbFJMm82teXrhjZwJsAsPzhSPAyiQaArd/tb 9IEtLubNED2HX0ENbKPYkWwhRaGNfaaUIg+5ZYIbfUQMz4ygY20oaauVeP7aqF4E+d44FLvddI+ z6bpu2LWwaJ5RXYV9z3zFAhXF/qSD3ml5KI2AM+p4Ra2dqB73BPUTUcP1HLE/FiaGCKws0wbl3T 6hi4R2eIcriMS0fiBMTjrFmEd5Xqngean99GJlR4Bua+Ywtaxhld4HJq3OrcWGi/bGSR7TWnjhd zG/DbyZp019oRgClB7tsLKETHnXaqRrAVKQD0DmHi30e6Qs5J7+6xJFEsOcM3Sgx0YYFORWkYGv wWSF9taWZOKXPhT60rt3NskXcz9hiPq6/b+DVczW+tq8EPKautS9VWqaIrl9ii5UF+3i68LEqct NoO14QwMGbG76V9oeJRW9Xq9Gu0A== X-Received: by 2002:a05:6512:1151:b0:5a1:448b:317b with SMTP id 2adb3069b0e04-5a337591959mr5666904e87.42.1775513652798; Mon, 06 Apr 2026 15:14:12 -0700 (PDT) Received: from new-nest ([94.19.228.143]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2c6cc5f90sm3738693e87.49.2026.04.06.15.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 15:14:12 -0700 (PDT) From: Andrey Skvortsov To: Dan Carpenter , Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Andrey Skvortsov Subject: [PATCH v2] media: cedrus: Fix missing cleanup in error path Date: Tue, 7 Apr 2026 01:14:02 +0300 Message-ID: <20260406221402.3721777-1-andrej.skvortzov@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Samuel Holland According to the documentation struct v4l2_fh has to be cleaned up with v4l2_fh_exit() before being freed. [1] Currently there is no actual bug here, when v4l2_fh_exit() isn't called. v4l2_fh_exit() in this case only destroys internal mutex. But it may change in the future, when v4l2_fh_init/v4l2_fh_exit will be enhanced. 1. https://docs.kernel.org/driver-api/media/v4l2-fh.html Signed-off-by: Samuel Holland Signed-off-by: Andrey Skvortsov Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") Acked-by: Paul Kocialkowski --- Changes in v2: - remove duplicate 'in-body' From: record - add details to commit message drivers/staging/media/sunxi/cedrus/cedrus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/= media/sunxi/cedrus/cedrus.c index 6600245dff0e2..1d2130f35fffc 100644 --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -391,6 +391,7 @@ static int cedrus_open(struct file *file) err_m2m_release: v4l2_m2m_ctx_release(ctx->fh.m2m_ctx); err_free: + v4l2_fh_exit(&ctx->fh); kfree(ctx); mutex_unlock(&dev->dev_mutex); =20 --=20 2.51.0