From nobody Sun Jun 14 08:20:33 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013029.outbound.protection.outlook.com [52.101.72.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 569983101C8; Mon, 6 Apr 2026 20:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508098; cv=fail; b=ERb6FxClHtyfWXixfAxTX2JLsejEU5E05wlkUwsG1vi1VDzsLqK/xc8u7w1zomgtjnuze+tR7PYUmTd/SAdwLV4pl0UmCkPPPeKukaRQo3y3LfJpbVMyih0+QzQ2RQpvpOrOUXu7r/TX/s333MMClg6a7f2yoQ8YI7cOzMsGlXw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508098; c=relaxed/simple; bh=ohFb/TMTIBVDdqjQHmTB4EC3d/crqW81zxzMTXM+hWA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=XMRdFCVnU9KHWr8VD7jHEbNrROHgs2zK1BtJY2ko59juCl7AtH9kabl7tN2lbMnRyqr2MAOt9mSxTjIGfoyQAret1hgNim3iLnb4Pm/s4gNks1ToKw6Hx9Ts7mFLYdMHFfXX5y8clBEwtuVMenh/WB4uA8ebPAiKIRfAOP0QxxU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=H3kgUEAo; arc=fail smtp.client-ip=52.101.72.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="H3kgUEAo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LyJJghGkcgsfCxsY+G0yiy2y/NBl9/cV6PzyRwv2xVnpMm2WQwbWGP7m9kNzU21jhAr4vf91R7lID/l19O/6HBAIegalowLXBZZuZhTtwx5s2BzpWc2MiK4qHb2eXsDJamR5OuRpvfA+Wbl9VfKOAQoSuVDks9WRGRns6pmqgQFseg2oqP+BbqZe/jPtHiqE1ytqYK70XRV5GwVBtaczM6Nuh3BVyEqF/LK5TQfhZhcbyPitIRSvpa0PE62bnv10PL2+z8jCNckNXq/vby2Qa1eLNVspVeTYA3kZUJYjmAwkWlO2SIVe7E2v5bRQco3eRbFDIP8lCbM0Yx5aoJXxSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uVVgWCf1zqsO2J90L3RX6QB6aXKH80eO8ECMvjE00Es=; b=oyYDMwRBcQBoer3v9lcRIK8vyZ2oe+qi9DHpmF2WN0TtaMexYHqhCZAa8+7xLXRK3v7P6PJPUabKjQ13htozKdgGheBNX+0ENLlGQXCCthAu8BOaC2tSkOXFuhXdFx0T7Yd1Yx/eXkhzTBLk5pY2DZKUW2WQ+ounE8HcRlFQn/ZL/6AOxd+Rhf/wI6aYR9x3xbB3HOo/nQSWRJ1EuZ+G8ir41ZVxv2ICL2IcrM6qS0QNZTe4amNjV1HFBTbr7/R/Ybj41s4H3oE6l7qR52LaxiEaO6rjEwV+6DyFtlQBpF0scf8Wpmi0WTKetRETsdIo854nn1lNVEr0t8+Kzhbaiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uVVgWCf1zqsO2J90L3RX6QB6aXKH80eO8ECMvjE00Es=; b=H3kgUEAoLtQJkOslp2Bv9TRdhmArK3tfNwdley2bBRuK1ZsPqQsXqh2N50a/+thtmu5CUlSJ4fvyA0DS9dzvOarDjMHE7B9EJOCtp3QbJxHaqSr0vK9IzwL91kqG+0fycLeyVru8kud7SMwCLWbmnhj42Nqvm63Vs/r+wyk6DzOTH73ShD0OsuBJFtSsF4QBesueBanu005UyJ12nuwX64E/s+chtp0TFoqhMURABneMny6eJ6L5tP+I/4eAcfqbl8CEdLhw9cP1y57VrSA/ADNoSf7oPBum6L6MLmYGYm+tSUMfBFW2MwcPOKqmnN95mR4zu9n7301HQ8PxA7YDfQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) by DB9PR04MB8347.eurprd04.prod.outlook.com (2603:10a6:10:245::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Mon, 6 Apr 2026 20:41:33 +0000 Received: from AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4]) by AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4%4]) with mapi id 15.20.9769.017; Mon, 6 Apr 2026 20:41:33 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Cc: Zefir Kurtisi , Claudiu Manoil , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ioana Ciornei , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Simon Horman , bpf@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 net 1/6] net: enetc: increment error counter in enetc_xdp_xmit() on DMA mapping errors Date: Mon, 6 Apr 2026 23:41:17 +0300 Message-ID: <20260406204122.167237-2-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406204122.167237-1-vladimir.oltean@nxp.com> References: <20260406204122.167237-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: VE1PR03CA0026.eurprd03.prod.outlook.com (2603:10a6:803:118::15) To AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8585:EE_|DB9PR04MB8347:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d8ffb4a-8f74-4f47-b596-08de941ce382 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|10070799003|366016|7416014|376014|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: n6JWQ/qZg7Aw3hh5KtroT6oHr+9UAolhi4klm1x7obzBkKeyp9z+gtu/5hC3I+vrMMTNMs+wGD/Y6rBgMiq91f4C0xmCOwqJwykOQ+G6iCyPbhOnPu5e68U9EyhA4+wbTSAyCDfpSy4UjaLVEm8eVFJcfO0wDWJAOtFjX5lzAuUJIZqiPulrF7h3JmktCM9eyKv0+ADpEiUk43uWYV0DYG49xbfKlV5Ugo1P2PAWaKdGksQjXKiJfpObWSNrVK8cWJaVdSiJm4OViYzXAQeCKBbs/0JtO3ljYKT1GUJRJ+8mIQBMQR7gn7MsaEAWX2ncBAGjd6UYpzY0Jjkb29sNQmM92zwrkfAWixrTL9I2Zmdtk2f5EzETNbs4h/y5j8S96jlffQIUY6pZZIHrdnwewHwuAW+zntMtSXERAr0CTY8+Mtf7eiPks6O0ZVpZsY05ZffQhoTCVwwX3MweAsoFdD5980qih9ggrcYAV3y1r9EJpNKsLel+ZRXsldmkkJ8FkHPDCWc9yn/pFhcozKWa5YorVSBfBL5ehc/GMPabDj1j6i8C8/9PUJeFNNBGcjZArjcwW9tBGq9GbvGi5vUEHtHl4BNuue5XXg6zjehJ8XovYIX5GAmPUL25ObrrF+H8BNMO8cn9P+BFpbFZtuQT4KFqVNWlcnyWSb9pYPRGldjhxklhbhNNRFC0Qtbq+2TPhUylnB0qwsYaNZkOhc+kGEVGwPlS7mXZhczV5bv5d28= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8585.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(10070799003)(366016)(7416014)(376014)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?q7L6XMZA+Za1FMHxjuL+JO2hnLsXrFZPeb1njQi6VcwgT5PU+1DKkq4OO3vG?= =?us-ascii?Q?4LzbNY8tR7329Ox7qdp0bb5w3z378mnMTHnzyEO/UAi1OH/FHyAU7rbbumIQ?= =?us-ascii?Q?YRCZ/BVzJVeNCbg9ppLwDODHjMD9bKWL7XDBYs8YHTuok2WQMtgmlW8ODpm4?= =?us-ascii?Q?TXAe304rds5XiM9RRY5r6iFqy/qt7SayK8PPDT9vqu4TeRtn5ObvdQsKWiop?= =?us-ascii?Q?5WgX6YvboAJJIWoR+UAtn5iWn67i6x4kSMyYk/xfoy0cHG3QSp0zdEa8yCYR?= =?us-ascii?Q?f7WTFajm61JU+PLSJ8UabvVmk5NYNufY1xkHIKS6MRZNtRGojih9RKv6mfLl?= =?us-ascii?Q?8Mh7g3NMVENhj8Ki6AlELmfgDzuEMjqjqloHshs7VMdSeLeLNJ+Vc3oOpHdl?= =?us-ascii?Q?cq4Wun4qfsDLX5DuKhnChzMQ7nu73H49Fx2lZNoismbh3pOs/JyX6z7Dzke5?= =?us-ascii?Q?1s5AJSamRKRZvt/9ldZWIE7l0BhoUzJGnoN+J3Ea40oaumUQrGhvmVUUJA9U?= =?us-ascii?Q?EnVAqPOSDkWrLHP9p2qTR4LxUtAVXhQz8PZhwpqWo6WuqED3/RAXzHc/nJY7?= =?us-ascii?Q?KvfrE2q+Q2/lmOio9HsWzVj2urNUxILp4QrDNPJWuX+KE8gr31TGntEpwnP3?= =?us-ascii?Q?/lpZ35phYrrXJYijMwtszVct9rf3nKvI9R8NW5M/om8W+YsTX7jj0oyiDgeI?= =?us-ascii?Q?KBu4mYNe5OXgJt/y8fMklh/fXr2FKjzAz+dn4JSbC5FM06703IeyjEdEa8Gf?= =?us-ascii?Q?/lw2HAv6JKpETYpab6zkOmtVrw+ETnJRA7Uzss9fhU6WZEJQ+EGP+8LN/7vB?= =?us-ascii?Q?v4HYTl0TzqqzxE9hXkLL9MdOo0tXu494Kn043Xdm71IIoLAcjgAhWzq5Oeju?= =?us-ascii?Q?DVGM8PgIXV4M6DEetpvuUTthrcoOZ1QIg+UYX0kJcYGfHRNh5cAmkk8i0pGl?= =?us-ascii?Q?ITMv/oYDIk+ima8F48doa355/qtX/nBpUH3qRxcEg8nUDrm82o4mjhWqAmR7?= =?us-ascii?Q?S4M3+nJpoYye2RDF1TPWbyAX2vZbkNcBNB1PrDP6iBVp22iubeU7XZcHUecw?= =?us-ascii?Q?aea5TT2NbdgA91vG8VV9oAnTR1U12paX+93H87tnrPEl8XO6xM+noit6GsZN?= =?us-ascii?Q?OQZT7VrXjoRDaCngBbsNZaRRAyVGkJdwnIdTEniiy8eYVZKUqQ+ONVFLZR1+?= =?us-ascii?Q?8tgZjXWEQdGi0yIlWogZIaMiblh2vpn6SCEP8o26kAXevnVJuBt/kCvbPgMM?= =?us-ascii?Q?cYF/WAh+KgCFj1ooh/h3ST14QIbyxN/ovCAJ6mb5yCSxAW5tmpn06JCBteZ0?= =?us-ascii?Q?D+OWELi2PmXfns+yP63np5RbuohJIoLbLwPfBC7B0Klktizi6hbkcK1n9phW?= =?us-ascii?Q?kNq0gNzBK36ITVpXerviWpnQdywFsVl05Ai/ltUT4QtVadeZGxUvFnwPXzpT?= =?us-ascii?Q?hB68Pu+ETvAQYSQLoG56M5VmXYPwQWXep+8/zSoxEELnHurx92WuR76i84Mq?= =?us-ascii?Q?gN6J6PWkSHaRFOX4zcoj2ID8Y5XxvNEkZp08wuHyRsYT4yQWdgcLbmol94qQ?= =?us-ascii?Q?7hXxNlEt0e63xqtVSxzokqn5xQdVlcuo3UWEVuO7u3b73bS3ycK+YBZ4+sM8?= =?us-ascii?Q?Mx1+axrBuJpUDDEBeMZUO/9azKZg1GkoB02AdLwdpDRSq4MerTIOIwThVzyh?= =?us-ascii?Q?FLrbW0z5xRs2InV4ew5hEMqOWOI3TDX5+oCelO3yJYXR9i6UJ92RxfcspY+R?= =?us-ascii?Q?AdPxqWuuztDsIdvf7BOsJVv2Kv6TXt90NDRO7le63/rVu8Qcq3tG5A2vdA+U?= X-MS-Exchange-AntiSpam-MessageData-1: ATEgBCXDyl9xd3Dk07IYtGr1+wN0Eie+DHc= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d8ffb4a-8f74-4f47-b596-08de941ce382 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8585.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2026 20:41:33.2881 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NnUd+nULFhCWJBTngNNANpC0yycN63wa8H5xz8J01vTWU46UqXxfmzmqR2owd9OTUJZo3Kq0olSS7adV7DXqkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8347 Content-Type: text/plain; charset="utf-8" Failures in enetc_xdp_frame_to_xdp_tx_swbd() should cause a bump in the XDP TX drop counters, like failures of enetc_xdp_tx() do below. Fixes: 9d2b68cc108d ("net: enetc: add support for XDP_REDIRECT") Signed-off-by: Vladimir Oltean --- v1->v2: patch is new --- drivers/net/ethernet/freescale/enetc/enetc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/eth= ernet/freescale/enetc/enetc.c index aa8a87124b10..ece10a58d44e 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -1801,8 +1801,10 @@ int enetc_xdp_xmit(struct net_device *ndev, int num_= frames, xdp_tx_bd_cnt =3D enetc_xdp_frame_to_xdp_tx_swbd(tx_ring, xdp_redirect_arr, frames[k]); - if (unlikely(xdp_tx_bd_cnt < 0)) + if (unlikely(xdp_tx_bd_cnt < 0)) { + tx_ring->stats.xdp_tx_drops++; break; + } =20 if (unlikely(!enetc_xdp_tx(tx_ring, xdp_redirect_arr, xdp_tx_bd_cnt))) { --=20 2.43.0 From nobody Sun Jun 14 08:20:33 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013029.outbound.protection.outlook.com [52.101.72.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0EBD311959; Mon, 6 Apr 2026 20:41:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508100; cv=fail; b=q4EvUb4sgqtiQ4lnONFNg2dMpJX7d+NiyHdb+6LK27gPiHJGPv0nmEE/SLDeh47fyMgjD4ql3BDvaTneOfmNh/ir440QmAxpTVK9Uu6MUF+tJjXCL7fbNLqT8Het5AcErN1tlyhRaZIx4MUkQNXGq6OfIgyw5vlwWj+IVbbiNGQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508100; c=relaxed/simple; bh=ZqItfYshzoXsI3KpzU97yVyU8NBl2aEvWbFXHWDbO3o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=V/9sSimQHCV7mqio+6JXA6t/MnBd+CW9OExw6frzUjgFthmt57F+rJIw17tp/sHpuSgHpwuuiCvuT3MfsQsx+cHV3wsVQ9oqYOZ79iZKDhpgnTfq96pAt3x44DvEv9VGkc+ET+0LN5zOPjF4C6BnwVWBqRfhTjF+1BXQDyWIDrw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=efH7o1+7; arc=fail smtp.client-ip=52.101.72.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="efH7o1+7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ffLKEAFlayGFM/5YtpeuE/l+Ry+yoGZfJSQgKxL8dnPNuffoeW3ltB5G4Xzj1GZUtg+PbXtMGqxpgSP0qCKfL/Ng7iJhPxzNqu1VtdZeMz10tdg+j+FOGJQHYt5oikrbYwboje0Ih86K77ewgHEnpj5A8Tn3p15Vmme5nlLepdunCeV+vWCwGO6+eVQWm5PUF61Zek7tZXJTu9V8uyIon79IyIp+f1xJG3GPhaEuC8dpi4jlONAm/dLtWjzNMrOohizAlk4S0rtOEM3eDVGoUqeSqn6M+IYEINysdM7qQ1gLcKwn+EFlBGB8fb1D8Q1esosssv+qzFvTVfs/ie9bNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WcetKXWsCDAb1qEc0rSxpxEnf2kRpgizrMOjjgezBrw=; b=bsCoddHTAzBepYZkIq2wWv1xjgilQPal7ZE7s93UndYQuc/WvBelYQ9KUWZWLEcgXqH8agEASGoe3RZNDYyLSZtPJzPlPl8z+jdHkDwT41pK5WNMcqk6FkQID6glOEjQGL8EAkEZCBFPxSMkfRmpUR1sVdDwL7xAysIsaDNXWY275A6nolvt7LBYmZ/Dn8XgOIQf4tBIrGUEMntpQOVqwm8+1dkM5S9iGpVB1tEiUnmYRzRwBiv20qQyy4uN1p5MhZnJaxcN566UnWVU6eCa47VOPJdQlnCh8eT8231xD1aD/NiEu0Q5rdAkT2IIf7zt2hko6JK4pwG/tmqHxsR8yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WcetKXWsCDAb1qEc0rSxpxEnf2kRpgizrMOjjgezBrw=; b=efH7o1+7ORJM9MWcR8mrhvNd/nrVHR/hDlaFBJeeKFWT5ZMMRtjmaO03vaebHWmw4W3rAYVB1+iiIVToS4wKTi4I8bWVrxjuveSgdG7Pg+MnbZIg7sJ9zOcyHuufdWVsTDRFD+5kvNAPOaYuJ1i54p9C1KKxSdu7WqOhEPwtn1xMgJ3otkM4uH6TheGDc8AtLgOYEaEePVi9GeoNZFjoWa3BtauC8g7MoMhRfBpty+bU3cdO1Oq6DwJQBZAfrLizYRSgY87ofXJqLVSQd6erHdG5EQ8mjRbettK1XzBe//ra4YbdkbgnhuM22WO9v1cxqDELJz4CsRVzQmaRwtJ9pg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) by DB9PR04MB8347.eurprd04.prod.outlook.com (2603:10a6:10:245::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Mon, 6 Apr 2026 20:41:35 +0000 Received: from AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4]) by AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4%4]) with mapi id 15.20.9769.017; Mon, 6 Apr 2026 20:41:35 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Cc: Zefir Kurtisi , Claudiu Manoil , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ioana Ciornei , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Simon Horman , bpf@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 net 2/6] net: enetc: linearize PTP event packets with one-step TX timestamping Date: Mon, 6 Apr 2026 23:41:18 +0300 Message-ID: <20260406204122.167237-3-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406204122.167237-1-vladimir.oltean@nxp.com> References: <20260406204122.167237-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: WA2P291CA0042.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::14) To AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8585:EE_|DB9PR04MB8347:EE_ X-MS-Office365-Filtering-Correlation-Id: 08fd2c8a-b30f-4d47-ab5d-08de941ce4c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|10070799003|366016|7416014|376014|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: 0strcTsBktODMbFz6QbcOq8qQs9q2gup/GvkFEsSbjUJGooGMlnDzh5J3mhS4YkehbJuztap+zqQUZa3Mt1RQie+jsuwwHfEMvVguVQ+2+PAL2Gt55w5RvTbCQ27+7AY8AdsXyAMTOzWzrfaOlQ+8/igs9EkSEeFPFEuN89axU9nkO6PdIEiPdvQd59+7AwqJPTPBJdYzUPotILOYmwynOvEjG17cgb2whf0CTBnB1ROh8D6xze6fblYfbAGGOFVHVIKA6qLUezcUEcsXXvR/rpGZ1EuP+v/AzsyqDBrAV1iAxatpOon8arcFVWPx6Ryotb7WuH1OaBOQu/8nK0IEg+Kp2u6nFYxWTcwrvr/UBofEz/sV66x4zVqCLl6RMT/scI1DTntQHbzFqiBC0i8zpJVNoyj0A7hd5UaBd69qo/mIUfKVAik+3ZVnWjVMosyQkCgpdkLmmyQcBWHyMqToCVbT682UBMKLyZKpjw+YnSxTG0D25URuAU/lLlnxG9bQqVVfgHgO9PQbtBkFoN4cBKa7bYbSVOf98c93ZblAaAZBhW8ukXHBvS4sKFXOY6HJikhSbqKJWBhpvxYSOr5lTr9eDVeXIlUocSFjf4shAkTbvxfjwzCp+QMqh402+Q0E8/PlTFO95nJIFSzSk23ZjrWbWwHxtVXtm5LZJOfzpQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8585.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(10070799003)(366016)(7416014)(376014)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TtI+lojhYxl/qImdD11MgqgTOLN8cbsfdcourKG9Xh1DZj+8V2VMH1p+oAQA?= =?us-ascii?Q?AcfEQkdEjmhLVE/MggEHrZVYTc1ivYs68D6n1LFn8R5IIWktF1E97uHTy3ZV?= =?us-ascii?Q?2PIhmRGNZrL8if5jL5T5K20Pcu2rnSltKa0MWzpdnMR7FiD5Y0R5RXU1rGB3?= =?us-ascii?Q?WROfk1eWTq//+OBXdFW02c69pGkj8Es0DsnGbrylo4ctIzMAmt+elnOTPEyv?= =?us-ascii?Q?ZBiwMKv5tRi6haNKyzNzPvv4DMb+CIUvigLWbq/bsGfax5BDJkwC5iITQDXi?= =?us-ascii?Q?n0G87dszRBBj1ukRrfL1WAGwXb/x4PHA8ofq0EdtC+YV+ec8G+X+M7Vj/w8a?= =?us-ascii?Q?8XqWhyu01ys+SFHw/+22tNva0PedJkOOJV2k3GDzqlcexFoSu2buTZRuivTZ?= =?us-ascii?Q?EEMXlTyNUrJFpjH9Yn6JoTv9GS/OXnNULkOqVMXPfe5W4J5rOmyf20ytpqQ6?= =?us-ascii?Q?/wDFe16GJlNXgwsaF7ZgeC4Kskxj8tek+WVFcYwFSzAyE46PYOqQFwLhvfbc?= =?us-ascii?Q?8VHToncZwMh92bwKOVi1QadogXEQzzMKBb7sgPPRqDem60chZk29YBakxZ+l?= =?us-ascii?Q?R66+XSWkAWXc1lzFKk3RUno77j3sLtS+Jql+i9jgKU832VwnOPts/zhhI2dG?= =?us-ascii?Q?us45MhE5KIwfol5+uohCbrSvx1gQZ/JjxIMhamUmN2yvg5itO6w3KmgFURtC?= =?us-ascii?Q?n5pNwbLZA5VIHZ8UT5L1on7xOJ9u3LRkJQy1qzWS9k1h2Ws1sxEt4ujBlRup?= =?us-ascii?Q?n09lvHaRoyLlvi5vW8Y6xXXRIWfB0G/07yIxI2FcJIHaedj9/DqHyXBpio2R?= =?us-ascii?Q?6xSZdlU45GYVpxc0C+O4hEe7ZaOqeVvs6NjQWJMn3KVnAE5hkthsspCY8X4s?= =?us-ascii?Q?7Aaq0CfHjmmZlNPbGyYNe9jKK8rVZl4VF1jlwra0ZBS42I9VRTrY6o4derBS?= =?us-ascii?Q?HDIXA2e2KSPZ2rhMIqT6EZ0GOxx3/lZZDZtAzmTvAjawtB9uFBWkgPQnIaj9?= =?us-ascii?Q?AIyTWfPt6dgYkzx/1FV2yCuIXlUZKdzYolKKj6TD0S58emkfiDffv+4Pwx8L?= =?us-ascii?Q?4Mp11yroldMSLX3QUnhqKkOTaBxQOJFHmn19f/ewrVW98lURVckrAwKUlmJo?= =?us-ascii?Q?fXf0/U3TuKDVN61HRKFQkIUw5ZXGPOI8zgUUmjzElB4SUr9Cj6RF5WqkPkub?= =?us-ascii?Q?ZhIFYGYTTwutNWeuG6ORDkbPKsQ8QCrapoNmqH/VEVW7edyuV/y3rRdb2FKQ?= =?us-ascii?Q?KIIZVkqV74zli/kGu1b30WDhrNJ1gR9gsMuT3qtmytlqcgBxsQGLkpRTdZUL?= =?us-ascii?Q?K5UYLi0xosQVbLPpgMdeG1XTCpKk2F7M0xtEOicyVeN4m47oD9xz0b9rUrZT?= =?us-ascii?Q?CSOGNn8uh0vkiMO4oaDx0KDANFETT3GgLSpqZBt6s/ryjZiMrABXlWPyXfK1?= =?us-ascii?Q?Hc51h+JLo0MBQkC4FE7RDZ+VatC4NJ3WQIrc+6FnrSdpJnUp6Q+mgMlhB6XW?= =?us-ascii?Q?La67H1AsEh39INFPCq8GzNzHZgOZg9zrVjL5fef8+aLbz6JpR8Qr2r9DvKtr?= =?us-ascii?Q?T7ppzhOgZUbretxH94AU6o3w6DLfc5xFneJ7z5eV9YxBqmPnuQqXqTAx6MuJ?= =?us-ascii?Q?gaQHkDfEf/NlkQ9lIv6qiDpuLERp0nWO0zVpIa418aoUZXGOaQj7wR+yzMy4?= =?us-ascii?Q?xYKZLxFVaesbEkIuvejihJH8nDku3kLMYOyVZPMvlaL+zzAMYtdHMhCw3r0v?= =?us-ascii?Q?GSwrkGGHYfufrVEZwD9ncJI4T1KNX1R5CM1OGIjU6ToB7gMqRYGAFDeBMMAB?= X-MS-Exchange-AntiSpam-MessageData-1: N1PX1+gOCIhLA9jRjtAxFfI4cfDjC+NqRtQ= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08fd2c8a-b30f-4d47-ab5d-08de941ce4c3 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8585.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2026 20:41:35.2635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XUPttprYU9zMDbwnD8oBHMX4KaIKzGZXIeSR0sH07ZSH4Or/WZtTdSuQLQeBlpEkkS9HObsmSH5dZv0iNMVlMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8347 Content-Type: text/plain; charset="utf-8" Sashiko reports that enetc_ptp_parse() uses ptp_parse_header(), which does not handle fragmented headers, and expects the entire area between skb_mac_header() and the end of the PTP header to be linear. When the driver fails to parse a fragmented PTP frame to find the offsets to the originTimestamp and correctionField, it falls back to two-step timestamping, which is technically not what user space asked for, and it may not be prepared to receive the timestamped packet through the socket error queue. The problem can be avoided relatively easily by linearizing packets with one-step timestamping requests prior to calling enetc_ptp_parse(). These are infrequent enough that this should not be a performance problem. Fixes: 7294380c5211 ("enetc: support PTP Sync packet one-step timestamping") Link: https://sashiko.dev/#/patchset/20260401172246.1075883-1-vladimir.olte= an%40nxp.com Signed-off-by: Vladimir Oltean --- v1->v2: patch is new --- drivers/net/ethernet/freescale/enetc/enetc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/eth= ernet/freescale/enetc/enetc.c index ece10a58d44e..ac6cad5605e4 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -1059,6 +1059,11 @@ netdev_tx_t enetc_xmit(struct sk_buff *skb, struct n= et_device *ndev) =20 /* Fall back to two-step timestamp if not one-step Sync packet */ if (enetc_cb->flag & ENETC_F_TX_ONESTEP_SYNC_TSTAMP) { + if (unlikely(skb_linearize(skb))) { + dev_kfree_skb_any(skb); + return NETDEV_TX_OK; + } + if (enetc_ptp_parse(skb, &udp, &msgtype, &twostep, &offset1, &offset2) || msgtype !=3D PTP_MSGTYPE_SYNC || twostep !=3D 0) { --=20 2.43.0 From nobody Sun Jun 14 08:20:33 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013029.outbound.protection.outlook.com [52.101.72.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8B68338597; Mon, 6 Apr 2026 20:41:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508102; cv=fail; b=lRd4B0cmEOrAGtZ0/H6UxlPUwlXfu+eg854bWyPKEl0zy0Lp5M/XPT2Imj31r/aRlUUkidT2HzaBITQoZwhJ5whznGmNEEjtF52GjGnYsOnECjHAj2FLNtM1TxEy2q3hqkhINbtd62RdE5NfrZAJHJcpyG10Nbbja4Hm82nNrWI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508102; c=relaxed/simple; bh=g6CSRNP2cRv0gKEeSjEg0xT8sN8CRk+BBjTlw3GiKxE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=dMdDTOHlDYkrWRDvke8D2CNm8R5YNs82cCqk7Zg2KBq+QH/bcKIY93qY4/iSEhJxwEw0ITUkTBaNcddCF2+Oed7MS43iljnowVkoE/m+xHCkasxUbtffWcswss4oXfbm5iH8e+7/xdSYqI+eUpcStfhSj1HULcBPgc075TJLUO8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=KcMBHLJb; arc=fail smtp.client-ip=52.101.72.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="KcMBHLJb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OrxXKBjVF4fjjqRhPeFPzOAnuTuIQfi38n1WgWaXmcVjnGMHaMhh3fy2sHwdQkCJ/+clf/J68LjWS7oQ++eJkjxibS+fapy2buiJrwhrphsKVU4ySMD49p6Z9Za/A1SB8KWBZ0LMlAt5FEz3ReB5eVx1lQQVi74S+qq9BlKT3JyefxL/F5Wu99pEn5k/GK5wNkE5Xk4iR1MSAvG1jAfNDTlzp/zdlZlRvZbYt+7tjbw7C3plkGM6HtU4usmk0QOwMMvNUutYE9A0mBk/kxZmnOT0IdNtndqxG3+gnSyKFMadgyVnfvZFcj8bPkm9hsnXR7d2zYrTLpCaOqooyqflng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZXBzzsoQNU6j7ofn0p4bUVGnCUQrVOJlAiEwyUk44oY=; b=Y7DUZpzWoC7sxueF4RrXQdtzVWLh6z7g2aTMAUslCsYcckmGMEFKRZynhyt4+Lnkj1lB1i5K7WHoHb7zfWBeLQEkateUSq6iWK9i6TY7FYcqfz30bOOqU3qHmyHANzIPr+FmYEnr53tSKknA0Dx42C0Z3wfZtfx+/aHEV++qQJ3FDM7mt/PgaxeHnfaB6zBF+Wy4z7LV8Wv9dcc+pzrBJH2UKHjFHzQt4akICqF83K5RB4iFbVLt7c4+quYLz4zqlDfUCEY03zSIrnVXXT5Iao5WNznZxR5fKFGYwvzxV3Wnes9lYAr5R5htTknj+SJHFEX4Kcii27ao4TE62BZOBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZXBzzsoQNU6j7ofn0p4bUVGnCUQrVOJlAiEwyUk44oY=; b=KcMBHLJb50MourlbQNCoqKT9dDVs/ZMThMnoIYGgiJPMnQ/vgcsfWAcPbjGJhaFmBtnJYV8XlBjIj2hAYM9VPdmV89wPrcuiDSnPqqdAAT67m/taOrVkeo5GmpBPfS8w4N3qLxQhNDCRvfcUUGQQGJcPjrFX1zRfdlI5FSIgK0BsW6fWe5igyz+mkciU2LLmQsgR6SiT13IRNeHa4RUMukPeghDZlFmGzyYDXWpiwW5E4nppf02Y98MI0tLx3bX4DKakEZsPKYEhaOnJJXlcRixD9Fth/C2D6k+3H9wh8dFe1M9ZSdwr86NyDP+lxYWuJIzT9T2MCfOLjtcKNFvF9Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) by DB9PR04MB8347.eurprd04.prod.outlook.com (2603:10a6:10:245::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Mon, 6 Apr 2026 20:41:37 +0000 Received: from AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4]) by AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4%4]) with mapi id 15.20.9769.017; Mon, 6 Apr 2026 20:41:37 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Cc: Zefir Kurtisi , Claudiu Manoil , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ioana Ciornei , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Simon Horman , bpf@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 net 3/6] net: enetc: ensure enetc_xdp_xmit() calls enetc_update_tx_ring_tail() Date: Mon, 6 Apr 2026 23:41:19 +0300 Message-ID: <20260406204122.167237-4-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406204122.167237-1-vladimir.oltean@nxp.com> References: <20260406204122.167237-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: WA2P291CA0032.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1f::21) To AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8585:EE_|DB9PR04MB8347:EE_ X-MS-Office365-Filtering-Correlation-Id: fed105e6-b2ad-4bc3-3f3e-08de941ce61e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|10070799003|366016|7416014|376014|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: C9owig+ExcbCJF+ak/ZyhGpwUug2bP/O/FaS4BFLXDI1XzahWqDCzq7KSStm6Lr9oa+5w4n3Si+us9T6ihE2uaQNR7yPjYXW3o1P16noBco1O1kMDMetIpTQZzH6C17lnJbFO+M0sFw8Mdlym3RRHI3gFf+MXfBEFVGyxLS3aUSY2oKY58IhzBuZM+U7bMUYgr3XJrzprNqTsIva8He8a6ijUFIOgGfdRM1C98/mjjsb8rhNZCxHbYx9Hykd2bBvaKLu9MZ5FcsFPMmfoKiPJqBfe1xjoxewzwM5vHq1XVtxR14vriJ+lcM4zUu99wWshd7P5yzL2c1t5GHCgfuyQzeu2B2WEgVkniyf3C2TIQu43ZvsHs3mJtWiH+jhRxm6icQggIZXhnHjK/M+oqHbNSQ3VU0mJJ8jrU72zjZM/v5WlNhgZplBEJzndQkIp5PEgjjw6oyAPDCCOs5Ffu/ofPlNu53Obt37tMm/oU45L1olVWoemieqmh10HKko8QUe8Jtltx+ICI0hY5Tm9Yza/JpAuWc00qhQQe2RQStQXGsNisZYHmu22wQ5pPf3Y/rkQwi7tusIWFQe4kaS6bqasfb13qgxXj2LdjYtOEbvBqT5BVJ/OKvLthosF/tnQ8nHz0NuVwECrdGhk8RoSxTGZyO4lvd3pSOKHEnbAH4/pNkHv9xTA6YY38yyW1lHKQBxu6RUQdETKlq8yIuVz/RoR44Ng5BoHfnkaGHwUJRL7xw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8585.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(10070799003)(366016)(7416014)(376014)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WTU3vjIkR6XIWg8oJdOunzUavahu4T1AbePQniO3novT9AwaehHO0xl52IF3?= =?us-ascii?Q?6uKaAHQpfw9PG6beykBAImle87wLrsJLAtSLky09P2B+54+gcSYQX9B8VGoP?= =?us-ascii?Q?15THVK/8h/kpSCFGT4EIrTkuJSw93dLH6Kyslz9GCwoyOmzZ5Mol/LHzfKkO?= =?us-ascii?Q?2BySHx6mndZD6PaQhqia08lZRiWrlEgbxhc9dAVmjlM+piG3k1fC9koStFfZ?= =?us-ascii?Q?50qMfZgiOQrAUSnay6Lu+o06fXmURArgZCwgqESUj4l6wdcN8Cm1aJXOwG4X?= =?us-ascii?Q?Whi1srW4crJZXkYpc7dgDvfhH+UuP0XofUVehMlWiZY1PQKpwafXJFqo5yxP?= =?us-ascii?Q?1SlNmtmFjimpSLDVA/+xFVTYiFnw3NWObZ+JraL18qioS5FQ7o2t7WDO76YD?= =?us-ascii?Q?CpXRudR2ogVO3LyqgMq3irJPr6frIs9MRsy67pJ7W+EfgMezAFUv+lb+6I8o?= =?us-ascii?Q?7Pp65qeFy6Cq4Y1+K6SBHycJ9L4i6ZBvp8NkD+MFUvl5ux+kZTB+TEVYOsMP?= =?us-ascii?Q?Lt9fFkDPfc9MvIXZ1+Cw3rr7nqvS/OzZjjh0OwoB5h8WGN9aUhm9YGTcfQSE?= =?us-ascii?Q?Mwwmtp6hQpc21aCjHXz8MGoGb2SwvRbX6rlR7s+voWGEXRAYeItwyFIJ4e26?= =?us-ascii?Q?9wCH5rYFaaspdcL1Dpyd1yt+RvHdyz5+bGjrn5y1F8lcvHC7RpIyuiHQJQrG?= =?us-ascii?Q?uNQeNmXIm69Dfkfwctw0/f7rbvgSRhkxnfk38J+uLuxJtufuu+emJG68ZvtA?= =?us-ascii?Q?m/QVJD5URyOFzZZvFpMhVEm3m4j+hlai4qMHbK3jBZPXfdDW46wLJw1l2LjQ?= =?us-ascii?Q?J0ssT6G6zob3BgA81FOnuuiDSjo49ntIRrNSeoFQT2FKw1yo1l/pG3hkPFP5?= =?us-ascii?Q?G2i747MKe+1YdRdhK1n715N8WNJpF2rAwAZV/yObqYvywvWUn0XaLdO8E0DR?= =?us-ascii?Q?o6/WxXK+73PDnoVg1jNjtrLgIP/e0GRuzzXx0bTPDbOoh8srQ7JfrtfNJG/r?= =?us-ascii?Q?GXm2qPKiN6SxNH+YDJquYI0tXfelcHciHq/2nV6/EdEzrUMVtOCGZkXYx64/?= =?us-ascii?Q?HwaG03AWaqXOGGHRTQ0m8ZDkK+4SXX1B/Vg+B2WjyfDILcyJseE5qFRMMNGt?= =?us-ascii?Q?CMel/6DLKLIahA9PJurIqVJKFqovpTGQMy/q9RzNkGffZWE4FEL97yWXmgEA?= =?us-ascii?Q?3IqmtG5b9DISlZmqZviQnswBxZJW76RM5STieDBTvNXqePJlZuIBH77qb+t/?= =?us-ascii?Q?lBAi82AX4de0d9Bywl1vphjFh2HTIvfWUQyk7dDbkudG/MNzr1lvFYKfyS2k?= =?us-ascii?Q?FxizeoyZUBkZ62BvA3xDLcG8XC34swAbIIIc+1nhp2B2VaSJzNBFLRnkYQ9B?= =?us-ascii?Q?JpTqMJo+vJXAttrr9iD9eU6xocw1fTSyIR5ALt1eWjzWCUYddUDGzROo/Rze?= =?us-ascii?Q?cban2PInn2KOVDWSfTPmrXD15C06gJ8U/wfofoLFqGG3dAIMDmG+rFt5jWcF?= =?us-ascii?Q?Gfd8WQr311UfYtvG7kfY2O8k0yQMwFT5vJXW2073LkhczRDFjL221+/LNfgZ?= =?us-ascii?Q?EWINNb/5fQL6mpVq3vZQRX6EZ8nO2E9ks8fhdOv31o9HiFj4wiX8MeC5Hm/0?= =?us-ascii?Q?OrrZlt2tFjl5fZWptjZiqH2+UHNDcP771S1AypsKcUJ4CZmrxK5hk9tJ72xG?= =?us-ascii?Q?AvRg1G/+maM7LKlby38PzwvPn/xD0IaDY5ff5i3ubAjltM1CRAat9rtrfB0z?= =?us-ascii?Q?V+lj8K/wbYy4ZH+MHNJIL6VpDkEXazEgXAMdl7PtS6wqTqSz8dNKGErOkU36?= X-MS-Exchange-AntiSpam-MessageData-1: QB1oFOjUtk5/g8VScesE6C3uBzJJYx8+Dd4= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fed105e6-b2ad-4bc3-3f3e-08de941ce61e X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8585.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2026 20:41:37.5576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2j3CbW2nJAcZ5MRCMmOR8F+XAHUfY2WF6bjH9NW1jF5BnsiItXCty7eXibIDGkVb04wAL/WXlYHr8W6OyoCxKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8347 Content-Type: text/plain; charset="utf-8" enetc_xdp_xmit() keeps track of 3 numbers: - num_frames: total length of passed struct xdp_frame **frames array - xdp_tx_frm_cnt: number of frames successfully sent - k: index of currently sent frame from array With "k !=3D xdp_tx_frm_cnt", the intention was to detect an early break due to an inability to send a frame, and to trigger a TX doorbell anyway. However, that doesn't work because every time when the loop breaks, k and xdp_tx_frm_cnt are mathematically equal. The correct condition on which we should ring the doorbell is when at least one frame was sent, and either the caller required us to flush, or we couldn't enqueue the entire passed array. Fixes: 9d2b68cc108d ("net: enetc: add support for XDP_REDIRECT") Signed-off-by: Vladimir Oltean --- v1->v2: patch is new --- drivers/net/ethernet/freescale/enetc/enetc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/eth= ernet/freescale/enetc/enetc.c index ac6cad5605e4..5b97f9e668ba 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -1823,7 +1823,8 @@ int enetc_xdp_xmit(struct net_device *ndev, int num_f= rames, xdp_tx_frm_cnt++; } =20 - if (unlikely((flags & XDP_XMIT_FLUSH) || k !=3D xdp_tx_frm_cnt)) + if (unlikely(xdp_tx_frm_cnt && ((flags & XDP_XMIT_FLUSH) || + xdp_tx_frm_cnt < num_frames))) enetc_update_tx_ring_tail(tx_ring); =20 tx_ring->stats.xdp_tx +=3D xdp_tx_frm_cnt; --=20 2.43.0 From nobody Sun Jun 14 08:20:33 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013029.outbound.protection.outlook.com [52.101.72.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5994A3876BD; Mon, 6 Apr 2026 20:41:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508111; cv=fail; b=hJJmgbuEAe8Ee2cAIJUYivZxM9kgIuRfzaM16F0BOQ0TAZaDgeH9Q2EQNvmm44Z3Mp1daIAPJOUDm+K8KxV76VHVzHVYFgxMIfAVGs6UQ1S1/A3oVzpkZpa0W73a6aGXBLJrXNw60rcwxLYC7p1jK4BnObowBCxnYAA+0zXqArQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508111; c=relaxed/simple; bh=ot+biiMAn8WYbbyiZZ2hCKHvvSYZUDjPAsfSgaOqsSA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=bTCbNDz8WG2X57AsFEZBKLeSRIqDW3Z2q8EJVjRwJ93F93YF2blryOBMcQMD/SbHW359tRNqPu4DmvUBELhJ8C5r40W13kjycJR+OqrixJBV14spuk3eFzsKUBt/lvPjNTxf6WyAm7Z63rbgxRnXq7IsLJLMfrrEItIO0nvF/p0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=ZPxD9cJ/; arc=fail smtp.client-ip=52.101.72.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="ZPxD9cJ/" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DYV/m6XgzxOdOr9F/3cL+uwNxIwOIJUVIm7W0PIsvUbg8Z30WWznkp2DI4He1MhdAMFZdP+Q6HhhKiU/EObJ2AF5ydzIa/sMV9moC338g/f8y+3rSX3st7f5+wTEzARgjw1cVMol+ekM6uyesVzvuS/UVBsGv3jvMX4qkN24pRbowuwUAdlWWQlKOGTlL4RoLQD2Fy44ZA4nAfMkLl7Cf3kL9oAF8WC5hcE1eVRlbG19F+Pcysv1iKeqySmlOZNpIJmTLhwoGdNWc/CTj7RZpGG0+nS5tegUVmBjau77k7aeiPdqxlYxUZGXHe3Y9w/WWxFgiABABopl8UcO/zbwaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QS7OTcZIMg7asBA41mfU39F+pUhrJ2X1g58ircLbP/c=; b=rax9s7b2/2QiEEuds4wKE/i+fvEpSe7fMg3uZ+AfPbUBGLuLZtwhSfVKr9Jp31+uExxKw15892yDR38Fd2SgWwFlB06EqPQs9ApFKX2NOrpPXjiQ/OCHXQJoYgIsW/FNjHJpOW3KONgqu+3j+leuaWw8mlPEfpyIIUq9HPvI45rn+ooPRwLAeIBS9DqbnvG9EXP19mA812HyS3xKNE7ZthnMTvFL9tM4dUjIBRbvvj70ZgDi9AN6igBiSg181DQcPNi3X9HxwBtoE8LbmlgHg4VXnbhqtwkLaMx5PvzoL6IqhtVc1TPFlqZnGDvhzmoIsRUnT/7RwdXepVLdwocROg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QS7OTcZIMg7asBA41mfU39F+pUhrJ2X1g58ircLbP/c=; b=ZPxD9cJ/YxlEvAzZo2zr7g/pwkc6sBmDsRI+0ox9yrByHmkQM0MCN74DLgCm1rm4lNA/4tsWqLb5YPjS4ACr0IgeZP8VSHXdrWYtIGcAX11iEgb9YEGpk5wro4IGS/ZSYvkKk4tvCR5nJdzc6kv8is8MZ4KBt6Kbse9T0UFkfFlve76ZQ8R3VAsQCNiShZfKk/FXKCjDhEKPIgpEdKuWIxYZwcluzEsrWtaKs0rCk6Pvk3f7u3ANJwtCaBwdRrDiMnYeEjdHBpn5+sx62a0dPKzZqhHeGw2QtrNtL5zkAlWLHjyAeELDai7QIPtJKwewcMyUwq5dVmXN+WMgH4mlSg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) by DB9PR04MB8347.eurprd04.prod.outlook.com (2603:10a6:10:245::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Mon, 6 Apr 2026 20:41:39 +0000 Received: from AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4]) by AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4%4]) with mapi id 15.20.9769.017; Mon, 6 Apr 2026 20:41:39 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Cc: Zefir Kurtisi , Claudiu Manoil , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ioana Ciornei , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Simon Horman , bpf@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 net 4/6] net: enetc: fix bogus TX ring consumer index after reinitialization Date: Mon, 6 Apr 2026 23:41:20 +0300 Message-ID: <20260406204122.167237-5-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406204122.167237-1-vladimir.oltean@nxp.com> References: <20260406204122.167237-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: WA0P291CA0011.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::23) To AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8585:EE_|DB9PR04MB8347:EE_ X-MS-Office365-Filtering-Correlation-Id: c93ea8c0-3821-4135-ba31-08de941ce745 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|10070799003|366016|7416014|376014|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: YQcj7aIasYnL0bby+Al7MRO6SuyS6NTSR/PkzwWLvpSTOdyExVwJ+SPoWpvmpe8qPcxoYYEeEyBKfFoLgH4ipaBLyDLYT8ow5XO1wZZGFijJQNfSBEmeRCiomdPzqZ9znEN/DbdHQb56Il+GeeZkR9QeQg74hJzfvCyyycqJZxhpi/VjRb8YenyHOvAa04WxEegnw9O6ERf46UgRxaxwsG5DLqv7L/ZUIfqofEQ4Lx+jW+geBT2FnpDx/1QKIwpqiccc8bCrlp1kFhZispYO4VJkuULy89+lzZnoy583sWD8uF+QhBhf6m2kVU7nXAA7ZJVmmTLSQ1vMyh66lgLtJNsmJzdWMqSjNexrc2G0KqeQJ8iLyujrHlNdkxg2m63pp4uvs4gkFc6AX/ubbDAhsqEVycHKJSRC/G+qTXV6rvfEhX5u6bnOQrrzQzBvt3trBUDNMTPDqg5GVhYYt805np2Zd8mNogKO/l7AZ04kbY56lECqJhcrIyKYjz6aywpU+YVcBMUnactc07QZrlOzOZa9cPmndt9HzJY8tHm4BRaT5IQPBQYcwQN8AK//cyvj+paOfAa18AzXMpJZ2fFXSjsXPcU3mPegZ3lV4Bm9NNFSVdqwloc2nvYsZXL2sg6sp08jv+Sn3shFmvzavmu5WWkwdM0XJfL5CgZ7yfb1GOChk+tzWnbsciAu7KotfZ5aVRPEDevZOvfH2Yah8kdNy1wYytdHw1PUzz6GEB2XJPc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8585.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(10070799003)(366016)(7416014)(376014)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R627Yy6IJhD+A5p3laBBag8yHoL8hr3QWZgEC3ko4aMA0tz6BTELq+/zh5YF?= =?us-ascii?Q?kxCGsgarguLEmU9RSlTKMNezCVLGCL7MYSawrEzfT1ItCxPegBwjgY6KHwMa?= =?us-ascii?Q?+5Lk4QAZOJImt3wawijdIPBmYCVgs/Z0hTMKewvCnC5wmWzAP4E/ekDy1aP1?= =?us-ascii?Q?SrpmfJXucRr/JI4R0MSU4+eyDoK+stgFqoYzK1JgOMRZtkixqBEBXNnx4+oM?= =?us-ascii?Q?vS4FqA+NgcbN6Uv8igreKU8BA/iOHlOU617dgWBp/Kab91GE13XjxaHgi2Ek?= =?us-ascii?Q?VmJQQJoCfogaD5XlSg78JEi59/2veOTZDLMZWBHO/KfjRteVvTBhs3aVUpxO?= =?us-ascii?Q?vYIM/+uxhqymDcByGB/XDRD3ztUm9pzmahO3MpW+UtplTX8tFlV1Zazo6zqD?= =?us-ascii?Q?V9YvFFxrZxQhqWA45YlwtP7TlElBrMu1b1XO8aPBlzDm7XqyLbDipEnyHvXF?= =?us-ascii?Q?B3ippoK7a1VbKs4MQh/BRWxl3XrmQy0Jxtn80IJBdteklLrk3BbphW9j4a4s?= =?us-ascii?Q?LgiXAljhyroHCrPCYpYRffuaPJhz5l6rv5qUQBtTFD2/YsiZA1VfvKu7cbrU?= =?us-ascii?Q?DkI8Z1Z99gp/Pu0Io6SCBmlZeyd+gB9HHa5IkVmEUcdNXy7wmW06dbWnrq/y?= =?us-ascii?Q?R0W5TF78Ow+gLpmH3CgdK7jwp4pj7dbpeiSnOK9pVrLbKMWUOB4/ryTFdoGJ?= =?us-ascii?Q?T7T4jikx8OTxF4XhP+dzuXKo56JAw+6Ofs7KQEQ7nDFdDdkJL36WutcJEF92?= =?us-ascii?Q?52RxtHcqQmBCSnneDemnCLAveMqMxPM1StUzw0yWEt8O2+3wlOOjIHuJvGWO?= =?us-ascii?Q?LNRikpWXvvyPkBU9WEJUYzA338VyFoE2D3pSPLLIiYn1ul1wQdw2H2agsIzr?= =?us-ascii?Q?Ehc8RPKUpLWg7LCl4RUAqF0B6n5Cn/zfRu2vPJygHT28EoOLw2RkmcnZ/z91?= =?us-ascii?Q?SZGo6C3OJhNhRAR7BBTNjf+uRrRth2fx7qRkGLrnu3aZdKpo6ENcjHA5ykjh?= =?us-ascii?Q?4StvqCNbHakfkc0CaEvbAaZ/ZpMQfBjwdUIFooZiX4TuJi0MmyKQYbRqYSn6?= =?us-ascii?Q?i+GE6drcIeYoD9P6G6Xow4hHEBWSw+LTNMfPsQi2LN3WZeWmpIO3IuGDfO76?= =?us-ascii?Q?xn819VrPXYrJh0tmHFKnV6TewEccubOSUOtFcVhddNrRRp3VQTBS/SYIQ8VQ?= =?us-ascii?Q?0nWG+cYAHu+WE6U4vf1wLffLDy4SBg4eLQDl+YVsaClmdoP3/9GB4HNypFNt?= =?us-ascii?Q?siycXkSYAwidcENub8eksPGyatOOF83tm4cc1ELjrjew3aqU8OzFmnUFJ+E9?= =?us-ascii?Q?Ny3qeY2lOkcgfcYQ/nylTRhJyM53HHfZIN+MlpbjsWsEoLOpmHr32aCyVC6l?= =?us-ascii?Q?3zp9u6AXbDF7clCPFaubvHITdxAQsAR03QnABwpQ52eSHQhhUA2UdnMeboD3?= =?us-ascii?Q?cHegUOiaz3QIt1GZezs4gCLXY+4eLX5/m9JakQt3w3FnZuyprt5HaM5cLscu?= =?us-ascii?Q?aNwxvgXoOKyGuXFWvrm/TK3HK6mHdk0rUBuIOpruW2fNYu1kh/EllEUOVq0n?= =?us-ascii?Q?v9ty8y4zt5BoHAou0K2eCXo+9ZTBGGJUmxzEZfmgSi1WWvK9vshYVf4CAVKS?= =?us-ascii?Q?fGPUva7tgqSokPL9FA8yNFg8LkHY0RBa9IFheDoer0soosJwzU6pkjNJZ10b?= =?us-ascii?Q?9l75C/myGqc5uGfaIHpv5Dryb6s3zhbathKQxtV9lJTa1jCqKdGqvLk6HTGC?= =?us-ascii?Q?a/cn54xZwHNaHeOcDTFHCS+vFZ+RBG/qRuD2IUs6C5roGDBfK85w7hYDtbwa?= X-MS-Exchange-AntiSpam-MessageData-1: Gw+SO+3M4ro7zDmdTuYKv87xY6/EIF+tbWI= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c93ea8c0-3821-4135-ba31-08de941ce745 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8585.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2026 20:41:39.5090 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5oEk39C/6LgD7WwYuYUIWMExJjeTZwnj643SicBOQZY8muB4/KQoVo8cYDPw7dxx4vG+IHSWuDrudP98at9Lrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8347 Content-Type: text/plain; charset="utf-8" The TBCIR (Transmit Buffer Descriptor Ring Consumer Index) register has the BD index as the lower 16 bits, but the upper 16 bits contain this field: STAT_ID: Status identifier. Incremented each time the BDR_INDEX is updated and an error status bit was set for one of the processed BDs. Clears on read. If there was any transmit error prior to the ring reinitialization and this is the first time we re-read the TBCIR register, reading it will give us a value with non-zero upper bits, which is saved in bdr->next_to_clean. If subsequently NAPI gets invoked and enetc_clean_tx_ring() runs, this will dereference the &tx_ring->tx_swbd[] for the bogus (and huge) next_to_clean index, and will result in an out-of-bounds memory access. Other places like enetc_bd_ready_count() do mask out the upper bits, so let's do that here as well. Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drive= rs") Signed-off-by: Vladimir Oltean --- v1->v2: none --- drivers/net/ethernet/freescale/enetc/enetc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/eth= ernet/freescale/enetc/enetc.c index 5b97f9e668ba..a48ee3040b80 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -2604,7 +2604,8 @@ static void enetc_setup_txbdr(struct enetc_hw *hw, st= ruct enetc_bdr *tx_ring) * adjust sw indexes */ tx_ring->next_to_use =3D enetc_txbdr_rd(hw, idx, ENETC_TBPIR); - tx_ring->next_to_clean =3D enetc_txbdr_rd(hw, idx, ENETC_TBCIR); + tx_ring->next_to_clean =3D enetc_txbdr_rd(hw, idx, ENETC_TBCIR) & + ENETC_TBCIR_IDX_MASK; =20 if (tx_ring->next_to_use !=3D tx_ring->next_to_clean && !is_enetc_rev1(si)) { --=20 2.43.0 From nobody Sun Jun 14 08:20:33 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013029.outbound.protection.outlook.com [52.101.72.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5146E2C11E7; Mon, 6 Apr 2026 20:41:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508116; cv=fail; b=X2g7r/AK5i6J38l1lxKB1fTeO/ii60Lb4Echnm+aWx/YZJBpo3PqJPZ+jXSguX8jJpbzzr69R6XQhRgOkv2qXuR5R0uPjiej3Smp7M+M4JCkAGiImmD5MKj93sW0B8Mil5PTfjJyZQS/5UQm8eW3iKRNjXGIT2JclTYk3XCPNeM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508116; c=relaxed/simple; bh=ZhHWAytwR0ubCUgf0LTwsz3S85AIRevfns2yZJmeBU4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=J11phk+lsN447uUCGCDSZsH7tdnOJdv0moCCnP8nKfGUMxd40Eg9dxoeieeAHmwT8fEbwCiHg/SxIcnYzJz5hPIJIDxa/obHB4TPfwltBEnPt7no7e38YCL3uemyQb0Jv+/7insR8Xhg5sXfmbvu+tcYgS4bC7baeCWKNcy8T6M= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=d7WNn35j; arc=fail smtp.client-ip=52.101.72.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="d7WNn35j" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Kb6yEnNwBXFi+XxyRziDjfBdC91wwgpPraWHCwl+7p61hgOcJyEj8LSzhM2s402O8EfYivviQPJDWkukJ5fR1yo2t08QUAovO+KCYp1cbYbUTiMNRsrXEAlVF+B586IUXHOc8OS13Ww85tkYKLWxQAWpr+JSFiPLmHtZBtoAElpFAZvB+CJtevZGCdef/eN5zKVG4atNRWCGDQXWjLFvCDEu7AEwhb6RrJKBTb5rHR0USYuX2Z+Rd6hb7mO6qi4SinPwtjZu9HrR6hRKzGqBOlRRKaW4G4HT7g7DCFZOXZ778MTxKhA1HzdV5Bnk+0MssJhvqk3iK2pqEPBnyoynWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5GevJqQ3FyRixkTsSfoR+g+laWsQI6lBTA3GelCi2mc=; b=mDxd/3f0Zkv7+UOG6dVzsd/+KGcXv6xwQidi5RSg3YVs5HsxFd4dgMt4yfkRpQVCxmXoOnnb/UBXMJFWxnNmmO++MTHrhIa/ZLE1sAvIAX8hU3G8e9nSKD/SLwbxt0DwjxwWBkIn2mzRZ4DlXtBNMQte/PJdI88v0xlv16z79Ruyk7i0qFmCV/Ja0YB/nbudQIMw5PaHVdz9yLBgOw3AKgL0/ndn5ZkLlI+Gl8PP/rLEfBKOoUCKqQ7wAvr4jlrm4ijyQ7vUlyICe3kCIx3sev/4Lrfdxhy6DP7xZOmEh6gO33+Bi10ZMcMeRKePSgHPIqxlnyztw6bqA9URJdTC6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5GevJqQ3FyRixkTsSfoR+g+laWsQI6lBTA3GelCi2mc=; b=d7WNn35jZTRhSPojj2IpMKCyVNjPHKatMwijypOjqxINvUWedeBjSEFYGJIb5mlSgtTFxy9wKiqS0j/EwFtHE9mSDoihye+7mBth6eS7aImA/nlrhfT4GnCgcnsFPELFyhYHCP1XjvGZkc8EvXhEpS4+AIBL84MfAYOBPy20YlAl1BLvtCSUVoWJbUbFurCu0TP5voIp7CqQ4UcrwPNC8EOWgziujuv8xiKRm9QLd0x0iQslpjF7CAlJt48JpfVCgHH7HN+HOHRbfCfPoxxFCHIzZAnkT8J8sNCc0rPAmJBFszBYfUxFgPXrs16km3UP93fhWRFNz6PatnAW5aPTMQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) by DB9PR04MB8347.eurprd04.prod.outlook.com (2603:10a6:10:245::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Mon, 6 Apr 2026 20:41:41 +0000 Received: from AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4]) by AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4%4]) with mapi id 15.20.9769.017; Mon, 6 Apr 2026 20:41:41 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Cc: Zefir Kurtisi , Claudiu Manoil , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ioana Ciornei , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Simon Horman , bpf@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 net 5/6] net: enetc: pad short frames in software Date: Mon, 6 Apr 2026 23:41:21 +0300 Message-ID: <20260406204122.167237-6-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406204122.167237-1-vladimir.oltean@nxp.com> References: <20260406204122.167237-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: WA2P291CA0019.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1e::26) To AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8585:EE_|DB9PR04MB8347:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e08a1e6-149e-4807-16df-08de941ce871 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|10070799003|366016|7416014|376014|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: H5FDKB8pGTRvDWo73CKzk7KL9AGDIagkDLjITaMt4x2BU4aywiOVH4fduS+MDAg1eTh9toFfGf8tpTVRJV2UeauzjCkSfqK+SBNuOQVrh2Xk1uqKIJbo7whgY4JpIf9pkE6TSu4yF4nGWtJY2zpGT3SIOZTZHwzrtZt73nj8NT5hqsY1XuruLMgUksOL+FFJLoPEKXkC8SPJuknoFMw+SZ+JOqF7GtNmR8QGEZAx2RSi76TjPmXd7Hg+wYM9BPqhVt2ISDj8tOqhLisKoxz6jT7bcrjn7ib7OkG98q6R6gOgZlBmeefOjHQ0TiS8iOIrodKX39MQ1fi1oa022/adc09yyUxhgTNkilGRrmNPqKwmq/iu0iEXjomO3IaB/gxQvXIZyvH5y4+bQs+HGjxS501gOfpqO9Ce7pODb/VT/FpJIFdU6FZSsSWS0BouGmnULkjfEQPI8IMmoBGOTnKZpQb9bix6i8mDF3iiHFNsOyn1NlngPnxYAlcm7rATtD45tBZ5ZllLhlMoWsLSLcUtrsJhBcPu+/YhBcKqlvNhdmXt0MRkifTzMJJuOjEOC6F81swnkqVFkJHFGOKL5w4Mld8LxqL7rB72sY723J+BTZpzHukY2p2In/neuWrBPd69us8uY8ySLZZT9Ezm836EQLJYvhnl4ENP0YI99cCnt2ujlk14A5dLerx2rASGR1Hx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8585.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(10070799003)(366016)(7416014)(376014)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QpeV24DyecPBB23sR8Nbwzg079mwIocjYp3lia2oa8eFk43i0+Z6Tm55CiBP?= =?us-ascii?Q?4RgY1e1eA2shZ8jIPTTlVdmulwk9+S17JNvzJZC+V7Prr9KAXGBYD7k/EqQ/?= =?us-ascii?Q?IYqLlhSq2D+rsZWnTPfmWzJStM5c6EzOt2tw3pDK2UfhWU+Kiooi3MOntNuh?= =?us-ascii?Q?trUupcffCF8NXY+J1T3E5Khl2RpF3aKa4QNYBDS1EHJobv83alMQ79V1O73f?= =?us-ascii?Q?rB3Lfz9caCU0/+z0vFWO2UssYK+IpVQJc9mMh4TeB7BpuwouWTHUld88wsId?= =?us-ascii?Q?ez1ds8mAQtydwYnXyY6C+mg/hySvEiyq1+OiyDU23EaR/JK7B4nbS7pg9PSu?= =?us-ascii?Q?lv5/guGpiu2FVfGA+yj/Aw991hL9VagEVMcJPK434KqdIyk3X9bVucidWiiH?= =?us-ascii?Q?nLt3MEyF3S1JyqHaUoK7cLyyZHzDZljRMpvJxWpFkNXcEs/IkfTQa2J3/7cl?= =?us-ascii?Q?+b7cq2K8cMcHeO92KVKIkMqVoVYKPhVD7TdeBdW5YY2TRzu9uw9fRbaDUxbt?= =?us-ascii?Q?Xr9bQ75PXZwgNBYqH5hpCgici8nO9eMHfJTwpLW1maCQhE4os55v/2RO/fcG?= =?us-ascii?Q?G4E6gtH+tPdNAImFL1NKbqbPlWHanm5aFCx5W3wM+4A+pitE+8wVpGkaYxzs?= =?us-ascii?Q?YLAEV7zQ5ksHovMMe83hq6b2b+NqY59P7EMFK2v+2gjuzV9jGRfSEmGSH0/4?= =?us-ascii?Q?43zNSaJBg0ZERCXMTeApR7VLiRtcLKw9joqoDYxZ/cVAiQtrTkMiM/K7N/UB?= =?us-ascii?Q?rG4VxU/AYOri/XPb616m9uvp4ycvXaUBAI/fHsIPZswR4J6bWwe8QvpKLMog?= =?us-ascii?Q?xfH5Cv+DzuoZLTMQMjxlxFII8uk7226ibrpT484pmYPnunHi7S6QSrRKZ9Q+?= =?us-ascii?Q?MF38Ll/RafzoB/rpIfAtXOngdOLF6TfokM2nxEsefpTi3tpffeMR7XYggF9x?= =?us-ascii?Q?pst8QvIoq1N0vXMnGaMq+kUCCUclObmPU1TPrccxAlSzNgGvmYNgfQm/KQEe?= =?us-ascii?Q?lsfFlLEETIZopFUSkJq55KquLfki6UCfSDwx1GBpmT3iXmwDHvJ0LCWfTS8e?= =?us-ascii?Q?kdsNfqgoVxYKNtISWUAa2yJSN9CBhMTrKqgTwQb73CA34iZtYx5fuvk3+s6b?= =?us-ascii?Q?alkIGRUgeG07f+Mr4A1PigLQlY/jW8hks+0sLLbZp6cxrXbINRN+2HHFxuS/?= =?us-ascii?Q?6C9z69CjAaFqE9rUv71hLXf1Z0tuDPKlDVv8f+jUmT7Zp1umsIECrkVshBfS?= =?us-ascii?Q?Lg1VIs2K9cNQrQuaJyuNDlFZnUO23y3Wew67vaNfrzBl5pI7mscuU66CauE7?= =?us-ascii?Q?1bqrM5Vm3U4PQwRVqQhTLaqN4LVi6+FsYsb/vjARWA1VUtAR7CceL5Blts8I?= =?us-ascii?Q?JhOknDhLxkHeMLmfBeVMiifc70DHwCeg1JWBaY1ZjSm/ottXHoDewyrcAbgz?= =?us-ascii?Q?V0vDyWv5bx10Y8dnc7QmKbUi3ia/FVwBofcbb2Fu016LQJrSxQ/BOM+lPymj?= =?us-ascii?Q?45AukQXsTslxrKm9LvFYIqM0qQqVQIL4DeLe2ThkbyaW8vMxJuixI3hZd36N?= =?us-ascii?Q?6DjX1MrhjBshwFD3uKVTMKNN9DbCNjCLl4evLf57DIKDHcOQ0PJO+148iOIa?= =?us-ascii?Q?oFwLkaKz9tX+RLMKt0VkmSqiFGVYV7lJ91h5dB310lmtr9BkVpTUnzJv1ccS?= =?us-ascii?Q?ai4T4bW7z4fE05d/LLz5K90jVsWdXisoTPo/sse6jVCeFRfPCLHV/7wCtIbw?= =?us-ascii?Q?1/BNSb1ygXyrfx4N1YOWifV0GKZc5OQUs68X/a0z3Kf0k+p+Kj7b0JPpRtqa?= X-MS-Exchange-AntiSpam-MessageData-1: kpJ6/SWsHo7LnBe/yBBmQcCynYhB/atJY7A= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e08a1e6-149e-4807-16df-08de941ce871 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8585.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2026 20:41:41.4451 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IYn6b4AgmAxvc+zUyiA8nMh7zLrflNoX6ivCvwQEC2apPbPfFPrqHEL+fcDWVMp1LSjEidhfaAxrs7LEisDV5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8347 Content-Type: text/plain; charset="utf-8" The ENETC does not support BUF_LEN or FRM_LEN in TX buffer descriptors less than 16. This is written in the reference manual of all SoCs supported by the driver: LS1028A, i.MX943, i.MX95 etc. Frames must not have a FRM_LEN that is less than 16 bytes. Frames of 0-15 bytes are not supported. (...) The first descriptor in a chain must not have a BUFF_LEN that is less than 16 bytes. I don't think proper attention was paid to this during development, we found the text at the end of a bug investigation. Therefore, the driver does not enforce this. But the frame length is out of the driver's control, and the network stack can actually send packets with skb->len smaller than that. The result is unpleasant, as will be explained below, so for simplicity sake, we just pad anything shorter than ETH_ZLEN. Zefir Kurtisi found a case where transmitting L2 WNM keep-alive frames through ENETC would soft-lockup the host through an IRQ storm. He later distilled this into a small enetc-killer.c user space program which sends a packet with MAC DA, MAC SA and EtherType IPv4 (14 octets in length) through an AF_PACKET raw socket. The IRQ storm is actually a curious effect of a chain of events. The hardware behaviour, when an invalid BD is put in its TX ring, is that it would transmit the packet as normal, update counters, raise completion interrupt as normal, but it would just not advance the consumer index of the ring (TBaCIR) to signify that the BD has been consumed and is available for software to free. The ring will also get its TBaSR[BUSY] bit persistently set to 1 afterwards. It deserves an explanation why the behaviour above would lead to an IRQ storm, since ENETC interrupts are message-based (MSI-X), and an unhandled interrupt would typically just be lost rather than retrigger itself as a wired interrupt would. NAPI processing in ENETC has 3 steps: I. the enetc_msix() hardirq handler disables RBaIER, TBaIER and sets softirq processing to the 'pending' state. II. the enetc_poll() softirq handler for the IRQ vector walks through the TX rings affine to that vector, checks which ones have a TBCIR updated since last time - enetc_bd_ready_count() - processes those completed frames, and clears pending interrupts in these updated TX rings by writing to TBaIDR. (I've excluded RX processing due to it being irrelevant). III. After the softirq handler does its round of checking all RX and TX rings for updates, it re-enables all interrupts in RBaIER and TBaIER that were previously disabled by the hardirq handler, and exits. Because the TX ring with the short frame is skipped at step II (TBCIR wasn't updated as part of HW malfunction), its pending IRQ is not cleared in TBaIDR by enetc_clean_tx_ring(). But because enetc_msix() disables TBaIER at step I and re-enables it at step III, another MSI will be fired upon re-enabling it. This is what completes the cycle and the driver goes back to step I. So the driver misinterprets the mixed signals it's getting from the hardware, and ends up causing a software-amplified IRQ storm. Fixes: d4fd0404c1c9 ("enetc: Introduce basic PF and VF ENETC ethernet drive= rs") Reported-by: Zefir Kurtisi Closes: https://lore.kernel.org/netdev/b3d9136c-2803-4203-b1ea-1f9e62de80a1= @gmail.com/ Tested-by: Zefir Kurtisi Signed-off-by: Vladimir Oltean --- v1->v2: handle the BUF_LEN limitation too, independently of FRM_LEN --- drivers/net/ethernet/freescale/enetc/enetc.c | 13 +++++++++++++ drivers/net/ethernet/freescale/enetc/enetc.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/eth= ernet/freescale/enetc/enetc.c index a48ee3040b80..c70df45422e0 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -1050,6 +1050,19 @@ netdev_tx_t enetc_xmit(struct sk_buff *skb, struct n= et_device *ndev) u8 udp, msgtype, twostep; u16 offset1, offset2; =20 + /* Hardware does not support transmit buffer descriptors with a total + * length of less than 16 bytes, or a first buffer size of less than + * 16 bytes. + */ + if (unlikely(skb_headlen(skb) < ENETC_MIN_BUFF_SIZE && + skb_linearize(skb))) { + dev_kfree_skb_any(skb); + return NETDEV_TX_OK; + } + + if (eth_skb_pad(skb)) + return NETDEV_TX_OK; + /* Mark tx timestamp type on enetc_cb->flag if requires */ if ((skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP) && (priv->active_offloads & ENETC_F_TX_TSTAMP_MASK)) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.h b/drivers/net/eth= ernet/freescale/enetc/enetc.h index aecd40aeef9c..819e643538b1 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.h +++ b/drivers/net/ethernet/freescale/enetc/enetc.h @@ -21,6 +21,8 @@ #define ENETC_MAX_MTU (ENETC_MAC_MAXFRM_SIZE - \ (ETH_FCS_LEN + ETH_HLEN + VLAN_HLEN)) =20 +#define ENETC_MIN_BUFF_SIZE 16 + #define ENETC_CBD_DATA_MEM_ALIGN 64 =20 #define ENETC_MADDR_HASH_TBL_SZ 64 --=20 2.43.0 From nobody Sun Jun 14 08:20:33 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013029.outbound.protection.outlook.com [52.101.72.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 855DB30F94B; Mon, 6 Apr 2026 20:41:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508118; cv=fail; b=rRaU3PXPSbnrR3PrFiGMaYqNV5T7supl6t+zqbujrVgeKIaNsKa1IBf+Nzn7atAHkoWrh8ftBzp4PkxKB26kJeL5EdQVicOmFehOJczw+jWSrtm+wLxFaF1vWIiXEJZJ+svu9NKaio1NzWmXJ16Afwnkm9a9shYTaNxNwmcjl8k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508118; c=relaxed/simple; bh=zBw3Ylbwsj1kCY8qa7NH0oTZGTVuU4pdCpBZJAPEBi8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=HIb/9FUT61bskS9WS0tWq7KFsvi1QsJj/0+4b+nfcUja1lOIdsppw9HxX9l5CzHztl7qomu/UddYvP3eNa0zvDggQL6tTl6SN5HWADe6dWhiSeIq2+gVV074P0R2Auk/To8saA7XFHwnULqIfD7qo5wvS5MkkanoiypNtA0qj7A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=FAk8uuNr; arc=fail smtp.client-ip=52.101.72.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="FAk8uuNr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mvKMEir7Rfhip+2IMZZaEyAVE+uI2fJfQhsmgviwCTrmXqd9QrgsoHakernFoO0LXfjjYdjfTzeoC0kmgcqAXoL19cKW/NMGWF3WtY98ZEMhUyIM9k/psnuomnq6WbfIu0iIA75ydLqv2lU6T9LUE9Fe3iZ7VFSQ/rGtHPhVI50m9ltPMGzgG1yM9+K+dSR4ktbyupvwrQ3aOfui1hLTlU+jhQeINn4jFus7opSFZAo1OBMaOMUQI5XG+ud2BBJxA3XoYRUO1NxOE1cgulXtUDNZOdSSk/bdg41WwsYbmf4YZLpq3nPsheDCtjVP9ma0sFD1XtwEs7pjVghEWmGZNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ggx0MDj0n6q9KOp6w6WvkpbbvrIkB9SSZZXNJ85oWDE=; b=r9KLLV95E2+FVjtfVjvsXidYI5BJRioQBsp70XI7AnvERL+83b0tQxjqqCgDfw0YCEDPoLjvajA7btX4d1cphJJFn4/f3vyrxbcXRAX5lT0eJ0bpLiG9c45sK0sDlNfMKUKpCziX9ER45ObeTjWX3Z1mSnGc40+EvLplVXJ6qlyOa6a1XDO4iaXst7vqKOwykZvYjjCUZfKa7X2mPBvPFrlY8+K59ry8eSAdzwLDpQKINTJJBCnpjkYhTvdCjthZLTLA8OxvlX4N3SE/Yb+R+ZUZJxq0D/+7CtfiprwpOrpty7aMMj4obakWL3FYI+yTeLg194O+mITxpgGCd3QY/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ggx0MDj0n6q9KOp6w6WvkpbbvrIkB9SSZZXNJ85oWDE=; b=FAk8uuNrnX0RWrsyVSwRl6AKh5UlM0bVKaItmcxr8fRA92kSvJsuahWyuusWPUkQpnhAdoLmvp6Q3utIcFJVGXF6MN7ZudZXkqaQ62YKQnP7EcEeinZPI+41qtoEhqg1DjRbHMT56F+BhX1b9Zw2YJ/mMvFWZXrwCiuecKTZGAeoDJgxjWONjSubczH112e+o2S+9gIeKQxTnQzVgHWKOT4gNg9yB6c8o6joJpF1do+zGDZwjhwTH46ZbeJyqzm9Vcf3XsCvyUCTPd7p3jKBv46V4zRRi1OL7Z6pu0pXvff37QfWIJunN9UgF8+5kd6m5+ZYX3xEjKjLCLhjjibvUw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) by DB9PR04MB8347.eurprd04.prod.outlook.com (2603:10a6:10:245::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.21; Mon, 6 Apr 2026 20:41:43 +0000 Received: from AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4]) by AM9PR04MB8585.eurprd04.prod.outlook.com ([fe80::f010:fca8:7ef:62f4%4]) with mapi id 15.20.9769.017; Mon, 6 Apr 2026 20:41:43 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org Cc: Zefir Kurtisi , Claudiu Manoil , Wei Fang , Clark Wang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ioana Ciornei , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Simon Horman , bpf@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 net 6/6] net: enetc: pad short XDP frames coming from devmap Date: Mon, 6 Apr 2026 23:41:22 +0300 Message-ID: <20260406204122.167237-7-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406204122.167237-1-vladimir.oltean@nxp.com> References: <20260406204122.167237-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: WA0P291CA0015.POLP291.PROD.OUTLOOK.COM (2603:10a6:1d0:1::20) To AM9PR04MB8585.eurprd04.prod.outlook.com (2603:10a6:20b:438::13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8585:EE_|DB9PR04MB8347:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ca71c76-d5db-4136-46a1-08de941ce996 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|10070799003|366016|7416014|376014|1800799024|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: Z0szbtvcQoweGZypzfal4pnR8q9nVgP+BKUgQlqsGPQtw2Uj+19l29rxGQL4Z0JAGME5U+qibcDTW70yEcILbyqa3Xk7qihQIKI1zSYd0qkp5AO3SD9W+4H8y7EHBRvcav0+UgXrsoWs9rahoJa3o7tt0yObGmSwO3wWR8hVz1sqm+0E9ueW46QuopKzc7jKnq26x0IWLGkyMngefWO9iGVYB66BURL0xRexNWZcUs19JyZse5XKJdeGk9Ht2mJF78KpDdQHcBnquUHaKbxPpMO7jsomQz6oduACi5b29+sBVeg+jNKMWIs280N+JU4FdLIaa7U2dighLQ1WfE5XMq5tpY+Oh2fMWFeyZfvSLcbvsV14yQcLwi0orRsxNLTVPiNaqeaBmTkYy3bUXJ6Q8PuxDn7fqOlvw7gWusKWFwNJrPYC1qqiAqb8kybJytlM/amWfnogvncrqXqmWDzv375Vk38lqiKPrjwc0AzAy8zABfqp/TpaP3dpzb4T/oTURiN1VTRmkp4+5k1hubd6faBftScmOj+rpG8GxY4SC6mU34Gdno++vkenQK/69/S1ObuA9zDOH6BKc7F4orpLahvzBWyoJ1NJ68MNfpI+/7+cxj7j3chMmgnVDEo0mY2fkmarv0fnv8bSh0rIQoP7dzoK1SuQMfLtWMaZnnKSJslghFaGrp4e5FUlbdphKxlypSTtzleQw/fhw5LhJAkhhNlIj8BPRUIvrWghmqOQY94= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8585.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(10070799003)(366016)(7416014)(376014)(1800799024)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aQWXjuoIR4p6MisQtUDh2wytmx7uYQJ2PNw8Y7s46keSDHLwwAwcFlYYjZrj?= =?us-ascii?Q?Hi4WyBBtao58+EfwrK2DYxaSypG4JkUlSclUhA6XMJQwWp80pj9FbwU+6Wrn?= =?us-ascii?Q?sgd15QJYNpptCTieCb9q3446+u/qxVWqHd/aoIa33lUv5w6BJK5G9TgUMu38?= =?us-ascii?Q?l0eFl2x/lLAlRhUMVzjv5teb0ePtvwgqHH/DZSlrmpYmK//+nb3865lIMyrJ?= =?us-ascii?Q?uG+3C5zPgQKDfucB2jFXgBrxsH3JH9dTvvuph6x5DmbnTTOATHjy7cbdxoqg?= =?us-ascii?Q?OGdkza50FAqbvx9+r85636L83OX7k753iNKY1zB9RGkb/Bd4q0fJM/6kPJ+O?= =?us-ascii?Q?8IjnnUxfpaHsdbsbNVfUNS79fP4KFvUw50m83KexPIFCFW4VqaHs/acl9ZHX?= =?us-ascii?Q?JtqYuWiBUwUwMbp6CWXk3vMzc4o3G0hFlTA9TGCka0+iM468rCHRcJBbArFc?= =?us-ascii?Q?Jou2Ri594RhCBpwQID23SBQ2A29/i3FzMOGvGGxVeySd+1X0z3i6xriywiGa?= =?us-ascii?Q?uigSkP5V4h/biNNJ3rHem85vk0xeqlfel/0y6aF1+2p0PBrYS7/ZSg5WZ7yv?= =?us-ascii?Q?jkCBq51s46KaGXMQD/YrOASu/sLKOMeVyyWFKe881YVT/sTcQW1ALIW95+2P?= =?us-ascii?Q?XDen07DRmD9JfifhwvS924uHYMBBvkh8pFKnXyBatVnzkf/jvqaW4CqMR+QE?= =?us-ascii?Q?SUXEYRSKazEolTwzwgjBFROjuuQ018x3bzxwzRqfu4d4iNty0mOqtdk/gBYB?= =?us-ascii?Q?e0/FPZqSShbGXn+Ndfpsq4zTDrkU91whbF1fF56g2IkzE9YQzea7hbkOlBKE?= =?us-ascii?Q?bQSDTUfLm/Q0zUmc+EwCtSL6xwCpKKxW6/boT5FAoZuOvp/K2Xur54TSbHqL?= =?us-ascii?Q?VRewsIxgWAggtTnKtzUB1TiMh/EqP8dwcUYMDwy1BMDSzj3FU5Yo1gopYWBF?= =?us-ascii?Q?kPWDy3oIzKYlbu0M6qH9cQTaiMYq/e+gtv5s0vAVP888x+afdraU2luRz9IK?= =?us-ascii?Q?caVVSSN5q+pYv9KmoZAZunnuUO9bUFFz6uDm+pPjK34aqGzDA74cDtrD4xJS?= =?us-ascii?Q?0O4uOYLx881XRVaDBNV8l6mARcBq7MxcaE+E2whPObbV/r0+ZNvahtIUni8z?= =?us-ascii?Q?JAi1fOTz1uN2Q3BXwVVSrwQNg4S888XAg16QsqOxZzpdLRFJ3EVY02uWdqJg?= =?us-ascii?Q?IYqKef19R43bWe2lMltCmSyh8y6Hp6vqqx0c4lt5eU8ShYi7KYYJoD/DcwTN?= =?us-ascii?Q?G3xWnOPGJPBgUDQeeGfOnufi4MASEnYud+nJnQTyEH0tBVSXAq0DDreDqQ9P?= =?us-ascii?Q?DxFw1KAAyJPuds8pNNEcTnLn1g05QDP5CUMdKFS/tlsOr/8+ffLie8BWlYAa?= =?us-ascii?Q?fHhJ31vms7IM6UMW4TsdrCo7tJHRxFilpTbBp0pAMCuLunWs4+JrQ+oHAXap?= =?us-ascii?Q?EhsLM3PvWN3B+Vnu3ow+mKa70Ob0lSmR5ZhSKQjzUZIZtw1qP0xC1zjUag3D?= =?us-ascii?Q?HrStGemeb3UxQCTDqvmBsOebV8T/GJmHZdBbuqoISjXWqzHhwyZANhimiOul?= =?us-ascii?Q?mxH7cdMhoGIjATXgYuy07t+I7/f7KxsTD7wIap8xW9okubMj4Ft8sFZthBlX?= =?us-ascii?Q?joKeIHdqg9XhAdQxlp/ETA0E1tnWo5oR56bItBG84XaatLVCHq371uLZbTKR?= =?us-ascii?Q?AJPSsGEqbpZLhAkgFBDhEZi6e91AO6p9bGEfrKx3jGzJDc2yGH6+/5kiD6bp?= =?us-ascii?Q?s1sowcK5Az3Y6oASUnr8c9MAl+P2CO0Mo80v19Y5JHgMvMvMoOzIIFj49HE8?= X-MS-Exchange-AntiSpam-MessageData-1: n8Y/hosDvSRH5LGpKivdJF0i4FjDkXJXg1M= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ca71c76-d5db-4136-46a1-08de941ce996 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8585.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2026 20:41:43.4264 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FMRq4/m833x6X3Mt6j0Cn/5cGUXeqtB5MMn+cSlF71trjwhYPC04h4C451xPsQ2+XPwC/dj0LBCCRJRQrXPoMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8347 Content-Type: text/plain; charset="utf-8" Similar to the skb path issue explained in the previous change, ENETC could end up transmitting short frames coming from XDP. The way in which this could happen is a bit contrived, but it involves XDP_REDIRECT from a veth interface pair. As for enetc_xmit(), there are two separate limitations for the overall FRM_LEN and for the head BUFF_LEN. For the head BUFF_LEN, we add a direct restriction in enetc_xdp_xmit(), and for the overall FRM_LEN, we introduce a xdp_frame_pad() best-effort generic helper which we call from the same place. This helper alters the frame, but that should be safe, because ndo_xdp_xmit() is the hand-off function where the XDP frames become the responsibility of the driver. AFAIU, struct xdp_frame doesn't have multiple copies. I say best-effort because xdp_frame_pad() can only expand the head buffer of an XDP frame. It cannot expand the last fragment of a multi-buffer XDP frame, because, unlike bpf_xdp_frags_increase_tail(), it lacks access to the rxq->frag_size, aka the capacity of the chunk of memory being pointed to by the fragment. So, if the frame happens to be less than minimum Ethernet size, but fragmented, callers of this function will have to drop it. Fixes: 9d2b68cc108d ("net: enetc: add support for XDP_REDIRECT") Signed-off-by: Vladimir Oltean --- v1->v2: - handle multi-buffer frames instead of being unaware of their multi-buffer quality - add separate restriction for BUFF_LEN - increment drop counter --- drivers/net/ethernet/freescale/enetc/enetc.c | 10 ++++++++- include/net/xdp.h | 23 ++++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/eth= ernet/freescale/enetc/enetc.c index c70df45422e0..196b7828e2aa 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -1816,9 +1816,17 @@ int enetc_xdp_xmit(struct net_device *ndev, int num_= frames, prefetchw(ENETC_TXBD(*tx_ring, tx_ring->next_to_use)); =20 for (k =3D 0; k < num_frames; k++) { + struct xdp_frame *xdpf =3D frames[k]; + + if (unlikely(xdp_frame_pad(xdpf) || + xdpf->len < ENETC_MIN_BUFF_SIZE)) { + tx_ring->stats.xdp_tx_drops++; + break; + } + xdp_tx_bd_cnt =3D enetc_xdp_frame_to_xdp_tx_swbd(tx_ring, xdp_redirect_arr, - frames[k]); + xdpf); if (unlikely(xdp_tx_bd_cnt < 0)) { tx_ring->stats.xdp_tx_drops++; break; diff --git a/include/net/xdp.h b/include/net/xdp.h index aa742f413c35..276afc9aa21d 100644 --- a/include/net/xdp.h +++ b/include/net/xdp.h @@ -477,6 +477,29 @@ xdp_get_frame_len(const struct xdp_frame *xdpf) return len; } =20 +static inline int xdp_frame_pad(struct xdp_frame *xdpf) +{ + unsigned int total_len, pad; + void *sinfo; + + total_len =3D xdp_get_frame_len(xdpf); + if (likely(total_len >=3D ETH_ZLEN)) + return 0; + + if (unlikely(xdp_frame_has_frags(xdpf))) + return -EOPNOTSUPP; + + pad =3D ETH_ZLEN - total_len; + sinfo =3D xdp_get_shared_info_from_frame(xdpf); + if (unlikely(xdpf->data + xdpf->len + pad > sinfo)) + return -ENOMEM; + + memset(xdpf->data + xdpf->len, 0, pad); + xdpf->len +=3D pad; + + return 0; +} + int __xdp_rxq_info_reg(struct xdp_rxq_info *xdp_rxq, struct net_device *dev, u32 queue_index, unsigned int napi_id, u32 frag_size); --=20 2.43.0