From nobody Tue Apr 7 04:33:31 2026 Received: from mail-dl1-f54.google.com (mail-dl1-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6729839C00E for ; Mon, 6 Apr 2026 20:14:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775506445; cv=none; b=cCxHBKU/cG1jUI5kgpm0wYbmX7/eh0z+cKryANGMJ6WA65xPXsLbtn0qZ+5/+pWH8WxnxsoR2Qnm+9tkh3ZFh40EdEcluFQ82NV/RJxKUy22pUpJEeIBTnTkdM+cN31Ckr1KryIOxUD87Lx8XkY3tkf+1ZYcLeidSdogjs7BquQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775506445; c=relaxed/simple; bh=QpvEj1emH+D7uyjHFu5brDKzkv5iOsNgAWo3QDRZ4T0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TyZRqtA89UddkuF1fG8KmPSLByBZhXO8psN3fw3mcVQSbFCxaq94lA/ok9yPKs5Rlyurkxg0iunchwzGxgzK5ctfajiLe35PMvdZfTrH+BqIne2SB8HKAMYqllxclxMWi4UZ1uqN7Wf853nzRHjF14bGusQuUsPqCGFma5JJTGk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PB9uVzGY; arc=none smtp.client-ip=74.125.82.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PB9uVzGY" Received: by mail-dl1-f54.google.com with SMTP id a92af1059eb24-126ea4b77adso4786827c88.1 for ; Mon, 06 Apr 2026 13:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775506444; x=1776111244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hj5KeLYeiV8K9ipCUKl33iACfT1+nJcLiRAjRSTKr8k=; b=PB9uVzGYA6vJaXCeU0dy9dKynpZCyKgtvtBDZw8hD+PfdYLZl5zxKlKDWkYFeV3Zol rvZ+l14i/o/F1wJy8i2C1JgQfIMwXQe2aDS2velbLC1x2iG31grWZmO6qlpqm/kmfsof cF+NalFxSEoSKGuCvBRjmTQ8iqYOJOAZEm406kXQYEcxYL0P0+cAkuBGpMz6pG2Ze8DW WGqFXZ1iMW21AUBOgcYh9RrJWDKnhASs759bbq35sY/xN7uLmUaTi532bemPBXRrsczI SQjVDtSgTo2lsXzKb5WsmRn2Tjp80Md18KAfKTynDp2N+T0gajmijdCjueeb2af3Xdqn EcJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775506444; x=1776111244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Hj5KeLYeiV8K9ipCUKl33iACfT1+nJcLiRAjRSTKr8k=; b=dGl8vqmps8QMr6HU+2kNO2zA+ZIVweYrXskY123bjJp96BvvJkvkn3x+PHXrkyidfo WofxNRivDJozzTfQbpcKg5l2ftXzs4VkWuHUbL6cyVr6dRSfuJYzj/S3g96q84OMsqeW ll7W1jBIZrN+sHOaHRtLMfGxEnkO3g0tchYLN9R4G2NFCYnPPFm+fHOuXWd1qpLTwTlX YC7gvEON0WjM0TxvlgkBpX+iWWh5vTSgFxTx+SJdp4H1/0lKgak12dTmCAUMupKCjmsY CCRDTZEnWXFW7igtVSh/FiJdCsmYZh7NqYMWfQ/Ta433qlnynlrDE6STiAxn/BA5EXep NfIA== X-Forwarded-Encrypted: i=1; AJvYcCU79/kRuTRU9EJd+/NLG9BYA/2/a2Ad3YwUsddHMKuP5Hk1y30VYiFGKB5Pg73Qq3SDCLqiPTF+z18xRhk=@vger.kernel.org X-Gm-Message-State: AOJu0YyKHaWASfw8uY6CM12ZOMWFC4RjBha6pg92Bx6YMzenXvfQlOFB esehosOdDgShQce5c5z+Z+pL5FPVZd7dt2CNUEzN7CgrnduSs7mnDH3r X-Gm-Gg: AeBDiesJy3HEruA92LMaig27GevJ1TlFLmgZ28oXYhh5o+L4XJwxCNGJZitmD+r05iY +kEwsf/G3VeXkjwDcZIvjx27czCoEFMG8jkhAME0PHI5oPmJ4KpZYZYJx+6uXLCLYWAbKjS757P KOWLQk05okwYLk8LH9F6j50ftSEauDuidBlkM+eylARTNYzM8nMVHMd6PfiGwRvj0zqGTGHBW7T k/fwAMMaPwZ4M1jAXO36Bp1E8Pzf2wfWPZxi4rOhjMhb+4VlNLaNxM7t1ZJT7LHHdr0jm3J3RX9 NQBVNZ5XPskcv+pgGxpapQ43S6GDmDlKBqM4go5gT0hTt2DVxhK2MwSkdaSEP1agRHg/ayNHbje 3CwjjF2ICIdhyFWj7P2VF8uoX4X03NvIrUOTaJ4KVe6MBvMcJNm1Dv/hnLxiANuCcG2NtCLb/UC dIsqg49zq3G3IEs6doSTjUeanKxk3bEsk6EReSY+he29tUruWm4hgFCJx+1VbSXK85E+kJjLbWF PHm X-Received: by 2002:a05:7022:f30f:b0:12c:43:839b with SMTP id a92af1059eb24-12c00438781mr2653107c88.35.1775506443579; Mon, 06 Apr 2026 13:14:03 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bed93f861sm17022333c88.0.2026.04.06.13.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 13:14:03 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v8 01/16] platform/x86: lenovo-wmi-helpers: Fix memory leak in lwmi_dev_evaluate_int() Date: Mon, 6 Apr 2026 20:13:45 +0000 Message-ID: <20260406201400.438221-2-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260406201400.438221-1-derekjohn.clark@gmail.com> References: <20260406201400.438221-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Rong Zhang lwmi_dev_evaluate_int() leaks output.pointer when retval =3D=3D NULL (found by sashiko.dev [1]). Fix it by moving `ret_obj =3D output.pointer' outside of the `if (retval)' block so that it is always freed by the __free cleanup callback. No functional change intended. Fixes: e521d16e76cd ("platform/x86: Add lenovo-wmi-helpers") Cc: stable@vger.kernel.org Link: https://sashiko.dev/#/patchset/20260331181208.421552-1-derekjohn.clar= k%40gmail.com [1] Signed-off-by: Rong Zhang --- drivers/platform/x86/lenovo/wmi-helpers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/lenovo/wmi-helpers.c b/drivers/platform/x= 86/lenovo/wmi-helpers.c index 7379defac500..018d7642e2bd 100644 --- a/drivers/platform/x86/lenovo/wmi-helpers.c +++ b/drivers/platform/x86/lenovo/wmi-helpers.c @@ -46,7 +46,6 @@ int lwmi_dev_evaluate_int(struct wmi_device *wdev, u8 ins= tance, u32 method_id, unsigned char *buf, size_t size, u32 *retval) { struct acpi_buffer output =3D { ACPI_ALLOCATE_BUFFER, NULL }; - union acpi_object *ret_obj __free(kfree) =3D NULL; struct acpi_buffer input =3D { size, buf }; acpi_status status; =20 @@ -55,8 +54,9 @@ int lwmi_dev_evaluate_int(struct wmi_device *wdev, u8 ins= tance, u32 method_id, if (ACPI_FAILURE(status)) return -EIO; =20 + union acpi_object *ret_obj __free(kfree) =3D output.pointer; + if (retval) { - ret_obj =3D output.pointer; if (!ret_obj) return -ENODATA; =20 --=20 2.53.0