From nobody Tue Apr 7 04:35:04 2026 Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79F0A392C5B for ; Mon, 6 Apr 2026 18:05:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775498735; cv=none; b=uK4d+s43yenvmn/kwcIbEcnah7YVElLdAosWM/87H++BVNypjE18UZybwRt0iCqJrBtM3xpNi+1lnoQBZKN8owAWva1AuEaxQT/23cTr5Nrv99piCu/fAbepNBzVwoTN9yczgXvtDTCiUE5Laz+hDp0OBLxZ/nGXIU3CqOVW/m4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775498735; c=relaxed/simple; bh=i9Dlhy6KmGeyPCFecRkazd93QFltkDDdeAA6Ep5s4UQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ch/Jao/RLxLPGm6o3GK5T5KgnGN/MlTzmPVEsKPWWm0YWm7YuXKZbPTY37oUCP0NRIUisIB7EVFt5ppHT0JdC6zq+5CxwCjAX6G3g4rwLG/W0C29M0/k9GhX4V3880P2FIiNZK3PlTwlPyeJAQCsexXuEheQEC8nOHA1mqdZROA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=am9jveDI; arc=none smtp.client-ip=209.85.214.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="am9jveDI" Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-2ad9516a653so20738535ad.0 for ; Mon, 06 Apr 2026 11:05:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775498734; x=1776103534; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s5LdGYUb6kFydxANMiMpTYECSq+5KGtGmECDY4Es5lg=; b=D9AQhwiVHBBUbtWtWOMKsrbzlCi3Mt2gnnVSn2DXCDYWHugKaaAOx5/28KeOnNhLWu mdY+93BY7epg9Gq4dpe61JDxCg3k9kxLs16nq4nQlIbFIpBTHHEMp2fe+SQuokmS1Nqy D6CURQCmU4Zxwb/il3XsFgsY3Mw1PLM4hyMo0gQnx/BFvbPQPfNLAYr6j10bdUtzC0Da k8pzbQ/d6r14+9zbL3vYWQZgxeF9FZ5ngsC42UWyZc+1xAreBJyg5/bbeSgrc1uMiLac +d3v70Pa+VeH576C0WKlHUKc3l39Q3iekhspy/3gevaZ9v23dEF9o+aQoHYVLTuCu5Of 3Yww== X-Forwarded-Encrypted: i=1; AJvYcCUfaY0qp9gy14yyQA5R2am/iki3wON+xWIjsYeflhZjucKieC65MzNj9NO1RrbbNtJYCr8mDioaXkyPIlc=@vger.kernel.org X-Gm-Message-State: AOJu0YwrzIu0bsy4UXzTN9Pg+EqC5wR7XuEqZ0nciltYy6WejBB0hK5b k8usdNomK66+1HEAAYCCXp/W5QOsgHiHogcSR2AUlsqJQokJXynR8HX21CtBTjWNpCdXEUiA+H4 Oy71GWHjnN5Lx1HWqVldKoDtuy1/qvUx7ss6qGvRIm8zGQKaGDLKu9s1xU5Wo/4BY4X9nnDLhdX Dq6raxF7faLJdyE8gbVSa+zgO1oXBPYGrv0eKX5cNFyfVG8XFHMA0YPR4H3ffg/W1M2ZXCUdZQG nKVQ++fMATgpQdgz/mbJ5UGAw== X-Gm-Gg: AeBDies/5IzVzj+4It4ev78DjutnZP7q/jy5Nn8rG6zfzllLUD5JGUivY8lnuv8G4cK FJp85YJS7SW0Q2JVKdCIDmmhtbF1kSIXHXkBGU6ODvgIR+DFoEL4y7vm5cNMLmVVBkFHRwTaQyw E0RiCqi+9LbdRIDB5tgzz4NMn2HFTB9hG0zjCL5Z8LN9FJJW2pzhkWz4I+BuAYNpMym0TH/vw7Q W/OAIyC2RhkcpJRWGSJr+OOobSa7GdcisWzX7dy2mjz9A+Kti77gupSDvJjMA56VN6BYXr2r936 tIucnoI1r31rOs9sfQ4oSfsa2iOVxm+a3XzBSymJDFuJX7BddQIH2yFfeN4Ra2c19kEi86/KoKy i4WtpoCwaBfxTuXbcgK9t/ZwJ/17aNdniFK+flTqw5Ml+3oNT/b6Qx9NmtvdJV1CQ8Ez50q7f2L E7QI47wumtmnaHB2y9IXDANIrzd62mx12Y7aKRJ6X3kwoKwRkKjmeiKPNe6tq6HX0= X-Received: by 2002:a17:903:a86:b0:2b0:4aeb:dedc with SMTP id d9443c01a7336-2b28178ad51mr124785495ad.26.1775498733823; Mon, 06 Apr 2026 11:05:33 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2b27477c531sm9801845ad.24.2026.04.06.11.05.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Apr 2026 11:05:33 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b0b57e192bso32680305ad.1 for ; Mon, 06 Apr 2026 11:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1775498732; x=1776103532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s5LdGYUb6kFydxANMiMpTYECSq+5KGtGmECDY4Es5lg=; b=am9jveDIq+mjwm6maITA2Xt7Opn7UDz/FT9brKhASAn8hSgsveLcZxqVuUDfCSC48S AiONUYPKQ8OyKS7CGI4plM5OhC5f60AwAmXWxd2x1+r1crvBj0hePZVHRchmvmGYpKRv x5qOaDWacbfZr/g1wPvIjMMHgUfD7NeCR1oqA= X-Forwarded-Encrypted: i=1; AJvYcCWEd6CvCKOpBiY1viCxtuYsj0gU1rB6uENKYo8Fd1kHzUrEE9ntqckIYKS0P7dxMuC4EQflrUG8nXYGvVg=@vger.kernel.org X-Received: by 2002:a17:902:ccc9:b0:2b2:539b:d2b1 with SMTP id d9443c01a7336-2b2816cfd51mr132266875ad.16.1775498732147; Mon, 06 Apr 2026 11:05:32 -0700 (PDT) X-Received: by 2002:a17:902:ccc9:b0:2b2:539b:d2b1 with SMTP id d9443c01a7336-2b2816cfd51mr132266375ad.16.1775498731622; Mon, 06 Apr 2026 11:05:31 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749a475fsm140625145ad.61.2026.04.06.11.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 11:05:30 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rahul Gupta , Ajit Kumar Khaparde Subject: [PATCH net-next v12 07/10] bng_en: periodically fetch and accumulate hardware statistics Date: Mon, 6 Apr 2026 23:34:17 +0530 Message-ID: <20260406180420.279470-8-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260406180420.279470-1-bhargava.marreddy@broadcom.com> References: <20260406180420.279470-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Use the timer to schedule periodic stats collection via the workqueue when the link is up. Fetch fresh counters from hardware via DMA and accumulate them into 64-bit software shadows, handling wrap-around for counters narrower than 64 bits. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rahul Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 98 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 99 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 290bf1cd96c9..6f41dff3fbcb 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -69,6 +69,9 @@ static int bnge_alloc_stats_mem(struct bnge_net *bn, if (!stats->hw_masks) goto stats_mem_err; } + + u64_stats_init(&stats->syncp); + return 0; =20 stats_mem_err: @@ -294,9 +297,98 @@ static void bnge_timer(struct timer_list *t) } } =20 + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bn, BNGE_PERIODIC_STATS_SP_EVENT); + mod_timer(&bn->timer, jiffies + bn->current_interval); } =20 +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp, sw_val; + + hw &=3D mask; + sw_val =3D READ_ONCE(*sw); + sw_tmp =3D (sw_val & ~mask) | hw; + if (hw < (sw_val & mask)) + sw_tmp +=3D mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *= masks, + int count, struct u64_stats_sync *syncp) +{ + unsigned long flags; + int i; + + flags =3D u64_stats_update_begin_irqsave(syncp); + for (i =3D 0; i < count; i++) { + u64 hw =3D le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] =3D=3D -1ULL) + WRITE_ONCE(sw_stats[i], hw); + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } + u64_stats_update_end_irqrestore(syncp, flags); +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8, &stats->syncp); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats =3D NULL; + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr =3D &bnapi->nq_ring; + stats =3D &nqr->stats; + + if (!ring0_stats) + ring0_stats =3D &bn->bnapi[0]->nq_ring.stats; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8, &stats->syncp); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats =3D &bn->port_stats; + __le64 *hw_stats =3D stats->hw_stats; + u64 *sw_stats =3D stats->sw_stats; + u64 *masks =3D stats->hw_masks; + u16 cnt; + + cnt =3D sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt, + &stats->syncp); + + hw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt =3D sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt, + &stats->syncp); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + static void bnge_sp_task(struct work_struct *work) { struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); @@ -309,6 +401,12 @@ static void bnge_sp_task(struct work_struct *work) return; } =20 + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bn->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } + if (test_and_clear_bit(BNGE_UPDATE_PHY_SP_EVENT, &bn->sp_event)) { int rc; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 15ededb801f6..a73f51b01bc2 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -278,6 +278,7 @@ enum bnge_sp_event { BNGE_LINK_SPEED_CHNG_SP_EVENT, BNGE_LINK_CFG_CHANGE_SP_EVENT, BNGE_UPDATE_PHY_SP_EVENT, + BNGE_PERIODIC_STATS_SP_EVENT, }; =20 struct bnge_net { --=20 2.47.3