From nobody Tue Apr 7 04:34:56 2026 Received: from mail-pj1-f99.google.com (mail-pj1-f99.google.com [209.85.216.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 419D5392817 for ; Mon, 6 Apr 2026 18:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.99 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775498705; cv=none; b=kcWIIlLk2hjW/UADyNqkQNIsJ7ZzCB7G4M7p4UrOHdDFI/ql7sfSZ6b30s5Zw/FGslAcSDix3dIXDxwLq07HW2h7UJXitkkXy9xssxXNigW6GrKT3wczmoInjoINzch6gA0W/C47PfFSLt73LPx33McAyebWWIaXrNaJXjb5HMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775498705; c=relaxed/simple; bh=EYofg1gpQ9rfOnBFkagL/sjEY+BAK75kZAJ+LOzBbnw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mj8dP4D0/cC5CGS8NOBcAIWCq8/BhMbGU+Z7TmXcUw3hgrEMhZxphW+zvaUhW2/xWs7JleF6YPsy5lEZLzZ4DOEiOhzHYTa7GsWNr8CShbs3uYKQaTnOIneKvAbb/iO3mz+gYwJ58GDZbyN9rAVjT38LMroos802lAWRTvwTwUA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Y8DPPwyP; arc=none smtp.client-ip=209.85.216.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Y8DPPwyP" Received: by mail-pj1-f99.google.com with SMTP id 98e67ed59e1d1-35c2fe0d90fso2465485a91.1 for ; Mon, 06 Apr 2026 11:05:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775498703; x=1776103503; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cFGH6qymgtvzYwWHNnXSxQD4gLAcLHVZRmJAUNjPk0M=; b=F2ETtLJ+BWi0iwvxjKeql9WwthhngaqoAkuwQV+nVGVUIwQ8u1enpEq4ytWzMTKrbc wPAOC4ycaobDrcuZ63Q5H/5aql2sG8MLb1wqEA+BXiqVN8TUKIsB81ah/QtBaalDWGS9 xcJwvmgXJUUeOGYpWH98zH/cYdqDq5Kb29k36uDW+YLIqghpmbEd/k/i4DzEHjc7HHzr Ylo+FRAVhc1w/T4VVLn+DLi/EGrS///DBo26eSmwNYZtdB/8iQqJMD+OeKXQfTqrr8Y5 FxeThGgX5yFEF5JTDxEpvQ0QMn9tUiU686ChOOTLdR99Klhkd/sHX9IqKLAArbk5sYHE nO2A== X-Forwarded-Encrypted: i=1; AJvYcCWrkVSQvfWA21qJTLo5WkHmWFzTFZ2RgIVxLj5qycmc03cQEC3Cb7C6KtKNYjblQ0mQ67HwCnjR0HRH6SM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5xYG9CdOAGWeAb4mXVoMe+zKfWS6TWG6dyCXX+JOrMJKwgZo3 P//n3xuazcGMgGYyzE59du+3M3+CiR1h78xy5GYVkjI1Xvus7ousFP6unwyw91grtE81WdXdF41 GmnbQMjdUW2k0l6yoTFGbgS7ntr1usyEIlm+KLfd6jL3i9hapMxCADr8pKqkc5AGZA2VSY8epqW JJFDjl6eDwwKTWdXaFjoaX9O5GTiMKvIN3k+l8XgZ9qm7R/jsFfTv38QsKZakObYVM+nB/KB41S FyiqvYxJn7MBVO+HCDm3nQ6Cg== X-Gm-Gg: AeBDievCeNgrPP3Eaf7xJrEKmA/EucIwFkJewqCH1p8EcSyT9163/dPwSbbznFqCR1B rmCmrK+j3IQXxISVtMU8aHfviFZWhDC7yMEzr88jpjm7SiT32n4sHNLvCEcWNOamOlCIDqOBm/W mbnJqrVAxTE9fwvnzGF8ytFA+Vtih9FKIPbVETaUYhrlShsgb2RHYGwWILGPytO+5LNUDq9GPkY OibmDb1rRvDZ3v8VcVeJIU95n7gGfvm+JJ3LvyRlX4jZJSYkp2oFiYvOVveF+0oa7ZQEKVl3ftW OIjgbzLXOcVFZVL6sX5tFBUhU+H6TXFTCyFW0uY4GSPv2kxEHUe/Z5669p8GfonjayCN46GSstA iHrwNwxj9uMC5yLjBOEUP2jc89cOpOvnoQOie5t0PjXEr76iYLEx3B/5kKf5KwohgjmmAfuOruk XSBNyMMOx0o2vzPPoMafdXOLeDbUHmuslZwvmB7VfZWObI7mOpNfaE+TuMdsGUnKU= X-Received: by 2002:a17:90a:d406:b0:35b:945d:752a with SMTP id 98e67ed59e1d1-35de68f82damr12907797a91.17.1775498703304; Mon, 06 Apr 2026 11:05:03 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-15.dlp.protect.broadcom.com. [144.49.247.15]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-35dbe42cd82sm1545486a91.0.2026.04.06.11.05.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Apr 2026 11:05:03 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b24cd2e2b3so45096105ad.0 for ; Mon, 06 Apr 2026 11:05:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1775498701; x=1776103501; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cFGH6qymgtvzYwWHNnXSxQD4gLAcLHVZRmJAUNjPk0M=; b=Y8DPPwyPBXgXCRcswyXZhBPbM2Sc8+KbbBDMK0w3auduQKiEpgT13BR+R2YPhpLryT yAVj9MT9nlEdR/ztCUksrWbGYNeb0J1t0NQXXxj+6SOy7FRzhpYeKoo1Weh9kGhGPVFo He7JTmG6CesmLTokYcjk9mtpz0lqAxtijQZNg= X-Forwarded-Encrypted: i=1; AJvYcCVUeP91iVqNiUoETQvj+ZWuQYzdUrshkQY0ZOKVOk4Op8OBtV5QUCErNNWpQQrOYFbDhqSn1fccEMmNixY=@vger.kernel.org X-Received: by 2002:a17:902:e78b:b0:2b2:4d36:7ba with SMTP id d9443c01a7336-2b2815b522dmr145873975ad.0.1775498701470; Mon, 06 Apr 2026 11:05:01 -0700 (PDT) X-Received: by 2002:a17:902:e78b:b0:2b2:4d36:7ba with SMTP id d9443c01a7336-2b2815b522dmr145873655ad.0.1775498701005; Mon, 06 Apr 2026 11:05:01 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749a475fsm140625145ad.61.2026.04.06.11.04.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 11:05:00 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Ajit Kumar Khaparde Subject: [PATCH net-next v12 01/10] bng_en: add per-PF workqueue, timer, and slow-path task Date: Mon, 6 Apr 2026 23:34:11 +0530 Message-ID: <20260406180420.279470-2-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260406180420.279470-1-bhargava.marreddy@broadcom.com> References: <20260406180420.279470-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add a dedicated single-thread workqueue and a timer for each PF to drive deferred slow-path work such as link event handling and stats collection. The timer is stopped via timer_delete_sync() when interrupts are disabled and restarted on open. While the close path stops the timer to prevent new tasks from being scheduled, the sp_task and workqueue are preserved to maintain state continuity. Final draining and destruction of the workqueue are handled during PCI remove. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 59 ++++++++++++++++++- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 12 +++- 2 files changed, 69 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index a20dc3ca640c..8d5d828e19a3 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -101,6 +101,36 @@ static int bnge_alloc_ring_stats(struct bnge_net *bn) return rc; } =20 +static void bnge_timer(struct timer_list *t) +{ + struct bnge_net *bn =3D timer_container_of(bn, t, timer); + struct bnge_dev *bd =3D bn->bd; + + if (!netif_running(bn->netdev) || + !test_bit(BNGE_STATE_OPEN, &bd->state)) + return; + + /* Periodic work added by later patches */ + + mod_timer(&bn->timer, jiffies + bn->current_interval); +} + +static void bnge_sp_task(struct work_struct *work) +{ + struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); + struct bnge_dev *bd =3D bn->bd; + + netdev_lock(bn->netdev); + if (!test_bit(BNGE_STATE_OPEN, &bd->state)) { + netdev_unlock(bn->netdev); + return; + } + + /* Event handling work added by later patches */ + + netdev_unlock(bn->netdev); +} + static void bnge_free_nq_desc_arr(struct bnge_nq_ring_info *nqr) { struct bnge_ring_struct *ring =3D &nqr->ring_struct; @@ -2507,6 +2537,9 @@ static int bnge_open_core(struct bnge_net *bn) bnge_enable_int(bn); =20 bnge_tx_enable(bn); + + mod_timer(&bn->timer, jiffies + bn->current_interval); + return 0; =20 err_free_irq: @@ -2542,6 +2575,8 @@ static void bnge_close_core(struct bnge_net *bn) bnge_tx_disable(bn); =20 clear_bit(BNGE_STATE_OPEN, &bd->state); + + timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); bnge_free_all_rings_bufs(bn); @@ -2774,6 +2809,18 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) if (bd->tso_max_segs) netif_set_tso_max_segs(netdev, bd->tso_max_segs); =20 + INIT_WORK(&bn->sp_task, bnge_sp_task); + timer_setup(&bn->timer, bnge_timer, 0); + bn->current_interval =3D BNGE_TIMER_INTERVAL; + + bn->bnge_pf_wq =3D alloc_ordered_workqueue("bnge_pf_wq-%s", 0, + dev_name(bd->dev)); + if (!bn->bnge_pf_wq) { + netdev_err(netdev, "Unable to create workqueue.\n"); + rc =3D -ENOMEM; + goto err_netdev; + } + bn->rx_ring_size =3D BNGE_DEFAULT_RX_RING_SIZE; bn->tx_ring_size =3D BNGE_DEFAULT_TX_RING_SIZE; bn->rx_dir =3D DMA_FROM_DEVICE; @@ -2789,11 +2836,13 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_= irqs) rc =3D register_netdev(netdev); if (rc) { dev_err(bd->dev, "Register netdev failed rc: %d\n", rc); - goto err_netdev; + goto err_free_workq; } =20 return 0; =20 +err_free_workq: + destroy_workqueue(bn->bnge_pf_wq); err_netdev: free_netdev(netdev); return rc; @@ -2802,8 +2851,16 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_i= rqs) void bnge_netdev_free(struct bnge_dev *bd) { struct net_device *netdev =3D bd->netdev; + struct bnge_net *bn; + + bn =3D netdev_priv(netdev); =20 unregister_netdev(netdev); + + timer_shutdown_sync(&bn->timer); + cancel_work_sync(&bn->sp_task); + destroy_workqueue(bn->bnge_pf_wq); + free_netdev(netdev); bd->netdev =3D NULL; } diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 70f1a7c24814..d2ccee725454 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -224,6 +224,12 @@ struct bnge_tpa_info { #define BNGE_NQ_HDL_TYPE(hdl) (((hdl) & BNGE_NQ_HDL_TYPE_MASK) >> \ BNGE_NQ_HDL_TYPE_SHIFT) =20 +enum bnge_net_state { + BNGE_STATE_NAPI_DISABLED, +}; + +#define BNGE_TIMER_INTERVAL HZ + struct bnge_net { struct bnge_dev *bd; struct net_device *netdev; @@ -281,13 +287,17 @@ struct bnge_net { u32 stats_coal_ticks; =20 unsigned long state; -#define BNGE_STATE_NAPI_DISABLED 0 =20 u32 msg_enable; u16 max_tpa; __be16 vxlan_port; __be16 nge_port; __be16 vxlan_gpe_port; + + unsigned int current_interval; + struct timer_list timer; + struct workqueue_struct *bnge_pf_wq; + struct work_struct sp_task; }; =20 #define BNGE_DEFAULT_RX_RING_SIZE 511 --=20 2.47.3