From nobody Tue Apr 7 04:36:16 2026 Received: from mail-vs1-f99.google.com (mail-vs1-f99.google.com [209.85.217.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCFC3395DA5 for ; Mon, 6 Apr 2026 18:05:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.99 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775498745; cv=none; b=FIya4eOo48t1NAcub6lMk/+J+p3QY9SJikDT5fiZCKlgudeoN2xwDdOrjVC35wVLX+eKSVHP3rvE0ePs6UZJllbYLeI+Jj0zZuygYFrIQ5REyMPjPpYbKw2z0mijBI97viwYNf/MueByLawZissOz6dYyEoebUxWyezKUGEZL/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775498745; c=relaxed/simple; bh=Cajp8ShyjCKsjkWXi07E3Ep1vQT5l4912QE0EORrpEI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LWUHZHNrHlPGGJ/4PXYAqB9A6CNqEUzNQSKFQ4J6qnX9dK12zN0KE+nnTXklLZW//vAYwMnttweeZ59jQDr1b+5XpgY/lSNIgLGXhy2I0vQOFJ0mFp/zqZKm3Xx/QPDS801x08ZGlkvK9gZ9uctlVCTZ3AkQ0GLW7dWa43zGn00= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=VNsq+l5w; arc=none smtp.client-ip=209.85.217.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VNsq+l5w" Received: by mail-vs1-f99.google.com with SMTP id ada2fe7eead31-604f1bfed92so3987290137.0 for ; Mon, 06 Apr 2026 11:05:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775498743; x=1776103543; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=62L+lkwkabTqrbJgOlUnrsnIX9RqZuB3+ZmXt/1peyc=; b=cZmHKbDT9vBMnxZz3a9wS3qe2aOayoillculzKN4QTHxwA3uK6GOhWiGjpm61Ev3bU gg+pmQcdfWUTvGvpOX8P3JK3xQqQkU4x5PIkNjSKh//nnTgl7vCwrBAZNdnPAFv1y4p+ uHi/k3VBTsCe+daU5Ow2hUD7SGu4nyhHCrmwj29OKSOoAKc4BTsFO13Ir4k3YDeVvC/f Ue39ruiJhwav127Eu9//9fw+OfeYmu5elMb7B9Sbev81KXe6QWUWH4GzY+7dDkaQHB18 K9nVkitjv8KfTTD3ajHmND2rkkVsis4yom7G1fPtONuuPwUulKcemYirJPcifNjapsjA mKOA== X-Forwarded-Encrypted: i=1; AJvYcCVY8aHNDpae8KSINsQpvO3h28A3sHj8WBBZWirGGBp3/SjishloBEepdFWs8A1qVppmUO3+XibQxE2uAWE=@vger.kernel.org X-Gm-Message-State: AOJu0Yxno4zhUllqCXjCvLDTQPOT/bVR20Jvk4Lg+fUoOsSJTrZoiCr1 RuLwEwy6wVD4DkZ+f/NitK9wF7R4r5m/wcnhRjUbIwwbw6kUM5S4ZRcJ/eT62CfPRUw/HIxDLNa uzLtDILMY0DnNd5oLsTA158qyWppjO4iLqjP+zMMIm2eZfHsRNVecG3q/E/jaJAkBvpXIC9g9qV UNqH9MtJ+QW0kZv6lYImLsJ8sIUOxmNltXB/8SC3zymmekjmc+IaDUm2jaRUbYEbwulbEEfZRvd ACXzA7RhUaMhPLjk+ZYa2j+OA== X-Gm-Gg: AeBDiet94BCgyFPKnr+PRfoNuPCaXsS5HumftKa9PdoAoZSnQP16i34jdqI2a56WXBW qGI8PJA4NxjmZ9KY++Vy+WJxGEGqvD/RYACDk1r/C5r5TeG1avSF/mM8abAuR20jvXsTU8PLzyn MYzFIH2xMd1eBrjAk2R4b1r/kZWuH4pnI7YUQW9ogsf2KgGc9q+JcyKI0WXQZ0gpQ/oI3fwGEO1 IEea7Bl0dkBZBV+jduVEOp3DOrQj0/enJhUsr3PWniLQZLZ0AD0v98qx995IzztDJoQI9G48RDU E0aT3IU/dFBbgxqN+tpen6XHXmxenZQsUq9OComj+LEVC/SmUulcD/YHl58i6gZHfSXqDdNr5A/ +BAys6P0ycAZHZiOHF1B4CpZUA3qdWIi36m2axVLKFmDLlRrhFYocSyxfKYO+qlrCug8l92ZDSa SJ3b7a447mqX2/cp5FT1RQu4I8mPKzmImt7jJwXghTAcAPFPvtAF2G4sB76eLeX+k= X-Received: by 2002:a05:6102:d86:b0:605:1f22:10f1 with SMTP id ada2fe7eead31-605a4e4d5c3mr5767509137.13.1775498742648; Mon, 06 Apr 2026 11:05:42 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24]) by smtp-relay.gmail.com with ESMTPS id ada2fe7eead31-6058302b0d2sm1150686137.24.2026.04.06.11.05.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Apr 2026 11:05:42 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b24a00d12cso45936285ad.1 for ; Mon, 06 Apr 2026 11:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1775498741; x=1776103541; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=62L+lkwkabTqrbJgOlUnrsnIX9RqZuB3+ZmXt/1peyc=; b=VNsq+l5wZz4JqxQ6dVCwegLb92wOKDtwD68XY8naDdjJApx3mCIasU842BGbgr+tMx 6z1clJzABLARHBau9KJ2vSbOmbd68S4AIEHoviufnzZCDVyQmAfcDZ44hwZMmzer77ZT vyiYmpYMGJvF4fjcgLyIhY4W5EXcy55Fgwx0M= X-Forwarded-Encrypted: i=1; AJvYcCUm4COZ4N52D6rdgmy3v2qq8bmc/uChnAs7DrcYaZRl/arwrE3V2PDjGM6NyUMeUSfSGplAtxIkdteSzAo=@vger.kernel.org X-Received: by 2002:a17:902:7c89:b0:2ae:5eee:7a5 with SMTP id d9443c01a7336-2b28167aa4fmr99852995ad.12.1775498741359; Mon, 06 Apr 2026 11:05:41 -0700 (PDT) X-Received: by 2002:a17:902:7c89:b0:2ae:5eee:7a5 with SMTP id d9443c01a7336-2b28167aa4fmr99852735ad.12.1775498740746; Mon, 06 Apr 2026 11:05:40 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749a475fsm140625145ad.61.2026.04.06.11.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 11:05:40 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy Subject: [PATCH net-next v12 09/10] bng_en: implement netdev_stat_ops Date: Mon, 6 Apr 2026 23:34:19 +0530 Message-ID: <20260406180420.279470-10-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260406180420.279470-1-bhargava.marreddy@broadcom.com> References: <20260406180420.279470-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement netdev_stat_ops to provide standardized per-queue statistics via the Netlink API. Below is the description of the hardware drop counters: rx-hw-drop-overruns: Packets dropped by HW due to resource limitations (e.g., no BDs available in the host ring). rx-hw-drops: Total packets dropped by HW (sum of overruns and error drops). tx-hw-drop-errors: Packets dropped by HW because they were invalid or malformed. tx-hw-drops: Total packets dropped by HW (sum of resource limitations and error drops). The implementation was verified using the ynl tool: ./tools/net/ynl/pyynl/cli.py --spec \ Documentation/netlink/specs/netdev.yaml --dump qstats-get --json \ '{"ifindex":14, "scope":"queue"}' [{'ifindex': 14, 'queue-id': 0, 'queue-type': 'rx', 'rx-bytes': 758, 'rx-hw-drop-overruns': 0, 'rx-hw-drops': 0, 'rx-packets': 11}, {'ifindex': 14, 'queue-id': 1, 'queue-type': 'rx', 'rx-bytes': 0, 'rx-hw-drop-overruns': 0, 'rx-hw-drops': 0, 'rx-packets': 0}, {'ifindex': 14, 'queue-id': 0, 'queue-type': 'tx', 'tx-bytes': 0, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 0}, {'ifindex': 14, 'queue-id': 1, 'queue-type': 'tx', 'tx-bytes': 0, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 0}, {'ifindex': 14, 'queue-id': 2, 'queue-type': 'tx', 'tx-bytes': 810, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 10},] Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 227 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 7 + 2 files changed, 234 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 4148a9ec6d23..70768193004c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2860,6 +2860,7 @@ static int bnge_open_core(struct bnge_net *bn) } =20 set_bit(BNGE_STATE_OPEN, &bd->state); + set_bit(BNGE_STATE_STATS_ENABLE, &bn->state); =20 bnge_enable_int(bn); =20 @@ -2898,6 +2899,77 @@ static int bnge_shutdown_nic(struct bnge_net *bn) return 0; } =20 +static void bnge_add_prev_ring_stats64(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct netdev_queue_stats_rx *rx_save =3D &bn->rxq_prv_stats; + struct netdev_queue_stats_tx *tx_save =3D &bn->txq_prv_stats; + struct rtnl_link_stats64 *stats64_save =3D &bn->prv_stats64; + + stats->rx_packets +=3D rx_save->packets; + stats->tx_packets +=3D tx_save->packets; + stats->rx_bytes +=3D rx_save->bytes; + stats->tx_bytes +=3D tx_save->bytes; + stats->rx_missed_errors +=3D rx_save->hw_drop_overruns; + stats->tx_dropped +=3D tx_save->hw_drop_errors; + + stats->multicast +=3D stats64_save->multicast; +} + +static void bnge_get_ring_stats64(struct bnge_dev *bd, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + u64 tx_bytes, tx_packets, tx_dropped; + u64 multicast, rx_missed_errors; + struct bnge_nq_ring_info *nqr; + u64 rx_bytes, rx_packets; + unsigned int start; + u64 *sw; + + nqr =3D &bnapi->nq_ring; + sw =3D nqr->stats.sw_stats; + + do { + start =3D u64_stats_fetch_begin(&nqr->stats.syncp); + + rx_packets =3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + tx_packets =3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + rx_bytes =3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + tx_bytes =3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + multicast =3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + rx_missed_errors =3D + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + tx_dropped =3D + BNGE_GET_RING_STATS64(sw, tx_error_pkts); + } while (u64_stats_fetch_retry(&nqr->stats.syncp, start)); + + stats->rx_packets +=3D rx_packets; + stats->tx_packets +=3D tx_packets; + stats->rx_bytes +=3D rx_bytes; + stats->tx_bytes +=3D tx_bytes; + stats->multicast +=3D multicast; + stats->rx_missed_errors +=3D rx_missed_errors; + stats->tx_dropped +=3D tx_dropped; + } +} + static void bnge_get_port_stats64(struct bnge_net *bn, struct rtnl_link_stats64 *stats) { @@ -2929,6 +3001,22 @@ static void bnge_get_port_stats64(struct bnge_net *b= n, } while (u64_stats_fetch_retry(&bn->port_stats.syncp, start)); } =20 +static void bnge_fill_prev_stats64(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct netdev_queue_stats_rx *rx_save =3D &bn->rxq_prv_stats; + struct netdev_queue_stats_tx *tx_save =3D &bn->txq_prv_stats; + struct rtnl_link_stats64 *stats64_save =3D &bn->prv_stats64; + + stats->rx_packets =3D rx_save->packets; + stats->tx_packets =3D tx_save->packets; + stats->rx_bytes =3D rx_save->bytes; + stats->tx_bytes =3D tx_save->bytes; + stats->rx_missed_errors =3D rx_save->hw_drop_overruns; + stats->tx_dropped =3D tx_save->hw_drop_errors; + stats->multicast =3D stats64_save->multicast; +} + static void bnge_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats) { @@ -2936,6 +3024,57 @@ static void bnge_get_stats64(struct net_device *dev, =20 if (bn->flags & BNGE_FLAG_PORT_STATS) bnge_get_port_stats64(bn, stats); + + spin_lock_bh(&bn->stats_lock); + if (!test_bit(BNGE_STATE_STATS_ENABLE, &bn->state)) { + bnge_fill_prev_stats64(bn, stats); + spin_unlock_bh(&bn->stats_lock); + return; + } + + bnge_get_ring_stats64(bn->bd, stats); + bnge_add_prev_ring_stats64(bn, stats); + spin_unlock_bh(&bn->stats_lock); +} + +static void bnge_save_ring_stats(struct bnge_net *bn) +{ + struct netdev_queue_stats_rx *rx_save =3D &bn->rxq_prv_stats; + struct netdev_queue_stats_tx *tx_save =3D &bn->txq_prv_stats; + struct rtnl_link_stats64 *stats64_save =3D &bn->prv_stats64; + int i; + + for (i =3D 0; i < bn->bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + u64 *sw; + + nqr =3D &bnapi->nq_ring; + sw =3D nqr->stats.sw_stats; + + rx_save->packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + rx_save->packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + rx_save->packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + rx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + rx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + rx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + rx_save->hw_drop_overruns +=3D BNGE_GET_RING_STATS64(sw, rx_discard_pkts= ); + rx_save->hw_drops +=3D BNGE_GET_RING_STATS64(sw, rx_error_pkts) + + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + + tx_save->packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + tx_save->packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + tx_save->packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + tx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + tx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + tx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + tx_save->hw_drop_errors +=3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + tx_save->hw_drops +=3D BNGE_GET_RING_STATS64(sw, tx_discard_pkts) + + BNGE_GET_RING_STATS64(sw, tx_error_pkts); + + stats64_save->multicast +=3D + BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + } } =20 static void bnge_close_core(struct bnge_net *bn) @@ -2949,6 +3088,13 @@ static void bnge_close_core(struct bnge_net *bn) timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + + /* Save ring stats before shutdown */ + spin_lock_bh(&bn->stats_lock); + bnge_save_ring_stats(bn); + clear_bit(BNGE_STATE_STATS_ENABLE, &bn->state); + spin_unlock_bh(&bn->stats_lock); + bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -2967,6 +3113,85 @@ static int bnge_close(struct net_device *dev) return 0; } =20 +static void bnge_get_queue_stats_rx(struct net_device *dev, int i, + struct netdev_queue_stats_rx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_nq_ring_info *nqr; + u64 *sw; + + if (!bn->bnapi) + return; + + nqr =3D &bn->bnapi[i]->nq_ring; + sw =3D nqr->stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->hw_drop_overruns =3D BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + stats->hw_drops =3D BNGE_GET_RING_STATS64(sw, rx_error_pkts) + + stats->hw_drop_overruns; +} + +static void bnge_get_queue_stats_tx(struct net_device *dev, int i, + struct netdev_queue_stats_tx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_napi *bnapi; + u64 *sw; + + if (!bn->tx_ring) + return; + + bnapi =3D bn->tx_ring[bn->tx_ring_map[i]].bnapi; + sw =3D bnapi->nq_ring.stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->hw_drop_errors =3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + stats->hw_drops =3D BNGE_GET_RING_STATS64(sw, tx_discard_pkts) + + stats->hw_drop_errors; +} + +static void bnge_get_base_stats(struct net_device *dev, + struct netdev_queue_stats_rx *rx, + struct netdev_queue_stats_tx *tx) +{ + struct bnge_net *bn =3D netdev_priv(dev); + + rx->packets =3D bn->rxq_prv_stats.packets; + rx->bytes =3D bn->rxq_prv_stats.bytes; + rx->hw_drops =3D bn->rxq_prv_stats.hw_drops; + rx->hw_drop_overruns =3D bn->rxq_prv_stats.hw_drop_overruns; + + tx->packets =3D bn->txq_prv_stats.packets; + tx->bytes =3D bn->txq_prv_stats.bytes; + tx->hw_drops =3D bn->txq_prv_stats.hw_drops; + tx->hw_drop_errors =3D bn->txq_prv_stats.hw_drop_errors; +} + +static const struct netdev_stat_ops bnge_stat_ops =3D { + .get_queue_stats_rx =3D bnge_get_queue_stats_rx, + .get_queue_stats_tx =3D bnge_get_queue_stats_tx, + .get_base_stats =3D bnge_get_base_stats, +}; + static const struct net_device_ops bnge_netdev_ops =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, @@ -3113,6 +3338,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bd->netdev =3D netdev; =20 netdev->netdev_ops =3D &bnge_netdev_ops; + netdev->stat_ops =3D &bnge_stat_ops; =20 bnge_set_ethtool_ops(netdev); =20 @@ -3212,6 +3438,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) rc =3D bnge_alloc_port_stats(bn); if (rc) goto err_free_workq; + spin_lock_init(&bn->stats_lock); =20 netdev->request_ops_lock =3D true; rc =3D register_netdev(netdev); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index a73f51b01bc2..f4636b5b0cf3 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -8,6 +8,7 @@ #include #include #include +#include #include "bnge_db.h" #include "bnge_hw_def.h" #include "bnge_link.h" @@ -264,6 +265,7 @@ struct bnge_stats_mem { =20 enum bnge_net_state { BNGE_STATE_NAPI_DISABLED, + BNGE_STATE_STATS_ENABLE, }; =20 #define BNGE_TIMER_INTERVAL HZ @@ -361,6 +363,11 @@ struct bnge_net { u16 fw_rx_stats_ext_size; u16 fw_tx_stats_ext_size; =20 + struct netdev_queue_stats_rx rxq_prv_stats; + struct netdev_queue_stats_tx txq_prv_stats; + struct rtnl_link_stats64 prv_stats64; + spinlock_t stats_lock; + u8 pri2cos_idx[8]; bool pri2cos_valid; }; --=20 2.47.3