From nobody Sun Jun 14 20:11:34 2026 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC87A33F378 for ; Mon, 6 Apr 2026 13:56:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775483814; cv=none; b=hqSci6zRDuazeqmCREO5Dqyf2Rv2sbARd2ygMf6N5R4iMw055k0iXhFZHQQPfwaFtv/SWbpUVFaIPDmALMFv9Gr5JRBzbDwQBlucXYgSYXTGnZH0TPcewAd+GtmOiduycaiQwpOlS5f0wTUAvExCmkCuvXAAgGOa3k3GkxWedig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775483814; c=relaxed/simple; bh=hSrL++7BFKBB2qjBSL6tIqon+XilxF4IH2+bdS1/RC0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=WjEBcmyjm9ciObaQ/5CkMnoEBDQJxxRPcAg7gh4GTtN/Ppzlh1CrSXk+nOlBkBcD8cH3F2FJ1qKx6kUIVmsHG92KF9b4jG+xzJnr3iR45uyr+YLKZ2KWpuGbx5YXQg3WQ/SDCUHnwa29iowO55LfiOmEtRqLyDzBUQF5dxTIwbM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=lvkasz.us; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.218.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=lvkasz.us Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-f67.google.com with SMTP id a640c23a62f3a-b941762394aso509961366b.1 for ; Mon, 06 Apr 2026 06:56:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775483811; x=1776088611; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OQtUgZBlTwv+xDoaiKb2N7gT+/y7cOGsVK3GMzZHFqc=; b=AW0DhTTdbWcOuC4qnWSJS6FFjhQ5NN8u5WBANMjNVMNrMLBdDJGd03OjR9pe1kRg40 7usUue/KSYpahDXXhrB7Pdn03sncf36YDExE2tMvfnZ948/Gaf1nkddsaiZLCGrAIB4J VQ9xxANqc1FEXBqG/jr4Mgc5iAO4D/0GcHqFvMWJ9oTMF0KWlHO/DA0iuPrTTq0Ycvd7 vUANNsKShPNZPE58Jbt9riBtbT43HiswuXleBq0j+1v3VqBh1GBVd3D7dCDR8OS7E+rR TQ3lTBsjZT6jOkgvvsGKENdFjveelRh9Q4D4q7d7xtavB30JRGVcGRL22vkmxLiKeWDg De7g== X-Forwarded-Encrypted: i=1; AJvYcCXAFFeJCo+Cv0kZOY4xctJ2ZZ8bleBBOx6fCNOw2BPK1R4d3Ss1RnQAUtsG8q28QY+o3e89dPreTbFD49A=@vger.kernel.org X-Gm-Message-State: AOJu0Yxy2RqhK+eAzlxVthfAT+vO760qdLW8CuF7f+55zPLBFbPV0GD9 dxbtBPqzbDbjrT0WdivrwF4DuNqkiw9Y631O7/Sy4/MbARaKlCMXN5bV X-Gm-Gg: AeBDieskWZjv96q1b/Or9P5OpRKcJ8J+TmbwDiqGYLUF5A4nEQqeaSsBna2rCCcwCmp JaGry1OfFy/mrDYaj8in2WOcsSlRJLI3IqS95GvIMEmTvLv7+74eWr/Mmd5BF1RtgeKovaseITu /XztGUNWc+eaGqcNogafcHo9pLlfVI2tLDPOFP9MAHlJJ2XjZXEDlzVyXZoUdsksW06hhTPKfKH N7HkSmcXlIfmJhSPEML4KWUCT0nxzlTW3EJGaW2f4zjBY4dyVZtxIa+izndGheR8afvyN7IZa8h jBY8DBEsh2GxPKeMsY6jvU/Bise66oragEpWt1v0v9ldwY+tgQn1rLHirCfOeUgj8wIm85C0FgW LdFAgsNBjn4Lx4NP1EVYXmtgdZZWN+Fk4sR0RjlCKwprohpVV7lWbBY9LRDz3Ba8siOQfB1IyAc UOOaWjrYO3PNcCOHk749Lav/7VUXUwpiMQM+gugJKm+wRahQ2HFTPvqr5pBLOguw== X-Received: by 2002:a17:907:2d9f:b0:b9c:b3b5:bbf0 with SMTP id a640c23a62f3a-b9cb3b5bc8fmr276106266b.6.1775483810728; Mon, 06 Apr 2026 06:56:50 -0700 (PDT) Received: from aorus.localdomain (5.185.72.109.ipv4.public.orange.pl. [5.185.72.109]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3cac0e1asm472921266b.27.2026.04.06.06.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 06:56:50 -0700 (PDT) From: =?UTF-8?q?=C5=81ukasz=20Lebiedzi=C5=84ski?= To: vkoul@kernel.org Cc: neil.armstrong@linaro.org, krzk@kernel.org, alim.akhtar@samsung.com, andre.draszik@linaro.org, pritam.sutar@samsung.com, kauschluss@disroot.org, johan@kernel.org, ivo.ivanov.ivanov1@gmail.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?=C5=81ukasz=20Lebiedzi=C5=84ski?= , stable@vger.kernel.org, Krzysztof Kozlowski Subject: [PATCH v2] phy: exynos5-usbdrd: fix USB 2.0 HS PHY tuning values for Exynos7870 Date: Mon, 6 Apr 2026 15:56:27 +0200 Message-ID: <20260406135627.234835-1-kernel@lvkasz.us> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The existing PHYPARAM0 tuning values for Exynos7870 are incorrect, causing the USB 2.0 PHY to fail high-speed negotiation and fall back to full-speed (12Mbps) operation. Fix TXVREFTUNE (transmitter voltage reference) from 14 to 3, TXRESTUNE (transmitter impedance) from 3 to 2, and SQRXTUNE (squelch threshold) from 6 to 5. Also explicitly set TXPREEMPPULSETUNE to 0, which was previously missing from the tuning table despite being included in the register mask. All values are derived from the vendor kernel for the Samsung Galaxy A6 (SM-A600FN), as no public hardware documentation is available for the Exynos7870 USB DRD PHY. With these corrections, the PHY successfully negotiates high-speed (480Mbps) operation. Fixes: 588d5d20ca8d ("phy: exynos5-usbdrd: add exynos7870 USBDRD support") Cc: stable@vger.kernel.org Tested-by: Kaustabh Chakraborty Reviewed-by: Krzysztof Kozlowski Signed-off-by: =C5=81ukasz Lebiedzi=C5=84ski --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung= /phy-exynos5-usbdrd.c index 5a181cb4597e..8711a3b62c8e 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -1958,13 +1958,14 @@ const struct exynos5_usbdrd_phy_tuning exynos7870_t= unes_utmi_postinit[] =3D { PHYPARAM0_TXPREEMPAMPTUNE | PHYPARAM0_TXHSXVTUNE | PHYPARAM0_TXFSLSTUNE | PHYPARAM0_SQRXTUNE | PHYPARAM0_OTGTUNE | PHYPARAM0_COMPDISTUNE), - (FIELD_PREP_CONST(PHYPARAM0_TXVREFTUNE, 14) | + (FIELD_PREP_CONST(PHYPARAM0_TXVREFTUNE, 3) | FIELD_PREP_CONST(PHYPARAM0_TXRISETUNE, 1) | - FIELD_PREP_CONST(PHYPARAM0_TXRESTUNE, 3) | + FIELD_PREP_CONST(PHYPARAM0_TXRESTUNE, 2) | + FIELD_PREP_CONST(PHYPARAM0_TXPREEMPPULSETUNE, 0) | FIELD_PREP_CONST(PHYPARAM0_TXPREEMPAMPTUNE, 0) | FIELD_PREP_CONST(PHYPARAM0_TXHSXVTUNE, 0) | FIELD_PREP_CONST(PHYPARAM0_TXFSLSTUNE, 3) | - FIELD_PREP_CONST(PHYPARAM0_SQRXTUNE, 6) | + FIELD_PREP_CONST(PHYPARAM0_SQRXTUNE, 5) | FIELD_PREP_CONST(PHYPARAM0_OTGTUNE, 2) | FIELD_PREP_CONST(PHYPARAM0_COMPDISTUNE, 3))), PHY_TUNING_ENTRY_LAST --=20 2.53.0