From nobody Sun Jun 14 20:10:16 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A88D306B1B for ; Mon, 6 Apr 2026 08:09:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462943; cv=none; b=AUErDfhmDRPFqlsSzTNCM/Bhryi4ujcGvuHasdQK02j4VCx0BrdxJ2OFzFZbcSWrkn85dq/zDqprZHCls9c/EMVzOKC5YsYnzQODf/v9vc2Y+3tFODTnBVbfN4NdPGFfKhgTONtQ7pg3KreiB9D+wzIJnhKx1EAbJtZNnd73DbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462943; c=relaxed/simple; bh=yqSb+xj+j+Zsm33QL0jScZhrcDvdKz/PHFkslCX+jao=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X2gGNq2pZdJCgQF6UraBvf+/qGTuEcavm1UhmC3CxXnY9hQQyTJDWxmB0qj+Om0DGqft9V5Py2ql0FZAc15Zi6cEnI2fMPp8pgG3nbmvcubooYI81X+dFSVtXvuoeBwwgWvyN57sQTLJdt2ynTX1o6fZqwxyR/4c50CJroR+Aw0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gg6j6gO3; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gg6j6gO3" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-3585ec417f6so1702321a91.1 for ; Mon, 06 Apr 2026 01:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775462941; x=1776067741; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WI8mxu0XOiC3NdF7Tl4p8eKdsZm/Gey97Qxo+LUKP1k=; b=gg6j6gO3+D1qmC8oyc04VsIgVRRO78WPM8E47k4KqQlcMXDKOi8W8EfU1eL+It1sDe fFT5mK9lVlY9hzm3SUgSrZ1xajN6lYdhpYhG39MiY4/1oZbH3C3wO7ECoFKX14FUDf2F LPcmi1TYK5XDoO/pIiIMMYfV3NqmhY57AIjLLv2ukMTqNW1CXpd3VnyrOn4q2B72yuul YzR0BRVtqBj8kBDPtwsygnYQCUEwobWFfyAfHxj9tZLmGVSsZdKcdXTgffN+Qg2GRCrv lndOsPjWD0pJ28uQWg0Ec/cbpl+mNalsWJlbyppNZPId7UDgXsgyHryRayrp3r6U9k5H sT+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775462941; x=1776067741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WI8mxu0XOiC3NdF7Tl4p8eKdsZm/Gey97Qxo+LUKP1k=; b=DVaqoAlDYPr0cqUaw2ozBLBIYSOlCdr79lqgrw1lJEWBljbRRHzoARdx5vCudc+L5A uvPM+ok95fg2nGXN/XhGjvoyGgd89gNc3dF2JO7UwM9qiW5L24zTulbkxUU/CiHtnmgP nWacIoK/e7xlyZFoyQNHYBzb5k5bQVd+JFeOBF0gBQse2ncB77gtyFQAS8uJYr6Fv0pP nKMqw+6YEddgaqEJnNUeQcKsm3tKF3hvsfAez6i9eDOHsOAfquhQcFmseQSTJoIk2tD/ MVGFNvOHwXbDF+I7GoA+CAwUi7Y9tYbJYVeaIGOGa+Y2tNtvPTvFBuuACPiWjqicebNf HQzQ== X-Forwarded-Encrypted: i=1; AJvYcCU/JbDj/eFFdVb73m6sWf8zlwvHeLqzF43zWli0mb8BVa9YR6LnRSxkiPzXv9Opk884EhDMw5x7lb5OTa8=@vger.kernel.org X-Gm-Message-State: AOJu0YxtdFdN2YBs4kMfQY68hbMe8MOZR+LukdQCbEBJdM9JnPmOfjIF QquqTHxS7vl2okjlwlrMfxzCQpQykfxjzm5Eg4VUX0Lh4VPdgHefoLeU X-Gm-Gg: AeBDievPOx1vgEzTb95aHM4ibTf4SSjAAxuBSsDB0e/Y4EkLU/ff1w0KagogTzmFUX7 gttslahJbv+jWR4TkYLt3+Na7vHcPBcDktkMrRjTynXppu+MiYlm+LwS9IR6alupADODXJ51z3d xvoVH2/b8+mAJu/9P416tBnHbqPJ84CwGOXMJOml54cgoHfXW1FLigbfATiwa+UflOBDVni2bmX slFahE1KotRVWl89MNAnwqng46M2PPbBP0Ub0RfOZnNXy7EzvOUp13NAO1O6qpzZ46x/hr7jaxF GYX4ZPFECbvCZOZmAsWJJoskwcpQOPT9VTl9OdGo9yxVy+qrxQo5tk2pnzPwnLtqsHhMgauCa1d /oKYAMCDwE5J9IIF4Dm1G21h7uti1h8++MfObwwHOD8OFggftGJIVpD6FFOoaJzBz3VCMyY4Ql9 WmQy2+mx2RrCLmYlKGE2Rm37o0vXfLK/KJwRBJIZi1dbK8b1GB X-Received: by 2002:a17:90b:48c1:b0:35b:d795:cf5d with SMTP id 98e67ed59e1d1-35de59535camr8452884a91.5.1775462941386; Mon, 06 Apr 2026 01:09:01 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af19sm127961835ad.50.2026.04.06.01.08.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 01:09:01 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v5 1/5] iio: ssp_sensors: cleanup codestyle warning Date: Mon, 6 Apr 2026 13:38:48 +0530 Message-Id: <20260406080852.2727453-2-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260406080852.2727453-1-sanjayembedded@gmail.com> References: <20260406080852.2727453-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Reported by checkpatch: FILE: drivers/iio/common/ssp_sensors/ssp_spi.c WARNING: Prefer __packed over __attribute__((__packed__)) +} __attribute__((__packed__)); Signed-off-by: Sanjay Chitroda Reviewed-by: Andy Shevchenko --- drivers/iio/common/ssp_sensors/ssp_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/= ssp_sensors/ssp_spi.c index 6c81c0385fb5..8c1e15d61db7 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -29,7 +29,7 @@ struct ssp_msg_header { __le16 length; __le16 options; __le32 data; -} __attribute__((__packed__)); +} __packed; =20 struct ssp_msg { u16 length; --=20 2.34.1 From nobody Sun Jun 14 20:10:16 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51A4230B501 for ; Mon, 6 Apr 2026 08:09:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462946; cv=none; b=YZIk3kD5BhbCBw17ci9uaGxTSd3nAk0EuI92dyz28UCrMrXIS9yInUf1LzRr8stRJHgXChvDd6Ti5Q6BOWMO7gSx/PikeDrvRl76GIKDfOTvmhdWJSKdvO61DcKTuD89z+mgwo40Yc64qvEtUv3JJrNBtr+eX1j5rJieBfR9lQE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462946; c=relaxed/simple; bh=IrfAI15OeYSzF7o8VJ7lq6QuUQJ761yxN1y3FeGgJ6Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PePgsOpcq0srz1HHSK7f753KGV6diu00TrMlBHYSQiLW5Z8J9M3RTcgIXEZooHTVaePLYUD/+QjT8THZB29w8aYCAymPoMnelqyIJWQ2RuxtR/S152vfW4s8VtpVLzylZEDI7lxtFAJ6TdT4m+LHWjlT5euzABlkHy2BBDm3xaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OK3ympHU; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OK3ympHU" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2ad4d639db3so15666435ad.0 for ; Mon, 06 Apr 2026 01:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775462945; x=1776067745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bWDKafWykqmCst/+PGgYmIJsGhpBN8tnTlfr4qxhHLk=; b=OK3ympHUf9UZlzVGFjUoVAsjM5Uk7vmb7KZ8dqXPP8pTcxtQQmbEGNSYs5RVpJoUF1 mFGXONhWnvjIbxZH747WprioR7c8N4q0VHZFbIpOJRoOOVdjaef9TvrqP+WxNJA/2rgH oZ83lyJNGBZESF6NjhSlwldhfEsGnqZqrgRVw7QUvepQ6RVmvJISjoE4zWOD0UbsfXId KM0I2pRuHnO0n3NwHsyEvf7qSzO8jnJIoxydC7fwstrVGBjL8rkFDcYE6/tS2YlNL48H Ecg3TtL4aN9sAmq8Cq+FHsRZDZOJC5zDfNLN+7lGhWG/EKBz6YSONL38uzj/fGSA24Jz GA3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775462945; x=1776067745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bWDKafWykqmCst/+PGgYmIJsGhpBN8tnTlfr4qxhHLk=; b=cJpadNLdiHA7Xm9YWG0T0y6aRD23ynF7w6t9I9cxBtmmRjzFMdHHxDBZDAIfdDCtn6 pGLSBRKAS475D6PvgQRAdzM6ynIt42oMt0V8ut0xZAce85nVuRaedwKl8MLFaFv7sk7a prfuiv05CAef4rBJxVdIzMua6Ji43a40KXBaDhIPLTHyazauU0nqs9wjJ4rwxOeFARig IpnzFMHAM0x0EbjBZEdu2B1V01VJt0qp05tK0W1CCEJ13UoB1MTUemhSm0+UfcgJsQgx dIiZnv2VAcwZl8T+hmxYQg2H7TPUrJ7s8Ac9yZhk4amnsdKVt9FRoW6T0RFJbkILFF6w GPag== X-Forwarded-Encrypted: i=1; AJvYcCWc52CCc2BVpC/TxOGczKkV/DgPhBopLyDFYrTmA/bfYGAF+NUjtdzN8mI/8fT6CWO+JqrETP8cTiCHkZk=@vger.kernel.org X-Gm-Message-State: AOJu0YyKxEJS3N07Ow09EDlb9RHqbZmlONTa4sFt2NPM68X+0Nz+b/cv UpDDYColmJns04PRNK8JqIrHTgVmV1xpED5xtinEGvQBzXOlO4e0Yy4D X-Gm-Gg: AeBDieuZApiifzC0e+Q6cIcRi+s3UNsbU64DBngh64ngfX8naCAB1g3efED/LYm9KO7 gGLyQ3NIAk9aG08JUwsSRL/8gbqSV1jr2ppKQDu9r8SL4ldRdXvVi//JzfZPY1hz7LmLVkCJp++ xSpUBZESPHpFUOBGocBFRdU2vlW21IDXVbV5DFRQaNfMjx4q2kUbnk80PPn0AroRlowsiFbH4z4 1EXyfeBzoN5KprOSBUggSOP5/eO9c6obvh0TKtrjjstG+kYUc/dws4Q8iun7hI2ubkYpXqq9Pux 5QQM7DqaZyQ0ADLVETP8KSFsh1cSPgW38jojc0KcFspMZH2C2cP5ZFJr5LmpI8UdFRxT+eAOzA0 Cxrh3jQLG/M8hgCERA6hbdzvEBb+TVVfxM1BjWoJ0O4h/Tvn3MQrp3YpYTdFsnUJK1ptUxvgQXR TvgxVmlyoKBFnPljip8pqUXXYyft3mesvZ1373Ss5IKnzlQ785 X-Received: by 2002:a17:903:32ca:b0:2b2:501c:bb8 with SMTP id d9443c01a7336-2b2818de2f2mr118441625ad.38.1775462944612; Mon, 06 Apr 2026 01:09:04 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af19sm127961835ad.50.2026.04.06.01.09.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 01:09:04 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v5 2/5] iio: ssp_sensors: cleanup codestyle check Date: Mon, 6 Apr 2026 13:38:49 +0530 Message-Id: <20260406080852.2727453-3-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260406080852.2727453-1-sanjayembedded@gmail.com> References: <20260406080852.2727453-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Reported by checkpatch: FILE: drivers/iio/common/ssp_sensors/ssp_spi.c CHECK: Macro argument '...' may be better as '(...)' to avoid precedence issues Signed-off-by: Sanjay Chitroda --- drivers/iio/common/ssp_sensors/ssp_spi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/= ssp_sensors/ssp_spi.c index 8c1e15d61db7..08ed92859be0 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -6,7 +6,7 @@ #include "ssp.h" =20 #define SSP_DEV (&data->spi->dev) -#define SSP_GET_MESSAGE_TYPE(data) (data & (3 << SSP_RW)) +#define SSP_GET_MESSAGE_TYPE(data) ((data) & (3 << SSP_RW)) =20 /* * SSP -> AP Instruction @@ -119,9 +119,9 @@ static inline void ssp_get_buffer(struct ssp_msg *m, un= signed int offset, } =20 #define SSP_GET_BUFFER_AT_INDEX(m, index) \ - (m->buffer[SSP_HEADER_SIZE_ALIGNED + index]) + ((m)->buffer[SSP_HEADER_SIZE_ALIGNED + (index)]) #define SSP_SET_BUFFER_AT_INDEX(m, index, val) \ - (m->buffer[SSP_HEADER_SIZE_ALIGNED + index] =3D val) + ((m)->buffer[SSP_HEADER_SIZE_ALIGNED + (index)] =3D val) =20 static void ssp_clean_msg(struct ssp_msg *m) { --=20 2.34.1 From nobody Sun Jun 14 20:10:16 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 623F330BB8A for ; Mon, 6 Apr 2026 08:09:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462949; cv=none; b=pzrQQapXXfKs2zYbEsYtx+vzJRKdqihzIrzGrD9WnI70Ynjq3A76TTB2SgAoff22wcjcoAy+t22MzxDAVvQ+E8FzG7dXSM9nx8/gBfSHfAegE8upb28REa6Z4X7oyngm+kXbWuvGosWIk5GwxmZ08uI3VLzOLk5dAzDxq8JXdW8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462949; c=relaxed/simple; bh=rU4vsCbZPCGD0vFrs6ml6LjfFL+wePC5vj6ZFMlpsQo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=jPpk8oE6fIgd31WQ5zYoTQzyfjh0CbjkRgj4gmiKlkwJ+3jcUNrQa7HTdP/457FoOjIMGTGYeTyCv6BhSJu3vKLSQAEqjpcqa6jd2peXp0iGv8mu4Yhg3e9daf6eQjlF/BIu3tnlyc/2ScrNQ9maC5xHSW/JFm++nyzNgk9I6p4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j3qkXJKn; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j3qkXJKn" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ab077e3f32so14780995ad.3 for ; Mon, 06 Apr 2026 01:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775462948; x=1776067748; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hpWKQRsVyCaZj6hI3lvjcls06PN5HybDlwyeC4uCUJE=; b=j3qkXJKnAbjC26YtbkUPEysEyKSZslNNyGOBEdvmlohcUhJDLuVqM/7EqmOX9IWplb C1T6KKJTf9RZOmKf0FL+CF97POI8po0DiGy7J/i8JTqhuKGZPgPwLAxkmlsS4AGcJq3g /0aGNLVqpCBxuac0J9jpFf89FBtLimIxiTG2dCRXp+ReoDRhVpfFdfhYuch6MULrT7fo yNNk6QMyJy2gGNxFtDCvsmR6eyvvO4S6BeAlridTWFCp3cSGN1aCr0GlRZUyTr6Fw80f R2dX/8e/sUrg+NTiWhyOJMqHVbfA458AQWwBs5de4RnES2eUNWQsObXYbJCIqBF8OuEh HGnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775462948; x=1776067748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hpWKQRsVyCaZj6hI3lvjcls06PN5HybDlwyeC4uCUJE=; b=PxC1Iuu8AfWgT/3C554r8XaYkv0Z/HtWIiR/HERPdKvwFqujpll5L04CZF17zjcq3L WObj5erSnGpadJI9Xx0oOPnJpL1+/5y3PYPG23oG/6F9bpUzU384MzTHSlVjhbvIqcZg BtTzG5e8aqtoWssOxbxlBFytLlKr7Ks/NSjvX/+bNbDMPfMjZksomENd+FsH1ot7jnzg SYIlQNvIXF8hgnL75Ul8UGYx0va0QvxINeSGIO/4E339x6mKUlIeQwM9Lb3ETxzA1E00 is5VZzBAgf2AiPjdHu12DisUGtPDm9Ekcl7IYFZ3DE/harDy/RYbt6kVr4mrNy9n0YaT 7NVA== X-Forwarded-Encrypted: i=1; AJvYcCWnVCMbOBkhxbcqe9H2/oisGbwHSU2Jg+/IAh5XLybPBR7kMT0/vP3Th/j7IR9vezD5yVrmtfw5i6F5mL4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzhwutn8QCPCAS42+HLTUlKXZarERwcMSTt7g4WLgkZpHzqXYQB DbNgckhhSAoPEKda7gfWAv2C9d/vyciQZ3Vn5yYOtT43t9t4ciVRxMeS X-Gm-Gg: AeBDiesLlGIrqoZQ/KPG02kmrgHHoB1B5k08JuMKHjQQJCS1K5VVSaMkEFYzFltk/HF ea0XBt1SbGcZ7gTmEX0PaVyARtvHTxZXnkvMssgy6yCOw3D1u0Z/La8jDpXRvqocyXWal6bGNfU 6c/lk3weVhkyosph55uIbW7W12bbNRgYwIQYxAln7HiZowlWSPWvuhtnNLgQKl2xK+UKg/GOf3o IJnxnEGE2aWVH4EUSckjtjEIlY7cHvupt42jZ56NPKRQmneO/XXDDWDOEZ5MYSYnkT0VdTdJai1 BhnfeoC3O34eXV2Zpa8vYPFffarsYE5KqBkZPSRY4wcz5NxPk99zvJwm+JC4IOm0h9xDbsOIfQ7 AmVokmCjbd0jbiI66HvdrbQCLv/vflNk6xuZ89Sew3nfY2Rd3evHONAUeIndnRj5ym+ZHtSYQaL 0oubHuFMu1kLFxrwv4KVIgQ7RhQom09eMfMoutJS0HKNSEnkmJ X-Received: by 2002:a17:903:3b8f:b0:2ae:cb0e:fd59 with SMTP id d9443c01a7336-2b28164cfebmr125528785ad.8.1775462947787; Mon, 06 Apr 2026 01:09:07 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af19sm127961835ad.50.2026.04.06.01.09.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 01:09:07 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v5 3/5] iio: ssp_sensors: factor out pending list add/remove helpers Date: Mon, 6 Apr 2026 13:38:50 +0530 Message-Id: <20260406080852.2727453-4-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260406080852.2727453-1-sanjayembedded@gmail.com> References: <20260406080852.2727453-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda The SSP SPI transfer path manipulates the pending message list in multiple places, each time open-coding the same locking and list operations. Re-factor the pending list add and delete logic into small helper functions to avoid duplication and simplify transfer flow to follow. No functional change intended. Signed-off-by: Sanjay Chitroda Suggested-by? --- drivers/iio/common/ssp_sensors/ssp_spi.c | 34 +++++++++++++++--------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/= ssp_sensors/ssp_spi.c index 08ed92859be0..7c1780e15acf 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -174,6 +174,22 @@ static int ssp_check_lines(struct ssp_data *data, bool= state) return 0; } =20 +static inline void ssp_pending_add(struct ssp_data *data, + struct ssp_msg *msg) +{ + mutex_lock(&data->pending_lock); + list_add_tail(&msg->list, &data->pending_list); + mutex_unlock(&data->pending_lock); +} + +static inline void ssp_pending_del(struct ssp_data *data, + struct ssp_msg *msg) +{ + mutex_lock(&data->pending_lock); + list_del(&msg->list); + mutex_unlock(&data->pending_lock); +} + static int ssp_do_transfer(struct ssp_data *data, struct ssp_msg *msg, struct completion *done, int timeout) { @@ -202,19 +218,13 @@ static int ssp_do_transfer(struct ssp_data *data, str= uct ssp_msg *msg, goto _error_locked; } =20 - if (!use_no_irq) { - mutex_lock(&data->pending_lock); - list_add_tail(&msg->list, &data->pending_list); - mutex_unlock(&data->pending_lock); - } + if (!use_no_irq) + ssp_pending_add(data, msg); =20 status =3D ssp_check_lines(data, true); if (status < 0) { - if (!use_no_irq) { - mutex_lock(&data->pending_lock); - list_del(&msg->list); - mutex_unlock(&data->pending_lock); - } + if (!use_no_irq) + ssp_pending_del(data, msg); goto _error_locked; } =20 @@ -224,9 +234,7 @@ static int ssp_do_transfer(struct ssp_data *data, struc= t ssp_msg *msg, if (wait_for_completion_timeout(done, msecs_to_jiffies(timeout)) =3D=3D 0) { - mutex_lock(&data->pending_lock); - list_del(&msg->list); - mutex_unlock(&data->pending_lock); + ssp_pending_del(data, msg); =20 data->timeout_cnt++; return -ETIMEDOUT; --=20 2.34.1 From nobody Sun Jun 14 20:10:16 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA24A30BB97 for ; Mon, 6 Apr 2026 08:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462952; cv=none; b=FnJ9Jen0SVBUdaDNxvlipzSuNi2mYNO+1GYbY65wHWzg7/opJM7q/DspTkllvWr4B+1qIuNQUjzMHV9hE5wj87V0LobwuhqprxmoblHPwHD+RCCBlUjTuk6fkjdR5hnXt+1O5cwaJ/Ie1XG9n1/OTfKNgSTU+vs4syYAB7eAjow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462952; c=relaxed/simple; bh=u/NbEkZKqHcYkS63Ubm7NmgdI+5+BWjcSYEk24oIQwc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fn+IZV66cCylgOwt4+LZ9P30Wp5USSdyRBwwxQqlLGD9AyAd00V0vPo9zHb1JosdBy3KbK5TAo61m6H2qmGFjRsqWu9r1+Bu8K9IWpXtopDj3EGeQU0D591FJASxLh1ClJ+lNO51/ZwXE2aKVN56wXGH0+5waTVZJV0c8rV/lhc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Dn2B0Ifa; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dn2B0Ifa" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c648bc907ebso2629693a12.3 for ; Mon, 06 Apr 2026 01:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775462951; x=1776067751; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u/7ec0UO3+S/ayxldfyYQuoWnFpVoh3m8YAbLEUE80I=; b=Dn2B0IfaaMtiDMJUv2xqsVwdVNtE2p0ujRXItQIa5SbYl+l+Ta/WTbVakZaHh5vU4x nnszTMnCXJ15WE+5nnGC4NgHORdCuO3ZvmdCubB9h409lvLwiyTlVmEFFBZPl56V9olv 3TOsnEhJJbZDq41Pat1TOqYjBcT9eCbGDZm15hVu3gCkhoDWhr/fUvrEpaGIdp4umAFn BO2/afJJYIMthcNOzAVHULvxZF65X1us0k09za1WMJ2bhNaAdk5V66uFRRYTQi/lO291 ilY//M17J57CkpTF5HG/dDikDI1Z9K41X+eCbBVykRLbcHkeEHc+nGDBkA7/MqIztgHp L1Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775462951; x=1776067751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=u/7ec0UO3+S/ayxldfyYQuoWnFpVoh3m8YAbLEUE80I=; b=rqHgycoYySOedSY4LLjODRB7U2GINzeTmjI3TYhIOnDQVq+yPWfGRCeCmfCJyrXF/8 N2pVohG2QyMx4bmVQahPbXEwoZf5yvnTkfsJ4nEHpCxxyTM9o1JkAETVzQlE76w+TpSt nn23CU05+2Go7iadRnLEFAOUa/UHRXS5dBaKufnEJoWmkhgjZMFwn8+l0aY/K/Yz/3az Qnb27yrIL+R+m9XKeDKDNhSM2ocvEpFQhZJpi059FMZfZ1pI4xUiqaH8+BULKXdisWhz KGAh0HYYMaZgxhovDPwmlIOqI98mYviVtVy4mG09W6jskI87Tuf/qTuqtQN0KzHQmzKh aJEw== X-Forwarded-Encrypted: i=1; AJvYcCWc/hyqtByJwP/RxLYv70zBA6CIfxNKUy6YwcuR3xxgZyoRhLR0Q9Tgblm5wFpFJZp7h8qaL9iP4MZ2MNo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4h6g2PfI4yT5RUCgKk/ie1zMJVdLlKSZDdguWGesMGrGi82f4 oZB3zH8dft95tKfJS+SEIb77Pnq0RVDH0NSvXcgrfXB7s3CPRPWOmjVx X-Gm-Gg: AeBDies3cA4GSaTIFtlutQoqK6NzjR3T/IQKtCNhFh3uWngeahfNuetEsIlOAL2/9tB AcZeG8SPT5lQ0LMulj0o2jtlKgHKrFH0JqQ7YzOquYLdYG+YBjPP4BMnA9xdrRBZTaK9HPlPRVC mDGujVxBqKLKEEZlM0pRnkRlqPNRgfBf5LkcOgeWPlxP37nDxm0Z+KDbTV+9L3iNww2UmuWTpTT ZIoMvqG3zDcSgBQMF0P5v+tILN5ibUqCfvg6XlqxjmwCWl+tzuep36sfGIQD7L2s/D3qEXWIccv OziTTeQ9KtZiEwSBYSFDwg+QLB5/MFwqxbWDJjAiYfNGcozNP38SBHbJqyz/g13y+l9jsRL3sZU ZtMkK8D6Qh39rwdNzc7Y9i4rauVV8er+cAK3GSHDdOwiZwfnFfuHKF/d+R8n4aU5H8r7Q56qZeL /+BS9yiZkLOtC8dXpsw7w7kqe+C0VDz8bmqc1PXOVekyVM/QgxAH4dqTn/uIc= X-Received: by 2002:a17:903:9ce:b0:2b0:54dc:63e with SMTP id d9443c01a7336-2b28193257amr126569705ad.33.1775462950951; Mon, 06 Apr 2026 01:09:10 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af19sm127961835ad.50.2026.04.06.01.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 01:09:10 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v5 4/5] iio: ssp_sensors: use devm APIs for mutex and IRQ resources Date: Mon, 6 Apr 2026 13:38:51 +0530 Message-Id: <20260406080852.2727453-5-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260406080852.2727453-1-sanjayembedded@gmail.com> References: <20260406080852.2727453-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Convert mutex initialization and IRQ registration to use devm-managed helpers, tying their lifetime to the device. This removes the need for explicit cleanup in the error and remove paths, as the resources are automatically released on probe failure or device unbind. Signed-off-by: Sanjay Chitroda --- drivers/iio/common/ssp_sensors/ssp_dev.c | 36 +++++++++++------------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/= ssp_sensors/ssp_dev.c index da09c9f3ceb6..f4fc869fc770 100644 --- a/drivers/iio/common/ssp_sensors/ssp_dev.c +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c @@ -510,7 +510,11 @@ static int ssp_probe(struct spi_device *spi) data->spi =3D spi; spi_set_drvdata(spi, data); =20 - mutex_init(&data->comm_lock); + ret =3D devm_mutex_init(&spi->dev, &data->comm_lock); + if (ret < 0) { + dev_err(&spi->dev, "Failed to init comm_lock mutex\n"); + goto err_setup_spi; + } =20 for (i =3D 0; i < SSP_SENSOR_MAX; ++i) { data->delay_buf[i] =3D SSP_DEFAULT_POLLING_DELAY; @@ -523,7 +527,11 @@ static int ssp_probe(struct spi_device *spi) =20 data->time_syncing =3D true; =20 - mutex_init(&data->pending_lock); + ret =3D devm_mutex_init(&spi->dev, &data->pending_lock); + if (ret < 0) { + dev_err(&spi->dev, "Failed to init pending_lock mutex\n"); + goto err_setup_spi; + } INIT_LIST_HEAD(&data->pending_list); =20 atomic_set(&data->enable_refcount, 0); @@ -533,13 +541,13 @@ static int ssp_probe(struct spi_device *spi) =20 timer_setup(&data->wdt_timer, ssp_wdt_timer_func, 0); =20 - ret =3D request_threaded_irq(data->spi->irq, NULL, - ssp_irq_thread_fn, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, - "SSP_Int", data); + ret =3D devm_request_threaded_irq(&spi->dev, data->spi->irq, NULL, + ssp_irq_thread_fn, + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + "SSP_Int", data); if (ret < 0) { dev_err(&spi->dev, "Irq request fail\n"); - goto err_setup_irq; + goto err_setup_spi; } =20 /* Let's start with enabled one so irq balance could be ok */ @@ -553,21 +561,16 @@ static int ssp_probe(struct spi_device *spi) ret =3D ssp_initialize_mcu(data); if (ret < 0) { dev_err(&spi->dev, "Initialize_mcu failed\n"); - goto err_read_reg; + goto err_setup_spi; } } else { dev_err(&spi->dev, "Firmware version not supported\n"); ret =3D -EPERM; - goto err_read_reg; + goto err_setup_spi; } =20 return 0; =20 -err_read_reg: - free_irq(data->spi->irq, data); -err_setup_irq: - mutex_destroy(&data->pending_lock); - mutex_destroy(&data->comm_lock); err_setup_spi: mfd_remove_devices(&spi->dev); =20 @@ -589,14 +592,9 @@ static void ssp_remove(struct spi_device *spi) =20 ssp_clean_pending_list(data); =20 - free_irq(data->spi->irq, data); - timer_delete_sync(&data->wdt_timer); cancel_work_sync(&data->work_wdt); =20 - mutex_destroy(&data->comm_lock); - mutex_destroy(&data->pending_lock); - mfd_remove_devices(&spi->dev); } =20 --=20 2.34.1 From nobody Sun Jun 14 20:10:16 2026 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6576306B1B for ; Mon, 6 Apr 2026 08:09:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462956; cv=none; b=KA0/xvYS/GCjGhFpDVdufAoX6fTD65U8H5RB4DuomJC0+wf9EOAR4dZWCm9UJKw0jrWDtn/BBCQPWBdsjxdfy6IouGZJYfFd71UW3KCWTMeB9e9MAx45u6f+Oa3s7bM3I44xDySoVWjnH5qsaE9fiwEJNjaL5N2H8ovuJvoFnMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462956; c=relaxed/simple; bh=3i4QqeQ0eDQeBGKnXpTijfSwGZD4a29IZdK8uDi6MJY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=E2TX+P61nEyaNogdE+6K6tOunnyrx477teW9p3EELrqzbzwKRoxWAm6qiPbVxFeVe3rLKyEoiwcvHS1KZhaGM5c3ERub9T8IxkAp7q7o1x6q+Z2X9pHgc0nE/TSppiorP9nHdvzFyEXAG154yJAQXY+wEav1DcYB++aQODffGik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CInyr+4f; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CInyr+4f" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-35c238f1063so2190821a91.1 for ; Mon, 06 Apr 2026 01:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775462954; x=1776067754; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W1j46ShQPfwpy3gXgQwfnfKhYctHDdp6l3ofiQ/AUxA=; b=CInyr+4fhIk3yodd1Qyt7miOi8o9pEfni4ZcjuJJdYq1T1itstxgj5ia7WsvtwdUax aTW1I7MigomBd5NXyCwuzVoqD48OzmhmrhilFpjnd2uwAg8h1QWhaxLjUi751LsAjiDC 7YdKSx9TYojI8eR0Qd1u9iLNRtNjw65MCqfIZjySlYs+O2BwUfZZeCiXGHkM0Kx3U3c5 oO2GbWSx22BZW0w6RVIZe5/Ok2SWupKRT/MGtsaUyT7JlmZpHPSfDVp7vXuoHIBmLvlF IJJBHiiuYkp5F1Igsl/LlexnQB9Yr+/MFSpxX1Y6d5bznckZFIXgrud8iEyg3H7JyA2v OgMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775462954; x=1776067754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W1j46ShQPfwpy3gXgQwfnfKhYctHDdp6l3ofiQ/AUxA=; b=J9b3d/869a7aywxgDq0iAqanOC7bNv2jp+cySsobsFxBhr2uLdCiulTYAbm27z/pRo xvuxzN1gSR/5MHaqKzUrM+u380MoanpXX7cph+XEErMe3CZ0lwDeLVhXXMSksgzDqfsT IBWY6b6pN68TlcTn2OgvRz4QLKBbDfVfrzvX3a2e6q/eX5Tth6BgERHAFT/oIxMexWvs MIyPLuxhXI2WoLk0jf94Uhxu6sh1wUNqt/o87m6IYXPgY4YCB68RUDQMISRAbaPt78f4 5sJvMTV/38r4o/37t1nWCpFVH3ON2j+fD77CB+HCU/tFOahQrj9G6j/8IQIpUp91Nb10 7MzQ== X-Forwarded-Encrypted: i=1; AJvYcCXbhD4bAX/F3FvJQr8rM4TGJOeJm0n/NU5bSC+Ig+LyNCZVIlu5zW7TghHoQCSNRbvY2+xsfjMKdXufDmo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1XKdMEmEUFB4wPxjUTDnqRfH6DPOfYvooTf4vIIPDbCzBD6qV KF4/p0d7xlrP2LS56PU/sNrHD9UfShdWC1nkmBXRsVq0I2RFLtnyCt/3 X-Gm-Gg: AeBDievrmyXmwgJ/HlDykKpbb8kqNIiLtnqXNDT/Bj8QcisHRq5HwbeUeBrSycfY+ZV XR+FOKiEhwsCxHoKnM0Uq1uDGPNbp04+KA0e+yaoOISbQxw0QWME64iaHSjvceTXCnF8W4hgHt9 ZaZI7CDJJVER24e3ZWcfq8nctCBrYoYdGeZlneVREaoScRKtTGzFZc0Rkj9rhCTclIZUBlRkX3a I1EGvhmFq6/H92Y2cI1PT6OJThIAUUHk8cboKQnUAK9NPK5U5tWf5vUuBH9rtUVzgTdwYD6CaD2 HQh6vDveH0ZCxz5ZOjXyM/N4usWuy+S0ZzEyzSYPLZAxdu+qpnjUju1C4PaHzZhLdWr0dv/e38U B2VFP3PAz14kCe52jh4O/B/LWWP5toK7lSVQ3zcZvF8dt32fpEa1YHZPW7Tjq1Lb2Bf2REdUvK/ KTQ2QIQUP8Ww8YAkP7RAX188j91eG06ydtjDeQHtf3QA9tZnXU X-Received: by 2002:a17:903:17cb:b0:2b2:50f6:cdd9 with SMTP id d9443c01a7336-2b2817cf037mr128244145ad.8.1775462954078; Mon, 06 Apr 2026 01:09:14 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af19sm127961835ad.50.2026.04.06.01.09.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 01:09:13 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org Cc: kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, sanjayembeddedse@gmail.com Subject: [PATCH v5 5/5] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers Date: Mon, 6 Apr 2026 13:38:52 +0530 Message-Id: <20260406080852.2727453-6-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260406080852.2727453-1-sanjayembedded@gmail.com> References: <20260406080852.2727453-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sanjay Chitroda Avoid allocating a temporary DMA buffer in the interrupt context when handling hub-to-AP and AP-to-hub SPI write messages. Preallocate RX buffer during probe and reuse it for SPI receive operations. This removes repeated kzalloc() calls from the IRQ path, reduces allocation overhead, and avoids potential allocation failures under memory pressure. The RX buffer size is tracked and allocated using devm_kzalloc(), ensuring proper lifetime management tied to the device. No functional change intended; this is an internal optimization and robustness improvement. Signed-off-by: Sanjay Chitroda --- Changes in v5: - Rebase change on top of latest v5 patch series. Changes in v4: - Use preallocated buffer and stash a buffer that gets reused each time ins= tead of a fresh allocation. - Link to v3: https://lore.kernel.org/all/20260315125509.857195-3-sanjayemb= edded@gmail.com/ Changes in v3: - prepare series to have all respective cleanup API support for the ssp_sen= sors following input from Andy Shevchenko - Link to v2 https://lore.kernel.org/all/20260311174151.3441429-1-sanjayemb= edded@gmail.com/ Changes in v2: - split series to individual patch - address review comment from Andy Shevchenko - Link to v1 https://lore.kernel.org/all/20260310200513.2162018-3-sanjayemb= edded@gmail.com/ --- drivers/iio/common/ssp_sensors/ssp.h | 5 +++++ drivers/iio/common/ssp_sensors/ssp_dev.c | 12 ++++++++++++ drivers/iio/common/ssp_sensors/ssp_spi.c | 19 +++---------------- 3 files changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp.h b/drivers/iio/common/ssp_= sensors/ssp.h index f649cdecc277..aa125fd1bed5 100644 --- a/drivers/iio/common/ssp_sensors/ssp.h +++ b/drivers/iio/common/ssp_sensors/ssp.h @@ -175,6 +175,8 @@ struct ssp_sensorhub_info { * @sensor_devs: registered IIO devices table * @enable_refcount: enable reference count for wdt (watchdog timer) * @header_buffer: cache aligned buffer for packet header + * @rx_buf: buffer to receive SPI data + * @rx_buf_size: allocated size of rx_buf */ struct ssp_data { struct spi_device *spi; @@ -222,6 +224,9 @@ struct ssp_data { atomic_t enable_refcount; =20 __le16 header_buffer[SSP_HEADER_BUFFER_SIZE / sizeof(__le16)] __aligned(I= IO_DMA_MINALIGN); + + u8 *rx_buf; + size_t rx_buf_size; }; =20 void ssp_clean_pending_list(struct ssp_data *data); diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/= ssp_sensors/ssp_dev.c index aab28f2a0f75..2a8d6f040ae4 100644 --- a/drivers/iio/common/ssp_sensors/ssp_dev.c +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c @@ -516,6 +516,18 @@ static int ssp_probe(struct spi_device *spi) goto err_setup_spi; } =20 + data->rx_buf_size =3D SSP_DATA_PACKET_SIZE; + data->rx_buf =3D devm_kzalloc(&spi->dev, + data->rx_buf_size, + GFP_KERNEL | GFP_DMA); + + if (!data->rx_buf) { + dev_err(&spi->dev, + "Failed to allocate memory for rx_buf\n"); + ret =3D -ENOMEM; + goto err_setup_spi; + } + for (i =3D 0; i < SSP_SENSOR_MAX; ++i) { data->delay_buf[i] =3D SSP_DEFAULT_POLLING_DELAY; data->batch_latency_buf[i] =3D 0; diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/= ssp_sensors/ssp_spi.c index 7c1780e15acf..2f7445e8b4d1 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -383,19 +383,13 @@ int ssp_irq_msg(struct ssp_data *data) * but the slave should not send such ones - it is to * check but let's handle this */ - buffer =3D kmalloc(length, GFP_KERNEL | GFP_DMA); - if (!buffer) { - ret =3D -ENOMEM; - goto _unlock; - } + buffer =3D data->rx_buf; =20 /* got dead packet so it is always an error */ ret =3D spi_read(data->spi, buffer, length); if (ret >=3D 0) ret =3D -EPROTO; =20 - kfree(buffer); - dev_err(SSP_DEV, "No match error %x\n", msg_options); =20 @@ -428,22 +422,15 @@ int ssp_irq_msg(struct ssp_data *data) mutex_unlock(&data->pending_lock); break; case SSP_HUB2AP_WRITE: - buffer =3D kzalloc(length, GFP_KERNEL | GFP_DMA); - if (!buffer) - return -ENOMEM; + buffer =3D data->rx_buf; =20 ret =3D spi_read(data->spi, buffer, length); if (ret < 0) { dev_err(SSP_DEV, "spi read fail\n"); - kfree(buffer); break; } =20 - ret =3D ssp_parse_dataframe(data, buffer, length); - - kfree(buffer); - break; - + return ssp_parse_dataframe(data, buffer, length); default: dev_err(SSP_DEV, "unknown msg type\n"); return -EPROTO; --=20 2.34.1