From nobody Sun Jun 14 20:02:30 2026 Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12FF93382C9 for ; Mon, 6 Apr 2026 07:06:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.65 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775459195; cv=none; b=gLwwA92keb9bET0vX0P8ECLJ02I3qnnxaa3w/1hNy1CH54ZzuKSmW0iHfGU9QJmQ3vhogdLWddyw2lUyNNdps9OwheMHHBzZYg2vGyz5WJrmFEhurNSdPMhx9SgLFOeRkBRMNW1/3P+VSRez7c5U31jjwNM15xzRBFWsBq18cm0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775459195; c=relaxed/simple; bh=IzwUOOk07arVzGnI3bxwELcmQCPD2zVHN2+sLLaQQaw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=QxG8QrWit+WrFmh/JOecGCN4SOzMsb7ExXpFPKENF+ojJuVipz08meIi6jqEEwdiQ2UDUlqqq/6Z6fTOOxEeh53Qokj7ROCTStClA6N5/ruff6NECpulaybQrNrgvtWUd0mua+WjT2ZSmL3FfKKYRZtOShnGRirhQRZ0+2xdSxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=lvkasz.us; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.208.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=lvkasz.us Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f65.google.com with SMTP id 4fb4d7f45d1cf-66eba04b29eso1867261a12.1 for ; Mon, 06 Apr 2026 00:06:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775459192; x=1776063992; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CmI+hzyBqRr28Y++VrQXgi0DtpH9W0BGd3T//ob2zds=; b=SWlY9+/GdPP+ACWLmBWUh3UKXj7cE9oxIUhZQFoG4tSlxjJnHOYoNjwWzaqKLk21uv joCns3Fv/lVvhGoVcAQ9gxz5JON4yKG/J7NqYhgUrkEBmBeF7GitS/2L0C3VroqmNcQ7 gaQqRlL6vR9Qs1wmynnxGoCSmjDU59DdfuFW3lybE99FIphkp+TNIqXhSGp3DRUOG294 ZriyQWtb7aexAoBEfLaRQ17IBOdAm/If7czFNb3eGzVb40pUJ7REVV/cncBtWeKIC5a7 WCd/Bz3Tasa4E8gpNmUg1R0eQYF5O1LTHKbN4glhmBny0D//h5BSWxYXoFgvYNCUrwmc P2qQ== X-Forwarded-Encrypted: i=1; AJvYcCXdyN6+L2lNuVvM5w3IzjpVeRqLdlMigYgV+0DErbZIJpN8HVXh0GVhWCKtA+lf5v6lvZP7TonTmt01Iyg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxc7Svj1RVtFcHDjagLTlASt1W//hgmf/peKdlJxcjjeY3tQrAs /TC0s18t0k54okfrbuz5yyh0pIL88L14Y+lp4d4joUZXt2WrDrvK5VVF X-Gm-Gg: AeBDieunNQAejWEfdmks1eCT6cKJtB+yBtZURp1rBZR6Erim9DTUPPnmtGHQEU5zDqG 8/khdu6V4WNcWicHaD5ml7qAHfxOq/bxosXa1PCqfrd5L78rVtvaBelFKuaDj8kWgwKxGTuGdIy Aaa8HKCECj2RnJV0/LI8Cu82BrJtGLP7CxbSTt9urplzaUddFozxD+J/fLKs0dQAGsduwczURS/ cS/N97VNgWsaqrfJsC8GD7FIeyIcseIy7mumf8Yvcw7Ksd0GCvotpuoyp2VSX7XuSbbdT5YYWpB oX2USv84viU4rEiucjEq879pZ23ztfcvHDGRGreUn0CR2F0SF32aiJ+eLvW9nsROl3tI78KrXeK r4/c4mjiRtvjD3l88+sy3taJD4oBW8UZ4tfGAJ15kHdZHHkOmS1NLZt2yOXz6xnbnsrtOrKFVHV dtdQX/DByxnZDcqUrR9vd0ndXddAD6wEMiXH08DGY0gPUUd0xkWL0widFCXqX39w== X-Received: by 2002:a17:906:4fd4:b0:b96:e11e:97c4 with SMTP id a640c23a62f3a-b9c676ad8bfmr559766366b.20.1775459192157; Mon, 06 Apr 2026 00:06:32 -0700 (PDT) Received: from aorus.localdomain (5.185.72.109.ipv4.public.orange.pl. [5.185.72.109]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3cff131csm450129466b.52.2026.04.06.00.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 00:06:31 -0700 (PDT) From: =?UTF-8?q?=C5=81ukasz=20Lebiedzi=C5=84ski?= To: vkoul@kernel.org Cc: neil.armstrong@linaro.org, krzk@kernel.org, alim.akhtar@samsung.com, andre.draszik@linaro.org, pritam.sutar@samsung.com, kauschluss@disroot.org, johan@kernel.org, ivo.ivanov.ivanov1@gmail.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?=C5=81ukasz=20Lebiedzi=C5=84ski?= , stable@vger.kernel.org Subject: [PATCH] phy: exynos5-usbdrd: fix USB 2.0 HS PHY tuning values for Exynos7870 Date: Mon, 6 Apr 2026 09:05:48 +0200 Message-ID: <20260406070548.132491-1-kernel@lvkasz.us> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The existing PHYPARAM0 tuning values for Exynos7870 are incorrect, causing the USB 2.0 PHY to fail high-speed negotiation and fall back to full-speed (12Mbps) operation. Fix TXVREFTUNE (transmitter voltage reference) from 14 to 3, TXRESTUNE (transmitter impedance) from 3 to 2, and SQRXTUNE (squelch threshold) from 6 to 5. Also explicitly set TXPREEMPPULSETUNE to 0, which was previously missing from the tuning table despite being included in the register mask. All values are derived from the vendor kernel for the Samsung Galaxy A6 (SM-A600FN), as no public hardware documentation is available for the Exynos7870 USB DRD PHY. With these corrections, the PHY successfully negotiates high-speed (480Mbps) operation. Fixes: 588d5d20ca8d ("phy: exynos5-usbdrd: add exynos7870 USBDRD support") Cc: stable@vger.kernel.org Tested-by: =C5=81ukasz Lebiedzi=C5=84ski Tested-by: Kaustabh Chakraborty Signed-off-by: =C5=81ukasz Lebiedzi=C5=84ski Reviewed-by: Krzysztof Kozlowski --- drivers/phy/samsung/phy-exynos5-usbdrd.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung= /phy-exynos5-usbdrd.c index 5a181cb4597e..8711a3b62c8e 100644 --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c @@ -1958,13 +1958,14 @@ const struct exynos5_usbdrd_phy_tuning exynos7870_t= unes_utmi_postinit[] =3D { PHYPARAM0_TXPREEMPAMPTUNE | PHYPARAM0_TXHSXVTUNE | PHYPARAM0_TXFSLSTUNE | PHYPARAM0_SQRXTUNE | PHYPARAM0_OTGTUNE | PHYPARAM0_COMPDISTUNE), - (FIELD_PREP_CONST(PHYPARAM0_TXVREFTUNE, 14) | + (FIELD_PREP_CONST(PHYPARAM0_TXVREFTUNE, 3) | FIELD_PREP_CONST(PHYPARAM0_TXRISETUNE, 1) | - FIELD_PREP_CONST(PHYPARAM0_TXRESTUNE, 3) | + FIELD_PREP_CONST(PHYPARAM0_TXRESTUNE, 2) | + FIELD_PREP_CONST(PHYPARAM0_TXPREEMPPULSETUNE, 0) | FIELD_PREP_CONST(PHYPARAM0_TXPREEMPAMPTUNE, 0) | FIELD_PREP_CONST(PHYPARAM0_TXHSXVTUNE, 0) | FIELD_PREP_CONST(PHYPARAM0_TXFSLSTUNE, 3) | - FIELD_PREP_CONST(PHYPARAM0_SQRXTUNE, 6) | + FIELD_PREP_CONST(PHYPARAM0_SQRXTUNE, 5) | FIELD_PREP_CONST(PHYPARAM0_OTGTUNE, 2) | FIELD_PREP_CONST(PHYPARAM0_COMPDISTUNE, 3))), PHY_TUNING_ENTRY_LAST base-commit: caf08514bbee0736c31d8d4f406e3415cdf726bb --=20 2.53.0