From nobody Sun Jun 14 20:13:16 2026 Received: from mail-dl1-f67.google.com (mail-dl1-f67.google.com [74.125.82.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7936383C99 for ; Sun, 5 Apr 2026 23:26:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775431572; cv=none; b=pfzJt/yazKmElJP+pPGoAiOvG1wjP2x2nt93OVaGT36W34OOWHwAeGOHVRMfz5tEQg663z8b1ktuZfns5Hwys6OztaUihnfQEgygdtR/e+eT9HGgX0RuJUrBInr+v6HTdNA6PTfN3XE5QA4di3BDJYPdkQhgq46raPuN/qpAaCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775431572; c=relaxed/simple; bh=jC5xfEvHSRHM2d5qpAyJz5Kmbr47k/f9lON6gXE1En8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=aITlUZ1rWVUwEDK2/6HcDuthgLQheCBi/J1L69nfotbAyvooEeA3jeca/ruJ+leg2lv+LQ/nqslxiZmvTlcTeTFv303OlZ5q20PehRUD5Fe4DazwNuiRgWlNYFtYuSiFJRghrt+9lCjbQ8pYIyGdwMvZzPMFRtVDk01O106ZoIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kHO8T7lt; arc=none smtp.client-ip=74.125.82.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kHO8T7lt" Received: by mail-dl1-f67.google.com with SMTP id a92af1059eb24-127380532eeso393729c88.1 for ; Sun, 05 Apr 2026 16:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775431569; x=1776036369; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CMV2dZVUW7DQMu0++s6lroI8YI0/U18GtCkj4isEdVg=; b=kHO8T7ltB6UThe6RgxJuRucNNlQ/OaBLlH+F8Dp1sXIG7ZsThrjdTClX9uQwxrC3uz OjodrZ2PV/PEVY1Vb2Y/Z4Q7zx0H5bmPgnCNnTi7MBQgg4fA0obXujN7QAGmBniwn8Ba TEY9TJZCILY+ZQEYeooO2Cx2ZrceuEvCGj1lvT13XSfJftqBdQlDSgNutImA7d4gI+lt Z6t/m8ZXnaSlzpfV5EMwGUimapnJQCxdfHoVqy+bThOYVLHvOQ5PfVhrxNPJyVrJ6yH/ qY0RWXTRB0FuiCFoYjWkbmnEJo1K+Pp7DjYNWXzlSTgAM0uKHbkgww5JROhXgaUHyXZ9 u0Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775431569; x=1776036369; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CMV2dZVUW7DQMu0++s6lroI8YI0/U18GtCkj4isEdVg=; b=dXW7liDrv7OAv97ZOukWG5P7l3A05zyt8nQh4wjPyrQfu9I9jR3ySHh7Jb6/xvTX9K mdNZGKiXAFO0HdJKcHuQ5q4nJNpoKpWkQe0Wvd7/FueIu7GL6cykkPPTJ7rno4Eaj70X SHtFT2qsqNuIWF2bed0NDCZ+L4Xe8NC/58vI1hCWEOmdImi98vOc5zoUeS1Xq5gY7cFp KlBHU2SjdcpiSttZuDWuYXBJrNdbdWuBrQ3AO6tBj9rEEAnHPBBn9MdB0tIhDOdVGZf2 UW/c6mUflgznCNEz48WhFp5eDGD9Q0j4qRYJS3GRPpZf53+nMTA2fvVuShgLUekoPXJI Ua+A== X-Forwarded-Encrypted: i=1; AJvYcCUmVH/eQr8VLwjwJqOMf1ULNisrbXCH14bYlGXr1u8Cja53VhINuipVBeTPyZ/cSEFg4uTDXrPZlyJ+Go8=@vger.kernel.org X-Gm-Message-State: AOJu0YwJiSKSHcVfEAxeh203tzenfdgRiHN4EqFKK/F0D16prB2pPG/c CUUiBzTIJZ/TTmV2wDfaLvnzMxlsYVi9CEweifH1D9KBq4aSSiw0ndaA X-Gm-Gg: AeBDietv9sm4/O9oFLUFxEHuB3KC5UqBnAbGCCHv8P3a/3W2umHgaArcbSUQz9jHG3n IBXolFx0LiHLnJ1N9d1HJeKHZ0F4IlgH3R6RVk8DWn/Gk/8xOH23OGbe+FZvHgo9imYF5IJPQ3B UfgVzKuPldFLkz0unPKahIhOrwScvqtYbgiey3dXY9b7osvTuxsb6+uWje65I0j5T2TamgqnFG1 oyFgPQaFaOa8GPoDtXbauVSj6go/tYUf88MwmDi0bEu98GAUQobshyrT16OZNtPTgQ5enh0SFAa 417sPHmv5yG5toG5v3iELHWvJsselZ+hbvtrdFspdJlZQ+qn5mx7KJQqdlivJqKDuraw2Wyh3mp 7AtYYGdXP31XhKrJ/RWK3wPq/Sf3Gpo7KUTXYXGsMR5uHvR24miE8uKxTPHOPYJ4LUM8qSC+FK6 QPuxBUh9ZCIiy1ugOsVfpm6a1UkAgjpNq3dmV9YUlnO4LVZu7QpHyOF0M= X-Received: by 2002:a05:7022:90e:b0:123:34e8:aec2 with SMTP id a92af1059eb24-12bfb6e8e9dmr5006469c88.1.1775431568808; Sun, 05 Apr 2026 16:26:08 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca7cae9e9esm11211040eec.23.2026.04.05.16.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2026 16:26:08 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: b9788213@gmail.com, ethantidmore@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v3] staging: rtl8723bs: convert xmit init path to standard error codes Date: Sun, 5 Apr 2026 23:25:34 +0000 Message-Id: <20260405232534.14122-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the use of _SUCCESS/_FAIL return values with standard kernel return conventions (0 on success, negative errno on failure) in the xmit initialization path. Specifically: - rtw_os_xmit_resource_alloc() now returns 0 or -ENOMEM - rtw_alloc_hwxmits() now returns 0 or -ENOMEM - _rtw_init_xmit_priv() updated to propagate error codes and use direct truth checks instead of comparing with _FAIL - caller in os_intfs.c updated accordingly This improves error propagation and aligns the driver with kernel coding style. Signed-off-by: Hungyu Lin --- v3: - Rebase onto latest staging-next to resolve conflicts. v2: - Rework xmit init path to remove _SUCCESS/_FAIL usage - Convert allocation helpers to return standard error codes - Update caller to use direct failure checks - Address review feedback from Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 32 +++++++++---------- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 +- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 4 +-- 3 files changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 7bce0343d59f..166861f42953 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -38,7 +38,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, stru= ct adapter *padapter) int i; struct xmit_buf *pxmitbuf; struct xmit_frame *pxframe; - signed int res =3D _SUCCESS; + signed int res =3D 0; =20 spin_lock_init(&pxmitpriv->lock); spin_lock_init(&pxmitpriv->lock_sctx); @@ -75,7 +75,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, stru= ct adapter *padapter) =20 if (!pxmitpriv->pallocated_frame_buf) { pxmitpriv->pxmit_frame_buf =3D NULL; - res =3D _FAIL; + res =3D -ENOMEM; goto exit; } pxmitpriv->pxmit_frame_buf =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv= ->pallocated_frame_buf), 4); @@ -112,7 +112,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitpriv->pallocated_xmitbuf =3D vzalloc(NR_XMITBUFF * sizeof(struct xmi= t_buf) + 4); =20 if (!pxmitpriv->pallocated_xmitbuf) { - res =3D _FAIL; + res =3D -ENOMEM; goto exit; } =20 @@ -129,10 +129,12 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, = struct adapter *padapter) =20 /* Tx buf allocation may fail sometimes, so sleep and retry. */ res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ += XMITBUF_ALIGN_SZ), true); - if (res =3D=3D _FAIL) { + + if (res) { fsleep(10 * USEC_PER_MSEC); + res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ = + XMITBUF_ALIGN_SZ), true); - if (res =3D=3D _FAIL) + if (res) goto exit; } =20 @@ -162,7 +164,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) =20 if (!pxmitpriv->xframe_ext_alloc_addr) { pxmitpriv->xframe_ext =3D NULL; - res =3D _FAIL; + res =3D -ENOMEM; goto exit; } pxmitpriv->xframe_ext =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->xfr= ame_ext_alloc_addr), 4); @@ -195,7 +197,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) pxmitpriv->pallocated_xmit_extbuf =3D vzalloc(NR_XMIT_EXTBUFF * sizeof(st= ruct xmit_buf) + 4); =20 if (!pxmitpriv->pallocated_xmit_extbuf) { - res =3D _FAIL; + res =3D -ENOMEM; goto exit; } =20 @@ -211,10 +213,9 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, s= truct adapter *padapter) pxmitbuf->buf_tag =3D XMITBUF_MGNT; =20 res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_XMIT_EXTBUF_S= Z + XMITBUF_ALIGN_SZ, true); - if (res =3D=3D _FAIL) { - res =3D _FAIL; + + if (res) goto exit; - } =20 pxmitbuf->phead =3D pxmitbuf->pbuf; pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_XMIT_EXTBUF_SZ; @@ -243,10 +244,9 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, s= truct adapter *padapter) res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, true); - if (res =3D=3D _FAIL) { - res =3D _FAIL; + + if (res) goto exit; - } =20 pxmitbuf->phead =3D pxmitbuf->pbuf; pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_CMDBUF_SZ; @@ -257,7 +257,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) } =20 res =3D rtw_alloc_hwxmits(padapter); - if (res =3D=3D _FAIL) + if (res) goto exit; rtw_init_hwxmits(pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry); =20 @@ -1875,7 +1875,7 @@ s32 rtw_alloc_hwxmits(struct adapter *padapter) pxmitpriv->hwxmits =3D kzalloc_objs(*hwxmits, pxmitpriv->hwxmit_entry, GFP_ATOMIC); if (!pxmitpriv->hwxmits) - return _FAIL; + return -ENOMEM; =20 hwxmits =3D pxmitpriv->hwxmits; =20 @@ -1900,7 +1900,7 @@ s32 rtw_alloc_hwxmits(struct adapter *padapter) } else { } =20 - return _SUCCESS; + return 0; } =20 void rtw_free_hwxmits(struct adapter *padapter) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index e943dcea1a21..15edf97ee9e2 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -653,7 +653,7 @@ u8 rtw_init_drv_sw(struct adapter *padapter) =20 init_mlme_ext_priv(padapter); =20 - if (_rtw_init_xmit_priv(&padapter->xmitpriv, padapter) =3D=3D _FAIL) + if (_rtw_init_xmit_priv(&padapter->xmitpriv, padapter)) goto free_mlme_ext; =20 if (_rtw_init_recv_priv(&padapter->recvpriv, padapter) =3D=3D _FAIL) diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/stagin= g/rtl8723bs/os_dep/xmit_linux.c index dc0b77f38b1a..b7cb50ad14fd 100644 --- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c +++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c @@ -51,12 +51,12 @@ int rtw_os_xmit_resource_alloc(struct adapter *padapter= , struct xmit_buf *pxmitb if (alloc_sz > 0) { pxmitbuf->pallocated_buf =3D kzalloc(alloc_sz, GFP_KERNEL); if (!pxmitbuf->pallocated_buf) - return _FAIL; + return -ENOMEM; =20 pxmitbuf->pbuf =3D (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitbuf->pallocated= _buf), XMITBUF_ALIGN_SZ); } =20 - return _SUCCESS; + return 0; } =20 void rtw_os_xmit_resource_free(struct adapter *padapter, struct xmit_buf *= pxmitbuf, u32 free_sz, u8 flag) --=20 2.34.1