From nobody Sun Jun 14 20:21:49 2026 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70B431A6820 for ; Sun, 5 Apr 2026 21:38:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775425085; cv=none; b=sDBeFgn8yAT/Uti9uu7htZS3NPoyOYAzV3+odRcprivaXSaAAe3nVA4eRxHpUagGPkXSBkiDvJaCnvNnXxNk3O1dUR5+Hl6accUDgLUPYEZRXqO9Y5YYHps13W0DI8YYJ/iurXO4cDpYhvndysJ+eMjZSBhFuQbxPXDwM9htaI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775425085; c=relaxed/simple; bh=8nODRcvUnS4p+vn4a/5ft5GQxgjyz+ZEzZN0WfPtPIs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZD6fLI9oELOX0BpRKSe1uPhaVZv0fJnpjjIl5B8w8LSQWmiaIjFOvJcnCM0siVjAkpyvMyuy/ltrH62picKSmQSpn24uzrmEh+SwpFxgA8NtI50nSMmZalv8qXW4zh+XqSynh8pEaTJgG8uLUtXWBvX7v82KMJeCDmUv1kJcTlQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=usp.br; spf=pass smtp.mailfrom=usp.br; dkim=pass (2048-bit key) header.d=usp.br header.i=@usp.br header.b=jq7elhb0; arc=none smtp.client-ip=209.85.221.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=usp.br Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=usp.br Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=usp.br header.i=@usp.br header.b="jq7elhb0" Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-56a8e0ea02aso4002684e0c.0 for ; Sun, 05 Apr 2026 14:38:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp.br; s=usp-google; t=1775425081; x=1776029881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qX7RWL7TDJnYlYdQ9XwBC0yy7c9ACcAwBuNCuK0VzFI=; b=jq7elhb0LiBpXvDGXgPSvY6wWLxMsp5k9CdVT7tLpKCYAobdGSBhnucWJ44vPLoNM+ 3WLziCrdlaGsKtcnf7uMGLNUnxNm10Wihg5tbknqX8Ci8cUNKstPa/GeXLjw66HHSj8C gH0lm2pyDo2Hv7l1I3/0GNVPWu3YcdM+OXqOAMboSfqdehX14SZq613KwXDRxYFvn2tI g+9zi6oMp6Z1tfTGgN8lLd1CigWlj4md2liXFcmX2vSP5liVRXsGh545lXOlSkWo2ALz +mSU3tFeFuGDAa+ToGuP3+/jlS9aDjLEThWkw61c0IKp8kJWmvqjjNhvvSyyxI4CLXrQ C2rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775425081; x=1776029881; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qX7RWL7TDJnYlYdQ9XwBC0yy7c9ACcAwBuNCuK0VzFI=; b=Vh6BcQZADcVpy8KHf/H0O9caU6ivTQbNQlgj1hF1XrFR0+4DeM1oqgxcW0W59xg+tU r9eAVDljDVkdMez6cGfoFfNkprj75MRWpOFiVFe4UCBcKMKSlMTsXurie1hy8lUXU8tc ue2RE4MLQ+BzIwZXb3QWJV75NhRKrKn0eWZMoZk5SkWR9rSppWFh63Zud6PPJf5v9oDh o+rLZMutgTgaDq1HO8TqR6QKbX/CV5j/Lhk4lOFjXn3FyB5//CtixfFCAIY96Xu+MgJK +hcUj5NS1tfmQIx7ME8BkLlSvl6tM1mr69L8XiDJdIqm7SsUGi72eFGQW/GHzoKcs36K PKJw== X-Forwarded-Encrypted: i=1; AJvYcCXBtx9gkxXK3ygoMYNeJjqEFc5vzfcHN1wWdTiTq6Ib8shAvDEAta5uwFFG4HLJPGUg4ZD/kdhOKtsyJp8=@vger.kernel.org X-Gm-Message-State: AOJu0YwJATqzX0ac09MMneb6qOy82GxnQkDA0Q+U+7Hs0JcSy1tm4lkE GEdPd83rbcWLJo4eH5pwZmQAPuxgVItNCijla+hBcjLgaeoibZvlL7+99UNqjPtKpo8= X-Gm-Gg: AeBDiesflPsyQTDX2jhDzxDODJCXNNnN3qhgHHaviWPEQhT5PucrkK++eKiGcZrLnD4 LvHSkdJzl+JXGH+c8NXJqP+3LcB24SB1gaWghPbc8thXyoPnQqolcNoiG3HBSH2/8a/C/9T7XA3 1oxkBA02WjKXsC3NUN8YnG3mHiuoPnvRJqhkzD5TPMJZzFs1gl+yKqgyPIZsNd5NRlwICy/kcAP ce6KTb5gj/LoBhsccFdTF4Y3cKMxP+sCRN2T8feb/Jb+kKwTlVqjIuBJbouk4kajjE4mg7smsUT h9Yr6AMSQ9o9lr0+XB8CYvABBEGxcxCJNH4+b5HvHYbG3fIiZ9OAoV80MeeaH5e5CC9vrfOW/Xv xpWh27GgGW1k6qqzVerLEXoLDvqC/WNiv7IjnjVzCHkbgEO6b0uW/HoFhZ0KI9JPCh0deo7EkS/ 0davwT7ows3F9ToWqrZaEHdjYEZ+9XpVAqFntGuvtyKx/2K8l8fzFLvUexbxZhnKlrXYOUz/bNV VkW7EkzDde1wjSU221jjhFeEgy5XfNg71JAeZWKjmVIQDDaJA== X-Received: by 2002:a05:6122:3b84:b0:56e:eb08:21ca with SMTP id 71dfb90a1353d-56eeb082629mr1053487e0c.7.1775425081452; Sun, 05 Apr 2026 14:38:01 -0700 (PDT) Received: from gui-host.Dlink ([177.33.104.190]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d9bd0a8a3sm14805210e0c.17.2026.04.05.14.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Apr 2026 14:38:00 -0700 (PDT) From: Guilherme Ivo Bozi To: Marcelo Schmitt , Jonathan Cameron Cc: Lars-Peter Clausen , Michael Hennerich , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, guilherme.bozi@usp.br Subject: [PATCH] iio: adc: ad4170: use lookup table for gpio mask selection Date: Sun, 5 Apr 2026 18:37:26 -0300 Message-ID: <20260405213725.25426-2-guilherme.bozi@usp.br> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Both ad4170_gpio_direction_input() and ad4170_gpio_direction_output() duplicate the same switch statement to map a GPIO offset to its corresponding mask. Replace the switch with a static lookup table, simplifying the code and avoiding duplication. This also makes future extensions easier. No functional change intended. Signed-off-by: Guilherme Ivo Bozi Acked-by: Marcelo Schmitt Reviewed-by: Andy Shevchenko --- drivers/iio/adc/ad4170-4.c | 47 ++++++++++++-------------------------- 1 file changed, 15 insertions(+), 32 deletions(-) diff --git a/drivers/iio/adc/ad4170-4.c b/drivers/iio/adc/ad4170-4.c index 82205bfae531..d1e971649b6f 100644 --- a/drivers/iio/adc/ad4170-4.c +++ b/drivers/iio/adc/ad4170-4.c @@ -1699,34 +1699,29 @@ static int ad4170_gpio_get_direction(struct gpio_ch= ip *gc, unsigned int offset) return ret; } =20 +static const unsigned long gpio_masks[] =3D { + AD4170_GPIO_MODE_GPIO0_MSK, + AD4170_GPIO_MODE_GPIO1_MSK, + AD4170_GPIO_MODE_GPIO2_MSK, + AD4170_GPIO_MODE_GPIO3_MSK, +}; + static int ad4170_gpio_direction_input(struct gpio_chip *gc, unsigned int = offset) { struct iio_dev *indio_dev =3D gpiochip_get_data(gc); struct ad4170_state *st =3D iio_priv(indio_dev); - unsigned long gpio_mask; int ret; =20 if (!iio_device_claim_direct(indio_dev)) return -EBUSY; =20 - switch (offset) { - case 0: - gpio_mask =3D AD4170_GPIO_MODE_GPIO0_MSK; - break; - case 1: - gpio_mask =3D AD4170_GPIO_MODE_GPIO1_MSK; - break; - case 2: - gpio_mask =3D AD4170_GPIO_MODE_GPIO2_MSK; - break; - case 3: - gpio_mask =3D AD4170_GPIO_MODE_GPIO3_MSK; - break; - default: + if (offset >=3D ARRAY_SIZE(gpio_masks)) { ret =3D -EINVAL; goto err_release; } - ret =3D regmap_update_bits(st->regmap, AD4170_GPIO_MODE_REG, gpio_mask, + + ret =3D regmap_update_bits(st->regmap, AD4170_GPIO_MODE_REG, + gpio_masks[offset], AD4170_GPIO_MODE_GPIO_INPUT << (2 * offset)); =20 err_release: @@ -1740,7 +1735,6 @@ static int ad4170_gpio_direction_output(struct gpio_c= hip *gc, { struct iio_dev *indio_dev =3D gpiochip_get_data(gc); struct ad4170_state *st =3D iio_priv(indio_dev); - unsigned long gpio_mask; int ret; =20 ret =3D ad4170_gpio_set(gc, offset, value); @@ -1750,24 +1744,13 @@ static int ad4170_gpio_direction_output(struct gpio= _chip *gc, if (!iio_device_claim_direct(indio_dev)) return -EBUSY; =20 - switch (offset) { - case 0: - gpio_mask =3D AD4170_GPIO_MODE_GPIO0_MSK; - break; - case 1: - gpio_mask =3D AD4170_GPIO_MODE_GPIO1_MSK; - break; - case 2: - gpio_mask =3D AD4170_GPIO_MODE_GPIO2_MSK; - break; - case 3: - gpio_mask =3D AD4170_GPIO_MODE_GPIO3_MSK; - break; - default: + if (offset >=3D ARRAY_SIZE(gpio_masks)) { ret =3D -EINVAL; goto err_release; } - ret =3D regmap_update_bits(st->regmap, AD4170_GPIO_MODE_REG, gpio_mask, + + ret =3D regmap_update_bits(st->regmap, AD4170_GPIO_MODE_REG, + gpio_masks[offset], AD4170_GPIO_MODE_GPIO_OUTPUT << (2 * offset)); =20 err_release: --=20 2.47.3