From nobody Sun Jun 14 18:48:32 2026 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 272DA26290 for ; Sun, 5 Apr 2026 00:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775347246; cv=none; b=o7rTh91DR1okjKk6uFbHDY/3v2HuNhYPRzQI/2gmEWvnovAeAGAxVhkg5eKVUYK4fAaivw47Fw9LAUG99RaOxd2eivZsqhzI1Oni/NMXsLiBtYx/VSKgL/F4dT6dElTlYpsveV3EvPZcy3z1zNjXpNEAvm1/9TXKLpwzOi9KjUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775347246; c=relaxed/simple; bh=MFYXzeV+MYNpZTCQHYFr09VgVSxe+OjOWjIuHtJ6XNc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lkvOHiOOER/LGeXDSH/RD//qaNAkmBVQsP9uGkXY/chv8Dw0P7u5QYFkaiCuCYa8jJgBGeenmsjco5UUVCSW483oHaw1VndW5oD0k+2Gmw56CixUzVJHvt2omBIV6XELeiu3tduVrrRCmqXVjC8Tf9U57D7zy4SxuwZBy9QafNs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jWtr/nwx; arc=none smtp.client-ip=209.85.217.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jWtr/nwx" Received: by mail-vs1-f53.google.com with SMTP id ada2fe7eead31-60580b17793so829301137.1 for ; Sat, 04 Apr 2026 17:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775347244; x=1775952044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zbKn6m9xcag5finRPB+a0t10FFieWhhuTYJnUAMc/5Y=; b=jWtr/nwx/8x0dlUmH7qnCP9B81f4+x+FiChrUAS+yQPB+xoEsTECO5PjtDN/J9b/ry 0/976IymLbFImIemHBIZExRvXYMLFGYuo3ANmomUKMzSt80MaSppo53Ml7chCARxGAee 4oOdV5tsvRZCOSZ/aBAtx3WWnsVEf6tRPnYu/M0BJYQXenxbGcWj7AAyiJognRsaJhPd 9SW79SLQOY247RRGg4YGah5YCeAcDymI+uyVRYkp0X7P7lO6NLUxJBXAVBk82WDlA5zI yQECslWrbaaqmVk81OFC1eynOiSY2HFNaUHSRRm8teVY3YubkdLvluLx2iqaDdaY9Hx7 lX8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775347244; x=1775952044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zbKn6m9xcag5finRPB+a0t10FFieWhhuTYJnUAMc/5Y=; b=Z3xtO69FAWRFTEkokAj8rI2BlEdllextaN7acWIU4qCyX8QKU3YDEJ93Mp+EcA/r4O jx6ww+chHHFwqSqVvphLw0gZDVMUAJZuRtGQNxc4/BnNn2DSMaVNYxNvrQ9fshTmKATg sHQTEOd+rSNFAgV9BfKlyTwRyZT1i3l3oCYZshLCRf3THWZgdvyILj2bMsnU0I7PLN7q tm5fdni0n7njePj7SgXbHy36OT7ChHda75BJJM5cUrPbIqClhqNHw8L+FLgz9q7Y5Lxd gAkShwal1PV41TFN/Mty926vWJGcrwF07rjIQ+gD/pStrNsVFsTaZK7Wh63sErWEPHca 5GnQ== X-Forwarded-Encrypted: i=1; AJvYcCUd6k/Y8f/FQI0H1glF0UVT5V7HN2SVQFBUTX8ZA8PlSEfRQMSx5ng2WaIb1UwxwKOH80QpAV4usAIwKY4=@vger.kernel.org X-Gm-Message-State: AOJu0YzfQyo3yJ2yy02JccYhCMDEiLvw+UqZ3Vc/YvcQe6hzAHCwthb5 QcSR7+OO+Jz7xzQe/B88CCkmYtY21jE+oXFFH0/AihJCB6eoOXtVrlhr X-Gm-Gg: AeBDievrnt13iqfhuOqUPzBUlzoTt2wrbQgT9AgqUBiJ1NwoCm3LnpYvL2dVKj2pq1n 0MwxJEM+O+v/A1bpD9KELR/ydd0Iwgon0PUoFaHuTUutfx2GzpwoJ7GR8in38VnLiXBf4SiSRS/ 4MDiros1xqLtlZVGqwN3x8uCWavtnNPjJqFwEw3iUnU8z+EhOwvH6PNMBnlnHGKOf9QX66Lw4uE bDxpQGab+C+A/2VAsym5bjjJlLIKCQKhuXHRQoy7r5ieG+uFxZgBnArS/sSxMeZf3/s9c0qj3XG ZfNEYHyALnh1TlSiQSs+pzn5vgQl6DJ/Tkdh3Dk0QuUOZxH9oFs5TFskduHNSF6IhLWykLfr03m uxpF3541cpCAXqjeENjS9TLcFLl9KwUDdTiFbW9ubRZD75ps/mS3fPk/RuHvZsTsnkQLdSOB/s0 eDE06sxr6AtLSi+LlAbYSyNgOC/j133CUcGJ/gWsaQ X-Received: by 2002:a05:6102:689a:b0:5f9:39e9:3562 with SMTP id ada2fe7eead31-605a4dd9a49mr2482596137.2.1775347243859; Sat, 04 Apr 2026 17:00:43 -0700 (PDT) Received: from localhost.localdomain ([102.244.98.15]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-60582e1214esm11671585137.3.2026.04.04.17.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2026 17:00:43 -0700 (PDT) From: Delene Tchio Romuald To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Delene Tchio Romuald , stable@vger.kernel.org Subject: [PATCH v2] staging: rtl8723bs: fix out-of-bounds reads in IE parsing functions Date: Sun, 5 Apr 2026 01:00:24 +0100 Message-ID: <20260405000024.73568-1-delenetchior1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260404222100.57946-1-delenetchior1@gmail.com> References: <20260404222100.57946-1-delenetchior1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IE parsing loops in rtw_get_wapi_ie(), rtw_get_sec_ie(), and rtw_get_wps_ie() check only that the element ID byte is within bounds (cnt < in_len), but then immediately access the length byte at in_ie[cnt+1] and data bytes at in_ie[cnt+2] and beyond without verifying that these offsets are within the buffer. A malicious access point can send beacon or probe response frames with truncated Information Elements, triggering out-of-bounds reads on kernel heap memory. No authentication is required. Add two bounds checks to each function: - Ensure at least 2 bytes remain for the IE header (cnt + 1 < in_len) - Validate the full IE fits in the buffer before accessing its data (cnt + 2 + ie_len <=3D in_len) Cc: stable@vger.kernel.org Signed-off-by: Delene Tchio Romuald --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 72b7f731d..e0fed3f42 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -582,9 +582,12 @@ int rtw_get_wapi_ie(u8 *in_ie, uint in_len, u8 *wapi_i= e, u16 *wapi_len) =20 cnt =3D (_TIMESTAMP_ + _BEACON_ITERVAL_ + _CAPABILITY_); =20 - while (cnt < in_len) { + while (cnt + 1 < in_len) { authmode =3D in_ie[cnt]; =20 + if (cnt + 2 + in_ie[cnt + 1] > in_len) + break; + if (authmode =3D=3D WLAN_EID_BSS_AC_ACCESS_DELAY && (!memcmp(&in_ie[cnt + 6], wapi_oui1, 4) || !memcmp(&in_ie[cnt + 6], wapi_oui2, 4))) { @@ -615,9 +618,12 @@ void rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie= , u16 *rsn_len, u8 *wpa_ie =20 cnt =3D (_TIMESTAMP_ + _BEACON_ITERVAL_ + _CAPABILITY_); =20 - while (cnt < in_len) { + while (cnt + 1 < in_len) { authmode =3D in_ie[cnt]; =20 + if (cnt + 2 + in_ie[cnt + 1] > in_len) + break; + if ((authmode =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&in_ie[cnt + 2], &wpa_oui[0], 4))) { if (wpa_ie) @@ -658,9 +664,12 @@ u8 *rtw_get_wps_ie(u8 *in_ie, uint in_len, u8 *wps_ie,= uint *wps_ielen) =20 cnt =3D 0; =20 - while (cnt < in_len) { + while (cnt + 1 < in_len) { eid =3D in_ie[cnt]; =20 + if (cnt + 2 + in_ie[cnt + 1] > in_len) + break; + if ((eid =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&in_ie[cnt + 2], w= ps_oui, 4))) { wpsie_ptr =3D &in_ie[cnt]; =20 --=20 2.43.0