From nobody Sun Jun 14 18:58:25 2026 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E1A133DEFC for ; Sat, 4 Apr 2026 23:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775343798; cv=none; b=nRpl1NcyRRAkKpw8s1JrWjI8Tx7k+57nihtJVvsE71fE9jsyVGPgxgpf83eBGOdfF69SgVY6K818nrNFKx2NTdZ2h6FeUF0M40uFWLBz4w9617ZHgdQZh3U1mMzDS/av/IF6l1hGkGAE9oztojD9xLLStTt/rkIehP2e6iM6dZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775343798; c=relaxed/simple; bh=HL1mwJBzaIwo1zGTYraOLa0fIAhVfWpdcbVPs6RmyZ0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tFRIH4enPVHnAprk/BahUuAzubZDNzY2KiEkA/Uhn3GmzsC4FJfB46bT/+h79tyPNH6h6ASD0oNPcZlgDXGD0V1AGMFWhl1g20FARCGWXk6BLkOCs7HBAmAV8e1TRpNu6IywGGBohv0xjS+xITWlqfvz4hcwP4pUDRZKZm4g7Qk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T/ujG4VB; arc=none smtp.client-ip=209.85.221.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T/ujG4VB" Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-56a857578a8so1070992e0c.3 for ; Sat, 04 Apr 2026 16:03:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775343795; x=1775948595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VT54FeMbxqX21ddtIQHdTpaD4nSQybFIj5pVbkZZyL0=; b=T/ujG4VBFv35IlIXHi6wjnHgBY2HB0KGUtcYw1biu8St9yjzlaCU2KAA3dYk/tHIdS R1/XSzgGynqekuvS7RM1KMotwBjvzx5nazzxGhSDRAKQ1zj9ygC4qulmwg/IYRDi4Q3B Nq/K/5lYU5HFLZpZ87aqoPf7hgYCJcSVEiJvi+/EkOqdRRS88I3XyQAVFGyt2X2TZ3BC T1pCobnt0lnXMDDmKtTafHU7NTAV+/yU3fBxR/6XWDA9eZo5xU5lsM8BP6xdqDx7Xri3 JmtKaM+S3PNYs3W+3OA2Sqjv3WkuyFC/Xv9VnTG7iV3p+nkfUWvKnVW7DJ+sztNymDbF mH9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775343795; x=1775948595; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VT54FeMbxqX21ddtIQHdTpaD4nSQybFIj5pVbkZZyL0=; b=cWC+pA2EuEnqImpn9DvEB5Av0mag1z4VDDzPkQxmSROkFrZBDoMvrTfUGyR3sr5lgO nYp++k1PvwjLTWMMrNqxhUBw1iKGR66SJABrBkL7RR3GODpchd3nWvkfCVVgLBC9EsTY 4Moocw+Hb58Lc5b7EWvDnKInQumS7VleKcdU9OKYknKtAYb9XIvnSC/C6/QLzTbOV0nU QA16/zlj4WK8b1v24Qj008VLua0zX/sD00aUTRydDHIzKgt1Wl5SFthW6dUpmvrNLygW kn9jZKZVN4zi5Wbzkxp7qgNpziGuqxm0rQhq8xvCPpxw6dHGHLzULrsAO+OgzhZC1URW SXOQ== X-Forwarded-Encrypted: i=1; AJvYcCU8yKuHNy4SMznkMMva12ZZI6bE/XndCFl0oJPFF0meErP8UnNc2boc7SWLXCJcQuekUnaPE/ikubZsfJg=@vger.kernel.org X-Gm-Message-State: AOJu0YzTi1O9CYa3b2fI7ggohmewzWqpsLiTas7PQMCu5BPkeaEEGfGU fGgiPLxaaMLqP/UV9p8OpaRwqpePAiHiiHwO+QBQq6u6Q7mcpZsgYxnxsOzX7DIS X-Gm-Gg: AeBDietTuG/SGg/dA0N4XFpQCyPO65YhBCwOLVbIsPCvIY/WH7GMmKg9SgZDm9k8LMF 0FEHTky18DwoPhGenPL3Gnt6ZOFBR47/dnqpNy5+U3Gqegl2t3a5+ub4ktpom4L6S1GucOU6hf2 YuE/FTS45749C1ccT5WnqvK8sQl/8puVPCym/wTMj94ZD1A6FrBlKRsq+pZJNT5PngjO3M0Ngtq R3DLHn8brt6/gjMPJ4n9efV4NLTzVjhVfYE93JA1KZHdWrE4GXyh9pl7hZlY55AtO8UisMr/jN5 qBYaSidD3ACPdSHcapyM/C24Q43EntKCOg6/xm+gsUuNAkXsfkKvFZR0pyz6/ptet+BUI0JQ7Ga r3e3QRkeZDow6uqm7oatH8oM7HV6mZ2mbZzp4Id7IHV+OghB24270D2q7zQCiEH6S8bVIgOTLZj W56sdqfkdCTAgKdXTm/ODdwNCNrVVeD1LkwX64m93Z X-Received: by 2002:a05:6122:e1b2:b0:56c:ce0b:fecd with SMTP id 71dfb90a1353d-56dab9d6df7mr2638405e0c.12.1775343795382; Sat, 04 Apr 2026 16:03:15 -0700 (PDT) Received: from localhost.localdomain ([102.244.98.15]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d9ba80290sm11317699e0c.3.2026.04.04.16.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2026 16:03:14 -0700 (PDT) From: Delene Tchio Romuald To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Delene Tchio Romuald , stable@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: fix negative length in WEP decryption Date: Sun, 5 Apr 2026 00:02:48 +0100 Message-ID: <20260404230248.62203-1-delenetchior1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In rtw_wep_decrypt(), length is declared as signed int and computed as: length =3D len - hdrlen - iv_len; If the received frame is shorter than the combined header and IV lengths, length becomes negative. It is then passed to arc4_crypt() which takes a u32 parameter, causing the negative value to be implicitly cast to a very large unsigned value (e.g., -8 becomes 4294967288). This results in a massive out-of-bounds read and write on the heap via arc4_crypt(), and a similar overflow at the subsequent crc32_le() call using length - 4. Add a minimum frame length check before the subtraction to ensure length is always positive. Cc: stable@vger.kernel.org Signed-off-by: Delene Tchio Romuald --- drivers/staging/rtl8723bs/core/rtw_security.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/stagin= g/rtl8723bs/core/rtw_security.c index b489babe7..807f4f3c7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -113,6 +113,12 @@ void rtw_wep_decrypt(struct adapter *padapter, u8 *pr= ecvframe) memcpy(&wepkey[0], iv, 3); /* memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[psecuritypriv->dot11Pr= ivacyKeyIndex].skey[0], keylength); */ memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[keyindex].skey[0], keylen= gth); + + /* Ensure the frame is long enough for WEP decryption */ + if (((union recv_frame *)precvframe)->u.hdr.len <=3D + prxattrib->hdrlen + prxattrib->iv_len) + return; + length =3D ((union recv_frame *)precvframe)->u.hdr.len - prxattrib->hdrl= en - prxattrib->iv_len; =20 payload =3D pframe + prxattrib->iv_len + prxattrib->hdrlen; --=20 2.43.0