From nobody Sun Jun 14 18:58:25 2026 Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4AF319CD0A for ; Sat, 4 Apr 2026 22:32:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775341929; cv=none; b=AXQbPiWlFYSO29SW2CEyGW7I/QCycSLojgbFEyIR9Str7lF5xCXVbMW1BBnDUBYejM3wh/pruS9YUS/tCAPqw356CWUcgzmbjpt27yR27zEBPE12TH7zQBAYUBjQxExxKCEgRuiaOn/cJu/gDoUx7un8A0bvgNsDt0TdsxwNmy0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775341929; c=relaxed/simple; bh=ZFOY+U8fUTrYq9I+LJFqUKM/5/KC4WNw5rgtdpRO39E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bfBxYo+sDgqfMipCMcVLNjC59yYCR7zjX0lxogkAXkkiDPJQ7rkTD12Jh1sroS1+wddPDLYDwOHrw8co1drVXmro6iKi/AXnkuoYVBgkLxBFosA3RgFShLOPw0rVrvWP/Yvu6Zu5NeU1oJmcDdNhwQG7vRhjtSWwMKvzN5U+erE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qAQs4R7q; arc=none smtp.client-ip=209.85.221.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qAQs4R7q" Received: by mail-vk1-f176.google.com with SMTP id 71dfb90a1353d-56a8e0ea02aso3365117e0c.0 for ; Sat, 04 Apr 2026 15:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775341925; x=1775946725; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=s7M/wb5ZE+bi0m58cYsS3oHIi0wg7WyajZ80sRcwVHU=; b=qAQs4R7quS0wgfiJokbTC0jMq8Dwq199m6U0eFuTlmcyi2tQTXvPmX3Tq0XsA5yrrS buwQY02/dC97Nm5RkP1RAsvOVxRLaX/otbkNvjGQVh3aQLQmpE/q6K5gagZX15RU6+t0 iAmuO/lxKf31EXtN/tBovD9qLtdQ1WxnozRBuhU7vXBwkGLwLvdMGMHHJ6oCVsERa20y uhT9QXkeXlyCfBBVWTkOJywcO/CmFBhNT9lJrANOPDzjKqPQn0VEvQQVJH86TiK3029i Y82ZXotqJmfRqEHso8yuXpYWzsVzW3O/C7Kllb6UFDgnitt3Tqn+jcIlhZOKd/TB3yOJ lN1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775341925; x=1775946725; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s7M/wb5ZE+bi0m58cYsS3oHIi0wg7WyajZ80sRcwVHU=; b=Kccs/1HfSml7Xl63S8ibqB/JhZ2n0wa1v9zVle78E0WFGH/Y+6K6iNd0N0kDM24sKc uZidF8AAPascUSzN8KmLNeCifT1AU05E8RdnBBfd3VZEoLAHWQdaKrrYykjl8fNj/oxe YbC+nJH7KzZefFc1IqI1fwdSVWwH/iNJTMlXhY/LKXFyZNaXQzsg4gPimWdKrHNaFZw7 KjF4zxAw1d3gYVDADIIgaFFCZ5xlbNLmC3JNJG+M1HNOVewgZXxFR8wcZ+1J20HWXTC5 Q/kjFGYs+SLupQPHcDgeYB3rHGebos9SXoFnJOAXSoNQDFcjxZoF42Tc0qNO/QP+knCe eVsw== X-Forwarded-Encrypted: i=1; AJvYcCU1lTqWegQKkyCAEMO0Qe9LVDQkRB54bIDlFUy3FZ0FUCo79/ZFDFmRsQKwpElRie+XQLUBDLbfxfbgNso=@vger.kernel.org X-Gm-Message-State: AOJu0Ywc3V149vHNUOtXD9iPdy1liSe3j5YcKyy9Gj0aJzNRGkaKyUZE eBIdZ01KOG/lFdg8ClywZz4/53m1jyRjRnzZn03OJQvMDBYU9jrNf8Yq X-Gm-Gg: AeBDieu6Zbn+w4enSY6LLaiU2DQFKe0Cncd6XlR0rIJhsyDXAHcwCmszc2saW4Fkd3K Fn6jG1zPX4UT1551R+sN4WBEPAEl/CY0b7Xx71MLoJ47WPUKfr5/E7mKOOH1FhW0lrQS/2vK/9m fQA1krkfs0+SgBAdVLSBnno2pqezkjrisj/08m4BKCzvsSyRZRlwXQs5Hox++LkE5A4QSuNRMig apr5opT7Y834vvH39NDww10mw/NHpejjc1030dZu4zG7K3MG+3aC/QzpAh3dPhz0heUNAfVUdcK Im5xZU7KL9P9cY8KL7NIUuU7syhzAFBrSdE1flvu+0pFrpSeCvVfwKXcIFuAN1gmkkpBqJJnI/q EbeaTJefPFDz/8Q5fagju7CdK8JiLAtXE3KDzA6FURl1RntWiSSVwK6juKIyyMfgO83FWzM8joe Gh9FiDMavGao2r4hzeM+yyQaeOUi8oWREgUqFjtD80 X-Received: by 2002:a05:6102:801a:b0:600:106f:5fa8 with SMTP id ada2fe7eead31-605a4e0b2f6mr2965878137.15.1775341925479; Sat, 04 Apr 2026 15:32:05 -0700 (PDT) Received: from localhost.localdomain ([102.244.98.15]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-60582e1d1edsm11631603137.1.2026.04.04.15.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2026 15:32:05 -0700 (PDT) From: Delene Tchio Romuald To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Delene Tchio Romuald , stable@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: fix out-of-bounds reads in IE parsing functions Date: Sat, 4 Apr 2026 23:31:44 +0100 Message-ID: <20260404223144.59168-1-delenetchior1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IE parsing loops in rtw_get_wapi_ie(), rtw_get_sec_ie(), and rtw_get_wps_ie() check only that the element ID byte is within bounds (cnt < in_len), but then immediately access the length byte at in_ie[cnt+1] and data bytes at in_ie[cnt+2] and beyond without verifying that these offsets are within the buffer. A malicious access point can send beacon or probe response frames with truncated Information Elements, triggering out-of-bounds reads on kernel heap memory. No authentication is required. Add two bounds checks to each function: - Ensure at least 2 bytes remain for the IE header (cnt + 1 < in_len) - Validate the full IE fits in the buffer before accessing its data (cnt + 2 + ie_len <=3D in_len) Cc: stable@vger.kernel.org Signed-off-by: Delene Tchio Romuald --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 3e2b5e6b0..0c1138b90 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -582,9 +582,12 @@ int rtw_get_wapi_ie(u8 *in_ie, uint in_len, u8 *wapi_i= e, u16 *wapi_len) =20 cnt =3D (_TIMESTAMP_ + _BEACON_ITERVAL_ + _CAPABILITY_); =20 - while (cnt < in_len) { + while (cnt + 1 < in_len) { authmode =3D in_ie[cnt]; =20 + if (cnt + 2 + in_ie[cnt + 1] > in_len) + break; + /* if (authmode =3D=3D WLAN_EID_BSS_AC_ACCESS_DELAY) */ if (authmode =3D=3D WLAN_EID_BSS_AC_ACCESS_DELAY && (!memcmp(&in_ie[cnt+= 6], wapi_oui1, 4) || !memcmp(&in_ie[cnt+6], wapi_oui2, 4))) { @@ -616,9 +619,12 @@ void rtw_get_sec_ie(u8 *in_ie, uint in_len, u8 *rsn_ie= , u16 *rsn_len, u8 *wpa_ie =20 cnt =3D (_TIMESTAMP_ + _BEACON_ITERVAL_ + _CAPABILITY_); =20 - while (cnt < in_len) { + while (cnt + 1 < in_len) { authmode =3D in_ie[cnt]; =20 + if (cnt + 2 + in_ie[cnt + 1] > in_len) + break; + if ((authmode =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&in_ie[cnt+2]= , &wpa_oui[0], 4))) { if (wpa_ie) memcpy(wpa_ie, &in_ie[cnt], in_ie[cnt+1]+2); @@ -662,9 +668,12 @@ u8 *rtw_get_wps_ie(u8 *in_ie, uint in_len, u8 *wps_ie,= uint *wps_ielen) =20 cnt =3D 0; =20 - while (cnt < in_len) { + while (cnt + 1 < in_len) { eid =3D in_ie[cnt]; =20 + if (cnt + 2 + in_ie[cnt + 1] > in_len) + break; + if ((eid =3D=3D WLAN_EID_VENDOR_SPECIFIC) && (!memcmp(&in_ie[cnt+2], wps= _oui, 4))) { wpsie_ptr =3D &in_ie[cnt]; =20 --=20 2.43.0