From nobody Sun Jun 14 17:34:33 2026 Received: from mail-dl1-f67.google.com (mail-dl1-f67.google.com [74.125.82.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 710CF374735 for ; Sat, 4 Apr 2026 10:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.67 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775297409; cv=none; b=sTusJ/n+HqCzA1sFP3YR9DVzkn0K5OVPCiaCtWrWf3TlYbnuvb5Jzb9ufwMruemNwWv4A45gSQjGV/boYhsXszcCaT0ZUqAiVrnaFl26DlDr8/jpbnXzpcLyA7P53TO13WxxITKqBcjlYvWy465GYWZd4PK8AsiPhcw3AjSHPf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775297409; c=relaxed/simple; bh=kGdzjNKChw9a93zcTrVjsPWvms1Vj9qFAFmv9YflOWM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=n5gn9W2Pzx5HwS5yY40gAPt2S+87F8MSgds9tU0eDXQzpi6KlhMrkrZCXxVtNq5DmgP0CTGzDBQBcYgSGn6HsHSoiqI1HAiS98IaJTUiYEF0J0y1JwDLSuysuXWxUtawHdcDdHxRaPIRAQmOADz/z2f13+Edl7K+HScFOZcFmRI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=tBUmBHFk; arc=none smtp.client-ip=74.125.82.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tBUmBHFk" Received: by mail-dl1-f67.google.com with SMTP id a92af1059eb24-126ea4e9694so4699862c88.1 for ; Sat, 04 Apr 2026 03:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775297408; x=1775902208; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=F1N0jwTmIBAkK80GMXMRCtLqUArvCFjyImESGdQuqgM=; b=tBUmBHFkEFKPmYIjGcgcUMKwmlTSZZZXwnJWz+r10KTj/eHgri4Qc2zhkwAtS/MSvv 1fG5lK7IFZIToa6SXzxiqdgWi7PRjFOGl6yqjs95/6rmbwxEFXv9xwm0F1I4WsZCIqTJ 0pWPDaywPdnMjpIBVkUa8NH6vZLGkdJ2IKUoKInm/0ePrbvm3S8Gql7rYKrXrH/9APcR 9N25pvQZncnFigRelgX4GyRry4uU4E8TMvhDbldNauGew0MT/svrile/CTXhHkMBM8lH f2nNwAo0d9wje+HndmsHTu+FBn8UGtwcZU5mOTIjSK4ltKoY0PCozUFpvlb2s/WRQT3i TVeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775297408; x=1775902208; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F1N0jwTmIBAkK80GMXMRCtLqUArvCFjyImESGdQuqgM=; b=fxmZ8kTsuRQ1960ZwXgbfzltkxDV3OnWuvl7uiP6wirx2ToACBI92Wc4LIZX09s++K tN++vhODYo8PqzBfxtP+vOyDpFlRCx6V9WspH7T2xgAY1tD+mLbSMtLz4cLoWQnmGzl1 fVX6J0/aY50lwek6MBFirvfUXyZ/mcGr+JXGhBzH4u8/FAkOLMDe9zPn7kqfKqdHMMwc QUqzsNdw2G0tbtLvljYkDM9V1gkiMre3h+dYP6s7aa/ZqMZq3nnK1ld1V9UopIIGLV/w G8PktHGYNdShKl8qxJtO6J9DjkQzOt0F/1cAQMquakllJQ/XQIgvccgmpqa8eMQLUCsW MH8A== X-Forwarded-Encrypted: i=1; AJvYcCWcNZypsZ0GN76sfhE8DTmoICFbrvltDR0Gtkx0XKd9A/L053N3nU7DeW4PKz+yEa9AZhHUm3fxFHFGS9g=@vger.kernel.org X-Gm-Message-State: AOJu0YywIMvxe2ZJ8jhINUQB6u8aENu3dZh4LAqSZwfO9ljHv+2HhU/r B4EMt1rxU8jQKdb1FNgKBD2W+tLZeVfhOxVxp9lxWpZVWf+nLRxo9jGe X-Gm-Gg: AeBDieshhzzv6d3qQy8ZX9wkZi916UIpQFyRdcOyc53kiVGbD3cjyJlf4f1kpp4BjXw ZGeZ+Aw1EKzRUR7pn92FRRuXAoSzptxMC8OwPVYCmokfeuaBo397x3VEeu2JgSM55d4LMK6JX/R JUhXPkifzhsTridNAffQaVs/jI/BSWX6iO4IqdW/GZtOZBCzF6Rgi1WK8mqYxnQBEsxiNZlaF+b G8xDizZyeGwPOEM24pIaZ0vez6CCFVLWiaixAY2W6bVdz/6bGjAG3sRdrvKOJTkhzfAYdX9srJb 3NDO86slglSrFOthEcqBehWsB08JEOyEAf6jbfg34FAIOqH1Co0njtzpha7Ek5Cvv+NlxCoKEd2 7wGfJuyVv7Oe+D57vbrIC/YKurJt66P5YqtYIo6MVx6KhSOXNeMTZKXYBuT8B9JPFkvOn66J5bE 5pxAWke4etQb9HbpNWyo9qSi3lLvxsCUCB+vjieOle4HhPRUT/EOZXq3I= X-Received: by 2002:a05:7022:1005:b0:11b:f056:a1b3 with SMTP id a92af1059eb24-12bfb6fb217mr3309937c88.11.1775297406824; Sat, 04 Apr 2026 03:10:06 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bedd6901esm5925929c88.5.2026.04.04.03.10.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2026 03:10:05 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH] staging: rtl8723bs: remove redundant assignments to res Date: Sat, 4 Apr 2026 10:09:33 +0000 Message-Id: <20260404100933.7911-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable res is already equal to _FAIL when the condition (res =3D=3D _FAIL) is true. The assignments inside the if blocks are redundant and can be removed. No functional change. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 7b18be8912e6..ea1923023caa 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -209,10 +209,8 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, s= truct adapter *padapter) pxmitbuf->buf_tag =3D XMITBUF_MGNT; =20 res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_XMIT_EXTBUF_S= Z + XMITBUF_ALIGN_SZ, true); - if (res =3D=3D _FAIL) { - res =3D _FAIL; + if (res =3D=3D _FAIL) goto exit; - } =20 pxmitbuf->phead =3D pxmitbuf->pbuf; pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_XMIT_EXTBUF_SZ; @@ -241,10 +239,8 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, s= truct adapter *padapter) res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, true); - if (res =3D=3D _FAIL) { - res =3D _FAIL; + if (res =3D=3D _FAIL) goto exit; - } =20 pxmitbuf->phead =3D pxmitbuf->pbuf; pxmitbuf->pend =3D pxmitbuf->pbuf + MAX_CMDBUF_SZ; --=20 2.34.1