From nobody Sun Jun 14 17:35:13 2026 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9659A1F3BAC for ; Sat, 4 Apr 2026 02:00:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775268043; cv=none; b=UQv+4FeFw6AS2Rq+BkUecIcNsyuOQmiwH8O0v77C74slAkSslQO94WrYqEaggPjwgk6Fmo7Tsfg+NfsQtX2fvPGIFTK7I3q0q6N8vl42lBSRTMFe4j4ZDzb2TN7JgS/SGfACbXo7iDFQlmevTLbSCvol8hfGS6qWJSfP2EXugn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775268043; c=relaxed/simple; bh=xwE5t0LG/3F20TNNrUtGY613jux+lpvRpheRVJYPn+g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IsLEOsAzWHSM0jqRKvpub2n6SSk83G3keixDCPlwQbWtz67T6eL+Lr4DljxcFdkS3uAAey690ptEs1EfLainIME6p0ZoYBYhevlApikoM222S3rqpuCge/nye5rX6YAdSqhfp4HkWp0OFvvVMurUc928xHFpDAJp4huB6PMUfHY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hWLRJ/EX; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hWLRJ/EX" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-50335b926c2so20257671cf.2 for ; Fri, 03 Apr 2026 19:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775268041; x=1775872841; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nna7XikjSIt8v38EvLKlFvQXyQgfQaOAHmwwtVCsG/8=; b=hWLRJ/EXn/1tAjQOg963jjsfgHXbWzeWHQTQPL7bqmcId7VWgX9EXYesozgO3/iGPY ZslA9wfKXPv2YTVzfmxlM7sZLMHm6+EnYwcLflRcazi5scOIbJ2wWkh9FkAXNqwEokIh 4bFl+r9PkRDarA/4mavR78vnFYABDtxVkmx4fqSKwDgZAY9ngi2sjeMm6vEWzHO0dxSx qJbHEu6BKYsOXmiNmBZXF5hZrXiSIaHejkzZNuXXQqbRi9bO026js3zKcPd6DYSygvNx xovUJuccHspS5bC0ruwopIoVG+f4HIkqTJ0/GDAhpZGeVAe5jE/4+mUuuEzfHUJLBqa3 9oFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775268041; x=1775872841; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nna7XikjSIt8v38EvLKlFvQXyQgfQaOAHmwwtVCsG/8=; b=hJGIr0AoF2+YwOsCyn+H7mVpvBAJCC94M5s3Q+prQDSHxPDHGxIVbkF7B9C6D9FG2q Ssxdsa/ODeoXCYQpBCMyCnNWq6OIryNCDKnjH8NbC19JEQdorRHBJgT+bc0ayhIBYUOF 7vslXYdwO+KZEYtSzGmecWcbxQesekhX7ycykXiP9mMDOfPj5V0TfZgfvCZPns5ozWru BWReMv8/UmJGHAPj+8PgohS3a9safJ3FRoqdbM5ZXP/wQO5zG1mOsgQXporIz4FAzKz8 AavT5v5RqlL5J8aHOK8C1TRY0b/Ef/nZLp7jeioE9ZcPNx5md6rNZ9bArk6mQTWlSYee BM1A== X-Forwarded-Encrypted: i=1; AJvYcCW3DKietkI1gOZE1Nw+LBnBfBMn8hmUhUYZa6lhNjA7sLzfNZ1/PD08SMBZXaxTkJDRYu9bx+jM6ywI7sI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx92fFtByKBVnrAJYIFVl5du/WLtzY200u80UkuXmsjxrfh6qXy da4HvUIc/lULpakGSuMeiT6uSOlnz6n3COaztq7jdPUIi8ZZmkMX7cIg X-Gm-Gg: AeBDieu881y0WMegmrEQmIf56u1v58+fM81Ahnxy7yJTAKjGIaOp7eYIWYP/ewsRUvS NnrFQUB70Xi8Q+C7bCJEE/IBy1Mp3Sxh+e3117zesgZKko6u0E8bdfyg4y8cRsqxOTpJSWpwHye O1tbYRJwWjvu3YSOg9gJa7ZngH5NCOxGv8g5aFCKqc65U3QLqU0TVLVZfaJN94bOYT74lTvvcAa cDB+PtE/zPGrNfy3QR486yGF6Jrrk6F/KW9aA9EQPD9nsQ7F7/JLcQdo2jZCtbCuX22Dz+s7Vkm yLfgj7GHpTwLL7Mktnvetp571eZT2YEhDTwXTq7aj1dHTXZR/96IX+EuqSeQze1MuszNxF4FkVv 93VA1GCIXE7yXHUtUHXhwKRYdMU7eG+75Hj41oEHhgOOAG5DkyNv1n7HVl6uLtmKihsHOldOAS5 Hzh3mz6kZorzjlqxagBEMuvKRimf3QDmrTPXhuT5Y2u5c= X-Received: by 2002:ac8:7dc2:0:b0:4ee:13d0:d02b with SMTP id d75a77b69052e-50d62c8a32cmr75557921cf.50.1775268041390; Fri, 03 Apr 2026 19:00:41 -0700 (PDT) Received: from desktop.. ([2607:fea8:d681:2400:aac2:af07:379d:ffaa]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50d4b8a8f38sm57316941cf.24.2026.04.03.19.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 19:00:40 -0700 (PDT) From: Tushar Sariya To: Trond Myklebust , Anna Schumaker Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Tushar Sariya , stable@vger.kernel.org Subject: [PATCH 1/1] NFSv4.1: Apply session size limits on clone path Date: Fri, 3 Apr 2026 23:30:25 -0230 Message-ID: <20260404020027.3327248-2-tushar.sariya77@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260404020027.3327248-1-tushar.sariya77@gmail.com> References: <20260404020027.3327248-1-tushar.sariya77@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tushar Sariya nfs4_clone_server() builds a child nfs_server for same-server automounted submounts but never calls nfs4_session_limit_rwsize() or nfs4_session_limit_xasize() after nfs_clone_server(). This means the child mount can end up with rsize/wsize values that exceed the negotiated session channel limits, causing NFS4ERR_REQ_TOO_BIG and EIO on servers that enforce tight max_request_size budgets. Top-level mounts go through nfs4_server_common_setup() which calls these limiters after nfs_probe_server(). Apply the same clamping on the clone path for consistency. Fixes: 2b092175f5e3 ("NFS: Fix inheritance of the block sizes when automoun= ting") Cc: stable@vger.kernel.org Signed-off-by: Tushar Sariya --- fs/nfs/internal.h | 2 ++ fs/nfs/nfs4client.c | 4 ++-- fs/nfs/nfs4proc.c | 3 +++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index 63e09dfc27a8..0338603e9674 100644 --- a/fs/nfs/internal.h +++ b/fs/nfs/internal.h @@ -253,6 +253,8 @@ extern struct nfs_client *nfs4_set_ds_client(struct nfs= _server *mds_srv, u32 minor_version); extern struct rpc_clnt *nfs4_find_or_create_ds_client(struct nfs_client *, struct inode *); +extern void nfs4_session_limit_rwsize(struct nfs_server *server); +extern void nfs4_session_limit_xasize(struct nfs_server *server); extern struct nfs_client *nfs3_set_ds_client(struct nfs_server *mds_srv, const struct sockaddr_storage *ds_addr, int ds_addrlen, int ds_proto, unsigned int ds_timeo, diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c index c211639949c2..71c271a1700a 100644 --- a/fs/nfs/nfs4client.c +++ b/fs/nfs/nfs4client.c @@ -855,7 +855,7 @@ EXPORT_SYMBOL_GPL(nfs4_set_ds_client); * Limit the mount rsize, wsize and dtsize using negotiated fore * channel attributes. */ -static void nfs4_session_limit_rwsize(struct nfs_server *server) +void nfs4_session_limit_rwsize(struct nfs_server *server) { struct nfs4_session *sess; u32 server_resp_sz; @@ -878,7 +878,7 @@ static void nfs4_session_limit_rwsize(struct nfs_server= *server) /* * Limit xattr sizes using the channel attributes. */ -static void nfs4_session_limit_xasize(struct nfs_server *server) +void nfs4_session_limit_xasize(struct nfs_server *server) { #ifdef CONFIG_NFS_V4_2 struct nfs4_session *sess; diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 91bcf67bd743..655617ffca8d 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -10618,6 +10618,9 @@ static struct nfs_server *nfs4_clone_server(struct = nfs_server *source, if (IS_ERR(server)) return server; =20 + nfs4_session_limit_rwsize(server); + nfs4_session_limit_xasize(server); + error =3D nfs4_delegation_hash_alloc(server); if (error) { nfs_free_server(server); --=20 2.43.0