From nobody Sun Jun 21 14:00:43 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 048C123A561 for ; Fri, 3 Apr 2026 19:55:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775246132; cv=none; b=frSPy14oWXRd4sBYWFZxmtiFWwGGrfxbALtyd8foDo5wSEVEQn+8HpeJLeskt4+E9lHfpXC1FXGEZVEUdO03NNDYucAG5sU3xmRDDs7lacTFR5GM62iRhZ7BIH3V2sJJwbVAVon+pKMe2yE8tgSEMckfdXymaXGhIhPOw43pt/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775246132; c=relaxed/simple; bh=Jk6wuPEJo+3AYgMNEz8BZHMUktNghhbc76k4DHqVaVc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jof7Yw0CpwBn9nsIGquR6KygQuUogDMHldDP/+5Ty6MRj9vbVISz1XrEgfWmxsfXiPEx/GTayHimgVU0T36pAeGYx4DxZNxBmHHwUOE13SM7P8HxJLm9GVsjd9J2zdHQkm/6kQ6dzyRFHg8RrITscVkSLpotmSMnTQb41TaNL9I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dqL7RGbl; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dqL7RGbl" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82cd6614a90so960606b3a.3 for ; Fri, 03 Apr 2026 12:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775246130; x=1775850930; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZIJhE8/NbCHEsvI6MaIU0MyPtyYi+r06M9QiYMpbhkQ=; b=dqL7RGblUxlv6b8smyqnKJFA+2P5VZbVT2MI4/W6YysQEmgIDH9MZEs8m6ewMFq/cP PNstrPfyNg37E0XYlh3EVRosjLSjmBVbiy1lEXs+vutvxO9jMkH7vnXhZJg2UTE2HM+J a3iHomoqWqsHbxE3gZ9GGFyQ+OfdrfWHUUtYjZOaB2NyPNsTAGT2rXFx80vkUJtNTnFj 9H5eHiJI7N8xyHHMgVyX9zkWs1RQ+adOrLp2MdZd0ax5GGIZ4AYSF5qypCSeD/qPSwuZ l+nAVvdV60kZw/WWx42ebR7f6V58K45he9LdTy9L6X9GywQ6nhopnaXE3ook8h6GMUWV fVCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775246130; x=1775850930; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZIJhE8/NbCHEsvI6MaIU0MyPtyYi+r06M9QiYMpbhkQ=; b=lzw2s622BufSZ+xuVBJnP+YdnLjXbNFYQ8DtV0aUgiwGjEbOVEcTkkoiFhSAFxUrz3 5InZ6XfgecUDlAe6QKcMteRpoocfXPzxPgGt/CblaaO5waYDr7nSZgTJSoJkNhAvtwlo ucwU0R9z//8UFsTP4dzEviX/KHrwhWGxiSsEG9WKPQLGYB7fORtGEmsZ0XdJ+0plkx1W QrvhgoTsWwqfLnQNMuA9QkmT3yricKBSAr/7QlQAeky7chxP5wqRYq/4hDCsVlnST14G HCDWXeSitoNPrkdyMDXvJJ78iO4e+32i0SQhTMbWPr1EIfpo+66GMOaN+DRpUL9w19oc kSbg== X-Forwarded-Encrypted: i=1; AJvYcCUmY7cr0r9iOQhbKKDF50srmNzjgPk8acZXaa0wbNunQUf/C9IsqLf4w2kVcdeLtmzB/zqZpJHX/8pVvLw=@vger.kernel.org X-Gm-Message-State: AOJu0YzVrZbWHQ7xz7cUKTKGcHAQwTdpORmJh2zlsW6ZG+BuJPt+V9Cb 7P3mS0jNY+6OE/iErvqJv4sbs9jGsKrpDUOISebyPuOZTZvte/nIM4T/ X-Gm-Gg: AeBDiev2IBziL7S0H0zlYud3ymGCk9pVVev9/P2QhoIQ/K66d0t7BDll22ruK50Gbt/ ibnjDhk1U52wA+6MIE0RgC3Gw33iOqeHYeqWiG8+q6sEpGj5iXaLbAwnSeMzKQV1hzPitTP5jHU mpjdagjHA48KmlFTbdo0BojxNJ+HjzNrvtjYstnif3Ibe6CWqehqnLi90zIdcEMe5p5I2+/kLrz G/ThVXFOI8fQBnvl90Yw18AFiD0e4O5ZBzYN7NvDKFQlqBhHT/uIOAAv2jMf8jVWjNKEr04gqQR 8MGV9U1ieGv9Brv4idifIo4P7jQwn0B7XIZpW/JP0TvPksKYg8coSwOmtzaf8SO1OLaSgyTDkNO IA3MUkJmHB2qPad1Q7c+RWayklyJAo5KC5pbC42IP0BYgH+FESg3ohcd6lco4hv2x331Hipgrrj qtwSLdDJ2sS2UZJm1RAkr8XGGDJ1dBWvXwK28VXO4tihayk0x5FW9BXbk= X-Received: by 2002:a05:6a00:180e:b0:824:a706:bd75 with SMTP id d2e1a72fcca58-82d0d7533dfmr4063725b3a.0.1775246130227; Fri, 03 Apr 2026 12:55:30 -0700 (PDT) Received: from debian.killsync.com ([45.116.230.137]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b272bdsm6901008b3a.12.2026.04.03.12.55.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 12:55:29 -0700 (PDT) From: aravindanilraj0702@gmail.com To: linux-sound@vger.kernel.org Cc: cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, linux-kernel@vger.kernel.org, Aravind Anilraj Subject: [PATCH] ASoC: Intel: sst: Fix firmware resource leak in sst_request_fw() Date: Fri, 3 Apr 2026 15:55:15 -0400 Message-ID: <20260403195516.15049-1-aravindanilraj0702@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Aravind Anilraj The sst_request_fw() function calls request_firmware() but does not release the firmware on any return path, resulting in a resource leak. Ensure release_firmware() is called after the firmware has been processed to properly free the allocated resources. This issue was identified by smatch. Signed-off-by: Aravind Anilraj --- sound/soc/intel/atom/sst/sst_loader.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst_loader.c b/sound/soc/intel/atom/s= st/sst_loader.c index a043443d2887..cba7f26cb0fd 100644 --- a/sound/soc/intel/atom/sst/sst_loader.c +++ b/sound/soc/intel/atom/sst/sst_loader.c @@ -350,12 +350,14 @@ static int sst_request_fw(struct intel_sst_drv *sst) } if (fw =3D=3D NULL) { dev_err(sst->dev, "fw is returning as null\n"); - return -EINVAL; + retval =3D -EINVAL; + goto out; } mutex_lock(&sst->sst_lock); retval =3D sst_cache_and_parse_fw(sst, fw); mutex_unlock(&sst->sst_lock); - +out: + release_firmware(fw); return retval; } =20 --=20 2.47.3