From nobody Sun Jun 21 14:00:37 2026 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C6E62E54A3 for ; Fri, 3 Apr 2026 19:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775245179; cv=none; b=qBFjAJbHqNx/OPizUmXj4R658H7GjYohGiiKbGst/DheCE+VEAISexfUot4BOAs4tc5Q6+sK0jstHVncd0DL1U+QF7NtaoJwhFitNBOCgeQn9Z8GipTKW/JHDWQ2n6orQ6uk8K2oJjfIZilwK3apZyY3Q6WvHuSYtWGK7gdrFr4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775245179; c=relaxed/simple; bh=mEnsa1m82X7Qbw/mh295eQAICuszh3WNwBTYCp116Ao=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=INwnfCC8WlYNQCJOzHltoOXSNHgVlcJWMxEJIy7bkghBamZxKeFj2h5qHXzzVnU/2cT+ppnNk97dLJMZAagDpL/O9Jq2WeCP7P2xL3PS9dubCxZKtvXtZGvE3GJBodrrk2TAhwO6NrgjlH3x+EI9SIKfTbhrk4Bk6+lcCvAi+c4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pWHgNov1; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pWHgNov1" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-43ba1f3fa7eso2161090f8f.2 for ; Fri, 03 Apr 2026 12:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775245177; x=1775849977; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Y6Qc95GC1vro/oOb+qTX+I6jitOjuvKVTkSWpRWYkOI=; b=pWHgNov1gP6Kuti2jYPj1FVYjV004ovjnStARHQGNKJlGqrCCrbsii7QjizcoXWpa6 TrIsPYc2SX0Luih/Q7tQ/XtboeLwNiF5DQMM7cLbhe7aa8R7dqnEg0thKQd8zQhMXiJh Cw6WIaFT9Btulf20dRsCLZgOuz42hCAXhpIh+IGwt3/zHlfJiJQVMC18vAwUETC0OpYm 5KmhA1RxVbg5dGzv6m17wKKms85foIX7wU+qRaKqSCB/dCdFAB2Fsuh0txo/IDy0xaTF KJ/HbjUOqNM9eSkGGKr3FPyN9Zh5B9Tp+br3qY/aQx42jAQa332WTeGGVRKVEyozw2m6 kWPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775245177; x=1775849977; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y6Qc95GC1vro/oOb+qTX+I6jitOjuvKVTkSWpRWYkOI=; b=PhLum10YIrwpf3S4kAwIzGnRohW4KQnxyVME5/Rypj472YN+3NFzUOgl1hHxE+uV2q wZ/8AtR7M0UjlWG1ViIijedLNEus9AM/IbLZgG78cJ2GGdIa0nyW3R3nzlAhzeqKg6vf iHgvNbW2ORFzmmAyFJSzC8VQy65KUb8UdOmpcEMj79FQK31Z3M+/3bkbr/1uYB1a7wd7 rPDURr+GVRN9ziOOZvqMx7hgkOvzp31kG7AItmygsJpCepEBrXUWa/9xI9b9Btu53Qsa afzjWRPQXaxiOqVbFCmheMuNvtuUtj3eGxx7LYC4higsGePo6LOqOFdhgRZbu8QGfiML XS4A== X-Forwarded-Encrypted: i=1; AJvYcCXk5+NXZ8wklj9sYdoD7OM7cAByDN4UtLEK5Prb0BmT+HpgmCTtJQfA85VyUQkSXepc1ZFYHHd+02h2znc=@vger.kernel.org X-Gm-Message-State: AOJu0YwbUr1h+XH1bfNQq9hO31Fy3Ox7oidKik+bxyp91v4ho1V6eFTz K/cHcWYiYvvYZFHf0gTU9IG8UB4VdGkpCJhPPvQfICabN6z3Tthke/hX X-Gm-Gg: AeBDies1fXl+97Bz3tsLYw9UnIpx/oj+7jvwJqjDGW/tAIrvs2iWTKLSeDPs8a2+GbY z0bAJC5FS/OIV59OqG6EzmQUSZKvdsPpkTB9Ll5zT5Dh5QgWA1E5ypW0vVKxWFhIusHn/PNOnYY E5QyECDbwHpKZoT2u4za1FeJ9Giup8tuA1OiKXddQXpn8SJs0cd99p2ZyWLerrvpzMDZAvZNp2C g/eMkZbd/Y5bPtQJwBiZNJBvkpEpZxOTMdJXb2kxEdinVd9kzKcyuDo+Dg7Cq8bwW1R/fmj5enG +xJmAmVLCS5+Gwpp9sxjZBDWkmVqGiJApNRNotqzZTpLyZ3TvLAPvHbZzrW67XujmVR8wNC8WYU BXcSqZfhYVT4zKzw9NV8FjSDiNH6cv3+SetvVET1UinBjR8AvlCkKx0NGxEz0lxfO3+3sjoHZbI MsKbcJaGSVyup7+ZV+IL6nZqanfFcEm4kEoOxvUZUjeXGkOYgBPVlx7aAQp92zxsBKbvMPiitVS evey9ukCipoJSFwr9TOrCqcXcweJ17x9jJY74+ydfArDbiRVVA= X-Received: by 2002:a05:6000:40da:b0:439:be67:a038 with SMTP id ffacd0b85a97d-43d292ec691mr7007250f8f.41.1775245176453; Fri, 03 Apr 2026 12:39:36 -0700 (PDT) Received: from localhost.localdomain (cpe-188-129-81-72.dynamic.amis.hr. [188.129.81.72]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2a720dsm18429186f8f.4.2026.04.03.12.39.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Apr 2026 12:39:35 -0700 (PDT) From: Marino Dzalto To: pablo@netfilter.org, fw@strlen.de Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Marino Dzalto Subject: [PATCH] netfilter: xt_HL: add pr_fmt, default case and NULL checks Date: Fri, 3 Apr 2026 21:39:29 +0200 Message-ID: <20260403193929.89449-1-marino.dzalto@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Marino Dzalto --- net/netfilter/xt_hl.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/net/netfilter/xt_hl.c b/net/netfilter/xt_hl.c index c1a70f8f0..9434d5ca8 100644 --- a/net/netfilter/xt_hl.c +++ b/net/netfilter/xt_hl.c @@ -6,6 +6,7 @@ * Hop Limit matching module * (C) 2001-2002 Maciej Soltysiak */ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt =20 #include #include @@ -25,7 +26,12 @@ MODULE_ALIAS("ip6t_hl"); static bool ttl_mt(const struct sk_buff *skb, struct xt_action_param *par) { const struct ipt_ttl_info *info =3D par->matchinfo; - const u8 ttl =3D ip_hdr(skb)->ttl; + const u8 ttl; + + if (!skb) + return false; + + ttl =3D ip_hdr(skb)->ttl; =20 switch (info->mode) { case IPT_TTL_EQ: @@ -36,15 +42,21 @@ static bool ttl_mt(const struct sk_buff *skb, struct xt= _action_param *par) return ttl < info->ttl; case IPT_TTL_GT: return ttl > info->ttl; + default: + pr_warn("Unknown TTL match mode: %d\n", info->mode); + return false; } - - return false; } =20 static bool hl_mt6(const struct sk_buff *skb, struct xt_action_param *par) { const struct ip6t_hl_info *info =3D par->matchinfo; - const struct ipv6hdr *ip6h =3D ipv6_hdr(skb); + const struct ipv6hdr *ip6h; + + if (!skb) + return false; + + ip6h =3D ipv6_hdr(skb); =20 switch (info->mode) { case IP6T_HL_EQ: @@ -55,9 +67,10 @@ static bool hl_mt6(const struct sk_buff *skb, struct xt_= action_param *par) return ip6h->hop_limit < info->hop_limit; case IP6T_HL_GT: return ip6h->hop_limit > info->hop_limit; + default: + pr_warn("Unknown Hop Limit match mode: %d\n", info->mode); + return false; } - - return false; } =20 static struct xt_match hl_mt_reg[] __read_mostly =3D { --=20 2.50.1 (Apple Git-155)