From nobody Tue Apr 7 13:47:49 2026 Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7310F3CF046 for ; Fri, 3 Apr 2026 18:54:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.28.215.223 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775242470; cv=none; b=SK62pSHwmysbAbJjDB/9pPLH9DYHEwprewCe5bPRUv97q1JkjYh9qTJxv7C8oPHgzXkfgN3rUBaOCQsQ3Lry3i+55zVwXetsWk/NQ0NC+7OO3E3r8nljlM3viCQiHfJiQvXnjZz8w/tWjRuimKz3daifCDXlBvyZVLHDpqkgIbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775242470; c=relaxed/simple; bh=t/rQI8NUVqyFzvB5kqORoctii02555/PewQweHS52zA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i2sydi7HjmIv3EMnytr51cu6/8qZjI+1x9mAujwg5coV0NwuLKTsNSXRMuATflsml/5mhkM4d8PlMHPZsA7B+6tQd8n/ohslhJLBXFUN0i6s4jvlmyZK+FtWb4XNqhSVQeWqpjcu7fm4s8AXx1gF264YkzhjuAGQ/L7CSfRaSDw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=nkO1H0E8; arc=none smtp.client-ip=149.28.215.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="nkO1H0E8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Cc: To: From; q=dns/txt; s=fe-e1b5cab7be; t=1775242467; bh=nIExr6iDGsDdBSnhO/V+GvTLLv5LVYrkOA1x0N8PkF4=; b=nkO1H0E8/aC4O6MDeu5k5waWL1jEZoDzCChrG+5HIZu45ub07aXbLWtUyvF6nSiOgliYPzc1C J8zOZUe79V8LYC8MBy27FjlN/ysjov60R7sacJS9V4O3MIxUGalPAFe07PxXWchJtSU+2jlb46C OVGwT5+3H4H8SvhMkqPoGz212aCw7uz1/9OTCee9pLHj0JI3fhSeTsJdQQ8NAaI9idDFeUlsdEh zTYHygEEHy2ZYIhAYWFUJyzpzQcjvdQ8ieTCiK0tL2srM0jKC+XV6TVEikeOq/lq0iYNllVe1+k ppkVF34Kxh7/J3FNvk4b9m8wKmvb6PdG443ubQCzkRrA== X-Forward-Email-ID: 69d00cdbdc98192b40b89432 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.6.68 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net From: Jonas Karlman To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Christian Hewitt , Diederik de Haas , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 12/13] drm: bridge: dw_hdmi: Use dw_hdmi_connector_status_update() Date: Fri, 3 Apr 2026 18:52:58 +0000 Message-ID: <20260403185303.80748-13-jonas@kwiboo.se> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260403185303.80748-1-jonas@kwiboo.se> References: <20260403185303.80748-1-jonas@kwiboo.se> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update connector EDID and CEC phys addr from detect and force funcs to ensure that userspace always have access to latest read EDID after a sink use a HPD low voltage pulse to indicate that EDID has changed. With EDID being updated in detect and force funcs, there should no longer be a need to re-read EDID in get_modes funcs, so drop it. This change make the dw-hdmi connector work more closely like the bridge connector does with a hdmi bridge. Signed-off-by: Jonas Karlman --- v3: Reworked 'Update EDID during hotplug processing' patch --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 24 +++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/br= idge/synopsys/dw-hdmi.c index 0d42fdf9a386..5b5654ef6015 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -2474,33 +2474,36 @@ dw_hdmi_connector_status_update(struct drm_connecto= r *connector, struct dw_hdmi *hdmi =3D container_of(connector, struct dw_hdmi, connecto= r); const struct drm_edid *drm_edid; =20 + if (status =3D=3D connector_status_disconnected) { + drm_edid_connector_update(connector, NULL); + cec_notifier_phys_addr_invalidate(hdmi->cec_notifier); + return; + } + drm_edid =3D dw_hdmi_edid_read(hdmi, connector); drm_edid_connector_update(connector, drm_edid); drm_edid_free(drm_edid); =20 - cec_notifier_set_phys_addr(hdmi->cec_notifier, - connector->display_info.source_physical_address); + if (status =3D=3D connector_status_connected) + cec_notifier_set_phys_addr(hdmi->cec_notifier, + connector->display_info.source_physical_address); } =20 static enum drm_connector_status dw_hdmi_connector_detect(struct drm_connector *connector, bool force) { - struct dw_hdmi *hdmi =3D container_of(connector, struct dw_hdmi, - connector); + struct dw_hdmi *hdmi =3D container_of(connector, struct dw_hdmi, connecto= r); enum drm_connector_status status; =20 status =3D dw_hdmi_detect(hdmi); =20 - if (status =3D=3D connector_status_disconnected) - cec_notifier_phys_addr_invalidate(hdmi->cec_notifier); + dw_hdmi_connector_status_update(connector, status); =20 return status; } =20 static int dw_hdmi_connector_get_modes(struct drm_connector *connector) { - dw_hdmi_connector_status_update(connector, connector->status); - return drm_edid_connector_add_modes(connector); } =20 @@ -2530,14 +2533,15 @@ static int dw_hdmi_connector_atomic_check(struct dr= m_connector *connector, =20 static void dw_hdmi_connector_force(struct drm_connector *connector) { - struct dw_hdmi *hdmi =3D container_of(connector, struct dw_hdmi, - connector); + struct dw_hdmi *hdmi =3D container_of(connector, struct dw_hdmi, connecto= r); =20 mutex_lock(&hdmi->mutex); hdmi->force =3D connector->force; hdmi->last_connector_result =3D connector->status; dw_hdmi_update_phy_mask(hdmi); mutex_unlock(&hdmi->mutex); + + dw_hdmi_connector_status_update(connector, connector->status); } =20 static const struct drm_connector_funcs dw_hdmi_connector_funcs =3D { --=20 2.53.0