From nobody Tue Apr 7 12:20:30 2026 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE4D427A476 for ; Fri, 3 Apr 2026 18:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775239205; cv=none; b=OHe8buR3CYq6ao1Tj6+9hfhMmXouwxqEUq9nH4rUs1tY7Lqf5WSJ4w8TpBkjYuIlz/bXXQma4uMsFfijdQ/OwTZM72G/guMmpwDj2TLbO02GWOZUuH1aZ5iJIEPY5uYlheKnffbgRziJusfLBjj4GX8blDQ8M/oZUenyQjM+VU8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775239205; c=relaxed/simple; bh=2fsLGvVY0SMsUTJJT9axs6GRqBZulL3PUToPu4loSEs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BtjCmJR2UMzQmApyg7cgythGtTDcXeyughCrrnUrr9ERBmblJ8TJK+VjBF/ck3D4DB0V0HHtqieWQka8z/2LIfHgPD9jyTXUocPtH014p3pkCIIzZ2iu+KAlymIhGZoMixxydt1MOMYQQ0EGkeC1Py8ZX+1dDDWK+5nBeVbQTmQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gkJTvl9m; arc=none smtp.client-ip=209.85.221.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gkJTvl9m" Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-56cc67e01deso1919516e0c.3 for ; Fri, 03 Apr 2026 11:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775239203; x=1775844003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ijE/S0QXUtP/n/cKmQTpWwB/oVtiQCLvUkDKjZ/lj5A=; b=gkJTvl9m0FHIR7FbVv7yX9QVezT4/biaKuikfmldrp05b7OjM5913pCnvbBZzmFp5y uxZLrBmae13hWUQyRoFNom7qXsv+ukv6V4evuKJVQNBYk4KNOaKj7l0f5ldZ+f/E54aw E6t6cwfSzEfAn4Rk52w8Cvr2/A9hFdSCqm/C4PnitAK0kqXQzW+KvzJ+IBJZkxlyMQiy efJSYZl7X5EpVNPMYS64/uEQ0ZkJXgp/yQHmpqW5sy1TCPNLOYi8zs/Kf/gQKYK1Vkas M0b1kqFTOFbQ+nQ9FkPknA5dLGC7WTGeGeAt+YKKfIeUDGtWNtQnXUF792OwXXcIqbiw RVEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775239203; x=1775844003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ijE/S0QXUtP/n/cKmQTpWwB/oVtiQCLvUkDKjZ/lj5A=; b=dFfe2W5QWO8DMrA8kQykBEZghxQrNfTVmU0l6V/TihzHLF7ugCKVaxP4TqkHbmeo2g vrc3gLALIGpizLmjGi317f2PgBP4ZjFEq9+vqBPyzIKkhqTUW5BvvxK2tfHLkh5eU81P fH5/12+o0V7Fi6gcJLOqRIXuw7wvQEi+bc9lmyQSEx72bvKLiOR0NUOZNMFd4G+Xg+5E oRaUsK5Zynu87S7qdL4LEDVFSSW8Zd+pB3NwhwoIlUATZUVSmpYBmLoM2lXTDyXbwzFn q2M5IHS6kbflzpZ1rk6iAxFFynYGTTM2djkRv0oiB9f2B3stjHIks/tckem38e7+pNOD MwJQ== X-Forwarded-Encrypted: i=1; AJvYcCVBw5xWso2XRgVmtuo8nJhpLscQHReGTHbC7j+PoLNrbtnNZU/OfOXdZhG3Ti5+G+nI9dZYXYRiQZgON3U=@vger.kernel.org X-Gm-Message-State: AOJu0YxOkVf1XWckMi4bDux2kND8bHNauLr8eIrlJ4EtltmmiUIIkuNg /lsNMUverSF4NZn5HnG7a8gIe/PXP1kHaIkKrLcmqn+HfOLpUyaDYrd1CR0mRfBtujE= X-Gm-Gg: AeBDiesrwi+38H3wGVkh8yRP8sXMkIPfBnMcPixmyhAgDYPpGDTnmrNK/cdXzLGIlke pdz9dN8c4E5JKV28wMnMa1HtSLY3ZdoQnoqk/Jn1IcLaGKwpfMuORhYYENotkT92Ozdqtzx3qOc 61l8D29/u9VTHWFBNaPAOmwQgDtrFWQCDrQI1gWMv6POhh3OKIhF0KkRx3YHdeEJgcbCm5yYg9v dsQESVbNqTIE3c85Lga9i30WPwVvI6J0ixGjUKnJl+6L0bB0dt82OHNT0JP5WUKK+tDxHUG42Kf DCNpE6ZQZr7pVmv+wDoiZqsyua4a121tmZm6ibSE6AFeXPsxG40dcZRh+ZmLy5K0RZXmHudm5LK nZlPtqcqckAZjWpRHHP4lXaZwTmUMOp2jivVuQU80GdbuVijkMeYNfILn2zPys708lwqnutu+sA oJtw/3FpId7AxrnJV9NFP1pYkD X-Received: by 2002:a05:6122:3a03:b0:56b:579c:83b with SMTP id 71dfb90a1353d-56dab8130f6mr1657452e0c.2.1775239203501; Fri, 03 Apr 2026 11:00:03 -0700 (PDT) Received: from localhost.localdomain ([2a09:bac5:6d75:aa::11:1de]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56d9bd03371sm7339999e0c.16.2026.04.03.11.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 11:00:02 -0700 (PDT) From: Sebastian Alba Vives To: linux-fpga@vger.kernel.org Cc: yilun.xu@linux.intel.com, conor.dooley@microchip.com, mdf@kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, Sebastian Josue Alba Vives Subject: [PATCH v2] fpga: dfl-afu: validate DMA mapping length in afu_dma_map_region() Date: Fri, 3 Apr 2026 11:57:18 -0600 Message-ID: <20260403175719.75904-1-sebasjosue84@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260402125446.3776153-2-sebasjosue84@gmail.com> References: <20260402125446.3776153-2-sebasjosue84@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Sebastian Josue Alba Vives region->length comes from userspace via the DFL_FPGA_PORT_DMA_MAP ioctl as a __u64 value. While the function checks for page alignment and address overflow, there is no upper bound on the length value. When length >> PAGE_SHIFT exceeds INT_MAX, the downstream call to pin_user_pages_fast() (which takes int nr_pages) receives a truncated value. Add the length validation alongside the existing input checks in afu_dma_map_region(), where all userspace arguments are validated before being passed deeper into the call chain. Signed-off-by: Sebastian Alba Vives --- Changes in v2: - Move validation from afu_dma_pin_pages() to afu_dma_map_region() to validate at the ioctl entry point as suggested by Greg KH - Keep npages as int in afu_dma_pin_pages() (now always safe) drivers/fpga/dfl-afu-dma-region.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/fpga/dfl-afu-dma-region.c b/drivers/fpga/dfl-afu-dma-r= egion.c index 0d1f973..7f434a9 100644 --- a/drivers/fpga/dfl-afu-dma-region.c +++ b/drivers/fpga/dfl-afu-dma-region.c @@ -34,13 +34,10 @@ void afu_dma_region_init(struct dfl_feature_dev_data *f= data) static int afu_dma_pin_pages(struct dfl_feature_dev_data *fdata, struct dfl_afu_dma_region *region) { - unsigned long npages =3D region->length >> PAGE_SHIFT; + int npages =3D region->length >> PAGE_SHIFT; struct device *dev =3D &fdata->dev->dev; int ret, pinned; =20 - if (npages > INT_MAX) - return -EINVAL; - ret =3D account_locked_vm(current->mm, npages, true); if (ret) return ret; @@ -319,6 +316,10 @@ int afu_dma_map_region(struct dfl_feature_dev_data *fd= ata, if (user_addr + length < user_addr) return -EINVAL; =20 + /* Ensure length does not exceed what pin_user_pages_fast() can handle */ + if (length >> PAGE_SHIFT > INT_MAX) + return -EINVAL; + region =3D kzalloc(sizeof(*region), GFP_KERNEL); if (!region) return -ENOMEM; --=20 2.43.0