From nobody Sun Jun 14 12:46:37 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B63676025 for ; Fri, 3 Apr 2026 05:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775194435; cv=none; b=FP+22Wz0UDZRbo0rXNkbOlYkzQHDZ2vERkilZNS186YqZ8U2GqncP4vw/P4ZAx7D+MF/SMjn9vIDvdk93UluSsSMSxGqyjWPXjsR+MQTpx37G8N4IEHgKkwGmR0KkfPuUkLp7zPQnv8Lb9WYkg+0Fk2BRaBcfEwgEou7RIp6DPs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775194435; c=relaxed/simple; bh=pQwaN71hvaMbY4i7ZYtk1STLT2mUbXXte6pwSdxuY0g=; h=From:Date:Message-ID:To:Cc:Subject; b=FC6VFdrWH5FHx9sLsBzhxQfh1vvGWfTlDYXChMgsMyakDji9rzRXnl0PVcvDxixUgIGYM5lG6/qhvRTOIVTThDQPWncJghlKqsTYxt3BNbFNZWGs/N4v4Zxqt2+ueoiz488l0f/m5W0D3IWANGZok86qEvYZhXsRJk8ZApQC3Gg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from 0001-arm-devtree.resend.eml (unknown [111.196.245.197]) by APP-03 (Coremail) with SMTP id rQCowABnhdw9Uc9ph0K7DA--.11493S2; Fri, 03 Apr 2026 13:33:49 +0800 (CST) From: Pengpeng Hou Date: Fri, 3 Apr 2026 10:41:58 +0800 Message-ID: <20260403151501.1-dt-arm-devtree-resend-pengpeng@iscas.ac.cn> To: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn Subject: [PATCH] ARM: devtree: validate compatible strings before dumping them X-CM-TRANSID: rQCowABnhdw9Uc9ph0K7DA--.11493S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJr4rCFW7JrWUuFWkXr1UJrb_yoW8Ww4xpF sxCFWDtrs8u3Wrt34UZF1F9r17Kw4kArnrKFyDK3yxZF9rtFy8Xr4vka1a9wn7CrWS9w1Y gFs0vayfAw45XrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUya14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IY64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48JMxC2 0s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI 0_JrI_JrWlx4CE17CEb7AF67AKxVWUXVWUAwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE 14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAIw20EY4v20x vaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAIcVC2z280aVCY1x0267AKxVW8 JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUj6pB7UUUUU== X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" setup_machine_fdt() dumps the root compatible list on the unsupported-machine path by walking raw property bytes with strlen() and early_print("%s"). Flat DT properties are external boot input, and this path does not prove that the compatible string list is NUL-terminated within its declared bounds. Switch the local walk to fdt_stringlist_get() so malformed unterminated entries are rejected before they are used as C strings. Signed-off-by: Pengpeng Hou --- arch/arm/kernel/devtree.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c index 3b78966e750a..a9593479305e 100644 --- a/arch/arm/kernel/devtree.c +++ b/arch/arm/kernel/devtree.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include @@ -207,19 +208,16 @@ const struct machine_desc * __init setup_machine_fdt(= void *dt_virt) =20 if (!mdesc) { const char *prop; - int size; + int idx =3D 0; unsigned long dt_root; =20 early_print("\nError: unrecognized/unsupported " "device tree compatible list:\n[ "); =20 dt_root =3D of_get_flat_dt_root(); - prop =3D of_get_flat_dt_prop(dt_root, "compatible", &size); - while (size > 0) { + while ((prop =3D fdt_stringlist_get(initial_boot_params, dt_root, + "compatible", idx++, NULL))) early_print("'%s' ", prop); - size -=3D strlen(prop) + 1; - prop +=3D strlen(prop) + 1; - } early_print("]\n\n"); =20 dump_machine_table(); /* does not return */ --=20 2.50.1 (Apple Git-155)