From nobody Sun Jun 14 14:31:48 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86DB93537CE for ; Fri, 3 Apr 2026 04:07:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775189238; cv=none; b=vEQrZREVIuRRhKGxmEiBGVI970EJiirLB0Px5Lpqgn4Mp6mc3l1q1+sqNN0QfW4i8PAviTDqHEB9hfncfLKHW4fZXbzEHiPgeK60JnAreQNSRjWOeUenDq6QnQRiflkBznkP9oH6E/TwxmJ7JGOweEUPofBA/X3IL8d1XZxbaIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775189238; c=relaxed/simple; bh=++XaA8GJN1UslZUirNOgDClgKRPlWkbnvtUwZV7D3s0=; h=From:Date:Message-ID:To:Cc:Subject; b=RWXbu8tOGYNU7lUgPgcfJrn++2/A2rISKdImEQSdkJSQZDzPOiBwvAGMCCj26CMAqQj1OOVKoHdnJJkwtjz1JHrwQo3EDuFp6s3x5vMN7xguvqBQVzQU8XHAS+p3ssbDp0xonySieCdu/vDwgAOo5OTNJZVjRzIHK5rJ+iJLcyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from 0004-arm64-pi.eml (unknown [111.196.245.197]) by APP-05 (Coremail) with SMTP id zQCowAA3yQztPM9pHU1XDA--.29765S2; Fri, 03 Apr 2026 12:07:09 +0800 (CST) From: Pengpeng Hou Date: Fri, 3 Apr 2026 11:56:05 +0800 Message-ID: <20260403143004.4-arm64-pi-bootargs-pengpeng@iscas.ac.cn> To: Catalin Marinas , Will Deacon Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pengpeng@iscas.ac.cn Subject: [PATCH] arm64: pi: validate bootargs before parsing them X-CM-TRANSID: zQCowAA3yQztPM9pHU1XDA--.29765S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Kr1DZrW7tr1DuF48Kr4xCrg_yoW8JFyUpF 4UW3srtFs5uFWUAayYyrnxWw15Aan3ArZIkFykuw4Fk3ZxZry5Zrn5Kr1avr4avrW0vayj kFs09as0yFyUGrJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkq14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IY64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r126r1D MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JV WxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Gr0_Cr1lIxAI cVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUjIJmUUUUUU== X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" get_bootargs_cmdline() fetches the raw bootargs property from the FDT and immediately calls strlen() on it before later passing the same pointer into the early command-line parser. Flat DT properties are external boot input, and this path does not prove that bootargs is NUL-terminated within its declared bounds. Use fdt_stringlist_get() so malformed unterminated bootargs are rejected before the local parser treats them as C strings. Signed-off-by: Pengpeng Hou --- arch/arm64/kernel/pi/idreg-override.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/pi/idreg-override.c b/arch/arm64/kernel/pi/i= dreg-override.c index bc57b290e5e7..310ed279ef26 100644 --- a/arch/arm64/kernel/pi/idreg-override.c +++ b/arch/arm64/kernel/pi/idreg-override.c @@ -373,11 +373,11 @@ static __init const u8 *get_bootargs_cmdline(const vo= id *fdt, int node) if (node < 0) return NULL; =20 - prop =3D fdt_getprop(fdt, node, bootargs, NULL); + prop =3D fdt_stringlist_get(fdt, node, bootargs, 0, NULL); if (!prop) return NULL; =20 - return strlen(prop) ? prop : NULL; + return *prop ? prop : NULL; } =20 static __init void parse_cmdline(const void *fdt, int chosen) --=20 2.50.1 (Apple Git-155)