From nobody Sun Jun 21 13:58:25 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43223B777C for ; Fri, 3 Apr 2026 11:27:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775215656; cv=none; b=iMk6nWGYRFO/yfvsCQo1eMWA+ByCM9I77/b7Fo0tRFjmGctYCoVIXelsUagkgogE8W6pVSS8n5PrSvvMvgCYIOo2M0Idm60EArETpbxQor6BkM0M9YxmRLUXHcGttxLnxlMMqmnJmEFji50c5yHwI/woCvibzTMpmFYlC4SE77U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775215656; c=relaxed/simple; bh=8kcJtqi0VHJvhXuEuRP4SR2nVD2GvzsAbGsi4Dox6/w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YXqEuBFw6Nd5Q4KpMv703e0+8b96S9BLpxMVrWlDu5l8g5B7KhGzMpkX9KIIHDgy9Kakr5GRph5C1EwGjg8BcjwVnvGpak2mrAzQd5rOJ5fm0HsP+7NlmE0sPGEMuNwDAV/fNh3M9sWPBwqnsYHaR+aYtgt1BYAG+z579+SuVL0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c3RjsWIJ; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c3RjsWIJ" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-82d03827316so537300b3a.0 for ; Fri, 03 Apr 2026 04:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775215649; x=1775820449; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cOr8dkqvyqFf6OUz7iSfGmZZS207nEioRgpDY/txeeg=; b=c3RjsWIJjIKLlkkMQDp+b/VbjgKVNxeaM/uUYoeFVL+auTorzu+sD2RjOPJjuLTuW/ kSneu1kWshF6tMve4iGVeT5dUNovxowb5H7zQkbktz9fDfMgXQd46Iv8awVz87rQxIeA RtZpqb+yoEURwmTJgWm1Rdc0n8Fmd9ihvsGGoabcK/grQPW6fwzNcCJhnWrfUlPkTvKc HKoKUoUKbpvCoBwEGLv4ZodFAbfpuBfMv20JQZzn2f2tg196cEIP4o+OI5YYRijaRaaw xLvTS+JrLC+ie+cYbTK5eNS/Nouw5fVo7rEuQOJo+fbEfz77pkEh7SgDCJnLuOkBdRjQ wkrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775215649; x=1775820449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cOr8dkqvyqFf6OUz7iSfGmZZS207nEioRgpDY/txeeg=; b=WxMf8NuWq2oMlpcK/90LOZblQ9+9BLufnUQT7srnyIM/2P+jqwQQmmPIcoo1inOk9u lDl8hqPVMZRAG3d21iDoag2vhrN1qvIYcv+gJZxb11NocYm1S9Yk8EwkU8vU0NjkS4hG CHeHj370HBkAK8UQjcrgpjn8V/nhOE/7wrslCOLq9yQbSbIuWC7sde+CHjK/xMCBWNam 7RGSncPJfTAasZ9QOSC5wMpqNsvR5mNaRNfWfGr5tMn3SdBPR7G8l59DOviKkSOEp3lH nLJG4wODpTGW3hIQgpoDzqT2MrFrVTRwBqgcpHt6b/jq5ZSEFodHhpm2qfCJiE188wcz iogA== X-Forwarded-Encrypted: i=1; AJvYcCVj3eb6RjrHGHfRM0ld/k30g82t9+Q8mnlD0jWzwStr2AmdvFLyGVsw1mXZMMYLPCTwbGlRAW/4fc6ljr4=@vger.kernel.org X-Gm-Message-State: AOJu0YyicE6AmZnUgUIs+shR0cZXHpE2DJYNUFf00vE4/i4VktDgQTUz 8A7nTIqvUObUrVJwF2TiTXtRVMpuHSk/VJ5+S9diKHr6uhrGDM0d+NiH X-Gm-Gg: AeBDievGfug4WFriRx+yEbdVFp6+xcudqXRdEGd321pUQMLOTaoe13hb5CLVov3BV5e xqvp/1MaCe+udZMY5PbRYvlIwtARQ+vedi7cq2AJqnmZqs/t/W47lM+du2RTHE9bN7b/XjbvyTg PlFROaOZ9Z1r+KisqsnlNI6oOXPEdJC2pmRU3gIXGbNeVtQKYC52c7ZYPpXk2RCVSDdZNFU2TuC smSARbdyoe59PkfEL41DgMubbvAUDz2YxCqYfpF8BefUaF/pf3ygMXVv4RS0RXtlMvPIbk537Jr 5HbI6TjFrl1vMRi9BsDg2VFQoC0VUmXAItOboRiwB9aEBjMSyz8AMPv+DrtP5hGHVS0P3I5E3KU 0kT1MqCgHM7fZWUBv4Mczm1cqJRcj4lZPDYm8Nnrvr1p0MduTi9TQ5zxWh1rwnzAXvSq51Zfc4f 2XNIT0yUnKaoxgK+BC2j8ZGLriH7Zrl9ZvAfFHeLQJfW2x2n825k9NOGT6oDAYg9M9QlLC X-Received: by 2002:a05:6a00:189e:b0:82a:76ab:3279 with SMTP id d2e1a72fcca58-82d001e92e3mr5481537b3a.4.1775215649367; Fri, 03 Apr 2026 04:27:29 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b6113dsm5202251b3a.23.2026.04.03.04.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 04:27:28 -0700 (PDT) From: phucduc.bui@gmail.com To: kuninori.morimoto.gx@renesas.com, broonie@kernel.org Cc: lgirdwood@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 1/3] dt-bindings: sound: renesas,fsi: Add support for multiple clocks Date: Fri, 3 Apr 2026 18:26:53 +0700 Message-ID: <20260403112655.167593-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260403112655.167593-1-phucduc.bui@gmail.com> References: <20260403112655.167593-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The FSI on r8a7740 requires the SPU clock to be enabled before accessing its registers. Without this clock, register access may lead to a system hang. Add support for the "spu" clock so it can be managed by the driver. The binding is also extended to allow additional clocks, as FSIB may require more clock inputs, while FSIA typically uses fewer. Signed-off-by: bui duc phuc --- .../devicetree/bindings/sound/renesas,fsi.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/renesas,fsi.yaml b/Doc= umentation/devicetree/bindings/sound/renesas,fsi.yaml index df91991699a7..225cd8d369bb 100644 --- a/Documentation/devicetree/bindings/sound/renesas,fsi.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,fsi.yaml @@ -38,7 +38,11 @@ properties: maxItems: 1 =20 clocks: - maxItems: 1 + minItems: 1 + maxItems: 8 + + clock-names: + description: List of necessary clock names. =20 power-domains: maxItems: 1 @@ -77,7 +81,11 @@ examples: compatible =3D "renesas,fsi2-r8a7740", "renesas,sh_fsi2"; reg =3D <0xfe1f0000 0x400>; interrupts =3D ; - clocks =3D <&mstp3_clks R8A7740_CLK_FSI>; + clocks =3D <&mstp3_clks R8A7740_CLK_FSI>, <&spu_clk>, + <&fsia_clk>, <&fsib_clk>, <&fsidiva_clk>, + <&fsidivb_clk>,<&fsiack_clk>,<&fsibck_clk>; + clock-names =3D "fsi", "spu", "icka", "ickb", + "diva", "divb", "xcka", "xckb"; power-domains =3D <&pd_a4mp>; =20 #sound-dai-cells =3D <1>; --=20 2.43.0 From nobody Sun Jun 21 13:58:25 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0EEE3B47E4 for ; Fri, 3 Apr 2026 11:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775215664; cv=none; b=vBh12yTBXyL5+t3YnZEnILN0UzkafAG1Ka7jcQpQRH/BXD6TlsURz1UOQyqUCcsO5FLVsMDZSJBUE46UVPSazTRa5p3tYcrHKhP2sDpFpd3PJx4LBFcf9+UVR+IZsx5z7Fk46eOUWTcAmac7yAXOMUS3olflFGarxgkmcKuiUt4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775215664; c=relaxed/simple; bh=5ZKt2RSjapJGUOO3d4vZSG9DTmpONEpsSL+hn9zyaLU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gRWpohZSihy+nj4+Szj1QX7bdXASOrX05+piyWkTKM3L5Haze+V0TrYNMhtFXtPkfXb5IKqb9/FmBxHkrhXnf7FnNix6AWnBgN6VLygIaPR6/WCP/4jyneeZF2nPxPVsZgW0y2MuRi/6Cemiea8uM9xByV8eO1V+voj/APCQY3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eXkTBHXL; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eXkTBHXL" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-82a7ebc729dso771280b3a.3 for ; Fri, 03 Apr 2026 04:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775215655; x=1775820455; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EFdHi2+kpz8pfg7CkbtM24aApOcYkAvDhf1e0BZOdSc=; b=eXkTBHXLLc8zTNNMGLFaQRgGYVlYn1G4L3RrDlMLEyhD8eVHUYAPVTTkdUf2x+jQnA oZXBR1Y2RHcDqMm9trK+RlV3dijPUH1wlbS0EfGDTpMLtP2pz3Dx2feZjIHN9YktPvBR fXW9NgHtavrE8+06skcyKDCHzXrW5s0EI8AZlTs52EgfpuoJAzETkSB3YzP9l7pvWSwS 2IhUkfQg2L+XUxinEScR+VHgG0j3CSTAWBKUYRbrfv9vT8cvYJia029jsLs98AAVIlJh zkoklv0vo43D11UQENsRL2L/fia7SA0YdBD1uRu897TzvivhHKnELLDzcYSbQY8nsMp3 S6vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775215655; x=1775820455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EFdHi2+kpz8pfg7CkbtM24aApOcYkAvDhf1e0BZOdSc=; b=gst2jQqN1WbQmiMVWeCoxmC6GJTqklSeheYpZZo0k6RgV/DQkBJin1PGR09Zl+a/AW +gYZmgW09+PKL0QhBhZkpYLz596vYI2KHjZASD++RBCT/oKL8YeH1LVHO8lbWvPj4j/n kMCzpDTvzn/ZMkbRC8RKdVt/eUzu1QwFQVwuLRzZFd+vfv2iTvdFOKWBFaRwt2mOdzqP XQs+DWMEjal2eHAa2Sh5h9a5CR4lXoVEYvBi3vdasKcYI8PiROsswUqxB7LpyuofhbCX xPiV0CI1YyfkAvLhfRh2xCQzngqyfUDusdxnAJN4JwwNlfVMfPQmA1YS8mjtjAyM62lr V6aA== X-Forwarded-Encrypted: i=1; AJvYcCW8sp6wp2pe8j9IHg8jW/tXSe5u3j6gGrhrRjfxklm3LLMO5D38iWATfFf5eQwXmS8Cr9O1f5IBVSrGx/k=@vger.kernel.org X-Gm-Message-State: AOJu0YwKSC2w1ZO19D5ulsujOT/wChPcICT1+Qban8ddUZTY4KBYMDmK uYxtyzGf/M8bUGu78lOK1LDkhKlEU/pVhkK3/7iaijswdktrC9Nzki/u X-Gm-Gg: AeBDiev5kX1GKviZNeuBkkMldUZ8zEyKvsSAnB/n0wLSPTw2j5qQ/g6jZFuZKCQvy2B YqHiARHqQSIr7vRJkwA96ijmafvUnxHVKGtO7tdNIl7/74NKBdVdfFPcK9mqqTyBN069mCKVwzj IKvxPn02AKR8A/+AmTdCeQjD3Z4mZi5yjQYJmP1Mo9Jm2nAabYlwWbAzoJaEJehGmykDNd8YMtA QndvbUptVj5gSyD6KOnCH4UOw4EZOSve/gCS2vAPgjD/PQNPmtZuXoItOJAy0iiou73NdG122KK hYAJxoYoZbTLiHVjcGOOtmuO3ojX7IME9sa5gIzs8nU7B3fGG3M70A91494l0VGyra+xjFKJrVo r88FWC9TrPTEZ4QE0EhwQsZc2T5UE3xJsRMzGfA8YCMvcyWuN0MXvRhK/NVM7vjYG7+YApJGADK o4CRJYg98emOGomDCwwWU3zuDdJlVpU2n2kpuAdHOjZ2Rx+dryCtpLkpvlNw== X-Received: by 2002:a05:6a00:2e1e:b0:82a:5ef0:20fb with SMTP id d2e1a72fcca58-82d0db53702mr2721652b3a.26.1775215655355; Fri, 03 Apr 2026 04:27:35 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b6113dsm5202251b3a.23.2026.04.03.04.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 04:27:35 -0700 (PDT) From: phucduc.bui@gmail.com To: kuninori.morimoto.gx@renesas.com, broonie@kernel.org Cc: lgirdwood@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 2/3] arm: dts: renesas: r8a7740-armadillo800eva: Add spu clock to FSI Date: Fri, 3 Apr 2026 18:26:54 +0700 Message-ID: <20260403112655.167593-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260403112655.167593-1-phucduc.bui@gmail.com> References: <20260403112655.167593-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The FSI on r8a7740 requires the SPU clock to be enabled before accessing its registers. Without this clock, register access may lead to a system hang. Describe the "spu" clock in the FSI node. Signed-off-by: bui duc phuc --- arch/arm/boot/dts/renesas/r8a7740.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/renesas/r8a7740.dtsi b/arch/arm/boot/dts/ren= esas/r8a7740.dtsi index d13ab86c3ab4..9cae87a1979c 100644 --- a/arch/arm/boot/dts/renesas/r8a7740.dtsi +++ b/arch/arm/boot/dts/renesas/r8a7740.dtsi @@ -393,7 +393,8 @@ sh_fsi2: sound@fe1f0000 { compatible =3D "renesas,fsi2-r8a7740", "renesas,sh_fsi2"; reg =3D <0xfe1f0000 0x400>; interrupts =3D ; - clocks =3D <&mstp3_clks R8A7740_CLK_FSI>; + clocks =3D <&mstp3_clks R8A7740_CLK_FSI>, <&spu_clk>; + clock-names =3D "fsi", "spu"; power-domains =3D <&pd_a4mp>; status =3D "disabled"; }; --=20 2.43.0 From nobody Sun Jun 21 13:58:25 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ED75EEBA for ; Fri, 3 Apr 2026 11:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775215673; cv=none; b=RbhMiRRiQPPqJUING8tJWM8IHEwQ1HkDpluen44sMnX5TTsdVclHeAXWUzi7IGW6QMNXknUZ7unIBscEpdM+1iukrGyruRro+BWZGcyo0wCppPVdzLELVDJERw0K4lQFoa7zqtgHAvzT4dG1HV3oue+I01Po4JwYURgb+3Txg88= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775215673; c=relaxed/simple; bh=BVteWb/phfOhOywch6JtszRF/l+CN+UQyrXxfcmY7BE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TPEfNPZ4h0T+7BBa92ZgR3dK48P1IndzU1m7V4kJjFBLyUJOsXsrfXam5nhtvEtYLePI22jZS7MVSCv6NEIl8UV1wfLNKSDUqoit4b0VZGcW9nbpAcxWGj7fYsJQ4Adimjd1EQv2kRqBZm8FEHjYAbGDZ/sAmU9o19ncTMIw7DA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O9pCyO1P; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O9pCyO1P" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-82cef263bedso882974b3a.0 for ; Fri, 03 Apr 2026 04:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775215662; x=1775820462; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z7WBGw3HYIKasCGZa6UoZqUVbnabzZNeOPFe5FYqFjk=; b=O9pCyO1PADi8rd6HfOFS5Zrua0Y6TPixSAZao6hbAqIlyfstz8FEWNURkxyOVQ8XOl oI5KowzbD9ncDz7PlYdz3II0LFIAP/+iAhcQZw6gAwU3wKWmhbkcAabwVzpayVNWOqB0 rNGFd/GPA/dZqTMO9GqewuNEBknrawo4S2evKLd6uxhJ0VffPt5pAQ6CJF9zqCMVETAo 6lxT6t4EmBeGe8u/GcF7F4n1O23oAk74uwj7dffBNlPhy0gP+jJi7mgFacRRiB8cF3RH kovG/EtPlEHsmlgvULN/Qe46NtGQd8pa8UYLFmMTFFxVFwSmwY7TNQ04IjC936prDq0r ZHUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775215662; x=1775820462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z7WBGw3HYIKasCGZa6UoZqUVbnabzZNeOPFe5FYqFjk=; b=oR+jrgjmtW4ztcoh8PV9qE8GC+rf0LCyoZb48cwndoMxZr1porHxd5xJlavhqmPf2L lbeV+LXxT5de+iQtQ5pxcihsH58RtKq5xObjxcWNSraScDp3ukCi/DtLT0VebQMLrqxB BEkvYiu0F4uBIkosOHi3KGPIciFK6iCg1Pifd4w/sb9lo5LV5gkCz1Q1iG59dyGJHYGY +ASkEVtGbpH7P19WDCkSk6QuHHPmUr2fdQKNfF/6oYiVkc31P7H+W3IrWiWDQJW/V+J0 JPaYEOYw1dBXJN1kMcGDkMPxfPB3CChtz9DnssBjELwUbIvouq6d4ndhp8R2T9q7a8BF loHQ== X-Forwarded-Encrypted: i=1; AJvYcCUrC6OoxaFR0p6y17fAA27Zv+mgsFDp8LSz7Q3nh4kqYUq/rwchnZxljgD7VX28OdAT6h1oL8Y/3kWLREg=@vger.kernel.org X-Gm-Message-State: AOJu0YxEp7e9i7L+awTnQzW5xX2gJ8NyrqbbefA7hw9NpEFXE7t3Bs/X eyp5x0xNsva2TYwCpinjHVJlJ8EsUYbpcSfYfp5GEJUbVjzElqvXkmyu X-Gm-Gg: AeBDietbDenxGDtJBclCCDa3DABq+urSZM4t03uy4oJHnTQKfcZZXcRoJi5pPqqPPsw lYgsiz9s+Xktfv+6FMGE9S8FzojswT86hnMBtR7M/XLPxZ0lTjQLHfNElGUqU3EgvTB4JVcwDRX hNcWxBbHeGX29YIc/fWHNmVcqj4pEFyrdiYj5KUytBO9qk35hOtk3FD/+erzkECHQVr57wvWRQj lNOnepa96VuDOSDcf3IskQP/mmtc3fHgqL8f0rKUbhlgNF73JWliuH0Y42sBUJOv1ihM255uU6b yLOBcOkScWdtb7sznfAk3eNRh2HnOcMD6sxnQI+IxGvMTofTYHpJdGkBmP5EIpNX4qdLhKGPCea PyHYHQI4M7ZAmdR8UQcryfdyjJg0c9ZCYwCiPajtp6tk/U1mavJ4dw9YBJNMyzCZ15gnMXBxpMZ JLzytv511RqyQuqLYAbISNjqkmwt8jBcMKbZS/vZUnSKO1IO2+XbnNTUAB0A== X-Received: by 2002:a05:6a00:3d56:b0:82c:d7c4:4c6b with SMTP id d2e1a72fcca58-82d0da2e1ffmr2446985b3a.11.1775215661982; Fri, 03 Apr 2026 04:27:41 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b6113dsm5202251b3a.23.2026.04.03.04.27.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 04:27:41 -0700 (PDT) From: phucduc.bui@gmail.com To: kuninori.morimoto.gx@renesas.com, broonie@kernel.org Cc: lgirdwood@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 3/3] ASoC: renesas: fsi: Fix hang by enabling SPU clock Date: Fri, 3 Apr 2026 18:26:55 +0700 Message-ID: <20260403112655.167593-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260403112655.167593-1-phucduc.bui@gmail.com> References: <20260403112655.167593-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The FSI on r8a7740 requires the SPU clock to be enabled before accessing its registers. Without this clock, register access may lead to a system hang. Retrieve the "spu" clock in probe and enable it during DAI startup. Disable the clock on shutdown to match the audio stream lifecycle. This ensures safe register access and prevents system hangs during audio playback. This is required even if the FSI functional clock is enabled, as internal units depend on the SPU clock. Signed-off-by: bui duc phuc --- sound/soc/renesas/fsi.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c index 1491c2f2cc96..44bd1c1e6294 100644 --- a/sound/soc/renesas/fsi.c +++ b/sound/soc/renesas/fsi.c @@ -292,6 +292,7 @@ struct fsi_master { void __iomem *base; struct fsi_priv fsia; struct fsi_priv fsib; + struct clk *clk_spu; const struct fsi_core *core; spinlock_t lock; }; @@ -1554,6 +1555,11 @@ static int fsi_dai_startup(struct snd_pcm_substream = *substream, struct snd_soc_dai *dai) { struct fsi_priv *fsi =3D fsi_get_priv(substream); + int ret; + + ret =3D clk_prepare_enable(fsi->master->clk_spu); + if (ret) + return ret; =20 fsi_clk_invalid(fsi); =20 @@ -1566,6 +1572,7 @@ static void fsi_dai_shutdown(struct snd_pcm_substream= *substream, struct fsi_priv *fsi =3D fsi_get_priv(substream); =20 fsi_clk_invalid(fsi); + clk_disable_unprepare(fsi->master->clk_spu); } =20 static int fsi_dai_trigger(struct snd_pcm_substream *substream, int cmd, @@ -1963,6 +1970,13 @@ static int fsi_probe(struct platform_device *pdev) master->core =3D core; spin_lock_init(&master->lock); =20 + /* SPU clock is required for FSI register access */ + master->clk_spu =3D devm_clk_get(&pdev->dev, "spu"); + if (IS_ERR(master->clk_spu)) { + dev_err(&pdev->dev, "Failed to get spu clock\n"); + return PTR_ERR(master->clk_spu); + } + /* FSI A setting */ fsi =3D &master->fsia; fsi->base =3D master->base; --=20 2.43.0