From nobody Sun Apr 5 20:04:54 2026 Received: from mail-qk1-f228.google.com (mail-qk1-f228.google.com [209.85.222.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 227CB37C90D for ; Fri, 3 Apr 2026 07:38:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775201925; cv=none; b=J6fL5giZJR7XuS02LMZMDgKH8dCZkxVtjrxLmtY98ujJZT+k8kS6oe93uxjb8MoBaLHNF5qgACZMAPUC39ibzbyC9Ah9BNwdcbW1eRNyva+pcHkEspKvgjbnkV6JJvfyBYFAUpGX6wN5VwagR6tTYyq20O12eOallj+53FEz7Tg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775201925; c=relaxed/simple; bh=xN6tiyKspxsgVMlC8vJzNsPDISw/N/AbJdMOGbgS6f0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vDLQLCKJeczkwIzTU4QfJUpUlxZXKalqIJu25UrQhYvTYjKK7UW7Z0k+pu2Emqht+KGTTnwRpxw9gd0KPqDWoOMUViCef9Fi9z/FitTLpF/Q4ZYQYXrim8IDX4zCJeN1eIdNinOtqtMQfMX60iJ1LneqPsIxkVE3xDkGqJv0aYE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=bMhKxiKY; arc=none smtp.client-ip=209.85.222.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="bMhKxiKY" Received: by mail-qk1-f228.google.com with SMTP id af79cd13be357-8cd78a4ce8dso220650985a.3 for ; Fri, 03 Apr 2026 00:38:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775201923; x=1775806723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1HFToVJAFcLFa0HENZoEwa3N44/rquYMYOZOURTmueM=; b=dHWqlY71/ommhZpcWLln8ksgWa9bpegHP0IScz3708m0zYGM6wKWy5I2BCySJqdPSp FBP0S6Xw0PuRemTuXMRX1bDl6jcXdvBy6x4iIIWJ68ocpjakRDtLWK9Um9gLeuyrXmhH IvjbmiAZL/+/QvWQLNkYC+ADgFIAmqHpSMVNLad1Lrh/zl4xoaEYKil1ypigeVLQpFZb kEzW4UVi37ow6kmn9k2x+ZdEZx+9qNPLzkTZzj6/RX1gITObhkyrkL+p5Q2LNG2ZCRnv JSAmTWrvNLd69oDCZgZ7DbR3yuAzW6eThy9UbFJh3A7nqfYg5dZh0dq1vBD3NhfpZznl 4cNQ== X-Forwarded-Encrypted: i=1; AJvYcCUAXhcIYno/U1M7rDhEn7Yx1eHs0r7GLpGyg4kL4ZHKmDVIyiWss3A0oWVWty7KdvHprJFjEwntZgZhReU=@vger.kernel.org X-Gm-Message-State: AOJu0YwKivtCzOqwAUSG3AV7tNFd+rprQAcqi4YAS4m5t7OjCOTcvMVF qzxfXjh/S77DQMTSGOQk3GNQ+srhiy7+px6/AvKEjkPBHKXzZlCK/nV8+TruxY1v8qE5O5gHFOQ 8jmiwy9gRzYWm7lquN/b/dZLCdw9R7/fSCoihTATIZLRQ0+kNm3kPy/sd6FgnSF6cEZVRfPFbLV l73k8TbpkkmO6Lx0PHxCAeo6/2+UQYGNJL1KzAO/tUahzeX+h4oWsogyVZYEynaP9P7A56Fg+7w QgmT1uZkjn03r4VFF3+396b7w== X-Gm-Gg: ATEYQzy4e3l3fGlI5hLWMzNU7dPOakSq6Orzv4VLX3RvG6PLPNxsbCbXxfA2XtebhvM l4v9EzKjWi2FqJJqcFaSnokT29fA+NjXiSu5CfKzTr9nnFgTQWjFRf0UHK2sk/nbO8X4EjzyBKB 8VlDeOOV1RmoDeMFft+eJy/8RbwyVqaBq16dW3QJL9Et0O07+/H0uK1PRfwd+X7ejX6pm9Qc4dm xZ4onjr6+wbxrTM8lwbOANiSScVEnZlucvTwpyjeU3TFXtIGXU1dZ8QhjCMy93OWpu0PQyOy6ou nW+GML6d5nRVL2rwuFl0Df4xVAHmkcZTYsOIg2py85Jsmeynz0S8/2Ifch96P6O3N9vWguJRb4g uDFJfg7NAoOTbDDHZbYbQqwQLg+bvlvkIMQxRO7VHRBa7Ycuoq5LN6uEvRej4ABOiJupMTQQFfV OaEXaawsO/sHAW/IxJxZ8KoegxYudXH3DdT4ukHGh4aHb3/eyljJECmp6QI94gsrQ= X-Received: by 2002:a05:620a:7113:b0:8cf:c08e:5f64 with SMTP id af79cd13be357-8d41adfbf80mr300904785a.40.1775201923041; Fri, 03 Apr 2026 00:38:43 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24]) by smtp-relay.gmail.com with ESMTPS id af79cd13be357-8d4bde1974bsm1975485a.7.2026.04.03.00.38.42 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Apr 2026 00:38:43 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-354c0234c1fso1870344a91.2 for ; Fri, 03 Apr 2026 00:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1775201922; x=1775806722; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1HFToVJAFcLFa0HENZoEwa3N44/rquYMYOZOURTmueM=; b=bMhKxiKYFMZCFi6py+WtSpyXiDJkA+1ioBJk6np4v53nSpHjeB/SH2ebHblzzvX2wq sNMd8fBIRSkpar3ukEPe7fYeXA4kmj3urSL3upCsJzXt96Qd1aFmFNrguobCGuGDlMYA 76JyRocuMKtplGxwSiCgfyaCgoKUl8h1RSIhI= X-Forwarded-Encrypted: i=1; AJvYcCU9CCcz9/yKNewkwOrzwLNZ8yrMUxwDC3kJSDeUDDkM5VKZraYbOGSWb9xzbaKPWgFKEozGmZFEl912tug=@vger.kernel.org X-Received: by 2002:a17:90b:3c4a:b0:35d:a412:3c79 with SMTP id 98e67ed59e1d1-35de69774ccmr1985050a91.30.1775201921840; Fri, 03 Apr 2026 00:38:41 -0700 (PDT) X-Received: by 2002:a17:90b:3c4a:b0:35d:a412:3c79 with SMTP id 98e67ed59e1d1-35de69774ccmr1985033a91.30.1775201921410; Fri, 03 Apr 2026 00:38:41 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe9377b7sm13124901a91.10.2026.04.03.00.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 00:38:40 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy , Rahul Gupta , Ajit Kumar Khaparde Subject: [PATCH net-next v11 07/10] bng_en: periodically fetch and accumulate hardware statistics Date: Fri, 3 Apr 2026 13:07:21 +0530 Message-ID: <20260403073724.194360-8-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260403073724.194360-1-bhargava.marreddy@broadcom.com> References: <20260403073724.194360-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Use the timer to schedule periodic stats collection via the workqueue when the link is up. Fetch fresh counters from hardware via DMA and accumulate them into 64-bit software shadows, handling wrap-around for counters narrower than 64 bits. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rahul Gupta Reviewed-by: Ajit Kumar Khaparde --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 97 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + 2 files changed, 98 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 290bf1cd96c9..61bac71c7f74 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -69,6 +69,9 @@ static int bnge_alloc_stats_mem(struct bnge_net *bn, if (!stats->hw_masks) goto stats_mem_err; } + + u64_stats_init(&stats->syncp); + return 0; =20 stats_mem_err: @@ -294,9 +297,97 @@ static void bnge_timer(struct timer_list *t) } } =20 + if (BNGE_LINK_IS_UP(bd) && bn->stats_coal_ticks) + bnge_queue_sp_work(bn, BNGE_PERIODIC_STATS_SP_EVENT); + mod_timer(&bn->timer, jiffies + bn->current_interval); } =20 +static void bnge_add_one_ctr(u64 hw, u64 *sw, u64 mask) +{ + u64 sw_tmp, sw_val; + + hw &=3D mask; + sw_val =3D READ_ONCE(*sw); + sw_tmp =3D (sw_val & ~mask) | hw; + if (hw < (sw_val & mask)) + sw_tmp +=3D mask + 1; + WRITE_ONCE(*sw, sw_tmp); +} + +static void __bnge_accumulate_stats(__le64 *hw_stats, u64 *sw_stats, u64 *= masks, + int count, struct u64_stats_sync *syncp) +{ + int i; + + u64_stats_update_begin(syncp); + for (i =3D 0; i < count; i++) { + u64 hw =3D le64_to_cpu(READ_ONCE(hw_stats[i])); + + if (masks[i] =3D=3D -1ULL) + WRITE_ONCE(sw_stats[i], hw); + else + bnge_add_one_ctr(hw, &sw_stats[i], masks[i]); + } + u64_stats_update_end(syncp); +} + +static void bnge_accumulate_stats(struct bnge_stats_mem *stats) +{ + if (!stats->hw_stats) + return; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + stats->hw_masks, stats->len / 8, &stats->syncp); +} + +static void bnge_accumulate_all_stats(struct bnge_dev *bd) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + struct bnge_stats_mem *ring0_stats =3D NULL; + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + struct bnge_stats_mem *stats; + + nqr =3D &bnapi->nq_ring; + stats =3D &nqr->stats; + + if (!ring0_stats) + ring0_stats =3D &bn->bnapi[0]->nq_ring.stats; + + __bnge_accumulate_stats(stats->hw_stats, stats->sw_stats, + ring0_stats->hw_masks, + ring0_stats->len / 8, &stats->syncp); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS) { + struct bnge_stats_mem *stats =3D &bn->port_stats; + __le64 *hw_stats =3D stats->hw_stats; + u64 *sw_stats =3D stats->sw_stats; + u64 *masks =3D stats->hw_masks; + u16 cnt; + + cnt =3D sizeof(struct rx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt, + &stats->syncp); + + hw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + sw_stats +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + masks +=3D BNGE_TX_PORT_STATS_BYTE_OFFSET / 8; + cnt =3D sizeof(struct tx_port_stats) / 8; + __bnge_accumulate_stats(hw_stats, sw_stats, masks, cnt, + &stats->syncp); + } + + if (bn->flags & BNGE_FLAG_PORT_STATS_EXT) { + bnge_accumulate_stats(&bn->rx_port_stats_ext); + bnge_accumulate_stats(&bn->tx_port_stats_ext); + } +} + static void bnge_sp_task(struct work_struct *work) { struct bnge_net *bn =3D container_of(work, struct bnge_net, sp_task); @@ -309,6 +400,12 @@ static void bnge_sp_task(struct work_struct *work) return; } =20 + if (test_and_clear_bit(BNGE_PERIODIC_STATS_SP_EVENT, &bn->sp_event)) { + bnge_hwrm_port_qstats(bd, 0); + bnge_hwrm_port_qstats_ext(bd, 0); + bnge_accumulate_all_stats(bd); + } + if (test_and_clear_bit(BNGE_UPDATE_PHY_SP_EVENT, &bn->sp_event)) { int rc; =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 15ededb801f6..a73f51b01bc2 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -278,6 +278,7 @@ enum bnge_sp_event { BNGE_LINK_SPEED_CHNG_SP_EVENT, BNGE_LINK_CFG_CHANGE_SP_EVENT, BNGE_UPDATE_PHY_SP_EVENT, + BNGE_PERIODIC_STATS_SP_EVENT, }; =20 struct bnge_net { --=20 2.47.3