From nobody Sun Apr 5 19:54:45 2026 Received: from mail-oa1-f100.google.com (mail-oa1-f100.google.com [209.85.160.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D73C34C134 for ; Fri, 3 Apr 2026 07:38:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.100 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775201912; cv=none; b=c849uIp5s7XPgS6+heeBiS2d+RHn4kPjT34+GYaSrcyxDpYO1KIJv+p9ql9MdXx0wXLXwwaXKUHiWqiBKJSbLbR/q/8iDBNBtGk/RoYFHKkMzxM/4Rqk066MO0ncrOzhbNJWthlV28vginjeZtISmcS0ywtQTdmk12s5V+38pRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775201912; c=relaxed/simple; bh=VrDAR49IVycPOe7piWEfXsLgfQfX9bhGR7zSuE3NSoQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hChd3M95Ss8zquMOugerU3bTL7rIK+BUK8p+qjCGz4Lddojm8w3PY+RKitngfQr4cQEbdG+UnP7eMmTUqMYK0btKkQnI5lbEhs43tgeJk3rlkPrSwKefa/HTUmDhN/mCPMHnPCPvWDzb5Z6YiwZewCGMC4zuRb6kXz0o/Ze9qPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=eZOduybr; arc=none smtp.client-ip=209.85.160.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="eZOduybr" Received: by mail-oa1-f100.google.com with SMTP id 586e51a60fabf-41708f6c3feso1112937fac.3 for ; Fri, 03 Apr 2026 00:38:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775201909; x=1775806709; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A2P7lgtvNOf8Os/zH65RPtJhaLvNMqNntscgZ8Xa5co=; b=Y/STk+Ak7Lw892Ccp7K33cn64uy20Vc7++yUS81JJiGuQZ2CrkGirbz4/TvMI58ESf xyXslIDos/wEbBiATrTWUX1DBA/QN5i0vVgyC5ka2GVP+eCTIqQ3IVx6QKh43bUoZd9F G5hQd/GMCVWJxomU78x4tdQser8sL+8IdBfae5co33iPicFi8cNEhJeYvTad9H3mSPZF U+I/A0VnlJoTx2hTv7KxrhC77yZ9aDWy3tN7bOTljKGRggPu29qXBfDmhLKTguqwOoEB Gssel8t5CfhC6gAa0WqAwoLA3Ffpj/J36yaQ31uGJKs4i+ODV6p0rNR7AXj4jzhIqrzL GmHA== X-Forwarded-Encrypted: i=1; AJvYcCUaxlb78BY+14D6i6JOyhH8aBHUWO+bbbrZPbdLUSN0mkORQoEa657s9742ReCyxQsNeSn7O+BHlrmKLSo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4fG92XKmdmluNoQQrSZN8r/LeHbBb/rls8352ESlValu6XCoX pMYtT8vJKMDFBzoSxXM6LuJzvwYwDNbZaYyfl0CPBIN2z5le1smKbqsBM5ujJUeLxpr6nPCS3/s 2+a3c2XEB5dkI/h/GOD6+fr0RoxVq4VrEit9t/4fGHMF/qLjlNcCD89XkGwvmVBb0PB2gegEwAI R2s6NIhSyO8MeuOR4C3MJaMPJIFNp+ie95LmNc7ywwF+eN/LaYjuoE3DaqRX/q4ibg3fxmDSPjp U067KhRY2xsnNPGUcPva08hYQ== X-Gm-Gg: ATEYQzzC08i2R8T53dzOgujE5JfXzQRIAQSDXFfL9x7J0hqV50vf2dkNqJ242eiiaSe eSNRdSCjLg+lGEgWzI8qiF6kMV6NEEHtLrOSun0wtWgbYiJE9Gdlo3SygxJjn1Sw53PpgdDRt0Y sRr3OqvOfbeOq6UVQJFL3fylj3MkLH0K6s0MS6ez1M5EUKs4J0ezP7b61dDZSQ+QSw9StS+L5Up wbzjD/jHcHebvBoKS0J+pmW+Al8SWiFE+uImEn5JYg/fkrP0GCsxzY6hiez7O1kWSZFL2TRO0qs 2Ce2EIS2C2SADem7yDdBG2qvsiSlCXjxI36GSErlqueKdQtdqpkZrG2tFvYyY0yvHreUdS9J7AO tYfv2QrNxxA0WHBNg8LgNm2Me2n5i57iQ6scXavqPz6sEP70KHmxDsM6WoEPUH0x5ibVth+AJTg zG16y9c/zKNWRDOCf8eF8kJBILvj6OURRCfY81K6X2PLDYIKA6kW2xVM7mEpoB0mU= X-Received: by 2002:a05:6870:b1c1:b0:3f1:6d93:4386 with SMTP id 586e51a60fabf-4230fc7bed0mr1107494fac.1.1775201909016; Fri, 03 Apr 2026 00:38:29 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-15.dlp.protect.broadcom.com. [144.49.247.15]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-4231c57141bsm70518fac.4.2026.04.03.00.38.28 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Apr 2026 00:38:29 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3595485abbbso2113160a91.2 for ; Fri, 03 Apr 2026 00:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1775201907; x=1775806707; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A2P7lgtvNOf8Os/zH65RPtJhaLvNMqNntscgZ8Xa5co=; b=eZOduybrP1jPwZPG/F6GQvFDnkGj5cRpAUvuagl24Cwm7SBPWP+DBHDpp11B5KN085 pmT6LtVt8GaAd8EDi2BBpWPwU1JQWi4+5Q3hkeacP/MqyLg/lkrHEYD7ijY8FK4bZvJb Mh7nWtmzJitrrsQlmajJ54FbUFxDXZfLau5Xw= X-Forwarded-Encrypted: i=1; AJvYcCW0qEacVUADYgt5tZkC8/H8IaYSGm4Y0J930DFtssKjQuU4BxW23GvP9RdrQlyLaqc8iidf/UeHLl4sHHA=@vger.kernel.org X-Received: by 2002:a17:90b:48c6:b0:35b:9ab6:1d4a with SMTP id 98e67ed59e1d1-35de697359emr1800814a91.18.1775201907342; Fri, 03 Apr 2026 00:38:27 -0700 (PDT) X-Received: by 2002:a17:90b:48c6:b0:35b:9ab6:1d4a with SMTP id 98e67ed59e1d1-35de697359emr1800796a91.18.1775201906882; Fri, 03 Apr 2026 00:38:26 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe9377b7sm13124901a91.10.2026.04.03.00.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 00:38:26 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy Subject: [PATCH net-next v11 04/10] bng_en: implement ethtool pauseparam operations Date: Fri, 3 Apr 2026 13:07:18 +0530 Message-ID: <20260403073724.194360-5-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260403073724.194360-1-bhargava.marreddy@broadcom.com> References: <20260403073724.194360-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement .get_pauseparam and .set_pauseparam to support flow control configuration. This allows reporting and setting of autoneg, RX pause, and TX pause states. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_ethtool.c | 63 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_link.c | 45 +++++++++---- 2 files changed, 95 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_ethtool.c b/drivers/ne= t/ethernet/broadcom/bnge/bnge_ethtool.c index 6bb74a84ea03..424bf2d6721c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_ethtool.c @@ -46,6 +46,67 @@ static void bnge_get_drvinfo(struct net_device *dev, strscpy(info->bus_info, pci_name(bd->pdev), sizeof(info->bus_info)); } =20 +static void bnge_get_pauseparam(struct net_device *dev, + struct ethtool_pauseparam *epause) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_dev *bd =3D bn->bd; + + if (bd->phy_flags & BNGE_PHY_FL_NO_PAUSE) { + epause->autoneg =3D 0; + epause->rx_pause =3D 0; + epause->tx_pause =3D 0; + return; + } + + epause->autoneg =3D !!(bn->eth_link_info.autoneg & + BNGE_AUTONEG_FLOW_CTRL); + epause->rx_pause =3D !!(bn->eth_link_info.req_flow_ctrl & + BNGE_LINK_PAUSE_RX); + epause->tx_pause =3D !!(bn->eth_link_info.req_flow_ctrl & + BNGE_LINK_PAUSE_TX); +} + +static int bnge_set_pauseparam(struct net_device *dev, + struct ethtool_pauseparam *epause) +{ + struct bnge_ethtool_link_info old_elink_info, *elink_info; + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_dev *bd =3D bn->bd; + int rc =3D 0; + + if (!BNGE_PHY_CFG_ABLE(bd) || (bd->phy_flags & BNGE_PHY_FL_NO_PAUSE)) + return -EOPNOTSUPP; + + elink_info =3D &bn->eth_link_info; + old_elink_info =3D *elink_info; + + if (epause->autoneg) { + if (!(elink_info->autoneg & BNGE_AUTONEG_SPEED)) + return -EINVAL; + + elink_info->autoneg |=3D BNGE_AUTONEG_FLOW_CTRL; + } else { + if (elink_info->autoneg & BNGE_AUTONEG_FLOW_CTRL) + elink_info->force_link_chng =3D true; + elink_info->autoneg &=3D ~BNGE_AUTONEG_FLOW_CTRL; + } + + elink_info->req_flow_ctrl =3D 0; + if (epause->rx_pause) + elink_info->req_flow_ctrl |=3D BNGE_LINK_PAUSE_RX; + if (epause->tx_pause) + elink_info->req_flow_ctrl |=3D BNGE_LINK_PAUSE_TX; + + if (netif_running(dev)) { + rc =3D bnge_hwrm_set_pause(bn); + if (rc) + *elink_info =3D old_elink_info; + } + + return rc; +} + static const struct ethtool_ops bnge_ethtool_ops =3D { .cap_link_lanes_supported =3D 1, .get_link_ksettings =3D bnge_get_link_ksettings, @@ -53,6 +114,8 @@ static const struct ethtool_ops bnge_ethtool_ops =3D { .get_drvinfo =3D bnge_get_drvinfo, .get_link =3D bnge_get_link, .nway_reset =3D bnge_nway_reset, + .get_pauseparam =3D bnge_get_pauseparam, + .set_pauseparam =3D bnge_set_pauseparam, }; =20 void bnge_set_ethtool_ops(struct net_device *dev) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_link.c b/drivers/net/e= thernet/broadcom/bnge/bnge_link.c index d8236a5daef2..7751bf07740f 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_link.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_link.c @@ -302,6 +302,8 @@ int bnge_update_phy_setting(struct bnge_net *bn) struct bnge_dev *bd =3D bn->bd; bool update_pause =3D false; bool update_link =3D false; + bool hw_pause_autoneg; + bool pause_autoneg; int rc; =20 link_info =3D &bd->link_info; @@ -313,24 +315,41 @@ int bnge_update_phy_setting(struct bnge_net *bn) return rc; } =20 - if ((elink_info->autoneg & BNGE_AUTONEG_FLOW_CTRL) && - (link_info->auto_pause_setting & BNGE_LINK_PAUSE_BOTH) !=3D - elink_info->req_flow_ctrl) + pause_autoneg =3D !!(elink_info->autoneg & BNGE_AUTONEG_FLOW_CTRL); + hw_pause_autoneg =3D !!(link_info->auto_pause_setting & + PORT_PHY_QCFG_RESP_AUTO_PAUSE_AUTONEG_PAUSE); + + /* Check if pause autonegotiation state has changed */ + if (pause_autoneg !=3D hw_pause_autoneg) { update_pause =3D true; - if (!(elink_info->autoneg & BNGE_AUTONEG_FLOW_CTRL) && - link_info->force_pause_setting !=3D elink_info->req_flow_ctrl) + } else if (pause_autoneg) { + /* If pause autoneg is enabled, check if the + * requested RX/TX bits changed + */ + if ((link_info->auto_pause_setting & BNGE_LINK_PAUSE_BOTH) !=3D + elink_info->req_flow_ctrl) + update_pause =3D true; + } else { + /* If pause autoneg is disabled, check if the + * forced RX/TX bits changed + */ + if (link_info->force_pause_setting !=3D elink_info->req_flow_ctrl) + update_pause =3D true; + } + + /* Force update if link change is requested */ + if (elink_info->force_link_chng) update_pause =3D true; + + /* Check if link speed or duplex settings have changed */ if (!(elink_info->autoneg & BNGE_AUTONEG_SPEED)) { - if (BNGE_AUTO_MODE(link_info->auto_mode)) - update_link =3D true; - if (bnge_force_speed_updated(bn)) - update_link =3D true; - if (elink_info->req_duplex !=3D link_info->duplex_setting) + if (BNGE_AUTO_MODE(link_info->auto_mode) || + bnge_force_speed_updated(bn) || + elink_info->req_duplex !=3D link_info->duplex_setting) update_link =3D true; } else { - if (link_info->auto_mode =3D=3D BNGE_LINK_AUTO_NONE) - update_link =3D true; - if (bnge_auto_speed_updated(bn)) + if (link_info->auto_mode =3D=3D BNGE_LINK_AUTO_NONE || + bnge_auto_speed_updated(bn)) update_link =3D true; } =20 --=20 2.47.3