From nobody Sun Apr 5 20:04:54 2026 Received: from mail-pg1-f228.google.com (mail-pg1-f228.google.com [209.85.215.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89CD0378D63 for ; Fri, 3 Apr 2026 07:38:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.228 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775201936; cv=none; b=uTVdBZNVKuYjOmAHkS0Jxn8q4gws0HnNzpXwd2AS9pD2GzP2KToDFLYFqFyQWHvhqrkK0H2RkmUoGybZ1ldmZ4+Q2X2ERaa/PiPyOA42U/63FsiEyF5M+jcWefjAfMUjB4g6eFH3RiNufqmwY2dOTkLerSZdArFAeF9vdX/953Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775201936; c=relaxed/simple; bh=ZZqrPTcVEVCs2us9N1me1Ia3g2J0SjMmqgrQS0luHOY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XSBoJr8K9p05vuajx+APHg2TdpV7VpAqD6Ys81gvU549exvTFIDEIdYZNW7g3fYNF8H6aheKo1upDFw+op+6P5T7wORARVYXbq4eDV+vCabdKEjXrYPtmW6+UKkFn9tJ3m9jUTbmg6dCjI0zvEFdtqT+aJYtUXBfkSLlY6KmN34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Jc98MH7y; arc=none smtp.client-ip=209.85.215.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Jc98MH7y" Received: by mail-pg1-f228.google.com with SMTP id 41be03b00d2f7-c70c112cb61so920659a12.0 for ; Fri, 03 Apr 2026 00:38:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775201933; x=1775806733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jBA5mYoFs7U2kVrS4kBVEGeuAEMM/jKmYSPSiTVI568=; b=P/X7lL90JVFb6Nda+bQR+k39Fo9HSud7tFOSbx9wbeIbJMsr5/onWKWeEoNnYOacH7 zx5j0GBNnb8lm79CBgcWw6r+i9lXEjXf4NEv2Pvf52rWwMfWhZG/LzhX+cpDWKpy5Lef nXo94dsfJwD5O1bEB8G+xJkccv9tDD1UywKqMxc1UGaOTRutdV2XHtzTrfGqvQs4vHfv DG7rnI0joM0FKtOIOgMr1RC9UERxsCrMvsQF5MbOIhkiPMqQYomgnn7VvqEBq0WoqQVx gtGiKjB8KRbAkFQ24oYksaEHjdT+JuKREGb5B846KFHR6cXVcELNSRTfTvdUI0g0ZFoA MyAw== X-Forwarded-Encrypted: i=1; AJvYcCWhe1eskqN9XdN0+6++yu2/XGXg8fVkTvbqPyT4KDZUf0lX10Mb8U+Y4PbE4Ezpz5G7sgu6VDqJslZlBbk=@vger.kernel.org X-Gm-Message-State: AOJu0YxWqGsCHO51XZLEmUMfEJ8XAmxCIAV7NaK+slYBryVbhpQ6KnjW n3EPZXt+bYSgXIGbkUIhdsMBPWnMi/uvVVy+1mEhXi0QuJODjfQdiAXkTDE4as2whbpg5KO02bL VBj7F4p2VWKbGMeDWX+bVuXvKE8y1d2vlPrIMHTJmkRrGxWMaUmHdxdIzPB0If9LLo5y5G5z13r iRYVN16VdppcAGL8YxVWyZuEOHvYx5gzYfMNrkhWZEZIpNDhvfSLnQ1NuxIiHNq6b2fM8C5mXVU fOpmMBqIydBuhPWaxdkkqSccQ== X-Gm-Gg: ATEYQzxQylBmVT58JPuGTrXU5JtFj3lZi+R+z8A4hPPWQ3fchpT3hMvOmoL2lvdCScQ QrRXgb1MVjl2R5INFmzzKogJ+4hpg2WMGscS4iQgp+6Bj4iE4x5TFEa4Fsb3dd6Vsf/HenjPAoU eocbGs0NJ6mTESlX8DCqnb6Ko5nqye5JR0PpS4N4y1FuuQvoygQI4hJrghlO3kYjsgCeWf4u9M3 Gyp3rVXKcxNOznJMUaY2S/MoFogAF8AKq6NeLAMabRFNK0qPmwM4Qh7X4IOfAX2XWEQzBPtYlyt s3T9bgGCSV/2WcEquFtBsPCQjD+APbedztTPmc32rRtjFDFF0ytkhha06Z4N5jxy+QVZapxTywE vL6yK9Ee4Y8G0iyVKFEA+UR6kGL5r6pcHA1shZWk2k62PWtS1lPhIhjrVZLMrreA58RTF7Mz8Ed CGpFBqTffjq3inYOmhAxo0wOlT8a2T4cwmilbLs+zwRp81+ndzFoBtoRJ/fDpYxP8= X-Received: by 2002:a05:6300:210f:b0:39c:126c:93b5 with SMTP id adf61e73a8af0-39f2ee49b59mr2056327637.21.1775201932874; Fri, 03 Apr 2026 00:38:52 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-25.dlp.protect.broadcom.com. [144.49.247.25]) by smtp-relay.gmail.com with ESMTPS id 41be03b00d2f7-c76c649e760sm253238a12.3.2026.04.03.00.38.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Apr 2026 00:38:52 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35c1874336aso3798248a91.3 for ; Fri, 03 Apr 2026 00:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1775201931; x=1775806731; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jBA5mYoFs7U2kVrS4kBVEGeuAEMM/jKmYSPSiTVI568=; b=Jc98MH7y5L1cGo7xYBR7wtVxUV0+SYbiNostYOApL7aGUcpi7sZLq3kxK0B29WMCml zv8JJ3VjS8vKIewHE67L/ArYPo4lGLcNrvQB2PJQyTsSZ5oXDqPeTXXtPU8E6mucSBmf i71m9zb27tMaMsSa5WsZEjXIM3MbXnx+d8PEA= X-Forwarded-Encrypted: i=1; AJvYcCV9uPl6NwHm3ZKdSWafspfrsn+TAOTdZEcbv1Uorfu+Pr5GCx3nzl8TDsIWtEO+YhLdUsjWlZF5UMVyVKA=@vger.kernel.org X-Received: by 2002:a17:90a:d005:b0:35d:9d28:e897 with SMTP id 98e67ed59e1d1-35de699f483mr1758397a91.28.1775201930961; Fri, 03 Apr 2026 00:38:50 -0700 (PDT) X-Received: by 2002:a17:90a:d005:b0:35d:9d28:e897 with SMTP id 98e67ed59e1d1-35de699f483mr1758378a91.28.1775201930506; Fri, 03 Apr 2026 00:38:50 -0700 (PDT) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe9377b7sm13124901a91.10.2026.04.03.00.38.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 00:38:50 -0700 (PDT) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, Bhargava Marreddy Subject: [PATCH net-next v11 09/10] bng_en: implement netdev_stat_ops Date: Fri, 3 Apr 2026 13:07:23 +0530 Message-ID: <20260403073724.194360-10-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260403073724.194360-1-bhargava.marreddy@broadcom.com> References: <20260403073724.194360-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement netdev_stat_ops to provide standardized per-queue statistics via the Netlink API. Below is the description of the hardware drop counters: rx-hw-drop-overruns: Packets dropped by HW due to resource limitations (e.g., no BDs available in the host ring). rx-hw-drops: Total packets dropped by HW (sum of overruns and error drops). tx-hw-drop-errors: Packets dropped by HW because they were invalid or malformed. tx-hw-drops: Total packets dropped by HW (sum of resource limitations and error drops). The implementation was verified using the ynl tool: ./tools/net/ynl/pyynl/cli.py --spec \ Documentation/netlink/specs/netdev.yaml --dump qstats-get --json \ '{"ifindex":14, "scope":"queue"}' [{'ifindex': 14, 'queue-id': 0, 'queue-type': 'rx', 'rx-bytes': 758, 'rx-hw-drop-overruns': 0, 'rx-hw-drops': 0, 'rx-packets': 11}, {'ifindex': 14, 'queue-id': 1, 'queue-type': 'rx', 'rx-bytes': 0, 'rx-hw-drop-overruns': 0, 'rx-hw-drops': 0, 'rx-packets': 0}, {'ifindex': 14, 'queue-id': 0, 'queue-type': 'tx', 'tx-bytes': 0, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 0}, {'ifindex': 14, 'queue-id': 1, 'queue-type': 'tx', 'tx-bytes': 0, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 0}, {'ifindex': 14, 'queue-id': 2, 'queue-type': 'tx', 'tx-bytes': 810, 'tx-hw-drop-errors': 0, 'tx-hw-drops': 0, 'tx-packets': 10},] Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 227 ++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_netdev.h | 7 + 2 files changed, 234 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 9a5d667defea..84090b048ba6 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2859,6 +2859,7 @@ static int bnge_open_core(struct bnge_net *bn) } =20 set_bit(BNGE_STATE_OPEN, &bd->state); + set_bit(BNGE_STATE_STATS_ENABLE, &bn->state); =20 bnge_enable_int(bn); =20 @@ -2897,6 +2898,77 @@ static int bnge_shutdown_nic(struct bnge_net *bn) return 0; } =20 +static void bnge_add_prev_ring_stats64(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct netdev_queue_stats_rx *rx_save =3D &bn->rxq_prv_stats; + struct netdev_queue_stats_tx *tx_save =3D &bn->txq_prv_stats; + struct rtnl_link_stats64 *stats64_save =3D &bn->prv_stats64; + + stats->rx_packets +=3D rx_save->packets; + stats->tx_packets +=3D tx_save->packets; + stats->rx_bytes +=3D rx_save->bytes; + stats->tx_bytes +=3D tx_save->bytes; + stats->rx_missed_errors +=3D rx_save->hw_drop_overruns; + stats->tx_dropped +=3D tx_save->hw_drop_errors; + + stats->multicast +=3D stats64_save->multicast; +} + +static void bnge_get_ring_stats64(struct bnge_dev *bd, + struct rtnl_link_stats64 *stats) +{ + struct bnge_net *bn =3D netdev_priv(bd->netdev); + int i; + + for (i =3D 0; i < bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + u64 tx_bytes, tx_packets, tx_dropped; + u64 multicast, rx_missed_errors; + struct bnge_nq_ring_info *nqr; + u64 rx_bytes, rx_packets; + unsigned int start; + u64 *sw; + + nqr =3D &bnapi->nq_ring; + sw =3D nqr->stats.sw_stats; + + do { + start =3D u64_stats_fetch_begin(&nqr->stats.syncp); + + rx_packets =3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + rx_packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + tx_packets =3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + tx_packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + rx_bytes =3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + rx_bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + tx_bytes =3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + tx_bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + multicast =3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + rx_missed_errors =3D + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + tx_dropped =3D + BNGE_GET_RING_STATS64(sw, tx_error_pkts); + } while (u64_stats_fetch_retry(&nqr->stats.syncp, start)); + + stats->rx_packets +=3D rx_packets; + stats->tx_packets +=3D tx_packets; + stats->rx_bytes +=3D rx_bytes; + stats->tx_bytes +=3D tx_bytes; + stats->multicast +=3D multicast; + stats->rx_missed_errors +=3D rx_missed_errors; + stats->tx_dropped +=3D tx_dropped; + } +} + static void bnge_get_port_stats64(struct bnge_net *bn, struct rtnl_link_stats64 *stats) { @@ -2928,6 +3000,22 @@ static void bnge_get_port_stats64(struct bnge_net *b= n, } while (u64_stats_fetch_retry(&bn->port_stats.syncp, start)); } =20 +static void bnge_fill_prev_stats64(struct bnge_net *bn, + struct rtnl_link_stats64 *stats) +{ + struct netdev_queue_stats_rx *rx_save =3D &bn->rxq_prv_stats; + struct netdev_queue_stats_tx *tx_save =3D &bn->txq_prv_stats; + struct rtnl_link_stats64 *stats64_save =3D &bn->prv_stats64; + + stats->rx_packets =3D rx_save->packets; + stats->tx_packets =3D tx_save->packets; + stats->rx_bytes =3D rx_save->bytes; + stats->tx_bytes =3D tx_save->bytes; + stats->rx_missed_errors =3D rx_save->hw_drop_overruns; + stats->tx_dropped =3D tx_save->hw_drop_errors; + stats->multicast =3D stats64_save->multicast; +} + static void bnge_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *stats) { @@ -2935,6 +3023,57 @@ static void bnge_get_stats64(struct net_device *dev, =20 if (bn->flags & BNGE_FLAG_PORT_STATS) bnge_get_port_stats64(bn, stats); + + spin_lock_bh(&bn->stats_lock); + if (!test_bit(BNGE_STATE_STATS_ENABLE, &bn->state)) { + bnge_fill_prev_stats64(bn, stats); + spin_unlock_bh(&bn->stats_lock); + return; + } + + bnge_get_ring_stats64(bn->bd, stats); + bnge_add_prev_ring_stats64(bn, stats); + spin_unlock_bh(&bn->stats_lock); +} + +static void bnge_save_ring_stats(struct bnge_net *bn) +{ + struct netdev_queue_stats_rx *rx_save =3D &bn->rxq_prv_stats; + struct netdev_queue_stats_tx *tx_save =3D &bn->txq_prv_stats; + struct rtnl_link_stats64 *stats64_save =3D &bn->prv_stats64; + int i; + + for (i =3D 0; i < bn->bd->nq_nr_rings; i++) { + struct bnge_napi *bnapi =3D bn->bnapi[i]; + struct bnge_nq_ring_info *nqr; + u64 *sw; + + nqr =3D &bnapi->nq_ring; + sw =3D nqr->stats.sw_stats; + + rx_save->packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + rx_save->packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + rx_save->packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + rx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + rx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + rx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + rx_save->hw_drop_overruns +=3D BNGE_GET_RING_STATS64(sw, rx_discard_pkts= ); + rx_save->hw_drops +=3D BNGE_GET_RING_STATS64(sw, rx_error_pkts) + + BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + + tx_save->packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + tx_save->packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + tx_save->packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + tx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + tx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + tx_save->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + tx_save->hw_drop_errors +=3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + tx_save->hw_drops +=3D BNGE_GET_RING_STATS64(sw, tx_discard_pkts) + + BNGE_GET_RING_STATS64(sw, tx_error_pkts); + + stats64_save->multicast +=3D + BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + } } =20 static void bnge_close_core(struct bnge_net *bn) @@ -2948,6 +3087,13 @@ static void bnge_close_core(struct bnge_net *bn) timer_delete_sync(&bn->timer); bnge_shutdown_nic(bn); bnge_disable_napi(bn); + + /* Save ring stats before shutdown */ + spin_lock_bh(&bn->stats_lock); + bnge_save_ring_stats(bn); + clear_bit(BNGE_STATE_STATS_ENABLE, &bn->state); + spin_unlock_bh(&bn->stats_lock); + bnge_free_all_rings_bufs(bn); bnge_free_irq(bn); bnge_del_napi(bn); @@ -2966,6 +3112,85 @@ static int bnge_close(struct net_device *dev) return 0; } =20 +static void bnge_get_queue_stats_rx(struct net_device *dev, int i, + struct netdev_queue_stats_rx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_nq_ring_info *nqr; + u64 *sw; + + if (!bn->bnapi) + return; + + nqr =3D &bn->bnapi[i]->nq_ring; + sw =3D nqr->stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, rx_bcast_bytes); + + stats->hw_drop_overruns =3D BNGE_GET_RING_STATS64(sw, rx_discard_pkts); + stats->hw_drops =3D BNGE_GET_RING_STATS64(sw, rx_error_pkts) + + stats->hw_drop_overruns; +} + +static void bnge_get_queue_stats_tx(struct net_device *dev, int i, + struct netdev_queue_stats_tx *stats) +{ + struct bnge_net *bn =3D netdev_priv(dev); + struct bnge_napi *bnapi; + u64 *sw; + + if (!bn->tx_ring) + return; + + bnapi =3D bn->tx_ring[bn->tx_ring_map[i]].bnapi; + sw =3D bnapi->nq_ring.stats.sw_stats; + + stats->packets =3D 0; + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_pkts); + stats->packets +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_pkts); + + stats->bytes =3D 0; + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_ucast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_mcast_bytes); + stats->bytes +=3D BNGE_GET_RING_STATS64(sw, tx_bcast_bytes); + + stats->hw_drop_errors =3D BNGE_GET_RING_STATS64(sw, tx_error_pkts); + stats->hw_drops =3D BNGE_GET_RING_STATS64(sw, tx_discard_pkts) + + stats->hw_drop_errors; +} + +static void bnge_get_base_stats(struct net_device *dev, + struct netdev_queue_stats_rx *rx, + struct netdev_queue_stats_tx *tx) +{ + struct bnge_net *bn =3D netdev_priv(dev); + + rx->packets =3D bn->rxq_prv_stats.packets; + rx->bytes =3D bn->rxq_prv_stats.bytes; + rx->hw_drops =3D bn->rxq_prv_stats.hw_drops; + rx->hw_drop_overruns =3D bn->rxq_prv_stats.hw_drop_overruns; + + tx->packets =3D bn->txq_prv_stats.packets; + tx->bytes =3D bn->txq_prv_stats.bytes; + tx->hw_drops =3D bn->txq_prv_stats.hw_drops; + tx->hw_drop_errors =3D bn->txq_prv_stats.hw_drop_errors; +} + +static const struct netdev_stat_ops bnge_stat_ops =3D { + .get_queue_stats_rx =3D bnge_get_queue_stats_rx, + .get_queue_stats_tx =3D bnge_get_queue_stats_tx, + .get_base_stats =3D bnge_get_base_stats, +}; + static const struct net_device_ops bnge_netdev_ops =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, @@ -3112,6 +3337,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bd->netdev =3D netdev; =20 netdev->netdev_ops =3D &bnge_netdev_ops; + netdev->stat_ops =3D &bnge_stat_ops; =20 bnge_set_ethtool_ops(netdev); =20 @@ -3211,6 +3437,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) rc =3D bnge_alloc_port_stats(bn); if (rc) goto err_free_workq; + spin_lock_init(&bn->stats_lock); =20 netdev->request_ops_lock =3D true; rc =3D register_netdev(netdev); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index a73f51b01bc2..f4636b5b0cf3 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -8,6 +8,7 @@ #include #include #include +#include #include "bnge_db.h" #include "bnge_hw_def.h" #include "bnge_link.h" @@ -264,6 +265,7 @@ struct bnge_stats_mem { =20 enum bnge_net_state { BNGE_STATE_NAPI_DISABLED, + BNGE_STATE_STATS_ENABLE, }; =20 #define BNGE_TIMER_INTERVAL HZ @@ -361,6 +363,11 @@ struct bnge_net { u16 fw_rx_stats_ext_size; u16 fw_tx_stats_ext_size; =20 + struct netdev_queue_stats_rx rxq_prv_stats; + struct netdev_queue_stats_tx txq_prv_stats; + struct rtnl_link_stats64 prv_stats64; + spinlock_t stats_lock; + u8 pri2cos_idx[8]; bool pri2cos_valid; }; --=20 2.47.3