From nobody Sun Jun 14 14:29:29 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9C6F618BBAE; Fri, 3 Apr 2026 07:10:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775200203; cv=none; b=f88BnnUVOX/l1KpQ+OtVUEaKUM3lqRnvdI4h7EuOBnQbo1yf3IZeAXCqrRh7FZMKCXVxJvc1VqoXdLgNCsumligKpiLOcD/3T5dO9N19pdB6KL/lJ5oy0S6VnSsl/8n1FCmVQ7Xg9nrBvfEGlDx56xGCnm5mKqYzhzobbK3Qvj4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775200203; c=relaxed/simple; bh=w21cLhiOkY5esQn9DHsC/Rtu4fH1zNEJX0o7QR2H05U=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OdX8sjmpNPwUm5MBMmA5rykRNonFO6EM+Js/dGEG7qjp7X5h6XQIbZyf5gkxxjQa2LgwwzJYJ8u2ihDUv93QTQPPp3Am5Zg5ymvXI3BgjKjxHaMHqM1KKNNdVRWFxIr7Lj2eFXu9YIsOiYQj5hOwZFfXKWSuhfs5+UMQpL0fgeA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=KDEsuuNO; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="KDEsuuNO" Received: by linux.microsoft.com (Postfix, from userid 1173) id 8157720B710C; Fri, 3 Apr 2026 00:10:02 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8157720B710C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1775200202; bh=cwYPRhVIctJk5zcX5H2P6TQrouKBAJ2cTusybCL+hKY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=KDEsuuNOT+turMnkLqdMTfe5qJqY8+Cwbj2axAB63J7Oh4Th1QjUBfQTbJXXVx6N1 dokwN7F4DN9mV8pMuBoi4+46eS3Kiv3o2ezCm9v3lfPwzWimzc3vAQQsmy1S7YBGpk 0jpxQTZkbk2vh4rVoMWxFuFz6Mkr5sh+iXsjvnEY= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ernis@linux.microsoft.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/4] net: mana: Init link_change_work before potential error paths in probe Date: Fri, 3 Apr 2026 00:09:40 -0700 Message-ID: <20260403070948.9225-2-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260403070948.9225-1-ernis@linux.microsoft.com> References: <20260403070948.9225-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move INIT_WORK(link_change_work) to right after the mana_context allocation, before any error path that could reach mana_remove(). Previously, if mana_create_eq() or mana_query_device_cfg() failed, mana_probe() would jump to the error path which calls mana_remove(). mana_remove() unconditionally calls disable_work_sync(link_change_work), but the work struct had not been initialized yet. This can trigger CONFIG_DEBUG_OBJECTS_WORK enabled. Fixes: 54133f9b4b53 ("net: mana: Support HW link state events") Signed-off-by: Erni Sri Satya Vennela --- drivers/net/ethernet/microsoft/mana/mana_en.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/et= hernet/microsoft/mana/mana_en.c index 07630322545f..57f146ea6f66 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3631,6 +3631,8 @@ int mana_probe(struct gdma_dev *gd, bool resuming) =20 ac->gdma_dev =3D gd; gd->driver_data =3D ac; + + INIT_WORK(&ac->link_change_work, mana_link_state_handle); } =20 err =3D mana_create_eq(ac); @@ -3648,8 +3650,6 @@ int mana_probe(struct gdma_dev *gd, bool resuming) =20 if (!resuming) { ac->num_ports =3D num_ports; - - INIT_WORK(&ac->link_change_work, mana_link_state_handle); } else { if (ac->num_ports !=3D num_ports) { dev_err(dev, "The number of vPorts changed: %d->%d\n", --=20 2.34.1 From nobody Sun Jun 14 14:29:29 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 774A618BBAE; Fri, 3 Apr 2026 07:10:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775200207; cv=none; b=GS5AFLzgOqzHWHovvVSdkYCW313RcO9kxHxmOYqAhMh2ejvSy9alsDFDxAinbqUFzZsL0XOXfIZIcu/Xq6jem4w2G7rNQjw9piD6wCax0n2HDCxoW2VGpc6X5rZJoD6Z8GEu2+k3MefGDu0A5QSHCY68y/EjzrxqJL3b68MhLJM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775200207; c=relaxed/simple; bh=/pU5A3xBq86VS1vAri5aQXl3uYXYcF2a0cSpoh8LkGU=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hXTWrEFeYAy2T+VGBkOU1Z3szI1jQEfJVkYuVItkk8b1SXWyf0Tkj2Gn8ZKOO1cHOu4ldTGHD28aQZvQQ6Y+1qe9kjTqcfffSRF+R6V/2h0+eUezlw2kd4i/QhlFJKNP8a56vrzztdWlIro0JC1D1rOMiHWh5kVS+HikRmmLJEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=n3Qwr+uA; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="n3Qwr+uA" Received: by linux.microsoft.com (Postfix, from userid 1173) id 385A620B710C; Fri, 3 Apr 2026 00:10:06 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 385A620B710C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1775200206; bh=2p3sm93ntdgO9xv/cGtBdCj2MVo7aGQL6Rx5fp5dy44=; h=From:To:Subject:Date:In-Reply-To:References:From; b=n3Qwr+uAdD4s5WB3wCZka8tnPN8NmqVXAIN4Kv+lSmN8rrSCxco22URj57QmBhAPQ KLV4vnSLFEzmCPpCSl5pPQS0T99yxlgjBvyQ5BH8NM3qTj2868W053UCPTMOLV4b6+ 5SlyrCWowQlDujRxZv90yHvxd8lWjLLgsEkRVk5A= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ernis@linux.microsoft.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 2/4] net: mana: Init gf_stats_work before potential error paths in probe Date: Fri, 3 Apr 2026 00:09:41 -0700 Message-ID: <20260403070948.9225-3-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260403070948.9225-1-ernis@linux.microsoft.com> References: <20260403070948.9225-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move INIT_DELAYED_WORK(gf_stats_work) to before mana_create_eq(), while keeping schedule_delayed_work() at its original location. Previously, if any function between mana_create_eq() and the INIT_DELAYED_WORK call failed, mana_probe() would call mana_remove() which unconditionally calls cancel_delayed_work_sync(gf_stats_work) in __flush_work() or debug object warnings with CONFIG_DEBUG_OBJECTS_WORK enabled. Fixes: be4f1d67ec56 ("net: mana: Add standard counter rx_missed_errors") Signed-off-by: Erni Sri Satya Vennela --- drivers/net/ethernet/microsoft/mana/mana_en.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/et= hernet/microsoft/mana/mana_en.c index 57f146ea6f66..f6ad46736418 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3635,6 +3635,8 @@ int mana_probe(struct gdma_dev *gd, bool resuming) INIT_WORK(&ac->link_change_work, mana_link_state_handle); } =20 + INIT_DELAYED_WORK(&ac->gf_stats_work, mana_gf_stats_work_handler); + err =3D mana_create_eq(ac); if (err) { dev_err(dev, "Failed to create EQs: %d\n", err); @@ -3709,7 +3711,6 @@ int mana_probe(struct gdma_dev *gd, bool resuming) =20 err =3D add_adev(gd, "eth"); =20 - INIT_DELAYED_WORK(&ac->gf_stats_work, mana_gf_stats_work_handler); schedule_delayed_work(&ac->gf_stats_work, MANA_GF_STATS_PERIOD); =20 out: --=20 2.34.1 From nobody Sun Jun 14 14:29:29 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 64C2937106E; Fri, 3 Apr 2026 07:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775200210; cv=none; b=iiKZYx11kjknjNGt093FR61+3Hcztal2/Ue+RU/378PxjQ7LpxCZetvNM8GUnODYpFhe/dV9dikemIez/K3YEF8BBRqpWmbJlVQu2PdEH8Wo7PcW3Fa1IY/tef1LKi8oCcBa2hkMb8xUjkoZFkBISn2diKAo13d8JdK8v/tXxFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775200210; c=relaxed/simple; bh=ka/16DcRr7cSsRbNKmTcO1Wl7m1LVPWnzPAbSolk2x0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TbDg7jPKBt6VICZIXjYnuTqqQ0WBgcH0lhvh2nck4lNB+KNGfqWlLp6T0xE0ciQ5xvxMLFnu4PJiH2tX/7G1cFg03w7Mhq/Kr+IvHAsToaraXxsIreV8VB4mA6g8JN0B03Oz/yQLujMblDPEmx+y1OP/BXBTDRY9dtE5W79GVPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=o9ig9vVU; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="o9ig9vVU" Received: by linux.microsoft.com (Postfix, from userid 1173) id 2662B20B6F01; Fri, 3 Apr 2026 00:10:09 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 2662B20B6F01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1775200209; bh=MufsKhMKlNj+f76vqmh4y9HL9SJDhi76GV0bkj0a5O4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=o9ig9vVUmK+8m8y+oD7axPdc6pchASjC2vmtZFkqRRgnY4Ytusg799dYV7o7FYRqh yFgQppPD7AG72gbZstLtPsTthZyD04HYEoqemC9JB1hLHb9rKiHEki+h9JQXKtmLj+ fxOuOWfi27uP+MHM0htxnyH/So96sjRvJejUjRrA= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ernis@linux.microsoft.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 3/4] net: mana: Don't overwrite port probe error with add_adev result Date: Fri, 3 Apr 2026 00:09:42 -0700 Message-ID: <20260403070948.9225-4-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260403070948.9225-1-ernis@linux.microsoft.com> References: <20260403070948.9225-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In mana_probe(), if mana_probe_port() fails for any port, the error is stored in 'err' and the loop breaks. However, the subsequent unconditional 'err =3D add_adev(gd, "eth")' overwrites this error. If add_adev() succeeds, mana_probe() returns success despite ports being left in a partially initialized state (ac->ports[i] =3D=3D NULL). Only call add_adev() when there is no prior error, so the probe correctly fails and triggers mana_remove() cleanup. Fixes: ced82fce77e9 ("net: mana: Probe rdma device in mana driver") Signed-off-by: Erni Sri Satya Vennela --- drivers/net/ethernet/microsoft/mana/mana_en.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/et= hernet/microsoft/mana/mana_en.c index f6ad46736418..1a141c46ac27 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3680,10 +3680,9 @@ int mana_probe(struct gdma_dev *gd, bool resuming) if (!resuming) { for (i =3D 0; i < ac->num_ports; i++) { err =3D mana_probe_port(ac, i, &ac->ports[i]); - /* we log the port for which the probe failed and stop - * probes for subsequent ports. - * Note that we keep running ports, for which the probes - * were successful, unless add_adev fails too + /* Log the port for which the probe failed, stop probing + * subsequent ports, and skip add_adev. + * Already-probed ports remain functional. */ if (err) { dev_err(dev, "Probe Failed for port %d\n", i); @@ -3697,10 +3696,9 @@ int mana_probe(struct gdma_dev *gd, bool resuming) enable_work(&apc->queue_reset_work); err =3D mana_attach(ac->ports[i]); rtnl_unlock(); - /* we log the port for which the attach failed and stop - * attach for subsequent ports - * Note that we keep running ports, for which the attach - * were successful, unless add_adev fails too + /* Log the port for which the attach failed, stop + * attaching subsequent ports, and skip add_adev. + * Already-attached ports remain functional. */ if (err) { dev_err(dev, "Attach Failed for port %d\n", i); @@ -3709,7 +3707,8 @@ int mana_probe(struct gdma_dev *gd, bool resuming) } } =20 - err =3D add_adev(gd, "eth"); + if (!err) + err =3D add_adev(gd, "eth"); =20 schedule_delayed_work(&ac->gf_stats_work, MANA_GF_STATS_PERIOD); =20 --=20 2.34.1 From nobody Sun Jun 14 14:29:29 2026 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7D235371D0A; Fri, 3 Apr 2026 07:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775200212; cv=none; b=D5SB+o4qxRSyfzojCotR6IBtrbe8q8NCsmIMsHiYV+BnhfNfPPaQLmeT+VK48u3fmgStkaeqe1t/cH0qcLyE9aJgsMzN1eLGKlBiVVbQ1udy73aSP8sr+orCaIozJMUfYHjYrK16C7HOsiA7PboY4CjacfTwGr3Z9IkeSaJ18ik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775200212; c=relaxed/simple; bh=0xgmDKsYqvacVPJ5rAhhSR5GcmWBrkLwMvk88WuI3wA=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EBpcalF/Gpvedn+spGXSmWaqZTolq/FMfxJhZtd1gLlGV1JHRCNKIDKhHm3/u1ZeIxTwJ+jqOznpiX8PN4/mqzdhTqW7EphMhvu6iJwF9mUbGVc2+Wz9eTYyuq7N4FcUZbeYahkHEZBDKPYTpBl7KQgDSasaOyXWk2DyjNARaNU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=ijDI2HQz; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="ijDI2HQz" Received: by linux.microsoft.com (Postfix, from userid 1173) id 49ACE20B6F01; Fri, 3 Apr 2026 00:10:11 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 49ACE20B6F01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1775200211; bh=OhD1X2monvqAOmG8Rm0rzvQIucQdiJXg2CJjthghJMc=; h=From:To:Subject:Date:In-Reply-To:References:From; b=ijDI2HQzy63xMFPJYQulCH40OfUEVPMSO5+fAEb7rp4sW9wKsU+1sqLCbv3IiUfZr FVApKiIl2PPD8yfXRcOT9j9+G4Lq4xOjbKHQt1XdBjE9vsboOfVdwgp4zc7Uva/fd7 axlzIZ7Ib0X3xYz2IzRk3DcBBoTYZxLjrtkz2V3g= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ernis@linux.microsoft.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 4/4] net: mana: Fix EQ leak in mana_remove on NULL port Date: Fri, 3 Apr 2026 00:09:43 -0700 Message-ID: <20260403070948.9225-5-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260403070948.9225-1-ernis@linux.microsoft.com> References: <20260403070948.9225-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In mana_remove(), when a NULL port is encountered in the port iteration loop, 'goto out' skips the mana_destroy_eq(ac) call, leaking the event queues allocated earlier by mana_create_eq(). This can happen when mana_probe_port() fails for port 0, leaving ac->ports[0] as NULL. On driver unload or error cleanup, mana_remove() hits the NULL entry and jumps past mana_destroy_eq(). Change 'goto out' to 'break' so the for-loop exits normally and mana_destroy_eq() is always reached. Remove the now-unreferenced out: label. Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network A= dapter (MANA)") Signed-off-by: Erni Sri Satya Vennela --- drivers/net/ethernet/microsoft/mana/mana_en.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/et= hernet/microsoft/mana/mana_en.c index 1a141c46ac27..97237d137cbf 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3747,7 +3747,7 @@ void mana_remove(struct gdma_dev *gd, bool suspending) if (!ndev) { if (i =3D=3D 0) dev_err(dev, "No net device to remove\n"); - goto out; + break; } =20 apc =3D netdev_priv(ndev); @@ -3778,7 +3778,7 @@ void mana_remove(struct gdma_dev *gd, bool suspending) } =20 mana_destroy_eq(ac); -out: + if (ac->per_port_queue_reset_wq) { destroy_workqueue(ac->per_port_queue_reset_wq); ac->per_port_queue_reset_wq =3D NULL; --=20 2.34.1