From nobody Sun Apr 5 18:08:38 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8677257435 for ; Fri, 3 Apr 2026 00:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775176555; cv=none; b=JXhsdwHGi5UaWmrTyiH6t0z+pfPSRU7IWT4i5hg9VyA019JmWKHp3eQk7rS6naAa7+mv+GY1kMb6rksAY2cEr6ZYODXFAy/x0b+pxqwFHX5NUxdlkIYnr6MKOzKSVAgyLANFyzWQPXLOQeac8FQEFMTM8LjRtS8mfwp91Jui400= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775176555; c=relaxed/simple; bh=QNzOKPdiy8cSJfr1mCdxlpDpX0PCIjFpk/12ymL9Mjs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lN0r0TQcU9jugMgFjMB86FMKNumP6PSgvDkaXAB0oN3lMyz/eye1/DyyQ0IpNqG977aD8tj3rkFHjvtcn18pgOsqc/ueV3llnhqJ7x0AzWBU0Vr83ceyop8Sr8lQokPX/9EdYzRM8CZVpAfb/lAEuzsOKlBXs7KzgyW78vsTly4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=UhtktxIc; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="UhtktxIc" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-35d94f4ee36so853694a91.3 for ; Thu, 02 Apr 2026 17:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1775176553; x=1775781353; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zg+/QcI8r5Qwsw6nUEc3qwhDPUQV4lyYXGZbebKcjco=; b=UhtktxIcidHzUonYIpKH7SGelZG1COlIHe35zZ+XB9INrYXj+iKMaaQ+p20k1qCA27 7qTGCJT4UgSqiPGQgSjqy7btQUct2+EfqiqQ7KxvebJfHUvxt2IonWHiyXJkgKyRlAqj ynOQc37Z1DBnN9W5bC5HQSBk2icEQ0EXx5uCP2WFi483niEq3jtQwhhfLA196qWWhV23 V6V6gr27HBJk5kN5HkbK7Zg+7gz7Th0QgKzwgxITNJdNjqMiP6UacQ/b55E2kKwBdcyv 4Ypo7gODS4QQuAPJ4K+8ZmO82FxkIFoudJMUEpY4Hi/gmpFM6JgQ7K1bQqENr919N9kp W9lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775176553; x=1775781353; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zg+/QcI8r5Qwsw6nUEc3qwhDPUQV4lyYXGZbebKcjco=; b=mAhQnab+G+fNwnYfGjrJwi4n7PANAACxSen3nfOBtNO69g9Yt2JyuKnqFxUZvZDt1C 2y5is8spdlf8TD4NDBJCvLZausOHhdpzh2mHWrJTRYqoa17Dkir7bLkEhhkVQGBSmRpc Cn3uzr46x4AED77EwJb+4Bt3B0etGXoS7+mX4B34G8BPcGMf0EZK2PUeT0+A2z+aYwnc D905EY4uW2z5eZFrW1VGIAk0KhMMIrV8WKCv400ZuQa4+WUWCEPqsnFNW1w3X878puT2 hJ2QhZ1T1Z9eyWbYvN4VHOgN9jIN+BIm2Lp3knmsvRee3sdN6wxvkTTDyz5Q7hdiVkKb ZyfQ== X-Forwarded-Encrypted: i=1; AJvYcCXsRgJfMg/NyzIL+uPOc7YhVQvcaxiuOS8eoIfSK4hcfI2KuRTt43NIe7xbN2OUpR0P8I95t5/KixKU7DM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw78Q7ynk3IO9511L2gA1rEyhADTwkQGCsJqoRAzc3d/aik+lHf qkhMk1wmDkptWbGPacDFOi2w/JbghPSnJcUX0FDoryvEY1PIV/HgN1ShoUX3kZaoM9Q= X-Gm-Gg: AeBDievUa+GZEEM/1hX8XgssHn/TDDSw0jxnFXQTJjsryyxl23PE4hnrxWfd/UgYVWo 3J9iFpnjFxNhHzzcdu5/M7X6dkvZ/lpYTAIikh050DCnB1WIE/oGWwY5u8YAUvp6+0cmtmMCSSK ACsZdA8nYXtbPdqWHR5qq48iS2v9tPHBxZE0zVMdXdj9IfPLZ6a5MdzhzFLAI/DMRb+XNZm0rr8 FKaspCMkZeK68Kee/QC0tw98CMPpYCVthuKkd928F9BFWVVg2JZxj3vD+KKKlPk9YMkUfXpuR0r oiqckdCcJmymm102BH9pvxFTV792g53LNJckLkqhDsolNtk3elrAMhosgvyPaXs2CxWmdqMq1dt FBsqW1CkJN1wLtWDtgCQJwvu8VoYCeeVIA7tdXB0IW0G12LJoy4f0RCpInDNJGjCubd2ccC0Mzj ISfMRb X-Received: by 2002:a17:90b:582b:b0:35c:1695:24a3 with SMTP id 98e67ed59e1d1-35de691b308mr725959a91.23.1775176552800; Thu, 02 Apr 2026 17:35:52 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:5e::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe41b11fsm8949063a91.0.2026.04.02.17.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 17:35:52 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: horms@kernel.org, linux-kernel@vger.kernel.org, leon@kernel.org, Joe Damato Subject: [net-next v8 03/10] net: bnxt: Add a helper for tx_bd_ext Date: Thu, 2 Apr 2026 17:35:10 -0700 Message-ID: <20260403003524.2564973-4-joe@dama.to> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260403003524.2564973-1-joe@dama.to> References: <20260403003524.2564973-1-joe@dama.to> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Factor out some code to setup tx_bd_exts into a helper function. This helper will be used by SW USO implementation in the following commits. Suggested-by: Jakub Kicinski Reviewed-by: Pavan Chebbi Signed-off-by: Joe Damato --- v4: - Added Pavan's Reviewed-by tag. No functional changes. drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 18 ++++++++++++++++++ 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethern= et/broadcom/bnxt/bnxt.c index d4288c458576..d1f0969b781c 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -663,10 +663,9 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb= , struct net_device *dev) txbd->tx_bd_opaque =3D SET_TX_OPAQUE(bp, txr, prod, 2 + last_frag); =20 prod =3D NEXT_TX(prod); - txbd1 =3D (struct tx_bd_ext *) - &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1 =3D bnxt_init_ext_bd(bp, txr, prod, lflags, vlan_tag_flags, + cfa_action); =20 - txbd1->tx_bd_hsize_lflags =3D lflags; if (skb_is_gso(skb)) { bool udp_gso =3D !!(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4); u32 hdr_len; @@ -693,7 +692,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) } else if (skb->ip_summed =3D=3D CHECKSUM_PARTIAL) { txbd1->tx_bd_hsize_lflags |=3D cpu_to_le32(TX_BD_FLAGS_TCP_UDP_CHKSUM); - txbd1->tx_bd_mss =3D 0; } =20 length >>=3D 9; @@ -706,9 +704,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb,= struct net_device *dev) flags |=3D bnxt_lhint_arr[length]; txbd->tx_bd_len_flags_type =3D cpu_to_le32(flags); =20 - txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); - txbd1->tx_bd_cfa_action =3D - cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); txbd0 =3D txbd; for (i =3D 0; i < last_frag; i++) { frag =3D &skb_shinfo(skb)->frags[i]; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethern= et/broadcom/bnxt/bnxt.h index 2b40a5bd57af..83b4136ccd31 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -2836,6 +2836,24 @@ static inline u32 bnxt_tx_avail(struct bnxt *bp, return bp->tx_ring_size - (used & bp->tx_ring_mask); } =20 +static inline struct tx_bd_ext * +bnxt_init_ext_bd(struct bnxt *bp, struct bnxt_tx_ring_info *txr, + u16 prod, __le32 lflags, u32 vlan_tag_flags, + u32 cfa_action) +{ + struct tx_bd_ext *txbd1; + + txbd1 =3D (struct tx_bd_ext *) + &txr->tx_desc_ring[TX_RING(bp, prod)][TX_IDX(prod)]; + txbd1->tx_bd_hsize_lflags =3D lflags; + txbd1->tx_bd_mss =3D 0; + txbd1->tx_bd_cfa_meta =3D cpu_to_le32(vlan_tag_flags); + txbd1->tx_bd_cfa_action =3D + cpu_to_le32(cfa_action << TX_BD_CFA_ACTION_SHIFT); + + return txbd1; +} + static inline void bnxt_writeq(struct bnxt *bp, u64 val, volatile void __iomem *addr) { --=20 2.52.0