From nobody Sun Jun 14 12:46:17 2026 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A28E1A680E for ; Fri, 3 Apr 2026 03:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775188045; cv=none; b=l8zUPXJqc4xaZKNyInIMkIXM5V5EohjmZDAI8Ib0NWke1tgNdza+d78KFTDkwwt2ywGVywmFHZlv9XGogy3sn73LWFCnbt5XZn54sl/ryhej4GtKYKlH2IpK0t8+dftOkQWa647Q0ue8O+r4kyrM4AzQuZuiGRco1weqb1USNVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775188045; c=relaxed/simple; bh=i+jTnj9uWTVTpk/43LHEyjWkuxe1ecxKHb3ofhIcLBI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=gwUBp6qDCmUNHuTTtpp4Lrc7qsoHtcz4cQIZkWdE6gT6/TQ4egVQwfBvvBhk0AovFk3urhJt0XNG3X6ZgJ2BJvQS1+guqg7q6u51RQsw1QxWSGU4s/i/2/5mw6k00v+QypRmjnLH2TYwpwXKMLsw21bzOx3Zt8rAE+EA9DqP9g8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hTRzPkt6; arc=none smtp.client-ip=209.85.217.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hTRzPkt6" Received: by mail-vs1-f53.google.com with SMTP id ada2fe7eead31-6055de93fa8so538095137.0 for ; Thu, 02 Apr 2026 20:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775188043; x=1775792843; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=mQJe7gr2NY91HuvsDinY38MzPt4uB1n6FAVnHxFtD78=; b=hTRzPkt6W5Nq5UKqtp01Kf3mlEeECOUUEmAe7d0+rgmWCJQ5dNgQ1pG5ltZe4lZ3Yb ncK/9f6rFtY9T9E/GN3Y3bLeR6zAeGhUjscKKk1qWQxuKxa7qgTDfbW43NS5YvfWKHpF uDjGDYb1BHZ+NZ6gDYtBji9CcMIVED5i5kGCJum0X4u5NcHx8+08he4Kn+5o0XfsCqjT eM+UmhwPvrZvzsDUxswullonM3sDbjQoNPqjBw5r4pTmLj9eXEK8+b8FdnTfwLFA+vNw P2RpllLYsshoFW1oS6Qjepp0XX518ZCJ2e5lV9wfdf4bl6+X1PJihf0GPAP01WcMyL9b R0sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775188043; x=1775792843; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mQJe7gr2NY91HuvsDinY38MzPt4uB1n6FAVnHxFtD78=; b=JrKRpNMCyYK6Z77FgA9sY9BSUqRNmonoO2p6Y1ggAAkN3Y84xK+jSsev8vBgQLQGdD 7E4PctRn6RgERO1951VlP5RY01s5vqj5IHIwHEg89MgLsh8Wyrg0zL3jPwNPpP2mD37F ZiK++Uf4BNVfnkNDG4pqyQTEtzEuXaaneI5N5NqMlO+BdAXEnCCnirmtISmgrJS7Yway JWH+dPfv9Gg3TwIaLg8EB9rAPrUuCLSCMuP48xSEAgSNRxBmDc1yGkWGJw/2aK2FlZx0 njlUlsZGUMAjXFdi/i0ofAcZwyaLwsvJRXU8VINPcKT+fBI5N4XF6p5+eGCfnth5zkn1 kwUQ== X-Forwarded-Encrypted: i=1; AJvYcCU6MRDpoMKbcHkn0dPVWBvbQZ7siYhRK118Qan6XrVgBv6+vPJ/MFcjqKsrFuh3o2ZrpRQLyKzvVfYA77k=@vger.kernel.org X-Gm-Message-State: AOJu0YwgG0iEVCCPb5vdb5MHuqyylqh6DjH6M3qLdoJMTxm6EB01bavo kETsvTHGswtT4UVX+yQqlrHbRyNvHm8fkZo80m83zyNRIvFlFXZn6zBV X-Gm-Gg: AeBDietwJUkMkI7yagnx8wxfnZEQVds5nXaCW63+U6FzmZpqGvO/hpG8PAAvhJshdvg IYDDznTUyt9RsPOHH2m+XdlTYFYQLNsvXLTv/dREU8yg8o2SyxKWAXC8HJJB8D84YosmVfO7bro XQ+QKO4E0Yvw+yn2Ak7gtU2RilH+03mSIg1/SYAmIb82gD8OMzrfms5v4oxPAJ0k9p4FUiUm3/5 gH4BzW0g8/zIiP+/mXxrEt9AC3AQdlXWA3gifp/d1oHH/dv6g9vLXuyOWzWl+w/nDHXGnktfEYq JaOJVqTxJxTUcve4xaiGG2Z1iiLT40fJcvcIBheFpDWtooi/Lrrss1MM8AmKYwrntzcrgU/wFoi rudyAQc6LZDMOL/VzpbX9Z6VoMBgbb7owxsCP1jn+4cNpmxxoyXhC6tY0WwtxkNjLBHQ1IwJaqH q8Uu+KOZHeY9t5SrtNT/DoSl1fVPkSlsQLKziK8r3JoxplWjSRqq+HMdp3vOH8wA27LcO8dVE+O HGa X-Received: by 2002:a05:6102:5107:b0:5ef:2457:8015 with SMTP id ada2fe7eead31-605a5099bdbmr580390137.29.1775188042928; Thu, 02 Apr 2026 20:47:22 -0700 (PDT) Received: from [192.168.1.18] (177-4-161-217.user3p.v-tal.net.br. [177.4.161.217]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-60583049c1esm6652525137.8.2026.04.02.20.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 20:47:22 -0700 (PDT) From: =?utf-8?q?C=C3=A1ssio_Gabriel?= Date: Fri, 03 Apr 2026 00:47:13 -0300 Subject: [PATCH] ALSA: aoa: onyx: Update IEC958 sample-rate status for PCM playback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260403-onyx-spdif-pcm-rate-v1-1-dcfaf931cf83@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMQQ6CMBBG4auQWTtJKcUQr2Jc1PKDQ2JpOmAwh Ltbdfkt3ttJkQVKl2qnjJeozLGgPlUUHj6OYOmLyRp7Ns7UPMf3xpp6GTiFJ2e/gBFca13j0fm GSpkyBtl+1+vtb13vE8LyXdFxfADCTi1WdwAAAA== X-Change-ID: 20260401-onyx-spdif-pcm-rate-ec45243ae8a3 To: Johannes Berg , Takashi Iwai , Jaroslav Kysela Cc: linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?C=C3=A1ssio_Gabriel?= X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2998; i=cassiogabrielcontato@gmail.com; h=from:subject:message-id; bh=i+jTnj9uWTVTpk/43LHEyjWkuxe1ecxKHb3ofhIcLBI=; b=owGbwMvMwCV2IdZeKur/u2bG02pJDJnnLdxF6urnCQd4eJhyftXVm5b8Lezv0c8Pn02ZpLFI/ Ulvq7BDRykLgxgXg6yYIsvqpEWWe7oeXK2PW+EBM4eVCWQIAxenAExEy5CR4fdqDs7wG8KzRU1O 7Xx6u1swOOzY4ZlpJ9ZuN/s3LVlE7xHD//CqMGO1YHGna4In6nzfJXNfagrYclny1+Q07Zgteia /eQA= X-Developer-Key: i=cassiogabrielcontato@gmail.com; a=openpgp; fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83 onyx_prepare() accepts 32/44.1/48 kHz PCM playback, but it leaves the Onyx IEC958 sample-rate status bits at the driver's initial 44.1 kHz setting in DIG_INFO3. As a result, 32 kHz and 48 kHz PCM streams advertise a stale IEC958 sample rate unless userspace rewrites IEC958 Playback Default first. Update only the consumer sample-frequency bits in DIG_INFO3 from the PCM runtime during prepare, resolving the long-standing FIXME in the PCM playback path while leaving the other user-controlled IEC958 status bits unchanged. Mark IEC958 Playback Default as volatile as well, since prepare() now changes the exposed register contents outside the control put callback. Signed-off-by: C=C3=A1ssio Gabriel --- sound/aoa/codecs/onyx.c | 37 +++++++++++++++++++++++++++++++++---- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/sound/aoa/codecs/onyx.c b/sound/aoa/codecs/onyx.c index 04961c456d2c..6e2da2aca2ab 100644 --- a/sound/aoa/codecs/onyx.c +++ b/sound/aoa/codecs/onyx.c @@ -32,6 +32,7 @@ #include #include #include +#include MODULE_AUTHOR("Johannes Berg "); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("pcm3052 (onyx) codec driver for snd-aoa"); @@ -514,8 +515,36 @@ static int onyx_spdif_put(struct snd_kcontrol *kcontro= l, return 1; } =20 +static int onyx_set_spdif_pcm_rate(struct onyx *onyx, unsigned int rate) +{ + u8 dig_info3, fs; + + switch (rate) { + case 32000: + fs =3D IEC958_AES3_CON_FS_32000; + break; + case 44100: + fs =3D IEC958_AES3_CON_FS_44100; + break; + case 48000: + fs =3D IEC958_AES3_CON_FS_48000; + break; + default: + return -EINVAL; + } + + if (onyx_read_register(onyx, ONYX_REG_DIG_INFO3, &dig_info3)) + return -EBUSY; + dig_info3 =3D (dig_info3 & ~IEC958_AES3_CON_FS) | fs; + if (onyx_write_register(onyx, ONYX_REG_DIG_INFO3, dig_info3)) + return -EBUSY; + + return 0; +} + static const struct snd_kcontrol_new onyx_spdif_ctrl =3D { - .access =3D SNDRV_CTL_ELEM_ACCESS_READWRITE, + .access =3D SNDRV_CTL_ELEM_ACCESS_READWRITE | + SNDRV_CTL_ELEM_ACCESS_VOLATILE, .iface =3D SNDRV_CTL_ELEM_IFACE_PCM, .name =3D SNDRV_CTL_NAME_IEC958("",PLAYBACK,DEFAULT), .info =3D onyx_spdif_info, @@ -695,9 +724,9 @@ static int onyx_prepare(struct codec_info_item *cii, case 32000: case 44100: case 48000: - /* these rates are ok for all outputs */ - /* FIXME: program spdif channel control bits here so that - * userspace doesn't have to if it only plays pcm! */ + if (onyx->codec.connected & 2) + return onyx_set_spdif_pcm_rate(onyx, + substream->runtime->rate); return 0; default: /* got some rate that the digital output can't do, --- base-commit: f16695c0dc9db64f0a5a9871a10b70daee2653e3 change-id: 20260401-onyx-spdif-pcm-rate-ec45243ae8a3 Best regards, -- =20 C=C3=A1ssio Gabriel