From nobody Tue Apr 7 13:49:48 2026 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6179F3CE483 for ; Fri, 3 Apr 2026 16:44:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775234647; cv=none; b=l7sgeCCnJKBFXloLg6UbpUSIDRTxQIpTjyT0yC/uneR0d30toQ4CN/xZT9UmgBC6lBbSdSq6czvWZYNWxA9OD5v7JXuFES6vUkl/tkj+Igy+f23DuD/ajz7Iq2wDaVP1gmd0nw2Bq9Vi7iHoa2lj35hEqueVZP+A/3X/Ekk9c0A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775234647; c=relaxed/simple; bh=c9ud9hMSAb29AtftWqh2+ul+32jl5aytaub0XxdrYew=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ONNfkjENjVWtQmU6EPIP2ho4VBUrFERrKyuoeIUB9WlgAA9h8ORzO5aYpQ64Ex0jJAZ35z+jgnERfwHn30zxFBxI0T7lmjyZtMFII6hpkLojH6T9PdWsvxE0hzA4h34WdHKwIqjZuPkE8Ym3e8X9rV6CJRLAMcHi+9KRSfD1+bs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=etF5eNW8; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="etF5eNW8" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b932fe2e1a7so266482966b.1 for ; Fri, 03 Apr 2026 09:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1775234644; x=1775839444; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kqZBtqbXpsXcGM064lzho6jfnaB+LmMlvvuZ2cyPGYA=; b=etF5eNW8Jg6DicZwBnIiQit9sNj0mTP2qqkZ9o3YXuaiaV6380KVNJvQCmdEBHsXe8 ytw3jLrliwUR3/Hlmm+kslPIgZvGe9U2CWHO9YWDYQLRIleJcBBZAj2r3ii00uh5aTB5 HGNgjGMs9U+izmMAcQRInpSK1OeBIo/hkfj66rwF/qiIGPvqIoVbZ1k1yIdtFgSNw1YC V2KKiAFgJHo5x/W6Z+b+YEwkmSjF9CI4IQmzfryfVq4/cMBQHTO70PBFUqvB/BS0qvzl YATmZ9GG3I2xx7bgbJ6zaBautH0TLY/2/q4A7gsjvLKPtopV3D78lsUJ8uAFYhmlPK2A R7Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775234644; x=1775839444; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kqZBtqbXpsXcGM064lzho6jfnaB+LmMlvvuZ2cyPGYA=; b=i7i3F0FueS+uxEuQVu+GfLkUiLfK7Zlgn1H79x/9S6ohmW9ep8R0z4TIT5teUCyxkq aSs2jwtpuAG5H5f9ZLzchoKA8Qmq1M/auSDU+OJivuPboOv7/LNjhdcd37+Jy7FGEMOs b81cI392N4ewXTumKOcpWL9pzbwN9wWMNWDbv6RRKUYWXV+vB/lCZxiIWVDDz6OjYfd2 MdcnNgyYuLJJgFD+7Jfj09juXq0st5fl/cax7NkpR1Fypzd7b9u+uzL9bHRZUh6/s0Ky vGKAFogvzCf5czDJL/GTFwdTVIbrCVlr0dzz0EOokii1cP0AMNGBcdqM+3c5QcisdlGF 5rzw== X-Forwarded-Encrypted: i=1; AJvYcCV7G2CpEIi7BNU6HqUE+gW5vR9BzhTKC3naHRMMCvQxes/ryH9bu9sRhD8oJ9So/T3aNVZdzy+07K4UTeY=@vger.kernel.org X-Gm-Message-State: AOJu0Ywu+TdlX1MI6JyGDeN/apL21X3ojXgbL75nuHR+PLi5m+ssulgh 5D4uz/N4w6oauqlz/PR5cLrw8gndriav3RlVSABwhVhLYaTZlWJd2m0vew6JT8RdQ10= X-Gm-Gg: AeBDieueE44BYdxWqYg2ueJxDmfh/btFdoJyjym6YR4Wc18FrQLut4A4FlllLxniemI p3pPzsMjo6JDAOWb3yLXxbQeKcxTKuReu1iram9LeyQUKvNUZR9dxGDhVdjarO1v+SNVm/MHzDx /BV5GyemM5hkAzVdYj8rcBQKSUOp7l0sCmcPMcGjSgwoq4F9ne939XXmT+c32Y+/1BC3i2I3MqE 1HX4Nu+FrXivAyVT0iYnSaHRFIVIORopffWW1IzFPaIOpskWtQQgc619mZxbuTcxsg+pSQmZHT/ MUt3pd6re/do5p4fsTdMSZ7pG88zCgOtvUE4HqLt1K/xSFXNHLq/2XP8wIhEgIv8EVAXbCqg1mX zCOBlsZNi5oqUpDmCWvx4m3Sxf4V0k0G3ZuGis9Il6gtgyR0kQPa2lA1Vl62gBKYHfSgI5Qeq9R c38ao1+lJQEbRtiUdRfJ2V4ixBDoRWCg1IAm/SPEVSrMzo8S0S33SuoeFr548LP2TLySaw7xtF3 bTXNofttCMA5O7JvYXkM0xDzAEofQej8Wahrw== X-Received: by 2002:a17:907:3e9f:b0:b97:ca81:e89a with SMTP id a640c23a62f3a-b9c66e8f0admr191031366b.0.1775234643574; Fri, 03 Apr 2026 09:44:03 -0700 (PDT) Received: from otso.local (2001-1c00-3b89-c600-71a4-084f-6409-1447.cable.dynamic.v6.ziggo.nl. [2001:1c00:3b89:c600:71a4:84f:6409:1447]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3ca9a145sm213492566b.25.2026.04.03.09.44.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 09:44:02 -0700 (PDT) From: Luca Weiss Date: Fri, 03 Apr 2026 18:43:48 +0200 Subject: [PATCH 2/6] net: ipa: fix event ring index not programmed for IPA v5.0+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260403-milos-ipa-v1-2-01e9e4e03d3e@fairphone.com> References: <20260403-milos-ipa-v1-0-01e9e4e03d3e@fairphone.com> In-Reply-To: <20260403-milos-ipa-v1-0-01e9e4e03d3e@fairphone.com> To: Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Alexander Koskovich Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775234639; l=1402; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=niHCtM98CmwGu9tGXQ1iV8G8OUNt7CyQAHGOy0w2ztg=; b=96TjL2CndxnnjLRlVhkbxUrsefNcmkkxoxcUib1ZyUIjblzrlIaLz8j/6EGfZLBeALxZc02AG rCUST7ZUZePDpYuFSjdZWozuZDKvMxsQvBPjxu48IEQqCxKA26ZqcEw X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= From: Alexander Koskovich For IPA v5.0+, the event ring index field moved from CH_C_CNTXT_0 to CH_C_CNTXT_1. The v5.0 register definition intended to define this field in the CH_C_CNTXT_1 fmask array but used the old identifier of ERINDEX instead of CH_ERINDEX. Without a valid event ring, GSI channels could never signal transfer completions. This caused gsi_channel_trans_quiesce() to block forever in wait_for_completion(). At least for IPA v5.2 this resolves an issue seen where runtime suspend, system suspend, and remoteproc stop all hanged forever. It also meant the IPA data path was completely non functional. Fixes: faf0678ec8a0 ("net: ipa: add IPA v5.0 GSI register definitions") Signed-off-by: Alexander Koskovich Signed-off-by: Luca Weiss --- drivers/net/ipa/reg/gsi_reg-v5.0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ipa/reg/gsi_reg-v5.0.c b/drivers/net/ipa/reg/gsi_r= eg-v5.0.c index 3334d8e20ad2..6c4a7fbe4de9 100644 --- a/drivers/net/ipa/reg/gsi_reg-v5.0.c +++ b/drivers/net/ipa/reg/gsi_reg-v5.0.c @@ -30,7 +30,7 @@ REG_STRIDE_FIELDS(CH_C_CNTXT_0, ch_c_cntxt_0, =20 static const u32 reg_ch_c_cntxt_1_fmask[] =3D { [CH_R_LENGTH] =3D GENMASK(23, 0), - [ERINDEX] =3D GENMASK(31, 24), + [CH_ERINDEX] =3D GENMASK(31, 24), }; =20 REG_STRIDE_FIELDS(CH_C_CNTXT_1, ch_c_cntxt_1, --=20 2.53.0