From nobody Tue Apr 7 13:50:15 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA98629ACCD for ; Fri, 3 Apr 2026 16:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775234645; cv=none; b=bVhxMe+1Bdw+QkFWzol6wr/hlRhv61KERVlz04wz6Nonmgeem+L9qpRVyrCu7XLfjKJprwdwscXPkrM3E2MnfGdTHoVxN3WOmMbP8h4Pam1ilQH+T5OxILLl9zgVIevgzxbabnHKXZhTS6A60zEQidnUEUgGMWwX1R2jZzHeERk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775234645; c=relaxed/simple; bh=i4p562E6xl+MsawXqPrNM2npLjWfOncAEU+VEhgYYCg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q7kLEtaLs/2hTqZMEGCTppYe063liCqJ2CjTkbe1DyHu0v+9QLO+ai9QsashJb8M1aTHrvVVO1bDkhz6GzFMzz/ah5IeAEthjXldfERgf0Y4cKXGyRqVQ1JxqMhbNR/zFqkfYjqAyIgU5N5S5SDk0p+xoRywGamtbZdK8F9WQJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=mhVywkwu; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="mhVywkwu" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b9c04152730so312680066b.0 for ; Fri, 03 Apr 2026 09:44:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1775234642; x=1775839442; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CTjtCff7Q4DiiNPMLHxYW0+3ALVFBVM6wubHOseE9mU=; b=mhVywkwuJvhO3WlBYE1/OaMAZo+a//kPHAerR2H7xcZmilHNo1HFI1aL5wsGO1cqt1 8nu3eZoHOYwNGej3Z/DTHBvDzqA9gU84/jq7TQyPD8/9QEuskruHPVbahFKHRQLyUBBG gZga5ZP+WLNa2rrwSKbJwso4fT/zcCC/+5jYvtx9TpETIsZ6gILSXNK2SZmDspAeKBLc H0bHMNLiY4rW1rIkFMw+blYwSUiIKhu0D9Fp3IxL4b0o4gbYg61bJKRNxjh90yR3Clw5 JZBegqsnMrDZzgZJIM/H/KCCEPW7rmI01tc4kcCMHJgTNdWdDqKq6GnqSERy1Hmp5Is3 qv3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775234642; x=1775839442; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CTjtCff7Q4DiiNPMLHxYW0+3ALVFBVM6wubHOseE9mU=; b=igGjSILJnfdUgl5cdHjHJDJbHqNJXsiZfvzk/oMzJZ0tsa/dQDq85pVJOSYwTuMf1S ImYM954AlE8uR/kHP2MRZeo06Aqd3sxfIIXwyV2LXfGD8GbdGhrumB+ZunW5TU+Z3W9v jROQnbUWyYz7MXsCxPNp5KuORTMycSWrx94dTqPo6Ax1XOH4IDSpJTaXMwMcDOP9D1BY Kpj77omYHFR8KgSCVgBzrtzxrzlaya8a9YJeW3V5e20bj98ZVigqN/HhC111/fDdyh+s X96jfKHJWwiJH4ZuCdBMudRN0rT1w5c2P9PHD+nG6L6fAImTVbge1DGU4D7tDJwRlZ+k TAkg== X-Forwarded-Encrypted: i=1; AJvYcCX/hrXL1Ee9borKGOWH2RQUcWzV9u2WUXNod+DcSk1MLbkv6sf/wJ0s3QfM5bVrYdZrhebiy/lGdkqlBbs=@vger.kernel.org X-Gm-Message-State: AOJu0YzrpAx4GKx5u4tZEznEeX82mU/Pdh+O+ZRqBDM/2SME/Zya/KtN 5n3Gx1BygWBMW7Bim4vj3ivUtEVPb4FI7CW9FStJoEFIYKtiWnCifBx9T9wXLxuMcz4= X-Gm-Gg: AeBDievPhsYOca4I4qqvTnpGna47+VvK+UWpGn7Ii10ZUm6/gzCr9QxwH7Ap/javVGy UdIZIuKAsxeeTVDY0ULwtVBQePeVTub0ZyLEGt8dfbHU2M189zMPKhwxPS7KTecyEJhYPjfrFoB E3VO/Mj+Fxd67BqQAXe4SYWn0hgrcaEiHt6qQywAvVbgNummAaZJokW+NtnuzQQK1zojHzLVIB/ Rreh6QCfcvY4UCBROFiQTLMEagq/kYBwQjGJm1skDFLf+nhEeyLpYOKsrf5poqJJNLocgL8IYTQ rYhs/IHXai8jBfkM3bptKqF1psX/QplZ06wHWbUPaHWKlUvh2t9P5gAHWfvF6SvgbOaePsPvyun NmxeUFVIhrkWbvr4n9zbKBwDBiKxTEkOXBhqWChahf9uF7fdbevJgF5gSW4VV7lXC7Q+Q194WsS aSlghDUas+ZbJzMpYojiZnK7iHao/YloNqRIlXt2A8kf/zMYJOiM+sWgjWntWEOpF59kUn5/bEY UA6voqBt8hf4e98GkTMqkZTWx8twEInGfkvaA== X-Received: by 2002:a17:907:c002:b0:b97:a1ca:e100 with SMTP id a640c23a62f3a-b9c67951901mr190889766b.32.1775234642271; Fri, 03 Apr 2026 09:44:02 -0700 (PDT) Received: from otso.local (2001-1c00-3b89-c600-71a4-084f-6409-1447.cable.dynamic.v6.ziggo.nl. [2001:1c00:3b89:c600:71a4:84f:6409:1447]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9c3ca9a145sm213492566b.25.2026.04.03.09.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2026 09:44:01 -0700 (PDT) From: Luca Weiss Date: Fri, 03 Apr 2026 18:43:47 +0200 Subject: [PATCH 1/6] net: ipa: fix GENERIC_CMD register field masks for IPA v5.0+ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260403-milos-ipa-v1-1-01e9e4e03d3e@fairphone.com> References: <20260403-milos-ipa-v1-0-01e9e4e03d3e@fairphone.com> In-Reply-To: <20260403-milos-ipa-v1-0-01e9e4e03d3e@fairphone.com> To: Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Alexander Koskovich Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775234639; l=1275; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=wVWwdatovjkVmj3hE2xttOnjurwQ7/UkaxiXvhYrMnw=; b=6f7dlNEqx/WgDEZTogxKVUxQuHWi4Gkbilt5KzzC4a4NlQluDwn1CvyiwdceB4Yn7NRmtQsWP oYcEdeFiz8oClMj8bu54iIa6PvIYpJRVe8H7ObjLR1rRgq5uRxrnorj X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= From: Alexander Koskovich Fix the field masks to match the hardware layout documented in downstream GSI (GSI_V3_0_EE_n_GSI_EE_GENERIC_CMD_*). Notably this fixes a WARN I was seeing when I tried to send "stop" to the MPSS remoteproc while IPA was up. Fixes: faf0678ec8a0 ("net: ipa: add IPA v5.0 GSI register definitions") Signed-off-by: Alexander Koskovich Signed-off-by: Luca Weiss --- drivers/net/ipa/reg/gsi_reg-v5.0.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ipa/reg/gsi_reg-v5.0.c b/drivers/net/ipa/reg/gsi_r= eg-v5.0.c index 36d1e65df71b..3334d8e20ad2 100644 --- a/drivers/net/ipa/reg/gsi_reg-v5.0.c +++ b/drivers/net/ipa/reg/gsi_reg-v5.0.c @@ -156,9 +156,10 @@ REG_FIELDS(EV_CH_CMD, ev_ch_cmd, 0x00025010 + 0x12000 = * GSI_EE_AP); =20 static const u32 reg_generic_cmd_fmask[] =3D { [GENERIC_OPCODE] =3D GENMASK(4, 0), - [GENERIC_CHID] =3D GENMASK(9, 5), - [GENERIC_EE] =3D GENMASK(13, 10), - /* Bits 14-31 reserved */ + [GENERIC_CHID] =3D GENMASK(12, 5), + [GENERIC_EE] =3D GENMASK(16, 13), + /* Bits 17-23 reserved */ + [GENERIC_PARAMS] =3D GENMASK(31, 24), }; =20 REG_FIELDS(GENERIC_CMD, generic_cmd, 0x00025018 + 0x12000 * GSI_EE_AP); --=20 2.53.0