From nobody Sun Jun 21 13:59:59 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA72E175A6E for ; Fri, 3 Apr 2026 12:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775217634; cv=none; b=cQr5xhnkvS0W8PKMgiGXf5pyop/2+z2rSXPnKirjG+A3+nfCqio2dNE4HyBj1iex9drFmp534QKg1ANiHV+kat+Ok842Sts7Pifuho6QjmJGbQhc9erp+QcMJ/O7T3/Zvqzc/ZOsAype1W4i5BOuCChFqONaZ3yrYtSs0m8+sbw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775217634; c=relaxed/simple; bh=UUaHSx9UwNftr+A/xRgyf4A3CKUAZeQm+LUEO0i9hr8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=FY9EJAMEfnFRIGjRH1d5DUATeZ6+/DaHPHCEfDoEtDczZ7v9/iGBURtwZvIRIhccb9BvSoPHRmOhX0WV7joJZs4oUHq0uqEKbhzT+H/Pp2C0+iWu4EOXAi+nwJaCuGxz8uXjZYfpNKT/iRYkf8Tj8p8HlBhSlrvEeHVopRLcrAs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FTnDNmYE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FTnDNmYE" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6DD93C4CEF7; Fri, 3 Apr 2026 12:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775217634; bh=UUaHSx9UwNftr+A/xRgyf4A3CKUAZeQm+LUEO0i9hr8=; h=From:Date:Subject:To:Cc:Reply-To:From; b=FTnDNmYEHuGlu/IzqKTLBW41dHDfKgeA4f62JAXgZ9gLiltvGY5sm1HKr/4wkJORE W7K2wgFEz4Z2tKeYIHDF+N5hcNzU+jNy2d6bsXMznIk4mDeAnmpJfjS7/BTa4hqbvE zxc0pKV3iwX/5XQmG9O30zVHKG6bCXErpDl0U5Knd7dYVIjtK9eD5Ltk31M3RSoNJL ERx3egS5xpiHXKoalrlH9BQ+Pz+x2OQ6POs3gOwCx1+TNhWQz5kwK8sY9fVEghI4fm 7e9NzDDdxg1wWHp2wTSsQZcaj4XzhgSk+hc3eKOaHe6Cu7974VbEeT7TdyWViYYhG2 StysP9EdZfSoA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D4F6E7E36C; Fri, 3 Apr 2026 12:00:34 +0000 (UTC) From: Shivam Kalra via B4 Relay Date: Fri, 03 Apr 2026 17:30:26 +0530 Subject: [PATCH] drm/mediatek: mtk_dpi: Open-code drm_simple_encoder_init() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260403-drm-mediatek-opencode-encoder-init-v1-1-7be86241b876@zohomail.in> X-B4-Tracking: v=1; b=H4sIANmrz2kC/yXNwQrCMBCE4Vcpe3YhNiEHX0U81GSiqzQpmyhC6 bsb7Wn4Lv+sVKGCSqdhJcVbqpTccTwMFO5TvoEldtNoRm+csRx15hlRpoYnlwU5lAjeR1myNLb eWg8XXEqWemhRJPn8T86X3fV1fSC0X5m27Qu6nSeShgAAAA== X-Change-ID: 20260403-drm-mediatek-opencode-encoder-init-36336e4c4ff3 To: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno Cc: Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shivam Kalra X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775217629; l=2101; i=shivamkalra98@zohomail.in; s=20260402; h=from:subject:message-id; bh=9DjXSfOgfUU5yg/kiJD0QlllCcJ+4tIybh7zqyvb0Gs=; b=CrHLxQL+7xEDYiixoSol8OG9gkFNY9o81VC5AbB67EE257gn+LlkpL+BZzcJKQZPavGvGk+Bf t59unbL8axaCODm0YSBCBgdyugg5VYLhB8fx3mf9gsqeuXShXgfhmcW X-Developer-Key: i=shivamkalra98@zohomail.in; a=ed25519; pk=U8kQSxcte8P8iZ6zB7phIj+Yl+i/5ntifBGuclgypx8= X-Endpoint-Received: by B4 Relay for shivamkalra98@zohomail.in/20260402 with auth_id=716 X-Original-From: Shivam Kalra Reply-To: shivamkalra98@zohomail.in From: Shivam Kalra The helper drm_simple_encoder_init() is a trivial wrapper around drm_encoder_init() that only provides a static drm_encoder_funcs with .destroy set to drm_encoder_cleanup(). Open-code the initialization with a driver-specific instance of drm_encoder_funcs and remove the dependency on drm_simple_kms_helper. Suggested-by: Thomas Zimmermann Signed-off-by: Shivam Kalra Reviewed-by: CK Hu Reviewed-by: Thomas Zimmermann --- Addresses the "Open-code drm_simple_encoder_init()" task from Documentation/gpu/todo.rst. --- drivers/gpu/drm/mediatek/mtk_dpi.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/= mtk_dpi.c index 53360b5d12ba..5b83ca6aecb2 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -25,8 +25,8 @@ #include #include #include +#include #include -#include =20 #include "mtk_ddp_comp.h" #include "mtk_disp_drv.h" @@ -993,6 +993,10 @@ static const struct drm_bridge_funcs mtk_dpi_bridge_fu= ncs =3D { .debugfs_init =3D mtk_dpi_debugfs_init, }; =20 +static const struct drm_encoder_funcs mtk_dpi_encoder_funcs =3D { + .destroy =3D drm_encoder_cleanup, +}; + void mtk_dpi_start(struct device *dev) { struct mtk_dpi *dpi =3D dev_get_drvdata(dev); @@ -1026,8 +1030,8 @@ static int mtk_dpi_bind(struct device *dev, struct de= vice *master, void *data) int ret; =20 dpi->mmsys_dev =3D priv->mmsys_dev; - ret =3D drm_simple_encoder_init(drm_dev, &dpi->encoder, - DRM_MODE_ENCODER_TMDS); + ret =3D drm_encoder_init(drm_dev, &dpi->encoder, &mtk_dpi_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); if (ret) { dev_err(dev, "Failed to initialize decoder: %d\n", ret); return ret; --- base-commit: 4b9c36c83b34f710da9573291404f6a2246251c1 change-id: 20260403-drm-mediatek-opencode-encoder-init-36336e4c4ff3 Best regards, -- =20 Shivam Kalra