From nobody Sun Jun 14 12:45:30 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB4193B8D6A; Thu, 2 Apr 2026 23:59:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775174370; cv=fail; b=MFzDIb/W+SXEjpkP3XyWmLv1Vid9NzwRD7RiXLtQ3xHHO4d4KGDnidT12ZlNb9FArx18u3BMxv70JPUHtees7f16Ax+h8Id7Iaky9prn4aT9+DsnPjheh5lKz8dC0SvBSHRm6jeitDsITXIs8MO5bxka6py4zCebr4h8QBDtL0I= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775174370; c=relaxed/simple; bh=geopkyWbceSmNN9qSVPgURie3vw5eMbQizBVsAgdPD8=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=kwfgxjyHIXQWBw21y/egEdoPY8ho9a4CJuFRpBaF27QGsi22F5shB7JfHbOig624mLgivsvZMdf4xkl9dgcXyFtG+ygJW7CL9k/eFlrJu+SbP3LCSQfiL1reVjuVQIz9XrHPNVB36OCrY1H43mF0Q2a4RV503/Y7kmqJkWU8CgQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=Ldnord3o; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="Ldnord3o" Received: from pps.filterd (m0134423.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 632HotIj764424; Thu, 2 Apr 2026 23:59:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=cw J3OgamUWGqcBmtrsWeOdCacIKsHtAMcKoJYuPZTeE=; b=Ldnord3omab7Y/ybvr e6J+FH1TPv0w22rvg3ojnbB7Pmo/IQtjvRNQggS0uOztY2wt0USb5Q+PW5eqhCDo uNR+IY7AxeGpSnXZIWJbsO9eHvzMTc+4IfipuU2FkwJho7QstmSTPIi4uVg7uJC1 TfN1Hdgpxd42uiG+59KtdPixAKNvFHHJFsVVUKzJwjxeXjq97A0fMbADFsxKNun7 fCYtfRwQCAbhHgZQRHUsCQvGcaqF8sGt27fghobKDS98O5RH8VgMur6Ne79jXvvb 55HKhHKw9zNaZp0jeLjafNRfTPq0BDR2Gv1HJ3KSQCTIn2LypfKTDaj8pdZqAfIV ZGiA== Received: from p1lg14881.it.hpe.com (p1lg14881.it.hpe.com [16.230.97.202]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d9rm2ffqh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 02 Apr 2026 23:59:10 +0000 (GMT) Received: from p1wg14924.americas.hpqcorp.net (unknown [10.119.18.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14881.it.hpe.com (Postfix) with ESMTPS id 8D8B7801ADC; Thu, 2 Apr 2026 23:59:09 +0000 (UTC) Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14924.americas.hpqcorp.net (10.119.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 2 Apr 2026 11:58:38 -1200 Received: from p1wg14928.americas.hpqcorp.net (10.119.18.116) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 2 Apr 2026 11:58:37 -1200 Received: from p1wg14920.americas.hpqcorp.net (16.230.19.123) by p1wg14928.americas.hpqcorp.net (10.119.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Thu, 2 Apr 2026 11:58:37 -1200 Received: from BN1PR07CU003.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 2 Apr 2026 11:58:37 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=idi7xK30nP195qIZB9YCSpLblvK3aVzRt6CkTFTD/rHmaZ5ZBoNWcZi/MJY/Xq8aogvp+X+4YQHUlERemJXs4Hxl2SKrev9IIAwkvzW/OFI7qwBjjooFRaeuP9NihvQIuWaiKx+3+2QXz2HFiGoMY54RgUUFP2GRZACA/tEdIH/AKmHcKBeNVtowQPQBojyDZgFOHfO/EpSrfsnBqdZ3pIpkpPEyCIHI5vS6jUOXVEj3R2wwUh2Bk0Umtsb/p5HBoxUEESXaKQXuATe6LpEk3M9Hxd57Qb2jyv9XugQGY99NtAYL8J67Vgvpro98fgKxH+qEOhUDPPxBVqWBF+2anw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cwJ3OgamUWGqcBmtrsWeOdCacIKsHtAMcKoJYuPZTeE=; b=bwVQojMEc+nfL68OfrBFC4qbaybFB6wBxm1/nuY5rX4r1sQ4L9BHYNbBpEyuAmAY1M66+Kuj4HTF+/A4hq4me76/ma8kn9iZCj2GlaWR+xD0JCN1YEZ/aTKpzxctYCPUHpbz3mEg4g89QbDEYBseTXpTuQO/dEDvCaZNU1Nwntwn9kKI+W1cUITmForYrW7aJBFd6RdFGK3dOdMRVaHlijAKQ8hHlFTad0e1Yh9j4T9zecw4Tp5WvYKgwKkdynvEacER3X4ejVKm4WSBBRuXqb2m+aQlCzrQjbPIRBNPKIvMuQpNrnq9jQri4ynJVBSgcr4WlxKRc3fwLFW17gQJnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by MW4PR84MB2258.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1b5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Thu, 2 Apr 2026 23:58:35 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9769.020; Thu, 2 Apr 2026 23:58:35 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "linux@weissschuh.net" , "cosmo.chou@quantatw.com" , "mail@carsten-spiess.de" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH 1/3] hwmon: (pt5161l) Fix undersized buffer for i2c_smbus_read_block_data() Thread-Topic: [PATCH 1/3] hwmon: (pt5161l) Fix undersized buffer for i2c_smbus_read_block_data() Thread-Index: AQHcwvycAnvFBt5rqUaiYZvTdRd+bg== Date: Thu, 2 Apr 2026 23:58:33 +0000 Message-ID: <20260402235819.86456-2-sanman.pradhan@hpe.com> References: <20260402235819.86456-1-sanman.pradhan@hpe.com> In-Reply-To: <20260402235819.86456-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|MW4PR84MB2258:EE_ x-ms-office365-filtering-correlation-id: 6984e955-18c4-452b-cd4f-08de9113c075 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|366016|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: 7ZGKEo67FgCHW0y6FTt6CICXxWN9ilwM+hRjHSIBKJcvKko4ULlA1VaumLNEYOIJ26uEsdx6xvYmQWBD+nrhnn2QGzd2iRqosBnpSLfIY5kdsXavopfmsGQuKq5E/Fq7ecmvqefOz60FRLMSicUYpQ+Y2EPNXFt8dVUgeUhxxNCpoa4E9K7Bo7aCEyuUywWLk2AzqwK3iAqBsGviK72SIQRg+WKygH/G8P0T73rQwhhAYyQZt/PY1Xqd3Ned4mWNHDqO6W+lBvcMOGhm0guWmjtKVoX5teRuyvA6gH3wyXF747WUFOIjn73NPqtDQzNn89QFkvWm7vHzTfnDxnIU/SDwWMw1+BeKivwKGNumqLxBAORKmSG2I4l+aK3nYMCOutmdxJHcm2ItRk2wmPqfribJ6sTtM7cc5PARyS+LllEyRPfd4eqfJz/lrh/f6IEN22IXSk+lU/Ct1Q1X7rrFvpcQAUz38NaMewfia5cK99SYVZveUiFhKCFilpR/eK4MfnmVQx1aY+HM/UquNWKcgp0RL3/fkb14whbE42rRoXCzPWXW2OGu4BmXwVi90NV2e9VgC3vGtvixgdahBDWzsa9CZiluQgqliaxlarmUEZPj3+zprIla3PU8DiEPeHWCciCxJsjOvAg4sF2ra6xKXsj8IyN+rOcUTL/XzIProGkCBx6QzvYDZoD8H8Dkzevz1rfKRrnSG5+Ey4MO7iPSERMVPNF5afh+km4CYQTMdZ2L2DSPyGd1EsMhhAinqUD1KuQ3M8VL2rUQIsUwlWyd1tSvZiTod6x8e3NidiO3uBo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(38070700021)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?D9W6t5Zb4EG4ex/NoIkUCisPhh/+y+2ugesYdHTxRhyUbbi/+gxoNzXEFu?= =?iso-8859-1?Q?SHt3AzdcLxD9DdTgmPnkQ7qT1RvRBLKyPTAh/0AyQiJh3fopgUJUNJ+v2F?= =?iso-8859-1?Q?Lbta0AemKMw9Mwwv/W6x8P+OluQ3bFRD1ip58WywGetnlmmbsEVjmTi9K5?= =?iso-8859-1?Q?4EXxQ5N2Gi4dYFZZD6cjLEYA/SnpMnV6RZMfvk1MdEQqkCWeba8mbwAyyq?= =?iso-8859-1?Q?K+j8975EW0ycYc/SNIylismpfElaNV0iDAW3TVmZJA41U/pBO4cuYgUZGJ?= =?iso-8859-1?Q?YfcLJMeOlzbdhu9bjbJDrAxq9MbsIKAmuzT+ZZA8CuJkn7qm1KFqwLxm0Q?= =?iso-8859-1?Q?8AaZM1dqgdYcbCHbVVqYiyPhCKU77uXemf1LftcTrhIVSm7NuZ1tlM0yuq?= =?iso-8859-1?Q?aDnhGptsKMadXQKwHSGGiZ0v2WK3Y0EBloUXCscBmASd/ZrdMa0X9rzQD/?= =?iso-8859-1?Q?IfvKnyx1zOOqf/tG8hgf3E/eOuUoJqqyQuY7DiJSVakToZMkS1cqcHHMN5?= =?iso-8859-1?Q?PCmXVF8zuqljvNMhiU8Qn0SG3bVsa1hm+2Bizisx0nRcpvLpIthJEfz3LL?= =?iso-8859-1?Q?4GhFUNzKOEKjh5uyrSWSiA3ZdlQuUWkEbiKRIVHNDcH/nh0BHBC4kydnY1?= =?iso-8859-1?Q?J9H5E3lnl8yOCt82HOubHn3YWAaF9lFh+MEZgKB7PUjiQ5cZ72kPcK6D93?= =?iso-8859-1?Q?iKxSe3xOpyeG2mObJ81batyCReYy3/uE7RZ8EqN3xjxnIas+scjGZ7qY95?= =?iso-8859-1?Q?Dubun0uZgmIDIWxemAO/HxwQ7jwgV8gWzr3eRFRhtZyWGXfe+emjVqw8BT?= =?iso-8859-1?Q?dtCgJg1FaOasrjeyFcjiVZhFPw0BWUi2z4Pq3qFLRTM829V9cTmkdfF+Et?= =?iso-8859-1?Q?P94jp88s9PFThk6droTdFMV8nFogECGtUZ/gFrmg5lOiF+geny6mDhkvz7?= =?iso-8859-1?Q?5sDc/cZ6avHgVAbsvlJrasrYAH8T/Li+s7uD6Wv37iQOtYYjn5Glo+llW6?= =?iso-8859-1?Q?img2UA1gyh7LgAKVTfu3V51Y0WNVKfVBmWh0EFxcUwAUHnGQ5+y86v56bO?= =?iso-8859-1?Q?oozoKre9tf88fKz18XTiln51MY6jZjYIGVO8b5pw28siOYEw60WLiJZSzh?= =?iso-8859-1?Q?6FGTGfDzTbpuW6/HkyRmLnbEC3oIqevUOZrTtcvqEtgvg0NgY5/NNbbxTu?= =?iso-8859-1?Q?sDIA3FWR3tCGoDkqbvwugLobyi84ioUSoekjAKqjUkGONLwbh/+uQtOhtM?= =?iso-8859-1?Q?Ur0xlJw8eIltbmVeTQLf/rnruHFRbrYAYCCPH9/TK5yLVZoU7GyksQ7kim?= =?iso-8859-1?Q?w3yKZSDzqzm5IG3OYawMGc7Voh6wmWz5Fty59aMjNthF6EEYEkwXrYjNvh?= =?iso-8859-1?Q?DVTmLSrwpxAc7y9WdAD8a8EUMRBAfayC5N24h6mYfkmiSUhj7IXImGbfA6?= =?iso-8859-1?Q?7YKuSrRRHSEbCYNfzuoYmY2tdOJNPqhPw5Y+AAZ81aKllibd6pYANZv7u2?= =?iso-8859-1?Q?qrqehouLlHgG3w9MPSVY/4c/oDU2YsoxELVSHYGfvQSM9sCPyglxhPs3eg?= =?iso-8859-1?Q?TRAndQU9WIYDahSJEwJSoj3Vm89/G7/roq2RnGNUcHcj902Gdi/sF8U4Wo?= =?iso-8859-1?Q?at9LoHfAsMeYOH/etZlDz5IpdmUD//oPEeGneozauxXKAWsrhSdoY6WFI+?= =?iso-8859-1?Q?waQwx8idAMm3XNlAZ9q2LT3GQDqTvDXjV6VAk7V/hp35KnIr3G5FeC6Y8K?= =?iso-8859-1?Q?DHp3X64CywWxDldXCqWW4gxlhs+VoRUF7w17RfD7cyIMYR?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: lhfqGVVN1CvuH8363Qqo/hh5+jVnqhqdiB39DwCUk46pvUNfstidd1ggXtQNwTRepgo/LrlTe6hi4T5kdsu79bKXLFhgdW4FtgtcKjvAlW+bi1P8FIXihplLh/o5Y1Zt7L1mxoVZkMiRRXw/qiD9j8JhiVhxqZmapEmo28almnEyXMYaXiYItDStCTdrNHKk8+JU2I+QzF0/njsymJuRNxxaSuu7V3ESwuyxnGjYJCm3dZGtbQ90VIfGcuEFF+QCoHXV17VYxrLmXylhb5SrogWCg87tD1m+c30RrrwA6+/bPhl+482m8l+QFrfmCAKBUyffM+fcwQxRAGLYf073gg== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 6984e955-18c4-452b-cd4f-08de9113c075 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2026 23:58:33.5789 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HYYrjiBOhUD/WZg/7CqZDQTK9vEoiv1djTIu1/zrikpGyoirfrfwbzfBHijhfnTpKTP1cnCHWWbOkFtzisKvOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB2258 X-OriginatorOrg: hpe.com X-Authority-Analysis: v=2.4 cv=YNCSCBGx c=1 sm=1 tr=0 ts=69cf02ce cx=c_pps a=FAnPgvRYq/vnBSvlTDCQOQ==:117 a=FAnPgvRYq/vnBSvlTDCQOQ==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=g3u0LPWLDYfGfufhFw6-:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=psGTehlhpka0orpKOXIA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDIxNCBTYWx0ZWRfX/8N4z21QZ4op Umi1efJSJu5CbTPdfRYaeVGmNDp/r0a8odCVrpZzt5G9doC/8HYElPXPx/YHo/bfQXlmtCpYykx TKQYUoz2MWpBRdPQPv6vYv2gIA6J6JKUce/dS/sNcCsIF7ak4hq6eJ/9vTzuKzB+26aO5VZBkAm NAnVdTbI9yfhzFZ6DiatdFB+J3n/5+37CzETWM++RHdDzextkkqJziBJFJ3Ko3r3ddH/MTWxwtQ ZFfJcA0+np47Gewxjbua6XQHYq3L+PcihxxVFdzTaxY4hD4z9bntPp4TS+nqtQuNPAJbG9voU4l xD/x3hVAU0kiOk8fRSPhQMa5Oobf8Se4j3FYXtbhgTBNnFEk1DeJMcffEG1nsoRdZAy+Dc6c4ux FtTRBvbcFf/pEKeu00zT/5lgKFB7W3GeJR94C5QsYEOQ/pqozSlFbpCU3fFc3l9OA2wiqsW1HE0 EwuJCqpoRpMWx7Ivl8g== X-Proofpoint-GUID: xSYGxasV46Ekbj94QTpZr0PIolFQwDRV X-Proofpoint-ORIG-GUID: xSYGxasV46Ekbj94QTpZr0PIolFQwDRV X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 spamscore=0 clxscore=1011 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020214 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan pt5161l_read_block_data() declares a local buffer as u8 rbuf[24] and passes it to i2c_smbus_read_block_data(). The SMBus block read protocol permits a device to return up to I2C_SMBUS_BLOCK_MAX (32) data bytes. The i2c-core helper copies the returned data bytes into the caller's buffer before the return value can be checked, so the post-read validation `if (ret =3D=3D curr_len)` does not prevent a potential overrun if a device returns more than 24 bytes. Resize the buffer to I2C_SMBUS_BLOCK_MAX to cover the maximum SMBus block read payload. Fixes: 1b2ca93cd0592 ("hwmon: Add driver for Astera Labs PT5161L retimer") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- drivers/hwmon/pt5161l.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/pt5161l.c b/drivers/hwmon/pt5161l.c index 20e3cfa625f17..9c450bcb9dd8c 100644 --- a/drivers/hwmon/pt5161l.c +++ b/drivers/hwmon/pt5161l.c @@ -121,7 +121,7 @@ static int pt5161l_read_block_data(struct pt5161l_data = *data, u32 address, int ret, tries; u8 remain_len =3D len; u8 curr_len; - u8 wbuf[16], rbuf[24]; + u8 wbuf[16], rbuf[I2C_SMBUS_BLOCK_MAX]; u8 cmd =3D 0x08; /* [7]:pec_en, [4:2]:func, [1]:start, [0]:end */ u8 config =3D 0x00; /* [6]:cfg_type, [4:1]:burst_len, [0]:address bit16 */ =20 --=20 2.34.1 From nobody Sun Jun 14 12:45:30 2026 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C01E83B895B; Thu, 2 Apr 2026 23:59:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.143.35 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775174365; cv=fail; b=DgOQ9aKBfgfRjEP6EMLGoej+sU6802SQRHTFIpEpRQb+8tswWxJk8BfyocF+BjvfILB0pYR/MKBjlU/WFM+vqdIxL6t9ROICcL/zcW+b9vt9LcX3AbVFFUAvkxqoZKpoMEd+p1kGyZp1GyQfNhlbybjmWlH9PGHOrIC/tiSqujE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775174365; c=relaxed/simple; bh=M9TGPwijrHORIBKSB+z4KblUxEv0/U/CBZFKcAjY4KI=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=bCnWU2C6v+7HE0ys3dhxdrRQTcaPzUa6vpX3EFA1lw6TIKh30X2CusXyOP0yKe4DrMEjGj/5Wm4lGvI5dvHahhx4Dbr+Xkt6dKmNyVocU5b0z+FYbrOnxNDGz6WPfr4dxdmFH0trHliPqyINgh4tYcxUDDVNmucvKKpJnMtbVEU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=ZP79Rsqd; arc=fail smtp.client-ip=148.163.143.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="ZP79Rsqd" Received: from pps.filterd (m0148664.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 632LW7iv2214621; Thu, 2 Apr 2026 23:58:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=fy qTldiIbUN/1zoH776sOdKowX/EmpgfZ+AzWPnWBJQ=; b=ZP79RsqdFDaQAxZIrk EbIVS71FKiLAeYzuFXqU0Zn68JNfRUVl/jT0JbXXR0kkXfu8EjA0gXPHaykpmrid litdJV9xaJw30l59XEbVOEmiU5HNl95iN10byun/Wl+UgsBsrTOoDoIbR4QwTtn8 fKeoHNmbY1WdTYlHKffiO5L974eGOC/ckM1eLZd/B0WD6C1BWICWRSz0lvfhl5Y7 ZZjrVx/ySYv/4hYZEK8scl8Mj2CNGUIIa4VolqtOVbK8otDtRenMyZmWGacq5OwV CDbuNAAI8srpp48vkNOIDiNc+gVxXZV+rPpcNe/r3CCtURF3psVi53xk4auHO1II lqlQ== Received: from p1lg14879.it.hpe.com (p1lg14879.it.hpe.com [16.230.97.200]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 4d9snxpj46-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 02 Apr 2026 23:58:59 +0000 (GMT) Received: from p1wg14923.americas.hpqcorp.net (unknown [10.119.18.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14879.it.hpe.com (Postfix) with ESMTPS id BA61E248; Thu, 2 Apr 2026 23:58:58 +0000 (UTC) Received: from p1wg14926.americas.hpqcorp.net (10.119.18.115) by p1wg14923.americas.hpqcorp.net (10.119.18.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 2 Apr 2026 11:58:40 -1200 Received: from p1wg14920.americas.hpqcorp.net (16.230.19.123) by p1wg14926.americas.hpqcorp.net (10.119.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Thu, 2 Apr 2026 11:58:40 -1200 Received: from BN1PR07CU003.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 2 Apr 2026 11:58:40 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EWgY9ZeqYkrb6rWt+F9Q/VWhGbYjWccdese9DiBZ1OArm2M54VqwgJlJRGzTr/RvoKo0crTNUgYcIiowUkCu7OHhqq/cf6e98UWHuoI+si5l3Vt3iJPUx6hlna6PMI/w2UQ698At0pxsMUrRG3SNMbppzEdbhuAzkYbO4vqZ2CUl35AbHMrep/b2e3BrcpVS9+p8ZjDjoTWkqlEJJ2PrjVOXiZ5p7JVX96AZheQXZwEwng8W58tC+8Q6o5coof4YTZdbWLWcHSL5vvZkOWpM/2DrW1ifaYVf14nbmO2d6TbaE7vomqdJzkGKkSN4EU2xNBLotEyyWEbNhA+0f9KMQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fyqTldiIbUN/1zoH776sOdKowX/EmpgfZ+AzWPnWBJQ=; b=LlhKCIJZaYr+SG5gWNx4epBiIubPWzkIkaPCNbo+e0UgS0ZPJjpsnZs5UZSj6at0FW5Nuw8f4JcgutR/JaHnwsg9Stqpt6HlAM2kemlWqGL+DC4OFAzv5BXRSj8QkocMKCyCIc8wXzLu+wM6wIOyFflpqoAc+D3YqMzZYTKl1n7wiiaaunnAnXFa/M05fCcwq3Fxkhk4AQ8cOQ57ZtBffkkBbfdmDipmOPkTVCpoUuAW1Os+Uq/N6cdoj6BjLpAQ/fqY2u8n578l0rbMkKAGHoilCSeKUli/O+gHnrKOlZJfH3bHujKh1XBIBFJUi38LtvofqVLeSqyaSNR1KTCFfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by MW4PR84MB2258.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1b5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Thu, 2 Apr 2026 23:58:38 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9769.020; Thu, 2 Apr 2026 23:58:38 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "linux@weissschuh.net" , "cosmo.chou@quantatw.com" , "mail@carsten-spiess.de" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH 2/3] hwmon: (isl28022) Fix integer overflow in power calculation on 32-bit Thread-Topic: [PATCH 2/3] hwmon: (isl28022) Fix integer overflow in power calculation on 32-bit Thread-Index: AQHcwvyfAyNxZAeCYkKubaBWqkT9TQ== Date: Thu, 2 Apr 2026 23:58:38 +0000 Message-ID: <20260402235819.86456-3-sanman.pradhan@hpe.com> References: <20260402235819.86456-1-sanman.pradhan@hpe.com> In-Reply-To: <20260402235819.86456-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|MW4PR84MB2258:EE_ x-ms-office365-filtering-correlation-id: 2fa05e1d-11c2-4cf9-3122-08de9113c248 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|366016|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: a/wSkY/XH0RHo+eFFILaAK29PYxljXb5/14oSAbYjCuom8pyTJjZmR5TaPmkb5HmRnHErk23hxzdTPocV5HzmFZyKfvbQ05KXkNmO25OPUvnyisTFaKcgaI3JXcjkOnNk04mdxnBzNirFB2cY7AADu4eybbY9TOQo+inY7n5m+2hRt6jL8nuwd/a/oKZ0993VCx8aSXsrQJR9DcLKcYSzAKs7mM9qepcgFJeozehpAPHi40WfAYCdVL1LxASk/IDKf2tKUBY37j9q6XxvrUYDDzV2vIgV30auBlbwbReWjBurC1cbsCGT6RI2JhaLJvMEOfK3JS3w+/8qSlg+T5NKPmWToj3/Mm2NmuifxR3kKg7xgBJlZt7vYTDc39ZurVww7/BOb+noVAKAoNTnx/qzTyWQ7ObuvCOUVWFOf1CnGJZKbFCz2GT+ER7wUudXAN+SS6xXRFFHYP8x0+s+6j6ueyk+vlQRy1FDNapoA3OX3YTU7OIX0CtY1EK1CsgpKgCj1XUZ5UVRzzO+YqlalVliIfVIsh50VxiO3nGI9YgntfbC1ef4or0zqdOBwlXux5FciFCzor7vwu/mKEQzgO5c1AL0qrPbe28uaKvd02J9iy+bOiIlDrqiOyuUEjoMCaEhm/6+kaESTyQ+rWkepaygVn0EtsD1dr2MIIrcR0a3QDAM9Vo/Rx2752FhbphgzGXmj8TdEczHr88y4P+AfFnaRxEFLehziDjseBQktnwA4NV70u5N3OAnFcWLcvi+iyedr4KdfArWVZT+ly4OKnevQC7TttAZoVZwwOHG6BMk2c= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(38070700021)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?jVQtaPyxO38i6OUw1XNLaR9Sdm5zqSbtO8M5/zguOnOfPaLQ9NmUNfc2B/?= =?iso-8859-1?Q?xIbgTB6VO9hQDtaaTbTEp+9+PMth806GQAjzn/Nqa1Pox1h5zNejSAwQGM?= =?iso-8859-1?Q?TFZbZfq/2VFLoNTxyRU9ESJbSsNKZ1Tdn1GyjRDh1rmobBVNOunqxWagCt?= =?iso-8859-1?Q?jlVqg8+55HpNmcrlHxkHxuGjBLFnkzRXS7bm7Qxwo8uXzt469RwOUIxwT3?= =?iso-8859-1?Q?DbbQzQqeUYVN3C0R8Zej0stbWyi/JqRfb6VuczNhKPmv5AuXSLDtjbmKSb?= =?iso-8859-1?Q?fjCGGg+5D7f+D7YHNP7wQc6bfh6uvHXpbxQjYyyYYL2a98oaFBabdwYOi1?= =?iso-8859-1?Q?sBrcewIFyXIDiRrnBPXej/cPAKg5Hkqghyptn1TXXhYQq9CXHx2G9+7Lmw?= =?iso-8859-1?Q?Hf4Gq0J5NIWQGUt7RHqEOcdP7mxtvv1yhhvX4D4HAt7oVhPVDmSU5yobn8?= =?iso-8859-1?Q?goRPdDz6k5AgV/xsik6Zik9/VP3ovO3zbaLgpnIp2Q8+HMtVzlKoYA/sVN?= =?iso-8859-1?Q?Xn1SvAaxTcudiP7DFt4CQh+BjkZELJEDGYeCyiSKTynjDfIRfo06ezIg26?= =?iso-8859-1?Q?H2H7u0KZY8uMjtYCA2EcTdyvv10+NX0BOI/yHKAghP8SOxsFHU2qHJCfMB?= =?iso-8859-1?Q?FyJU9nA0E3NvpeD8LVRDMy9jbccQii8iVu50VB/VrnqAKfn72noaAJsU56?= =?iso-8859-1?Q?QsfrIPEXQekLpQCwI8yMdpfJB4vm4yFQy5RKXw7FdAestcCj7448OWHloA?= =?iso-8859-1?Q?+Eq6FCTDBDzo6KpPLAgNzPmHA1oC0BxQJXr2WyspdaXhwaGCOPWYd/RXNE?= =?iso-8859-1?Q?M8Knz74bDkLX4GlWUXjK4to/PR4W0NGZGz7Z7HW0Vu/fzC19JqPKsbOxu6?= =?iso-8859-1?Q?XOTXtp9MMsH09UeDCDelCaVZntP9AyYV6atU+EGZ+97H/YbDuHGEkYlE1e?= =?iso-8859-1?Q?I6yaghlpN8A8TBQzHfOawk94CYprMGBNG0p0aJs76aGeZsJtspUR6xAXja?= =?iso-8859-1?Q?6vQmywnRZgTtgH9kqKa1cG6VzY3iln2/xd6rabv7nITagKNgtgJ9iDHyae?= =?iso-8859-1?Q?y6bJNJ+pnRnIJW3y2e4ILUsCh1vxlcYTlxmJnBrYuoWTh3Xiw6HTlTCLcl?= =?iso-8859-1?Q?B8d/a1C+Og/Dx/oro8kJyxFYuE5C0xAW7eAzhCmmhy7fELxJ64V2pNGI6/?= =?iso-8859-1?Q?7G9M3il9hiCO/2ko6tgBTrWggCCER4qVK/6hfnXI8j1IIwKlGLpFqziJ7/?= =?iso-8859-1?Q?qs31BiDZr32wN9Fq6Kr1sE0FMpvvM9J1sOXmGV1Sq4uewwvnY2imodJF5y?= =?iso-8859-1?Q?BC6JRrNkOjkLC70ENANJBMLbKXZqNGIN0x8ZXR0tsB6k2O+P1NKg4vk9qZ?= =?iso-8859-1?Q?iSLHEXqDp8rS51yM23gXyr9nBZbHab7JdBjQj3NIdjCbICSVNDoDa/X928?= =?iso-8859-1?Q?uNAZDVEqAf2eia7vQlqEn79KNtegqPVpSZH08pDWlUr3Q14qyafThT68qF?= =?iso-8859-1?Q?SeJZX4Xwwvw8ekVVYFHOdAb57I/k1AK56IvRNH+PYoiflLJA3N2dIS2EDb?= =?iso-8859-1?Q?hNP3JX6UPWDrlIv5U3pCqcoXJXLgnyp4v8V+BuGeRu1yJhpiXWhLY/e0hn?= =?iso-8859-1?Q?T5qPSFjDipM7PGBFMBfescBKKcNN4jFR/1E3K/FUF/jO8S79xzyqv+/HMy?= =?iso-8859-1?Q?1uuxYcPfQ40ay58OCXZTyh1fcEluPpFbZGFPTUOK5woixDW4XaJ7CGtPuI?= =?iso-8859-1?Q?Cl6WSkTaX9AJIHAYbvDMw+FIE5u07Kyyx/4grcPu54Nde8?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: hRyG5J9JguQJM04VsQSfIJaHI8GehfebI9BcziLIqxJm+t0GtA5Dt+gy8Ekn0I4oSPN19cCAxBKebeI8RWbsk/dN2feCRZoxv7BsdMXtUftDHnRHT7MyeMcESeiWzTSuUoLxmkL3aHgh8JlB8znENF6rRCoTtGpMwPfCUBhmritaljRCz1uOAW/csAUPlTEDzyyyTVFJrhOLTtKRhZ8jxpPxx8fduMdUIJ2xF1aSKGo/bArTiRuvE8a4ci93U/0lnkgfl3Ve1sfhLxXsQK6NzN9jiCdNV8wGFQuLQCs6pR8wM/p6uSNEOfX5GHEGfzTbtiUM2aSZx87SPfxxLj/LFw== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 2fa05e1d-11c2-4cf9-3122-08de9113c248 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2026 23:58:38.2615 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kNAs5D2R43/nGSyMcW5YJSusodLn7AqjbIZ91vnv6m4rQLYPwWohjv+yMcOmVtdAzJEHJBkeH39jxuNf8ciUOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB2258 X-OriginatorOrg: hpe.com X-Authority-Analysis: v=2.4 cv=dLSrWeZb c=1 sm=1 tr=0 ts=69cf02c3 cx=c_pps a=5jkVtQsCUlC8zk5UhkBgHg==:117 a=5jkVtQsCUlC8zk5UhkBgHg==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=NCWKwCw8Xy9Og0ibBRsL:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=kT2SCdrF01qjGp29COUA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDIxNCBTYWx0ZWRfX+1UTFAO8B24M uTclRzIWrKFFkqxFVk06LqcpxmrouTfwiYlwrI8timeIRQS4mR+qTGOHru9Pq62VHtEONF7AmRD wDc+xmOqfxxTMwqoSPepinDZy52CaM9BXgLBO0GQu0K6xAZ75pY4WoeKPqrIup94NKQzsCafkIt rm3YMsAPEGfyUa9xU2aZ5l0kBOeqE9/s2qZBCnMON4eTeLMst7crfEAShjFtikThDHZcIpkqOTx cNVIOlwc5yuXRy6pwFSLE9ciMbegf1Z+VO61atmFqtYULJ4ckPr9I1JBkKkq9anmwh0+wy51/12 h7FkKTAXMZfBw/FjHN774EvLZuK8qjOr/CKgm1JnFtpZP1i5Z3ooZM76BIUtyD96Kk5MH0hyU+3 Ynlwug322s0G3pYnBpZ9i3/zJVIecK7iP5RQm8eSxiiNSZN936zmoZ6xdfux+mRTXTNh1yHWKO7 E3cnWxfA5CslvyTt/3A== X-Proofpoint-GUID: J-gEFi9ML7_zZFbuYec7SgnmZhYXKTNN X-Proofpoint-ORIG-GUID: J-gEFi9ML7_zZFbuYec7SgnmZhYXKTNN X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 clxscore=1011 phishscore=0 spamscore=0 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020214 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan isl28022_read_power() computes: *val =3D ((51200000L * ((long)data->gain)) / (long)data->shunt) * (long)regval; On 32-bit platforms, 'long' is 32 bits. With gain=3D8 and shunt=3D10000 (the default configuration): (51200000 * 8) / 10000 =3D 40960 40960 * 65535 =3D 2,684,313,600 This exceeds LONG_MAX (2,147,483,647), resulting in signed integer overflow. Additionally, dividing before multiplying by regval loses precision unnecessarily, and division on s64 requires the math64 helper on 32-bit platforms. Use s64 intermediates with div_s64() and multiply before dividing to retain precision. Clamp the result to LONG_MAX before returning it through the hwmon callback, following the pattern used by ina238. Fixes: 39671a14df4f2 ("hwmon: (isl28022) new driver for ISL28022 power moni= tor") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- drivers/hwmon/isl28022.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/isl28022.c b/drivers/hwmon/isl28022.c index c2e559dde63f6..5d4ca1f5c5839 100644 --- a/drivers/hwmon/isl28022.c +++ b/drivers/hwmon/isl28022.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include =20 @@ -178,6 +179,7 @@ static int isl28022_read_power(struct device *dev, u32 = attr, long *val) struct isl28022_data *data =3D dev_get_drvdata(dev); unsigned int regval; int err; + s64 tmp; =20 switch (attr) { case hwmon_power_input: @@ -185,8 +187,9 @@ static int isl28022_read_power(struct device *dev, u32 = attr, long *val) ISL28022_REG_POWER, ®val); if (err < 0) return err; - *val =3D ((51200000L * ((long)data->gain)) / - (long)data->shunt) * (long)regval; + tmp =3D (s64)51200000 * data->gain * regval; + tmp =3D div_s64(tmp, data->shunt); + *val =3D clamp_val(tmp, 0, LONG_MAX); break; default: return -EOPNOTSUPP; --=20 2.34.1 From nobody Sun Jun 14 12:45:30 2026 Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B64513BED24; Thu, 2 Apr 2026 23:59:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.147.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775174369; cv=fail; b=LaS7XwsxkI3uunM+diIL6n4jUObfMR3kfswTzEbfBIceUqm0aiKUQ16caaiLPndAh4IeuneMtzSgmwOqy9nTC1/knRmuB7Hw/JR4uClkGB269dr2Dm7cYwBcCibEOiiYIAZweiKX3pMNie5LTYOLORjD9xTHVoKQgOIMyHJM72E= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775174369; c=relaxed/simple; bh=NF30B6n8xdo5n9FxDALWf+uF1VkkMct2HPGnBBzi/Ig=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=AYYtPqN1y0jPMrae1QDpDaCfIuEqqZqf8txAr8sfqMklrobYsa5/wJ6yBJhZBF3JmXBnli+OWnJUU+h6TOnGaU8B/lu3Yp+0a4UXysfs/QtfaPUrL8OOmgP8fDP0A9Nws98aqphKuvCZatQLs0eYUjeGqcRsHaxrIONsBBCdMe0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com; spf=pass smtp.mailfrom=hpe.com; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b=lHiHgl2D; arc=fail smtp.client-ip=148.163.147.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=hpe.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=hpe.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=hpe.com header.i=@hpe.com header.b="lHiHgl2D" Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 632KWbui3042183; Thu, 2 Apr 2026 23:59:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps0720; bh=lM oFBFzE0CzU6RItU0IMWkKCh5a0aQyBVWM9UZghxVE=; b=lHiHgl2D5yyFMHowdL Ik2jH+JfIAOE5ThFfgCBGJX17coDkKrwUBk8V31ooxU1bYTGEehauhXdjqm0sV6R 301kkCw4zXCc7/Grow0lwEv3mEyoDg+WwAJd4Mil61T2z3tSG1QbAxuarsDR19yg KZjSsCyq05DsOn00bdzSJ01vU/xbvOBivvOjamTnLTO2805vh96OCZ29H5piU3B+ SU9qSz9Qmu1RfV7hBXOVsk4oMkRkXsdD/hKWgQOsIO0qvfqOj5EAEzJPa4krxf0v ZmTB+LUlLsU1lXXWxqjWmxtGaTuG27xUv5sBu/vXPr10K7lEVjL28CCJswj22g77 8xkQ== Received: from p1lg14881.it.hpe.com (p1lg14881.it.hpe.com [16.230.97.202]) by mx0a-002e3701.pphosted.com (PPS) with ESMTPS id 4d9tjhnurh-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 02 Apr 2026 23:59:10 +0000 (GMT) Received: from p1wg14924.americas.hpqcorp.net (unknown [10.119.18.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by p1lg14881.it.hpe.com (Postfix) with ESMTPS id AAF7D801AD6; Thu, 2 Apr 2026 23:59:09 +0000 (UTC) Received: from p1wg14926.americas.hpqcorp.net (10.119.18.115) by p1wg14924.americas.hpqcorp.net (10.119.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 2 Apr 2026 11:58:48 -1200 Received: from p1wg14919.americas.hpqcorp.net (16.230.19.122) by p1wg14926.americas.hpqcorp.net (10.119.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17 via Frontend Transport; Thu, 2 Apr 2026 11:58:48 -1200 Received: from BN1PR07CU003.outbound.protection.outlook.com (192.58.206.35) by edge.it.hpe.com (16.230.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Thu, 2 Apr 2026 11:58:48 -1200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ecmsSvAEnxEwCbaAfhv/OiVWUejmIXgoh6Yv0JwhKAChUbR1G+z3ZgFmDPahXaxYZcgFlOrSxUkjCuvPQWrWNtw2S+XumajwYMS9zvWQ0OVA4WjbbKPwChs461w2Cgu9j/zCzdSJk2ICr7hj8j//Uv/wTUdE3Vw4Gg/SUfrwp3Bci9mjcIaGOZeF00hcPdvzJe259r6C8mWCeqmnGM1sp0SDNmoNO2GC8qrVddDw/Mhhuy4ZWUuzp2u/ELuFlLO2V6P/8JmjCOAbmwP27LWTithsNr3TQJWT42qVLWOIhEOeyqxFohcS8jd6//zQlqkwwKQW5TVrqpZbYLIt34JOJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lMoFBFzE0CzU6RItU0IMWkKCh5a0aQyBVWM9UZghxVE=; b=KFadfdS8q1osM4VHgTwAHXZIgaqamfIEM2NVV4qQduIyJtQMoDhqTrdZZRndPO+RtLdgaOblSvDt/y7noP0rGIia/63pZDBguBxPi8/nn2+ighlhGmoxFv6tqmBQJZ2cTUPuvt1YH8nwmEVfLcCt9dXtDvKobiOrsRCyoY5b2lM9o9FyRVLhZjVjJa2HdQqWdFefjel8F5FBapwmFGNHExsncOKVpjPQ8rqGVTEmJFs1oJMRWzjZ7jkDum5Is4iROsik9eTBLrwLuuOK93baO6OBnKFX0poINLbZ3OJQYDJzjMh2HorevZOZvjy4uCvvf414Un4AfpfMWQcjW3m80A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:610:1cc::7) by MW4PR84MB2258.NAMPRD84.PROD.OUTLOOK.COM (2603:10b6:303:1b5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Thu, 2 Apr 2026 23:58:43 +0000 Received: from CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f]) by CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM ([fe80::2c54:3534:122f:e74f%4]) with mapi id 15.20.9769.020; Thu, 2 Apr 2026 23:58:43 +0000 From: "Pradhan, Sanman" To: "linux-hwmon@vger.kernel.org" CC: "linux@roeck-us.net" , "linux@weissschuh.net" , "cosmo.chou@quantatw.com" , "mail@carsten-spiess.de" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: [PATCH 3/3] hwmon: (powerz) Fix potential use-after-free on USB disconnect Thread-Topic: [PATCH 3/3] hwmon: (powerz) Fix potential use-after-free on USB disconnect Thread-Index: AQHcwvyiYtIhg3IYZEuE/MdgjLqehg== Date: Thu, 2 Apr 2026 23:58:43 +0000 Message-ID: <20260402235819.86456-4-sanman.pradhan@hpe.com> References: <20260402235819.86456-1-sanman.pradhan@hpe.com> In-Reply-To: <20260402235819.86456-1-sanman.pradhan@hpe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH3PR84MB3523:EE_|MW4PR84MB2258:EE_ x-ms-office365-filtering-correlation-id: 8304f9b8-aa70-4143-fad9-08de9113c536 x-ld-processed: 105b2061-b669-4b31-92ac-24d304d195dc,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|1800799024|376014|366016|38070700021|56012099003|18002099003|22082099003; x-microsoft-antispam-message-info: CgqaQ8BWYEWJcbd9HYeg6BdGLm2UxSMD+PkV2GzL2kumtnqO2UXuCQeyQ4RZWhvfNpqvkRoJwLgJExkOj5CDdFEVY3sqxAs6n2XZaloIigxrr0hzDz2UKl3y+QM4k7zKgt3w+99YdQp+V3B88uMHENAXWQCNozLRgbilus69WrMIWAVrjiQ4aZFTyk2b47uVRfe90ZaAEph+UbYPd8p9k2GL2KBHr3dsdNKzQ00BRDR8Zz3MeFIV3eSwqcw5GbSxOvuzeSpzibzDqpQYiGQtaWX/x2QVrK9RgDF3xnB28iLBpOf0kPCUJ5GOuiEytJvJ37i40BGZD4ZdqHR1ZpjSf/oVy3Ws7/mpSCa90q1JPjbTSxn4/a+MS0kIeeKxw9X/DHWW8bkLwTLaL7UAT5mK7nCd5ZTOvs5mUCrmucZGZ8xc9McyL7Ln6zFD6CW+9SjApNy3BLeRhMQDL5t9LK03u9etB6/rspDYulcG003TrWhK/MCz7aTBYZRJmltWUL2pnK2oPWOTRROHciitiylQSPdkgaqDlfMtx8XqCWiglCGWjH5q0gedu6QTlGsBVBUFfIZogj9vXchIU7N7ycwzFC3EbQGGoMCyEqrr4KJSiVeMf/lotNEqJ2+P9WHWxe9lf8cMwrWJ1zyc6hlGRUm0FJwUIKi2G3xIBOi36MWNg03OkeOXoy8Bh9dPVN3AENnPR5M/4m9Fh/RJd0I3+3SuKe4CoDNhb6o20gZb475UbxJrK6bk9pH0s3bqfrZCTDVcMslt/L+RgeogghV9LnRZADoUylIywnZ//TvyYiJR8n0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(38070700021)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?M+L7xp3V/1lch4fItt63ai6zXauqcoWPXiepwcTIDJ9RpaEXHGZbc1EEww?= =?iso-8859-1?Q?l7BqupEAWgwFdJTxklHpgXg6uqwr/eCPS/mLSKiqLRIu3zD4W28vgQ2zrv?= =?iso-8859-1?Q?Y/kWwzL5JSUZdq843ijSP4g5eciMTNP69cXnSj4ua27d3B5hyLm8TE5ibu?= =?iso-8859-1?Q?HCPVlJHSGxI3nsCqQyPMereZ4P8zQ3EAISIYjCuAUUHrREGHIZDzSpiKuL?= =?iso-8859-1?Q?1kgpm+Crnh3qKZsl4vZ0Gm0sSgMcXGuAF6LAHCca4a6xDvCu3vDf2EKw0A?= =?iso-8859-1?Q?Z2mUrHOw5iK0c1eeptEqyCh4Q8z2a2LbbddncQYPXJcJrQDuW6T1NIF98+?= =?iso-8859-1?Q?1or2uzPo/GRysOsuMroHTANp/gMjK0D0uw55GubpwM2V7E5rpe0tiFMfvu?= =?iso-8859-1?Q?LV/CocOFT5gwY0ee1ZpZPoZi70VAnhFbpwtC/z7oBC/uTELrBBCq5fCvIx?= =?iso-8859-1?Q?66NTm/Z/OhvYuST5+yDONzZaJ9JydnSLmjhdGG25tmLtAVbguKfVj8uxjA?= =?iso-8859-1?Q?ssgqDPBIolwMVZ2em+gAmbTLyYVGHMGcNyDr7CGaIjiSymMnuEPaQpxry5?= =?iso-8859-1?Q?KwcYAr9Rh810Y3fdoPBY90NZdsZ4X8T+8sWnCYw4HKKvRSJcFiyd1Dq9S8?= =?iso-8859-1?Q?3nl300SEqptnY7XRT5v5rprVFDdVqw+rUXVVGvBRniZcf7jl8TxESnaH73?= =?iso-8859-1?Q?5XazhEVk2cBztPT1Bap+DkLiw0jy6sB4AnqczhoAQxPa7fLHFuRYx7ZJMt?= =?iso-8859-1?Q?6G1MYBZSofw7ysBTMmHMTDIiwWdOzOLk9XquCnVVY9fRmMBEyJjmdxTDkE?= =?iso-8859-1?Q?uK1zTfiFBtWTmPk5rGFWZYbWQT/YKu/Gg3ZKOqgyGlr/PbqyP61xHhIMlc?= =?iso-8859-1?Q?2Q5mSCuZQvTa+PRGiKlGxGFvgdHcnxCZ25dYnvKxNc6Yz671rzAFOZeD00?= =?iso-8859-1?Q?S7aUBXjiNQyFxPZxSPolMYZrjxGsP9sLdxSjPc28oH/mYeFEfQDG190J/T?= =?iso-8859-1?Q?EtYiYgv6BJip76vN5RKgW3T6u1CbrN0RrVGgY6oI1Xvc1l+gLczi7o6MBq?= =?iso-8859-1?Q?cWxJ9Kt6dBzzZSAkEYJgpP21zw5qBZS1AD9jmWIHkB0yRNEHujeaDgQlCK?= =?iso-8859-1?Q?S1AGm1ge1Oj8tqYHxakDwOA56q/8XOWXa8z8v9e8C6GXszDlO8kjMpi+xS?= =?iso-8859-1?Q?dumgb9K1SU1Mt9PsyEyQdbx8vL1E9z67GcNqFkDeeDxncxcwD5WWdEsew4?= =?iso-8859-1?Q?WpnkLvdZCC0pOKLENK3ft9JGJ5XiJZxm6IA35lD2qw8lROz0HJslfeg793?= =?iso-8859-1?Q?l7hL5183r6RyRFTHPRUTUhd6zLGfUfYkf+yNPWmgFwNG9PHST7sfIT6VIy?= =?iso-8859-1?Q?Uo0ddSKhv/uwQRd8l4CMMAsu9J2iNpQxCjIPRDZtkjRbFX9shT7+sbo+FX?= =?iso-8859-1?Q?aRc8/2QaCFMpnsjso4QZW0Hgu1NZm8utPtgx862a9X+86mWN1McCoR3NKD?= =?iso-8859-1?Q?ugKxTJDGAqpgB108ZxXUTT953ClUwWebNUoowrgLx0wfCwUnOjCQiACubb?= =?iso-8859-1?Q?jsLOwDVLOgQ3rf67HlINjM0AnWxsurFackanVjCeN80WpTi2REbyCZ44V4?= =?iso-8859-1?Q?iFwSM/hGf+ILPTjb/sKhBTVaF+vXCKkceM+Yesd+zTa6h8/5hGoRo2D5yF?= =?iso-8859-1?Q?+Kvwh1XmashPKIzNT+mBqZvuiu3CsFI2LeZhTT4IH8hOn4KsHjkpJ8YJf0?= =?iso-8859-1?Q?KuuskbIHWWep//XmEkx5o84biGbnb1ZsgHjayQB1KiWAiD?= Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: tfwTG2RSRSp/Cvecxp689P7vwnZ6IG0K1ORoxuNiwi4vmRPYm67bA8lw4aLxmz+KZQYYsJf1a8NXkFXjz8S0FdzZMa+G3Hv5s3C7crLpqn4HaX9r4fSUkZRBOAcFMoI2VZ2/m1hnXjYDFUDOKGmy7DKGDsyNStFOLyqP0v/Mic1Q0Sq3EYbm522X8clOtinBVP5WfF7PKjzU1GMvmHwB9usY16ZBC/Eq+bD6XGm9tTsllOHm64Kr4w6aNZ9AGn3JvcPveCPRyyX8s9mPfdxguAMk/G4zLbvJHAXgpciysidB/KuP8NE2NMvl//P3k3Y/OZvcrF/RS6uQPZLfEvB8Qw== X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH3PR84MB3523.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 8304f9b8-aa70-4143-fad9-08de9113c536 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2026 23:58:43.2060 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qypOIZqQBdIaq/VIlHn3FQ5dKhPK0B4iysKow1y7UCXE8RtxPR8DPFDLuxsF/2lQDbZVk5F1eoN10INSQ9XUDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR84MB2258 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: 5LZl0a5-yhIIhlHCtskyGmCZZKCQO89N X-Authority-Analysis: v=2.4 cv=Y6b1cxeN c=1 sm=1 tr=0 ts=69cf02ce cx=c_pps a=FAnPgvRYq/vnBSvlTDCQOQ==:117 a=FAnPgvRYq/vnBSvlTDCQOQ==:17 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=8nJEP1OIZ-IA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=gQcMVamqm3wCPoSYhaRC:22 a=_ZmgHqWwjZUDpi_pur5s:22 a=OUXY8nFuAAAA:8 a=VwQbUJbxAAAA:8 a=sZCmHRT7lcuF82sXxaYA:9 a=wPNLvfGTeEIA:10 a=cAcMbU7R10T-QSRYIcO_:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDIxNCBTYWx0ZWRfX/D3lbaHQ7k1o rgAdERDxTs9YOQGMI8fZSIBMp3wlYKqXEZ3DGaxdKRxs/z6wQJqLnhA16mgfhUNSXVyLkB+U+ja M8AHA791cK9EJfDLpl3bEGCAAg2ji/YyMUxMhc7JrxulIhjcc60370DmxmUA6KBIZbP//QUxirg b4mNfdNULlYSN7NWuh1UvPzi3OdEun8bgjO2oD1J/ZP9eLAcWMBwEs7y0CLIVjFlA4MQbUHqR+G SXI+C9DoFrfJjqurP8xkmhttFPC3TshbDi4CIQF3wylIoPsqzu5V+YuYOpoDoXgSrIDoGpYnV/7 u/o4Dohc0YX9xYKGA9hnwLLTRCRZyjtNkvN6yAhZGyrDBkxz76o9WRM8cRYeiLuokXucKCoIwIu oUjSdKKJG8Z6B/3Jy0AESpz94+fXrxeqZUXXWIiDGhpciE2rsafbDbl6E78oGpvebqvtSXCYfES +kQ6fEXMYYXypwe0EaQ== X-Proofpoint-GUID: 5LZl0a5-yhIIhlHCtskyGmCZZKCQO89N X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_04,2026-04-02_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020214 Content-Type: text/plain; charset="utf-8" From: Sanman Pradhan powerz_disconnect() frees the URB but does not clear the interface data pointer. The hwmon device registered via devm_hwmon_device_register_with_info() is unregistered later during devm cleanup, which runs after disconnect returns. Between usb_free_urb() in disconnect and devm teardown, the hwmon sysfs files remain accessible. A concurrent read through powerz_read() can reach powerz_read_data(), which calls usb_fill_bulk_urb() with the freed URB pointer. The existing NULL check on the return value of usb_get_intfdata() does not trigger because the interface data was never cleared. Address this by: 1. Clearing usb_set_intfdata() in disconnect before taking the mutex, so concurrent powerz_read() callers observe a NULL pointer and return early. 2. Setting priv->urb to NULL after freeing it under the mutex, so any reader that obtained priv before the interface data was cleared sees the NULL URB pointer and returns -ENODEV. 3. Adding a NULL check on priv->urb in powerz_read_data(). 4. Moving usb_set_intfdata() before the hwmon registration in probe() so that interface data is set before sysfs files become visible. Fixes: 4381a36abdf1c ("hwmon: add POWER-Z driver") Cc: stable@vger.kernel.org Signed-off-by: Sanman Pradhan --- drivers/hwmon/powerz.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/powerz.c b/drivers/hwmon/powerz.c index 4e663d5b4e330..add20b354f862 100644 --- a/drivers/hwmon/powerz.c +++ b/drivers/hwmon/powerz.c @@ -108,6 +108,9 @@ static int powerz_read_data(struct usb_device *udev, st= ruct powerz_priv *priv) { int ret; =20 + if (!priv->urb) + return -ENODEV; + priv->status =3D -ETIMEDOUT; reinit_completion(&priv->completion); =20 @@ -224,16 +227,17 @@ static int powerz_probe(struct usb_interface *intf, mutex_init(&priv->mutex); init_completion(&priv->completion); =20 + usb_set_intfdata(intf, priv); + hwmon_dev =3D devm_hwmon_device_register_with_info(parent, DRIVER_NAME, priv, &powerz_chip_info, NULL); if (IS_ERR(hwmon_dev)) { usb_free_urb(priv->urb); + usb_set_intfdata(intf, NULL); return PTR_ERR(hwmon_dev); } =20 - usb_set_intfdata(intf, priv); - return 0; } =20 @@ -241,9 +245,12 @@ static void powerz_disconnect(struct usb_interface *in= tf) { struct powerz_priv *priv =3D usb_get_intfdata(intf); =20 + usb_set_intfdata(intf, NULL); + mutex_lock(&priv->mutex); usb_kill_urb(priv->urb); usb_free_urb(priv->urb); + priv->urb =3D NULL; mutex_unlock(&priv->mutex); } =20 --=20 2.34.1