From nobody Sat Apr 18 13:42:36 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E94533EC2C2 for ; Thu, 2 Apr 2026 16:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775145881; cv=none; b=qBZj0ugXyStck2Sjgt4Vc6ybExh7sz35cRW5+pZp6zfTGU1EEuyeaF0rgjkMwhZT/C2kSxAQbdSNgQ6jASzEVfVDh9W1WkuyrdI12d/R26Gd/s6SZdEwqFPVdlmAFChdLfnG+XhQplhjJ9UaUjY1ql1VMLTW87Gt/x+hsRNV7+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775145881; c=relaxed/simple; bh=vbR9luJi2b5bo/PrlmldXqoQ6slG09mFuhpP189oVoU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=inOoJ88JJFPKRRlAqwHgHAUcWypWthF1FviAevurp5pOf8TiEvDBHmQ2NICG99cq7FK7B67kLYBzGEH/50G1L7j/SjDdv+96fLsw1mP/b3pDK1N2yyLQ85yenRT38GgHB8QwvztCyJlqivw730RhoeaH9aBx1Gm3zQEIw6E69P0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dWyBXilU; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dWyBXilU" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-823c56765fdso552110b3a.1 for ; Thu, 02 Apr 2026 09:04:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775145878; x=1775750678; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=prBjVrj8/bfyqPL6p9NnkzgN1t0pLTHzzXHQ/VzSqEA=; b=dWyBXilU7p9gu4PeZY1vyxV7rHmbImctKB5DTvxtzeZ+VauA2EUW8c/3GMaokh+or+ bxpByONyHDf7wM67FVzcnIYd2wjh5erM3qpl8fWIpoXbKRbgcsjcf0CuM3IgEcD0CMD+ sZtBksbeIHxe6wwf4Brvp9cPNR1epHHaTVFt+CgKdAAQQbqSn9eCcblyga4Zjp8yhr2Y 4juDHdiqzQ/hfsdZ4FAKeREiqGP/qc2e7STh0wMrYK6o6pSXZT5fdoJ6trXb2yGXRO5p mFKO9nAK/67tz+uPIz8oPDSPVj01mVoNynY/TX06eIsyyoVVwDplnLbppUIfAYinQB23 EDow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775145878; x=1775750678; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=prBjVrj8/bfyqPL6p9NnkzgN1t0pLTHzzXHQ/VzSqEA=; b=lePSxnqLDIyHQt1vBbxM8SVzlMCsXSu1JixW8AUuhVHo8eYZD8VXKveicBEQBqGfuO Dhxi6vnWkO+79FinI502AN5Zm7U9Hpn/MhWHp6ehb0L9HVEZrNM4jMc8F+PGs/asGZYL DPYDWt4HA5pegnNs8M6oYOy1zdnO4pIYV7oTnKsaWPtxwGi2KfkrwhqVcbvkh2TuyKK/ ib8QtWSXSg7PoKjR2zWHRd0r3bmskToC/D03wdOsDRl/zU5+nGPk8DDTGdBuMK1yC+1G esWT1IWH0ZiufVY1QvEsHioGszGt+QmlkClsj5ors6hxh7KObRtzaSZBip1WnMSibAoA kTiA== X-Forwarded-Encrypted: i=1; AJvYcCX3jpvdKmqe2FldaxbW8s/RSv/+rCSUGI5lahDBJeRqqyswtwA1DhXXYMg0ze4iuXlv9gqVvviscw/iAt4=@vger.kernel.org X-Gm-Message-State: AOJu0YzLCdieohmAEpKWRgCJ1Tqsq3QxO3+Q5nkMid4iNMBODWsItyop j8onZkyHIDfrxw072gDTd8zfPLNY9b5327wcT98jgTuo29yclrJw2LLz X-Gm-Gg: ATEYQzw8wnlq6WlvoAUp2ROT61Py+DX3lWs1h73lGF5CqSfMSMymKblcdDJmkD1bB+v +IzKa0m13ImdMWydU2XpnLvnumhFei4nFqajL2bs3kxXPjw8cTIBO8rATyR8bRIzI6LbymNfBHq DkHokdrw99NnlTQ3oZFmJCvsXzXWsxybGIpKYtufTMdxqyt2+gUqGgD+QOpnpLT2ltMmaQbBr5n e5edPmr1H/UNoE8HWgRheuzMeE7OtP17kryZm+4T0WvT4RprPB0lapwGaSf6m+EJE3DOjQv8qxN yTLxuJ2yibmqBW5v0uSYt0FoWTHel3OWze7LpBwOkhQoOmdjJvHGDMnIx23YX0vEXejCMWp3lEz 0t1kiU2AH/LfSF3VXOSM6Q/dhMGcz6HkoqXlpQ5Hye1qmSZHeTNPMHx6o3xHDu/c7dX1LDT7wqv vqKsdRaXsxFa+HEExKFAD2iHsdnKCL1INj7mamf+rgpuMnegU= X-Received: by 2002:a05:6a00:298e:b0:82a:7f1a:758c with SMTP id d2e1a72fcca58-82ce88c0f1emr7664298b3a.11.1775145877863; Thu, 02 Apr 2026 09:04:37 -0700 (PDT) Received: from fedora ([61.74.238.173]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cfebe5b23sm2822987b3a.59.2026.04.02.09.04.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 09:04:37 -0700 (PDT) From: SeungJu Cheon To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org Cc: mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, me@brighamcampbell.com, shuah@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, SeungJu Cheon Subject: [PATCH v3] perf header: Validate build_id filename length to prevent buffer overflow Date: Fri, 3 Apr 2026 01:04:10 +0900 Message-ID: <20260402160410.425978-1-suunj1331@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The build_id parsing functions calculate a filename length from the event header size and read directly into a stack buffer of PATH_MAX bytes without bounds checking. A malformed perf.data file with a crafted header.size can cause the length to be negative or exceed PATH_MAX, resulting in a stack buffer overflow. Add bounds checking for the filename length in both perf_header__read_build_ids() and the ABI quirk variant. Print a warning message when invalid length is detected. Signed-off-by: SeungJu Cheon --- v3: - Fix printf format specifier: %d -> %zd for ssize_t (Sashiko) v2: - Add warning message when invalid filename length detected --- tools/perf/util/header.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index 9142a8ba4019..9ffc0f4ca6d1 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -2545,6 +2545,11 @@ static int perf_header__read_build_ids_abi_quirk(str= uct perf_header *header, perf_event_header__bswap(&old_bev.header); =20 len =3D old_bev.header.size - sizeof(old_bev); + if (len < 0 || len >=3D PATH_MAX) { + pr_warning("invalid build_id filename length %zd\n", len); + return -1; + } + if (readn(input, filename, len) !=3D len) return -1; =20 @@ -2587,6 +2592,11 @@ static int perf_header__read_build_ids(struct perf_h= eader *header, perf_event_header__bswap(&bev.header); =20 len =3D bev.header.size - sizeof(bev); + if (len < 0 || len >=3D PATH_MAX) { + pr_warning("invalid build_id filename length %zd\n", len); + goto out; + } + if (readn(input, filename, len) !=3D len) goto out; /* --=20 2.52.0