From nobody Mon Apr 6 09:08:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 159ED3CBE72; Thu, 2 Apr 2026 15:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775144989; cv=none; b=MKoOqbYJfHd7ZlbPlQ6/Y/qxA8gJZUEc1Cf3fylxwU5itheDjbaX9wIuv9powMDM4buZJKvvg44m8QqTFjKQD38R3W2ZIS5g82aOEGGkwDZ1kcm5k2XtykxPq7gCDFZoJvzh4A/ZZk9LvBNHLbNaVrOlQPHhvj2Smb4W5Zna5K4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775144989; c=relaxed/simple; bh=XpuoG8mvycp03fgAimW2iAGcsycTMXVNftW28CIwid0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KCAdXs1MJKCoUCnC39MUCIdSwD1ezEmS2NvQr1X5aJys1h+MECBz8zEhPLRNOnyaZ1hqPV7IQ6u+iYKkSTEryoby5+vFpmENiWcSsowiWwM9KaNq9C5DTZR871HJilRamdlY6VvOsgChFfwVgpi1IE5NYFjljkkxHTeUpTd+aZE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IBwm3z/r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IBwm3z/r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C18A8C116C6; Thu, 2 Apr 2026 15:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775144988; bh=XpuoG8mvycp03fgAimW2iAGcsycTMXVNftW28CIwid0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IBwm3z/rNqQW8v6IflGSzqUxuShah55UPnHwpll5A1z28si50HEtea1N3umg+vmuW afaqx+Smv0aWg9UbeV86RmUwAtke4XUuhxtHQteeAUSKF5B0uX9E2cfqE+p8T+8gdn yjop/11TaknCUtVY1Q3lTrBE72Z1I4ZThMXD+u5WvXIEXsQd0Qp+oa0y/p0linwMo+ tfmB1sLghiC6mlBINTA9CU6VPTW7j+h1ZDUo1C6ZBYPB7QL74kxhyFndmBoGebDKl4 XLCGEqdUDCUdDIh/6okVAEAPh8/PDiQERWOwk90FzvbTyS2d9k1leXgwKEuTk/bt0w SXB/V1Xz9/36A== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1w8KIk-0000000ALvQ-27LT; Thu, 02 Apr 2026 17:49:46 +0200 From: Johan Hovold To: Luiz Augusto von Dentz , Marcel Holtmann Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Rajat Jain Subject: [PATCH v3 2/5] Bluetooth: btusb: fix use-after-free on marvell probe failure Date: Thu, 2 Apr 2026 17:48:07 +0200 Message-ID: <20260402154810.2467291-3-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260402154810.2467291-1-johan@kernel.org> References: <20260402154810.2467291-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to stop any TX URBs submitted during Marvell OOB wakeup configuration on later probe failures to avoid use-after-free in the completion callback. This issue was reported by Sashiko while reviewing a fix for a wakeup source leak in the btusb probe errors paths. Link: https://sashiko.dev/#/patchset/20260402092704.2346710-1-johan%40kerne= l.org Fixes: a4ccc9e33d2f ("Bluetooth: btusb: Configure Marvell to use one of the= pins for oob wakeup") Cc: stable@vger.kernel.org # 4.11 Cc: Rajat Jain Signed-off-by: Johan Hovold --- drivers/bluetooth/btusb.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 97de6e6e7dbc..b6f2bed7d1b8 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -4183,7 +4183,7 @@ static int btusb_probe(struct usb_interface *intf, if (id->driver_info & BTUSB_INTEL_COMBINED) { err =3D btintel_configure_setup(hdev, btusb_driver.name); if (err) - goto out_free_dev; + goto err_kill_tx_urbs; =20 /* Transport specific configuration */ hdev->send =3D btusb_send_frame_intel; @@ -4346,7 +4346,7 @@ static int btusb_probe(struct usb_interface *intf, err =3D usb_set_interface(data->udev, 0, 0); if (err < 0) { BT_ERR("failed to set interface 0, alt 0 %d", err); - goto out_free_dev; + goto err_kill_tx_urbs; } } =20 @@ -4354,7 +4354,7 @@ static int btusb_probe(struct usb_interface *intf, err =3D usb_driver_claim_interface(&btusb_driver, data->isoc, data); if (err < 0) - goto out_free_dev; + goto err_kill_tx_urbs; } =20 if (IS_ENABLED(CONFIG_BT_HCIBTUSB_BCM) && data->diag) { @@ -4390,6 +4390,8 @@ static int btusb_probe(struct usb_interface *intf, usb_set_intfdata(data->isoc, NULL); usb_driver_release_interface(&btusb_driver, data->isoc); } +err_kill_tx_urbs: + usb_kill_anchored_urbs(&data->tx_anchor); out_free_dev: if (data->reset_gpio) gpiod_put(data->reset_gpio); --=20 2.52.0