From nobody Mon Apr 6 09:08:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15AF23DFC98; Thu, 2 Apr 2026 15:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775144989; cv=none; b=WBHD+kxJNYwkKp6L3OYULWmi3ndp3ajMAKwqvRIkCGbxaNNjUQRpTGTB8/oY+lF+BhzroIYycCEpv/PYOb8JcvniNyLWuUDKw54hJNqgsnrAJBiqqH7HGpYBFjHcKvTf9gNlNGEuOeIo5NZkj6o5PW4x1kFPUbRGuY8PTRw6ex8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775144989; c=relaxed/simple; bh=VL5LBw99FRqrEC5kFcGQ9UvBX6IvWRUeRbZCGJ/xtvM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ENVA8gCSZTDJ+R1i7JIEJB5C91crmcaIp/xt00w/VxabPHnZy5vxCgTpdoSCXkv1C7kPFV8zQ7Ih3smODSeCzhaxg97pmQOMHIEV5Wq0cSpNy7JsXgAuK3YxVqsOih3hXwAs/A5Ku9HM1Xrn3/edMqrf1gtvKRSbcEgUXgAAMyk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F41NZasR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F41NZasR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1904C4AF0B; Thu, 2 Apr 2026 15:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775144988; bh=VL5LBw99FRqrEC5kFcGQ9UvBX6IvWRUeRbZCGJ/xtvM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F41NZasRETl/Z6T1sqazPHpz2jx14eVbzBEBwndFzIWT/YVIp9HgrQnjIbvk9LHzI AMs1Qxm909CwowWYk5oc+wKbVsA7GtNuZkWIfD9/tuQhtMK773SoFQkQIj73IbFZxc uPc9R9BxEpmP4bDV0KO6jx0ftccvupHpdMgO8Gl/LAJNXFAbPWglTLHcGzfo9ay0D0 BVDutsekGWO/HphfxneKks4mcZlR9bmrL7lFvtDk/c1TzjQQaW4GC/YkmJMs3F9KYU 3QDAF96LIMHvjxo1oRH4YfVn90vwpmko72etSMQ+qH1zvyDHLh74xX4yQp7HPMMnJq j4IaxXa/vinfQ== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1w8KIk-0000000ALvO-24qN; Thu, 02 Apr 2026 17:49:46 +0200 From: Johan Hovold To: Luiz Augusto von Dentz , Marcel Holtmann Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v3 1/5] Bluetooth: btusb: fix use-after-free on registration failure Date: Thu, 2 Apr 2026 17:48:06 +0200 Message-ID: <20260402154810.2467291-2-johan@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260402154810.2467291-1-johan@kernel.org> References: <20260402154810.2467291-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to release the sibling interfaces in case controller registration fails to avoid use-after-free and double-free when they are eventually disconnected. This issue was reported by Sashiko while reviewing a fix for a wakeup source leak in the btusb probe errors paths. Link: https://sashiko.dev/#/patchset/20260402092704.2346710-1-johan%40kerne= l.org Fixes: 9bfa35fe422c ("[Bluetooth] Add SCO support to btusb driver") Fixes: 9d08f50401ac ("Bluetooth: btusb: Add support for Broadcom LM_DIAG in= terface") Cc: stable@vger.kernel.org # 2.6.27 Signed-off-by: Johan Hovold Reviewed-by: Paul Menzel --- drivers/bluetooth/btusb.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 21e85c212506..97de6e6e7dbc 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -4372,7 +4372,7 @@ static int btusb_probe(struct usb_interface *intf, =20 err =3D hci_register_dev(hdev); if (err < 0) - goto out_free_dev; + goto err_release_siblings; =20 usb_set_intfdata(intf, data); =20 @@ -4381,6 +4381,15 @@ static int btusb_probe(struct usb_interface *intf, =20 return 0; =20 +err_release_siblings: + if (data->diag) { + usb_set_intfdata(data->diag, NULL); + usb_driver_release_interface(&btusb_driver, data->diag); + } + if (data->isoc) { + usb_set_intfdata(data->isoc, NULL); + usb_driver_release_interface(&btusb_driver, data->isoc); + } out_free_dev: if (data->reset_gpio) gpiod_put(data->reset_gpio); --=20 2.52.0