From nobody Thu Apr 2 15:41:22 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90EF5382390; Thu, 2 Apr 2026 10:47:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775126836; cv=none; b=jKg5GLPIqY86OnSiokUhlCD0zdtrEUNJttjr1wUSJDdX3fzWI7knUkj/BmqiXVRgubJrGoFqyA6fmkJHDvwmuxj+5esCEjv4EXahhUWwSmEDVTGEp2+EiSUi2dhGsSU1U+NvNkAblBkJEpjLLZiQnxBC+nK/HLWEfV9sufzbU28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775126836; c=relaxed/simple; bh=wMKxK9YDj8LokFxE0NrwRGnOperzcrKXGr3afqvpD9g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BpzprxryE/HtaFDc6jDq/7+q6sTj3yTnzgsXiAFMsT+21IMCbbZjdnvpuF4UtbDSgAvdKpDJYDvpUtwv0LapKWUHpHGa1KFLdYbBck+Ro6ZN+aO0+tuEhGm2fRZ6Jzl/bkQjMwko1QKHgRZBgzhRtDDYZU5Wmp5rZQ8n7xav/yE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Kj7zcpur; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Kj7zcpur" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775126835; x=1806662835; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=wMKxK9YDj8LokFxE0NrwRGnOperzcrKXGr3afqvpD9g=; b=Kj7zcpuru+ytmmpNvx8JxA9lTg0zBeJYwDgfGfxsQEVX4C4cAktEwpdU 8UDAICTvbHD83tOzRBumnyMrcAjm5ch6R77AcP9yABd/8qgHbZulVko/d PIfFT/WxZ3hDe8/kkPMYp6AWoY+JiYWI92bJx9xD9xNqTQbBSLWZR1hJf /NnweH/27NIwNkoQ7hah7tHL/IIh3TYEA5bvb/R2xM/RuGdUoMgbhOskj 7ZlxblsLNsaYc1bLWfD14ry6fXi8PrTyjD2opzoFvCmK0YKkdWuWv3SkT P0kvQu6cuMfnDif9QXxkhX0wiUsEVWZy2EV/cNwwk3R1ZRPnO3JrxPIPm Q==; X-CSE-ConnectionGUID: HzWcZ/ShTT+crEBPiuRhUQ== X-CSE-MsgGUID: up9wu1zmSaeyA9go9XZJbA== X-IronPort-AV: E=McAfee;i="6800,10657,11746"; a="76370700" X-IronPort-AV: E=Sophos;i="6.23,155,1770624000"; d="scan'208";a="76370700" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2026 03:47:14 -0700 X-CSE-ConnectionGUID: TQtSBwTgSXO7rseXqPQgZA== X-CSE-MsgGUID: cClCMLm3TuCDDN5OgIBHoQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,155,1770624000"; d="scan'208";a="231349392" Received: from intel-nuc8i7beh.iind.intel.com ([10.223.163.35]) by orviesa004.jf.intel.com with ESMTP; 02 Apr 2026 03:47:12 -0700 From: Arun T To: arun.t@intel.com, johannes.goede@oss.qualcomm.com Cc: sakari.ailus@linux.intel.com, arec.kao@intel.com, ilpo.jarvinen@linux.intel.com, dan.scally@ideasonboard.com, platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mehdi.djait@intel.com Subject: [PATCH v8 1/2] platform/x86: int3472: Add TPS68470 board data for Intel nvl Date: Thu, 2 Apr 2026 16:10:37 +0530 Message-ID: <20260402104045.4040328-2-arun.t@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260402104045.4040328-1-arun.t@intel.com> References: <20260402104045.4040328-1-arun.t@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Intel NVL platform uses IPU8 is powered by a TPS68470 PMIC,requiring bo= ard data to configure the GPIOs and regulators for proper camera sensor operati= on. Signed-off-by: Arun T Reviewed-by: Daniel Scally Reviewed-by: Hans de Goede --- .../x86/intel/int3472/tps68470_board_data.c | 108 ++++++++++++++++++ 1 file changed, 108 insertions(+) diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/dri= vers/platform/x86/intel/int3472/tps68470_board_data.c index 6bec5a910396..bfec0f1af065 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -144,6 +144,24 @@ static struct regulator_consumer_supply int3479_aux2_c= onsumer_supplies[] =3D { REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), }; =20 +/* Settings for Intel NVL platform */ + +static struct regulator_consumer_supply ovti13b1_core_consumer_supplies[] = =3D { + REGULATOR_SUPPLY("dvdd", "i2c-OVTI13B1:01"), +}; + +static struct regulator_consumer_supply ovti13b1_ana_consumer_supplies[] = =3D { + REGULATOR_SUPPLY("avdd", "i2c-OVTI13B1:01"), +}; + +static struct regulator_consumer_supply ovti13b1_vcm_consumer_supplies[] = =3D { + REGULATOR_SUPPLY("vcc", "i2c-OVTI13B1:01-VCM"), +}; + +static struct regulator_consumer_supply ovti13b1_vsio_consumer_supplies[] = =3D { + REGULATOR_SUPPLY("dovdd", "i2c-OVTI13B1:01"), +}; + static const struct regulator_init_data dell_7212_tps68470_core_reg_init_d= ata =3D { .constraints =3D { .min_uV =3D 1200000, @@ -221,6 +239,61 @@ static const struct regulator_init_data dell_7212_tps6= 8470_aux2_reg_init_data =3D .consumer_supplies =3D int3479_aux2_consumer_supplies, }; =20 +static const struct regulator_init_data intel_nvl_tps68470_core_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1200000, + .max_uV =3D 1200000, + .apply_uV =3D true, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(ovti13b1_core_consumer_supplies), + .consumer_supplies =3D ovti13b1_core_consumer_supplies, +}; + +static const struct regulator_init_data intel_nvl_tps68470_ana_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D true, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(ovti13b1_ana_consumer_supplies), + .consumer_supplies =3D ovti13b1_ana_consumer_supplies, +}; + +static const struct regulator_init_data intel_nvl_tps68470_vcm_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 2815200, + .max_uV =3D 2815200, + .apply_uV =3D true, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(ovti13b1_vcm_consumer_supplies), + .consumer_supplies =3D ovti13b1_vcm_consumer_supplies, +}; + +/* Ensure the always-on VIO regulator has the same voltage as VSIO */ +static const struct regulator_init_data intel_nvl_tps68470_vio_reg_init_da= ta =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D true, + .always_on =3D true, + }, +}; + +static const struct regulator_init_data intel_nvl_tps68470_vsio_reg_init_d= ata =3D { + .constraints =3D { + .min_uV =3D 1800600, + .max_uV =3D 1800600, + .apply_uV =3D true, + .valid_ops_mask =3D REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies =3D ARRAY_SIZE(ovti13b1_vsio_consumer_supplies), + .consumer_supplies =3D ovti13b1_vsio_consumer_supplies, +}; + + static const struct tps68470_regulator_platform_data dell_7212_tps68470_pd= ata =3D { .reg_init_data =3D { [TPS68470_CORE] =3D &dell_7212_tps68470_core_reg_init_data, @@ -297,6 +370,16 @@ static const struct tps68470_regulator_platform_data m= si_p14_ai_evo_tps68470_pda }, }; =20 +static const struct tps68470_regulator_platform_data intel_nvl_tps68470_pd= ata =3D { + .reg_init_data =3D { + [TPS68470_CORE] =3D &intel_nvl_tps68470_core_reg_init_data, + [TPS68470_ANA] =3D &intel_nvl_tps68470_ana_reg_init_data, + [TPS68470_VCM] =3D &intel_nvl_tps68470_vcm_reg_init_data, + [TPS68470_VIO] =3D &intel_nvl_tps68470_vio_reg_init_data, + [TPS68470_VSIO] =3D &intel_nvl_tps68470_vsio_reg_init_data, + }, +}; + static struct gpiod_lookup_table surface_go_int347a_gpios =3D { .dev_id =3D "i2c-INT347A:00", .table =3D { @@ -340,6 +423,14 @@ static const struct software_node msi_p14_ai_evo_tps68= 470_gpio_swnode =3D { .properties =3D msi_p14_ai_evo_gpio_props, }; =20 +static struct gpiod_lookup_table intel_nvl_tps68470_gpios =3D { + .dev_id =3D "i2c-OVTI13B1:01", + .table =3D { + GPIO_LOOKUP("tps68470-gpio", 9, "reset", GPIO_ACTIVE_LOW), + { } + } +}; + static const struct int3472_tps68470_board_data surface_go_tps68470_board_= data =3D { .dev_name =3D "i2c-INT3472:05", .tps68470_regulator_pdata =3D &surface_go_tps68470_pdata, @@ -379,6 +470,15 @@ static const struct int3472_tps68470_board_data msi_p1= 4_ai_evo_tps68470_board_da }, }; =20 +static const struct int3472_tps68470_board_data intel_nvl_tps68470_board_d= ata =3D { + .dev_name =3D "i2c-INT3472:04", + .tps68470_regulator_pdata =3D &intel_nvl_tps68470_pdata, + .n_gpiod_lookups =3D 1, + .tps68470_gpio_lookup_tables =3D { + &intel_nvl_tps68470_gpios, + }, +}; + static const struct dmi_system_id int3472_tps68470_board_data_table[] =3D { { .matches =3D { @@ -415,6 +515,14 @@ static const struct dmi_system_id int3472_tps68470_boa= rd_data_table[] =3D { }, .driver_data =3D (void *)&msi_p14_ai_evo_tps68470_board_data, }, + { + .matches =3D { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Nova Lake Client Platform"), + }, + .driver_data =3D (void *)&intel_nvl_tps68470_board_data, + }, + { } }; =20 --=20 2.43.0 From nobody Thu Apr 2 15:41:22 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BF373803CD; Thu, 2 Apr 2026 10:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775126840; cv=none; b=jSgWxaD+9DesAwnmTX4SBr02uCcqtQgl3kqyn02qlpzNrkS1+5Ely3zOI56CaxFXAAJodKTdSEGXiY77BKSzH+ZUnPPLDIjgV5Rlosi6eCD9x8KDdVpdUZhBDPJlPH/2hJDFxmlkQpdQO6oIqb0Mp/gYJcthfqPV06CMirF/BbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775126840; c=relaxed/simple; bh=I/xKuF04j2MAbZqz3njmiYIBz0WmeHEBkGYbSpvr/Wc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IbQTvdqcsQj73Hey0FGWL/s3ZSlF+jQW2yonx5Pu9FjYp27bTwXZUgm5wpFIrbCUn6H0QnhPyU2rohbyu4FGAPOE09dZ/tL38QDL6/6Cqdui7O4n/XYylI39CGJPJiXHmEYsPmsJhLfehMbEJPsO7HeybipQxvdlfno04b52qGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=R/X83ocz; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="R/X83ocz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775126839; x=1806662839; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=I/xKuF04j2MAbZqz3njmiYIBz0WmeHEBkGYbSpvr/Wc=; b=R/X83oczLQCw2rKqjBsTqktR46asbdsFYZPS/lIfMsys1oNfGsAVQjZ5 68Y2OhCAK1AhqCIz3K4VhD/nSW4gUlJYGOh1ClWtzXPN5cTxXp4UE2QpQ c7xTZ8eDWFTlVNRVsS3s7GzFxcWguC1v8AFqEruzAAKWoqCLNCgw5Xv6+ CfrUMa3fCR5t5qASY9zLS0ugjrf+oxqpXR0GGUHaC6e8EP5v6WdE23ihW nWU39d8KrjB2vud2XXFKcCYgKX9AbrQIVs/DCjQ3h7vjSfcMga6QHy+Zh xdyezDsCxkkDb04d3pIEsd+WC5y8JLAi1Bw63sVyjzHKqGcJ+Pao11vjQ w==; X-CSE-ConnectionGUID: zXh83RIOTgiPBs8nL4ZhGw== X-CSE-MsgGUID: JeRhPbefQG23PeFEhF+jzA== X-IronPort-AV: E=McAfee;i="6800,10657,11746"; a="76370705" X-IronPort-AV: E=Sophos;i="6.23,155,1770624000"; d="scan'208";a="76370705" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2026 03:47:19 -0700 X-CSE-ConnectionGUID: 3xSlXnZsRLGrvnRz8k+Elw== X-CSE-MsgGUID: ZfTteFKMTVivMmRBgfcF1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,155,1770624000"; d="scan'208";a="231349397" Received: from intel-nuc8i7beh.iind.intel.com ([10.223.163.35]) by orviesa004.jf.intel.com with ESMTP; 02 Apr 2026 03:47:17 -0700 From: Arun T To: arun.t@intel.com, johannes.goede@oss.qualcomm.com Cc: sakari.ailus@linux.intel.com, arec.kao@intel.com, ilpo.jarvinen@linux.intel.com, dan.scally@ideasonboard.com, platform-driver-x86@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, mehdi.djait@intel.com Subject: [PATCH v8 2/2] media: ov13b10: Support multiple regulators Date: Thu, 2 Apr 2026 16:10:38 +0530 Message-ID: <20260402104045.4040328-3-arun.t@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260402104045.4040328-1-arun.t@intel.com> References: <20260402104045.4040328-1-arun.t@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The OV13B10 sensor driver currently handles a single regulator called avdd, however the sensor can be supplied by up to three regulators. Update the driver to handle all of them together using the regulator bulk API. Signed-off-by: Arun T Reviewed-by: Daniel Scally Reviewed-by: Hans de Goede --- drivers/media/i2c/ov13b10.c | 47 ++++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/ov13b10.c b/drivers/media/i2c/ov13b10.c index 5421874732bc..b0d34141a13a 100644 --- a/drivers/media/i2c/ov13b10.c +++ b/drivers/media/i2c/ov13b10.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -699,6 +700,12 @@ static const struct ov13b10_mode supported_2_lanes_mod= es[] =3D { }, }; =20 +static const char * const ov13b10_supply_names[] =3D { + "dovdd", /* Digital I/O power */ + "avdd", /* Analog power */ + "dvdd", /* Digital core power */ +}; + struct ov13b10 { struct device *dev; =20 @@ -708,7 +715,7 @@ struct ov13b10 { struct v4l2_ctrl_handler ctrl_handler; =20 struct clk *img_clk; - struct regulator *avdd; + struct regulator_bulk_data supplies[ARRAY_SIZE(ov13b10_supply_names)]; struct gpio_desc *reset; =20 /* V4L2 Controls */ @@ -1194,9 +1201,8 @@ static int ov13b10_power_off(struct device *dev) struct ov13b10 *ov13b10 =3D to_ov13b10(sd); =20 gpiod_set_value_cansleep(ov13b10->reset, 1); - - if (ov13b10->avdd) - regulator_disable(ov13b10->avdd); + regulator_bulk_disable(ARRAY_SIZE(ov13b10_supply_names), + ov13b10->supplies); =20 clk_disable_unprepare(ov13b10->img_clk); =20 @@ -1214,14 +1220,12 @@ static int ov13b10_power_on(struct device *dev) dev_err(dev, "failed to enable imaging clock: %d", ret); return ret; } - - if (ov13b10->avdd) { - ret =3D regulator_enable(ov13b10->avdd); - if (ret < 0) { - dev_err(dev, "failed to enable avdd: %d", ret); - clk_disable_unprepare(ov13b10->img_clk); - return ret; - } + ret =3D regulator_bulk_enable(ARRAY_SIZE(ov13b10_supply_names), + ov13b10->supplies); + if (ret < 0) { + dev_err(dev, "failed to enable regulators\n"); + clk_disable_unprepare(ov13b10->img_clk); + return ret; } =20 gpiod_set_value_cansleep(ov13b10->reset, 0); @@ -1475,7 +1479,8 @@ static int ov13b10_get_pm_resources(struct ov13b10 *o= v13b) unsigned long freq; int ret; =20 - ov13b->reset =3D devm_gpiod_get_optional(ov13b->dev, "reset", GPIOD_OUT_L= OW); + ov13b->reset =3D devm_gpiod_get_optional(ov13b->dev, "reset", + GPIOD_OUT_LOW); if (IS_ERR(ov13b->reset)) return dev_err_probe(ov13b->dev, PTR_ERR(ov13b->reset), "failed to get reset gpio\n"); @@ -1491,15 +1496,15 @@ static int ov13b10_get_pm_resources(struct ov13b10 = *ov13b) "external clock %lu is not supported\n", freq); =20 - ov13b->avdd =3D devm_regulator_get_optional(ov13b->dev, "avdd"); - if (IS_ERR(ov13b->avdd)) { - ret =3D PTR_ERR(ov13b->avdd); - ov13b->avdd =3D NULL; - if (ret !=3D -ENODEV) - return dev_err_probe(ov13b->dev, ret, - "failed to get avdd regulator\n"); - } + for (unsigned int i =3D 0; i < ARRAY_SIZE(ov13b10_supply_names); i++) + ov13b->supplies[i].supply =3D ov13b10_supply_names[i]; =20 + ret =3D devm_regulator_bulk_get(ov13b->dev, + ARRAY_SIZE(ov13b10_supply_names), + ov13b->supplies); + if (ret) + return dev_err_probe(ov13b->dev, ret, + "failed to get regulators\n"); return 0; } =20 --=20 2.43.0