From nobody Sun Jun 14 09:53:37 2026 Received: from mail-dl1-f53.google.com (mail-dl1-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A7DB27EFF7 for ; Thu, 2 Apr 2026 08:39:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775119163; cv=none; b=drTIrIr75goEeyjttjUqeMn+pE9Eh9k9i0u2VB9jj//fGCl0GrqVhdLqlIA0rqXbewob3/cEbZ2zfxYFxRPvfJn3UqcJrBsgGdfgMhHmrhLtgFeQhDvD/BZkJv0WCXqSBxJ3Rp61xuFQjsNaz5tqednoFlcbvgpMGStDsLrFRRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775119163; c=relaxed/simple; bh=cwiMGb+QvJPPbyOUbTGVlCDSVPPTs9vIaN+NXNJAVn8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=hKpTHaLnaFSWazZEkN6uQ/oPoEMvi4oCUB7MoP7ug3FcV6X89FxukkSF/PGLrmqBc76DqliMYyh85cpU10UCfnbk35PqmP0OaLOYzn5hjhgq3ncOIYII06iFxdSmvl6BR0U0BQ4uwub92QJMJVUT57EIvUaQayhD/SToWC/dcq8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K/FgGiS+; arc=none smtp.client-ip=74.125.82.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K/FgGiS+" Received: by mail-dl1-f53.google.com with SMTP id a92af1059eb24-126ea4e9694so2025148c88.1 for ; Thu, 02 Apr 2026 01:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775119161; x=1775723961; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7eITVDgwa5tEdf7gs96GHN8iyQzNKskoC8moYtKLcKc=; b=K/FgGiS+3PI2cFIE2N+jYPaP3BbsprXkLelxACmeih+ZJPGr6NWju/f1916TjbFFkf hZe/o0+7Mi9Nh8LR39DkgNxuql0TvOgBtyNcn1eupfqiLol1ElVgjyYZR+Z8PlS4FUBE 7jRTE9z5OvIAyBmxLHB9M+3u5Q/wfYaqkcEvbBY70NJPMbUDyALNBmj/2rjWlr9+XU9s oEZt77sdmJCjDlY3137MMUZLABPhV1KibPuvqW/3dyFG6aQuDsPk7Ocbx2P6e6QcOYNw d+JugzOrlkOzt5+fw89gpYcKlXSuZDxFsSJX/CTvk7oDCSVYAXzPlMbzdiN6cfqaiK3N 292g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775119161; x=1775723961; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7eITVDgwa5tEdf7gs96GHN8iyQzNKskoC8moYtKLcKc=; b=FZARLe7zNnd9ZYt9L5FV9jxRlug4mDkODeimAd9geeicZCG2345QtM+enpOY4gGsrN HfI5P7oX5iVK2dZZ0PO0LGt4CljAjy6Gk02YuFz6aW90lcamB8Uvg8Qsoc49YqIZart9 KSV9OK7U5n91LXgv1xFltOB5kI3MAf/dgfbTLH+olFmteDjNnYDr5ZSo1oOnE/HrbV3J v5Htsx0oOqMBswz9jbyFIZ5i6k81IfrPWOjDy6kPExc1M0WLwofOObWjyrE7EIilJIvB yZXZHOFTUh1r0If9Pw/G/IpnsXDvxFULHGj3xypHPDs5K/8aG7J211xYG2RmyD9Gr8zu FU5w== X-Forwarded-Encrypted: i=1; AJvYcCXaypyOz1YUegA1YdqPlV5zXSlHKcPar+LnR+N7IDaSAnBQ/Hl5MqS0T8nug/JHnhsKNqexn+Z6JwyezHs=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0zIbWe5jvX6/X8whghNzq8ycgevSfbizuZLD0PJlWjj3/bYus HrirtL6H2A/Rfa8nz5M5CI9Tc0fODvNHFzF8LbxoFD92XueotndvM6Bf X-Gm-Gg: ATEYQzywi6w0dKb3vNIF4ncC+5p0cCbrUVzOT547WgHtz+JsW6AIAIOvGIEpmolNRQe 29IHl1E4efsUeOI5OiBvUIWtMFdeU5uoIevFJFiwDXMNHjkPY5h+8W8s9VsaAcOVdZ1r8/mUZfH xzC6h/AZJU3NEDnQ+QwZ0/PKJE3Z/pLxz6BsE4T0YLFNl0rUI1kdDDkIccBOCXObibozapwUK2D /W63zPhYjrENgxexk11JSqd/OWOsYplHwK6uUhvk+ezaje66j0TeMUajq5LYB0BTIfQwLBdbrlF L1qejO4l5JhOn69lMgwvjrJkDi0flEP9/mq4Fn5brYjHrpUkKC59x+mrBUHayjwtpCkB+DxBMdN KYLnoZUjxwjpxjpUJpaeq5bmrUYvoHW6RlXF66sZzI7tqFp4n4OUhs4rSHB7YlfnH/HgFo654K2 fPvV8q0nl91WCtZxPcxYP3WiHX5ERa1ivP0/kmM6PWltPVZ7R6mg5c+1aggA== X-Received: by 2002:a05:7022:f8e:b0:119:e56b:957c with SMTP id a92af1059eb24-12bee613f8cmr1450943c88.1.1775119161057; Thu, 02 Apr 2026 01:39:21 -0700 (PDT) Received: from ubuntu22-base.lan (104.194.93.216.16clouds.com. [104.194.93.216]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bedd4e4e3sm1716646c88.1.2026.04.02.01.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 01:39:20 -0700 (PDT) From: munan Huang To: linkinjeon@kernel.org, smfrench@gmail.com, senozhatsky@chromium.org, tom@talpey.com Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, munan Huang , stable@vger.kernel.org Subject: [PATCH] ksmbd: fix use-after-free in __ksmbd_close_fd() lock cleanup Date: Thu, 2 Apr 2026 08:39:12 +0000 Message-Id: <20260402083912.457676-1-munanevil@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In __ksmbd_close_fd(), when cleaning up byte-range locks on a durable file handle closed by the scavenger, the lock cleanup loop unconditionally dereferences fp->conn->llist_lock to remove each lock from the connection's list: list_for_each_entry_safe(smb_lock, tmp_lock, &fp->lock_list, flist) { spin_lock(&fp->conn->llist_lock); list_del(&smb_lock->clist); spin_unlock(&fp->conn->llist_lock); } However, when a client disconnects without SMB2 LOGOFF, ksmbd preserves durable file handles via session_fd_check(), which sets fp->conn to NULL and arms the durable scavenger timeout, but does not detach the byte-range locks from the dying connection's lock list. When the scavenger timeout expires, ksmbd_durable_scavenger() calls __ksmbd_close_fd(NULL, fp). At this point fp->conn is NULL and the original connection object has already been freed by ksmbd_conn_free(), so it would cause a use-after-free or NULL pointer dereference. Fix by checking fp->conn for NULL before accessing fp->conn->llist_lock in the lock cleanup loop.=20 Fixes: c8efcc786146 ("ksmbd: add support for durable handles v1/v2") Cc: stable@vger.kernel.org Signed-off-by: munan Huang Reviewed-by: ChenXiaoSong --- fs/smb/server/vfs_cache.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/smb/server/vfs_cache.c b/fs/smb/server/vfs_cache.c index 168f2dd7e200..772a84d95fe3 100644 --- a/fs/smb/server/vfs_cache.c +++ b/fs/smb/server/vfs_cache.c @@ -463,9 +463,11 @@ static void __ksmbd_close_fd(struct ksmbd_file_table *= ft, struct ksmbd_file *fp) * there are not accesses to fp->lock_list. */ list_for_each_entry_safe(smb_lock, tmp_lock, &fp->lock_list, flist) { - spin_lock(&fp->conn->llist_lock); - list_del(&smb_lock->clist); - spin_unlock(&fp->conn->llist_lock); + if (fp->conn) { + spin_lock(&fp->conn->llist_lock); + list_del(&smb_lock->clist); + spin_unlock(&fp->conn->llist_lock); + } =20 list_del(&smb_lock->flist); locks_free_lock(smb_lock->fl); --=20 2.34.1