From nobody Fri Apr 3 17:36:51 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22AED3A4501 for ; Thu, 2 Apr 2026 08:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775117518; cv=none; b=d+QCRsb6PHcsG6VHos7gVnwsDTd9tlihA9lFcOZzswZI/wkATU0MBh+3xD8EWD7kFUfv7B3nv4x1TmSvvBlyyI/M01FYxz1XBLy6SC+XxQYGnThFluUjIVQEGf3UdaQiaFHsC7g0JzcoEt8isy4YgMV8IVkJp2dMpoR8DEjxTE0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775117518; c=relaxed/simple; bh=aiDV+ay9pDagfXi99dECc3+gFHUApEvFgcp/SMLLkOQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WeFnAZ2Jimu712nfWvOcapSaHTPzse5wJhVFPWWMm53gOq9/M9BH3vsn6XP4m004CZMT38WF5gnJskhFGg4ODH2oZ03NGCaS8thYL9DAfIve6vK5Id2PC61TgRnH3tNJSKZ4Hv+OQaIPhQgdbysQbMfn90FvARXe+E4iLqp+dss= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QVOh9pWE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R3kuIe8b; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QVOh9pWE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R3kuIe8b" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63271bGH1965112 for ; Thu, 2 Apr 2026 08:11:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=yFv97piS34p vw8S7ZuPziYbAwBwFldQJ4NalWJR5jGw=; b=QVOh9pWEICPGgTVQyCUf2lFQUB3 /3lHUE8RrAhf1r49B3XSffGuoEHAWWsQ1tp7fV31ETW4u8Clx3bL3vnhauJY0P3B YtWDeAS3hwXMj3EmEfFVIdye/XfKu1KB4GWS6jEmz4bHfyUfy5hIhz4JW6j/2O7O p1pFOy3NT4JtoYhBFwFYjfHfrqtdkucq95sX1a5IaPuoYdtGh/WwtutHvD2bP+l+ wLoE/aiWO7Q9KycepcdLkYu9w3ZZRuDzb/KsmpHXFikQ5hWIQ5JOV+CHlzvTLV29 2EwTfnpAN2j0umYyEKwGPkgr8U4jqSsK9XP5vjfPKHWMxhKqNRvXYSQbr8g== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d9b9h2383-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 08:11:36 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cfdc479f68so68061985a.1 for ; Thu, 02 Apr 2026 01:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775117496; x=1775722296; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yFv97piS34pvw8S7ZuPziYbAwBwFldQJ4NalWJR5jGw=; b=R3kuIe8bKjjXm0vU2ggqOTTFVcPQ5cQefR1J+4rD9jfYqwyoJ9hi+X4RJC3iJuixgm WpW8WKrhmUuSe1m06UhwGf8Q3cydwEZo89sVzHjdF8gCcMq42k+OO+YGzpJEp9wJqYV9 3t/0WSdXnDX0Ljfd1DQD6uLZyZiPwu9Pw8bY34TCoeTGwteH07Z21DgM2nXO2AWQFp4w DxIV/1vNH9ZuBq5pDtVJC5L5KZAJintNdxLh95NpPweiu9oa9E/W2CR+XtK43PIBpDdh uvnGqsfxBY5moTaGg56+pVoCdpTtkkyzJf9t3HC3kZUVM3Rba7CLnkeLZUtpyuILJ7WI adhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775117496; x=1775722296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yFv97piS34pvw8S7ZuPziYbAwBwFldQJ4NalWJR5jGw=; b=kDmYygShX1omi+/o5wjRK92gJJyYpSr+cTKcMjvmV5HbzlAFJAWNpMnuihvhREsURu Bcym2QpSI+9qpS0crbMa4SdZ1n3hJFxSPVMHFfSXHGoFXuaHHA2FOvLxwSfQW2Gjy4G7 oi/Z2KDpBudrme3b4E8pbpJYhYE3oGasTQQOSGo+79xA8TjRSS+CWEwdYeghVW08nJmz IFZwtUGuXUKPNVGfVyGumqJ6VUudBSoSbjrrqDo7rXTfzwra4+oWTQ/iqiNkltcZlvJS PeroRhlIc3d+pvXIMqAr+USMayF8alKnHodxoQawgWEPMNiVgjjRnWLFLX4MtNyMEGE2 QHWA== X-Forwarded-Encrypted: i=1; AJvYcCU6P/5IUnKC/dU3zc6MRKSmYu4kWH+yStNGKxaG5MdZMhONmNqxdMc5mP52b0gK7Bf9Ni7dOqfk3N6dut8=@vger.kernel.org X-Gm-Message-State: AOJu0YzdpBuu8IE2tcQvBrnnXNNE0wNqZB0Fh8VQN3D/wmWPWhcaked0 71m1BZBUTg2CZ2/xwodgmmV7/n6lDCjo18Aas41JXjLseZJ7ASwAlUB66kw7CPIvCy1iSARWwy5 aRpXZSz0Ry286Ca+oPZ2faTnYCyuiCu9zVK+AVtsNCDKo00Pg8sHaDfo4FcSt9cvnsUg= X-Gm-Gg: ATEYQzx3INMnaswtmkmy9EKU6E2Jc5ZSQq0v09IaZD4zk9D1CbER34n+duPcNGBJ4be Bn4gj21+vnlok4jx753drLT1OWbYzsFiFSHFEjfHlCbmnmW8qqTZyJ6c6VlrLuYLKDd8R77dw2A MHvGed9Ul60ycQVTtF7YNp0XUThYNQiJtSKDoCuQHQB4SsS46xGuvLyRn9WPehUJ0Tg1GYg40S/ yGMHYNbQRxkyEIgShOaC7JogMmgj7gAzzWshxuuVZgYYhF4uYfE/GPmxABYSqRFd5bvQukYSNuW JgY26mglSldtLfpaR1paofngSM5R8WPSD/Mn1Gx1Y21S7VwoOQGp3os5uSjUrfwmUxjpIhh0QnP VpwJNkxjWTjQEruuEYD3vrtNm+J01bZR44wUmZQUbCz/EoLBvvidX8DA= X-Received: by 2002:ac8:59d6:0:b0:50b:4d74:6614 with SMTP id d75a77b69052e-50d3bd9e18emr90671171cf.63.1775117495856; Thu, 02 Apr 2026 01:11:35 -0700 (PDT) X-Received: by 2002:ac8:59d6:0:b0:50b:4d74:6614 with SMTP id d75a77b69052e-50d3bd9e18emr90670831cf.63.1775117495403; Thu, 02 Apr 2026 01:11:35 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2c3a01sm5712604f8f.12.2026.04.02.01.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 01:11:34 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH v9 05/13] ASoC: qcom: q6apm-dai: reset queue ptr on trigger stop Date: Thu, 2 Apr 2026 08:11:10 +0000 Message-ID: <20260402081118.348071-6-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260402081118.348071-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260402081118.348071-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=TqLrRTXh c=1 sm=1 tr=0 ts=69ce24b8 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=w9bA4Yi6UXS1dLCTJJEA:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: 9gwltyYIWZH90M4PRuI0nC3SOIA_Lj-B X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA3MiBTYWx0ZWRfX0pjLCYGvZPZ6 OUurTAbEaykF0fLzIedLoDhBtftMkdjO+idf1Q8tot12HAofxCUwui2gmRrIOU+/5qRJVHRhPbe edVs22Sd1wwtv4wfmL1cT+DSZEkfo3tBfajmA+BWKgPB91JxQQGGcZuh2bKHy8Qv8F0nqjVt02e MOrHBIHZCtPpH2PXaPLkPDMryvPn0szPVnKCbmD01glIZMljKquLzo5NyIPrM3/ZXQI0F3h1zNY Aow5lKMSNUX0P7heCYvSW21j0CPgUdvkRBvocqCjvYONpbLQ2al4F1gs1DiUVTJUFckvgHGxU4Z Fp4fxDwIGKaJn4MThLA906CMS43hKgzPsVFXVJQBKrKS0xFfpn+hfJtr5rzXLQVJErCWW+0EwlY 9wolm09DB246VeKzf583MxTG66/xTzAhtKFFBRX3WSLS93E4X1S1+CEcxBWPIm1nkworqVNLuRv FvH0XOVoRsNkIt8BRPw== X-Proofpoint-GUID: 9gwltyYIWZH90M4PRuI0nC3SOIA_Lj-B X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020072 Content-Type: text/plain; charset="utf-8" Reset queue pointer on SNDRV_PCM_TRIGGER_STOP event to be inline with resetting appl_ptr. Without this we will end up with a queue_ptr out of sync and driver could try to send data that is not ready yet. Fix this by resetting the queue_ptr. Fixes: 3d4a4411aa8bb ("ASoC: q6apm-dai: schedule all available frames to av= oid dsp under-runs") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm-dai.c | 1 + sound/soc/qcom/qdsp6/q6apm.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-= dai.c index 306e928e7b49..292be457764f 100644 --- a/sound/soc/qcom/qdsp6/q6apm-dai.c +++ b/sound/soc/qcom/qdsp6/q6apm-dai.c @@ -317,6 +317,7 @@ static int q6apm_dai_trigger(struct snd_soc_component *= component, case SNDRV_PCM_TRIGGER_STOP: /* TODO support be handled via SoftPause Module */ prtd->state =3D Q6APM_STREAM_STOPPED; + prtd->queue_ptr =3D 0; break; case SNDRV_PCM_TRIGGER_SUSPEND: case SNDRV_PCM_TRIGGER_PAUSE_PUSH: diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c index 2dc525c8be42..5751e80b3b92 100644 --- a/sound/soc/qcom/qdsp6/q6apm.c +++ b/sound/soc/qcom/qdsp6/q6apm.c @@ -215,6 +215,8 @@ int q6apm_map_memory_regions(struct q6apm_graph *graph,= unsigned int dir, phys_a =20 mutex_lock(&graph->lock); =20 + data->dsp_buf =3D 0; + if (data->buf) { mutex_unlock(&graph->lock); return 0; --=20 2.47.3