From nobody Fri Apr 3 17:36:51 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4715E3A4520 for ; Thu, 2 Apr 2026 08:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775117515; cv=none; b=XeT2QIigyWMFEYRrkuhjeMDtNx8CsIR4ok+P//5VA5Z2XEd3QxcBg1i+XU5PqBdMkI1krW/dvI7iDqzG1K4Q/od0l2fIu7207De6sgUxxiTJEX43jtdvzu/N9jg6cQRiPfD45IfwiQrnQjwUMdWk/2hTmiyp2g/INsUIIHKzxDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775117515; c=relaxed/simple; bh=Nn5W6j2KgfG3MXrQpHQ1hcxXhxv/yUbhKAiv5Knj23A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Iu9vy1TM+EVK5F7a8AwOMBDozgv6MIyjb16ZgENxbtnDmD7UusHGaqDEqU32u2MlWDA+ceibtCwO7G3y+TZUpySm8gv73A/AcYhT2UJrR55wDXBE7zr6sclh7noYFZY0EZl/M/LIw7NWGAcBKiqcMatpziRjJB6zfdof7MUT/vg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VunrPcgz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ax1EiWH7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VunrPcgz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ax1EiWH7" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63271Gqo3746099 for ; Thu, 2 Apr 2026 08:11:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=it+OAEpYU8v 0MR39X1WR6T1UKdIHL61i+TcaqL8baj4=; b=VunrPcgzCR4Khhq5LSz9P3y5QWz rd3i7ujxBJdTYvcqnClTpViVW2hCkxj0siCNTQmKHHrJiMNo86Att8TNMcEMV9KY 8oNUeU6gaxrC+uq3T+Wo56M4427r45hc2qLxYjK4WWYgpbmgNarClxWyQfeJHFV0 LBVpODUNzfsA/qekN0Ti4c2YE3E4Yn+EFOg/2v8VuLE+dBfVJKAW7Jyi72OQmo0b AmtdYp9wjFCTQBNiBQlyUUQ3tqds/b4Zsr79+hdimJdY+wXayXiEujNRJKlY8Rry EOBh2O26HPZffO6iy71w9w+mRz1rzdk/2Qb1D5bq9Ci4MrAt3/aqQgBsUcg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d9324m7yg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 08:11:35 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-50b878a8c07so11986081cf.0 for ; Thu, 02 Apr 2026 01:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775117494; x=1775722294; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=it+OAEpYU8v0MR39X1WR6T1UKdIHL61i+TcaqL8baj4=; b=ax1EiWH7sS+miN0M3o/OGtuXIKfiJrkJPHNejtx56wmvOv8ZP9EGs0IyqgCWGAUsbw kcD4pXhDAE2/jZMbX4HzO3SYW4OZn+adGyo+YC/CdynJoSZ01/MIYKMIlmtY0a9tc5Vb ApX909+XWEmiaxywD/GmrB0b7W+4OMFlrmrcv6+uJrSGycKs1YvqA8ZHxBfvb9ergjq9 3owJEckXynyL/gWDwpHu2oJUgZ/vT3ictMWgLmtd4bJ0seHfzmzZs8QoVG+6+8RighFd UMGmtnQcVAXTJOgkaOMkkKKIq1ZCCLEIdfV3v1PsaFJvWHQerBqXgSAnpKqKZuP2S4A5 TgqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775117494; x=1775722294; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=it+OAEpYU8v0MR39X1WR6T1UKdIHL61i+TcaqL8baj4=; b=UCYJEiwbM13gXoEyBg1dfG0bcaUD12EuTUW6gv23NBLhEpa7H9UMeNABnqO/hjJ7ME J7BbURFRlPA53WX3LinlnXtDwNguUPQxPdv7XwYPooBfnvNEdBgSl2ERWm3kLHnbpjNt 6ap0sUdIvxkrn8WrXVjVp7e5X4YI37KaEO/YkELwOqbpPrzkpM1bVTYSCzDCFjCaIibN oVHh35mwjyMawJZ1BQ5zMvWW/9ObMr6XjMzUXcklbHwaXqFOIx2pKuA05NDDhY8iVACX PSYG10kgR24b8pZqXN8LvgzueTnsdGDgJhI7U0AGZjJuABU8oEVjHRb5UNHAMo/HpO1T m9sA== X-Forwarded-Encrypted: i=1; AJvYcCU5HK+vookQc7Uqc3IgIzJ+Va2eadW9EhcsSosbp2fFz/EYALjQnwmLOb0y1ZaxCEM45aF/l1wpTY4kgZ0=@vger.kernel.org X-Gm-Message-State: AOJu0YzXBuJ9pgFr36l69oEQkbEQuRispiFJ/2L7SXXt2pwMLcPzM8yG 2SfYb5tMy3fq4+PXBDJaLQPpcI/50YyqH5XayKa+yN7GlTelKNBwB+ROAGsY9KrH6W9BOR3ldu2 LqAuOMIkzW19qEUK95gqHioMuf8XtJCNa6ZMCYmBNJwsHz3OA0ng7eMYXoOdjm/OZPGk= X-Gm-Gg: ATEYQzySKvqlVhcDX9N7Ke8no+m+6B/XwHTt4OCRAsEI0qAZOxI4+vsjMZpCzF2oHmW EbFHKWOm4MF1h9o13BfCaeai7p/1BsZedoQdkzNM1eKQAODB8kELnmvA7IXBFmSPjwklyUPbcDM cGe68QhNG9z5e1y2SOqxrPAG8ekrAQvhnmwGlUo71atJ6BkB5N5qfAkGCYpFslft56Va+J2O/Fb 5pYUuSvX0/jX7gOWyaDtUjhofOCq5WkJjsEC4uGQc8SyFgnx6QHKTw8cnJuxnYzSrLmbtXsorqv EsMC6+b+5+r0/fpHo7/O608xJBNt6x9b2BVbRhgswdYyCpEI+xpvZn2R4/a074nlBIuQ329dgdb r6hYR1tKxY//i2oGU1BP+CKJkAzUy7aOE/6hnjvLv6Wp6MZpxGIy58lg= X-Received: by 2002:a05:622a:1e89:b0:509:1cf9:ea09 with SMTP id d75a77b69052e-50d4c1176c4mr34007041cf.67.1775117494376; Thu, 02 Apr 2026 01:11:34 -0700 (PDT) X-Received: by 2002:a05:622a:1e89:b0:509:1cf9:ea09 with SMTP id d75a77b69052e-50d4c1176c4mr34006791cf.67.1775117493979; Thu, 02 Apr 2026 01:11:33 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2c3a01sm5712604f8f.12.2026.04.02.01.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 01:11:33 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla , Stable@vger.kernel.org Subject: [PATCH v9 04/13] ASoC: qcom: q6apm-lpass-dai: Fix multiple graph opens Date: Thu, 2 Apr 2026 08:11:09 +0000 Message-ID: <20260402081118.348071-5-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260402081118.348071-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260402081118.348071-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: arKDbZ_2P5ZauvMZngsiOcNscKsJllM5 X-Authority-Analysis: v=2.4 cv=TKBIilla c=1 sm=1 tr=0 ts=69ce24b7 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=M_mAHeyD2EURj3i0m2kA:9 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA3MiBTYWx0ZWRfX2TdNsSkGv2Cn GVEUsX2bPcYp3rVU99nIZYJQ09T87sKmo9Ktr4PpDzS4cYrY1OmiT7y57o29Mro8BQQOeLRDQrC O7N9O+Er8EPv6cQHrWT+wNI/wMTl/VeLELz8qNAOSTP5WIwyKT6GvueRuK9BzZY2Bx/E547z4+X i8zB+CaSb9oTokf7MMrJnLXtcHLtyfQSgP18ORWHTTXzH/lr0NrLZF539kzXnzjH19OLTY4aGRj oLvO/AbJTJc1lkz7ue+8fYEDpMvXi+8c0p6UsnH/Z7FQAw8GlZTAdlA8fil6VrpIu7q9knjxrvB rz7zEggJUHvdac98wiJ51gvljld5OulLCF3qFfm7ec0rni6QrDGDRN2TnZRQLxT3yFBtCIPi0fG LLwCsl53rp5gTjPw15oLw6+wwsXAyUh6lhlkfY9toBangcwmSswSF6hNO0GIkjV78oCj1s2oXOf KskpXik/TWOlgrapQcQ== X-Proofpoint-ORIG-GUID: arKDbZ_2P5ZauvMZngsiOcNscKsJllM5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 spamscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020072 Content-Type: text/plain; charset="utf-8" As prepare can be called mulitple times, this can result in multiple graph opens for playback path. This will result in a memory leaks, fix this by adding a check before opening. Fixes: be1fae62cf25 ("ASoC: q6apm-lpass-dai: close graph on prepare errors") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6= /q6apm-lpass-dais.c index 5be37eeea329..ba64117b8cfe 100644 --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c @@ -181,7 +181,7 @@ static int q6apm_lpass_dai_prepare(struct snd_pcm_subst= ream *substream, struct s * It is recommend to load DSP with source graph first and then sink * graph, so sequence for playback and capture will be different */ - if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK) { + if (substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK && dai_data->graph= [dai->id] =3D=3D NULL) { graph =3D q6apm_graph_open(dai->dev, NULL, dai->dev, graph_id); if (IS_ERR(graph)) { dev_err(dai->dev, "Failed to open graph (%d)\n", graph_id); --=20 2.47.3