From nobody Fri Apr 3 17:36:52 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD59A39FCB6 for ; Thu, 2 Apr 2026 08:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775117506; cv=none; b=MukX6SVoUtVIB5qtsxkZcD5HVLP6urqhlDZuGRdJGgenWThdB92KaT27/pST/CkT5/QHIHZmGiUAyBPZh2pyZowwhhzsLlhDZryjFuUZEBSluhzBvvC0LfdOPiilTdRH7gBtlWnnNSFLAvrQP+QAVuJRow+DbLPXVon9/n0eTSw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775117506; c=relaxed/simple; bh=6jShP5otc7Z/xglFZY5mqaUqDhEckaI1JOm+jwe6kcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z3t+YZxma9/nJ3bcvnzKaEqtgrdD48Gev74vlIegsddbb0PLJ4bhQVt094W8LV3wphF1jsYO9zz5JBJ65qJppepO+x4O0b8I2WfpfQx9SCkryMu1pd+sh4jSRNCBilt5yATmDBICrV8RnM4G8gwXuEoIwOsF4B6kXmSHDqWLQsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S2+HEmJ3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SkPkdTXs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S2+HEmJ3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SkPkdTXs" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6327E4J01128392 for ; Thu, 2 Apr 2026 08:11:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=xKWL+GAYqNp +tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=S2+HEmJ3crj0wV11XDg2YgQvH18 a02FPNaTVFkTDaGhtLm4FWUPs3Nbt7ANG7Hkh1PJDZF5AoK4AcDPQinGI7LYvZOh Cw/SytMcQZtiaYuTxanDCGCaibH69gLTwZOO0rNCjwOiKiHi8UucFWOMAXhkcMm5 Bsy28+ZhrIjSXb1hyDG7uZdmZlaZAjCV2B8PvzRMNzjTL6t49fBttl2svAOTCLVW edkJBYXnz94tJeD0lI//5WF77q+5i/a/dmeHKA1LC/suuO4a/1ATBoYcyKWdm8SF o5ppAWx5uuYaWrFmw7koQ+RxeRMJKv8XCXhaTtJuJpD8Ttm3JN7hWwpwHbA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d96k9b1j4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 08:11:33 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd722c1a69so150150485a.0 for ; Thu, 02 Apr 2026 01:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775117493; x=1775722293; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=SkPkdTXsRsBIsiUJn74uHNoSYimewlGu1IFheNZgq3SBDXK3nvXVijHDUlvnL+O2mv ZphzAGpVlv6Tjun3k49MPq5skQVK1OOjtUbqL9U2eaxWfuj3Hq4wjWpm10w5X+/ATAaa rsUN2G6HFCx8E4QeOBk6d36FiDM2buSTH98I9Y5b8VcPDyNTCgsokWIJHa9wUTRm181L Q7ohXy/bkZbXplBKZHzkPiOqDhcXde20Zevnuv4fxwmcZ6trRNS8wpsSqRdsRY2Sczi3 EMvaHaDxsBoNZfsXEGAif7i3EZgAHq+DEcrWeypfRmb1EYvK6NrdQTzUqbFSFLpqcSvN ex1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775117493; x=1775722293; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xKWL+GAYqNp+tTujHQMkzR7HCGoYVVs3sPVjIKR0hiY=; b=j0HC/0Ccy5uMeza4+wkZyCIVN5qZdpJq4IIsRxzYaFfCkFLm8bjdsqsY0O7lPfufr3 Q0cm1frQK/NyVsH/1GgL+AHjImxj5A6Yzll1cksxK0NUUnjUuKInQbO8veRlg5p86AZb BSe+mtKpYFuKyVekDOKx3bgJ5SYmSQa62tfKjKC7gpa0fE0/i6xZJvZmElpXxRV/hIqr Varm8HDu+OUdQ9J2b7XlCqAww62M95QzNImy3UDfzcw+dasyhikBQKzysARSsbi3xdsq pdO9Sa9cHK1iKDhdfxdV30XxDFNYEHZTrQr7EUchYPIDwZcGm9UAfFyYi6redl6cO1hh ZW2g== X-Forwarded-Encrypted: i=1; AJvYcCVil07z+z4zUJ8HPlIQmHzJTuawnwxmP89tC//VDpqIbJHuqL5SSROY3wkHGBzH4DG8A8mMtSixNvJ3Nj8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5u5iY2uDVR4uru5scWzZqVd4MZjg1xRFxITTPhmyWmAcSIkEO qPBCzdJlOqf0/AHvGS+70z59a3z5M+zHAs82ckvcy59Y+vk2/Hdtx5i1xFp17tnD+CpXKT/emtU HGwlfgRk2QpWdY+9xSpelpZWYhDztS4lTDhhZzBQzmPluoHEIr8d1BSRsyA5NcB4bNDQ= X-Gm-Gg: ATEYQzxntoZnPdC1xy3QfTsiDlNxyRFJKUXSyGjaG8ITccBGu3oje3M4RLxqhmzWC44 GsYBKhYKR0mkuFiYmdTSCiOxRngrngfLJKjVpwn99I+IgGOuUdQzG2BD06o+ajq8euWP3INlV8/ czUu2PvSRKHdAEPBXYOeEAtYske2WT5N3EcDxTidIgwNRYf+u0D/rTWBm/aZKsYHwceIThqS7LJ 3rAIQiZsNaDK1ZYwy+MoFwWu17I6zaNgsl6aBvJCydOLCtEcFj14ELiXEikFy/44rq3MBfVeqbO l9DLpdIYMjS+gbysDpgOCNPH4wgA9rg8rAu4LACH3UIIFxvdNXvolDbcasGZfWGh9ATR8VgMcFC fWiT74gFeKvCAicGDVRHHxfVGMMGX4j5Js44FXI3rYOhUzUfxPKW6hSE= X-Received: by 2002:a05:620a:44cc:b0:8cf:d804:4569 with SMTP id af79cd13be357-8d1b5af1029mr968085085a.23.1775117492948; Thu, 02 Apr 2026 01:11:32 -0700 (PDT) X-Received: by 2002:a05:620a:44cc:b0:8cf:d804:4569 with SMTP id af79cd13be357-8d1b5af1029mr968082085a.23.1775117492486; Thu, 02 Apr 2026 01:11:32 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2c3a01sm5712604f8f.12.2026.04.02.01.11.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 01:11:31 -0700 (PDT) From: Srinivas Kandagatla To: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org, val@packett.cool, mailingradian@gmail.com, Srinivas Kandagatla Subject: [PATCH v9 03/13] ASoC: qcom: qdsp6: topology: check widget type before accessing data Date: Thu, 2 Apr 2026 08:11:08 +0000 Message-ID: <20260402081118.348071-4-srinivas.kandagatla@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260402081118.348071-1-srinivas.kandagatla@oss.qualcomm.com> References: <20260402081118.348071-1-srinivas.kandagatla@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=doLWylg4 c=1 sm=1 tr=0 ts=69ce24b5 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=5HTw2GpdgXbBP0wXRk4A:9 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: BW5qsI7wF7QIbbin75fUz4Nj0XfA6PAC X-Proofpoint-GUID: BW5qsI7wF7QIbbin75fUz4Nj0XfA6PAC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA3MiBTYWx0ZWRfX5OUcV6hRH/TJ C4T+1XNJaX5SUr/KZNMBIcVJygh1XAMODmArV91mLrikGeUF0cIIIQ04od2+tYLt7ghlSPvpIeC 0Ex2+Q/mRUPwkgsKx5qpGGnoxbQjGkEVOyDcSU/tiWvh7jWEVsdGX5BVNJpz6L45QO9QAnnZQOz XlUfECQXIEeCxMnpZ+OYzJn50CzF2+MbioekiocKEC0UiCghnQ7b5ylWx3HT46k+eOBkCTt5CcB 1HF8Rcji8GLnPB8S09Z9sJxqCM2vn3MsAkp1a78vFS9eRbYRJ2nV1lwD0724s4gjzVjTtZrFKcG IFieMijmZxKWXJUwKkzAYZJ16Y9Oft61W23itRMijGFunT4WC1rWH/aa0qO+KIxkxCYInolmtVO w4p2J3dQkAlNqDWXj/LirmnlX3fqhvTIDs2EBjQjIUiqLYSlhcwNwjYc+ax1WRWy5ze7Ouz1jwH 4m/4qq4hi+ZMsMRw6ew== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 impostorscore=0 spamscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020072 Content-Type: text/plain; charset="utf-8" Check widget type before accessing the private data, as this could a virtual widget which is no associated with a dsp graph, container and module. Accessing witout check could lead to incorrect memory access. Fixes: 36ad9bf1d93d ("ASoC: qdsp6: audioreach: add topology support") Signed-off-by: Srinivas Kandagatla --- sound/soc/qcom/qdsp6/topology.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topolog= y.c index e732fac9b8ca..1f69fba6de26 100644 --- a/sound/soc/qcom/qdsp6/topology.c +++ b/sound/soc/qcom/qdsp6/topology.c @@ -952,9 +952,6 @@ static int audioreach_widget_unload(struct snd_soc_comp= onent *scomp, struct audioreach_container *cont; struct audioreach_module *mod; =20 - mod =3D dobj->private; - cont =3D mod->container; - if (w->id =3D=3D snd_soc_dapm_mixer) { /* virtual widget */ struct snd_ar_control *scontrol =3D dobj->private; @@ -963,6 +960,11 @@ static int audioreach_widget_unload(struct snd_soc_com= ponent *scomp, kfree(scontrol); return 0; } + mod =3D dobj->private; + if (!mod) + return 0; + + cont =3D mod->container; =20 mutex_lock(&apm->lock); idr_remove(&apm->modules_idr, mod->instance_id); --=20 2.47.3