From nobody Fri Apr 3 01:23:05 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE557309F09 for ; Thu, 2 Apr 2026 05:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775108982; cv=none; b=jRroCZFRlKis6cfZxUZvcpuztP/tu+j+D2QbEIONjMz99TFcPd9ULokAFfMyo+aNDTkarOXxfQ26fYKwY23rO8ujjYzEZK4GDlg/ysp5IbwsIGhJXC98XD4Bk1HrvHTWYObmYG4zdDqByu8NeCotYZynjqJVLjlDDT2tk7VsfZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775108982; c=relaxed/simple; bh=GcJa7Pz0PPXt0b9IVULyqmwnNI0VqYsX73C2BhOipgE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bk50xVHJuy9yGgS7QjTXILgUS7z+g8I2IAoflit9x2ngAgIW97Fh0ZYWcs6s7B9ooIFpobg3CjTmZlSYvtlwNEV/Op0gVMu44VARzHGucfH5MOWgwWI1xI9Ycf+i9qvsCJgVxTb2o9hRI5ZagHoB116YCJ4m/g0lXCAMAgb7+SQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gGYVLTx7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ftp8GT5/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gGYVLTx7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ftp8GT5/" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6324Qs1J1551690 for ; Thu, 2 Apr 2026 05:49:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=f3tzm5JBMwO w31Vut+2DEjfXxJ0rtenkMsmzXkmycbw=; b=gGYVLTx7Zby8UkIW7dM1Jd/DZuA ainZAqX99Czs+QMXlZ2RKPUQfWTbnC7gBnlVSRdTCXeST1wwu97JyZMfpYgmox3u UxrPWmTaabx54Y7xDNLw34Eyf/3DhHhWTKKnW91tgHgZg77JplFu2/aSQK6B02PV Erlzr9b+BDvDePtV/sy/OEdn8Df5ZHeW9bzUKCKqzRTWDJmzAbklrmwkNeZvmnvp M/3Tf87Mg0rcbq6cX6r3+prYc20NXp5VYWliw8+EqT/YGvctJbyP8KjqYQ8Hrh3h 6LD0ojrMwM14IfqPwX8p+8alH30EPTjc7N9H9flLNHNGXCtppqzTWF1khJQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d9heer8ae-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 05:49:40 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c7691378914so235584a12.0 for ; Wed, 01 Apr 2026 22:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775108979; x=1775713779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f3tzm5JBMwOw31Vut+2DEjfXxJ0rtenkMsmzXkmycbw=; b=Ftp8GT5/RSO+Tz9s1juoydKXzp83KTFNurgUjBAvNLYskj1axrq6YJGOSr5BgcHCiR LMOhOsQAo6a8Kgd3O9HVBBzkV0AoXVOlUOdGcaiYZLPM04T+KqFKfA5+M3Y/dAYufsj1 zbWqm5sB9H57CqdWogiNS4DNQa4ESs3BO7KxH96woXbNpT47NViHeC1bb4hFsmza+c03 sglJXwydefL85eCeckksLmbVIOjtz6pwZ6kyS5LR0EVKWde9MNAAyLKRIjU4Af9guKHW pZgo8w6RlrY4ZEzct7hynB+hxiGtcVelH/mV/0UqPJMfTKULipM3LDGqqwG3aqhnmUy+ pBJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775108979; x=1775713779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f3tzm5JBMwOw31Vut+2DEjfXxJ0rtenkMsmzXkmycbw=; b=iQTAlUC+T0+NSsk6i2cDulia3YyUhc4lYDbdD+yDp5JpVHrCHXsTrezcLocQtPwLnL /pgj5Nic7rHjG6cVZiHsmozW2ObHIC+s+u2LQbYBxDTKDoEe5oM3Kka7R30alqO5LukO IWiBGuE3RKegmIolw6igEaMTfn5aJb85eI7uWlEe8Eb0lVZk9H+3zbNKxADvoVKw0fOM zEfTXIJ2Odh9xjFOJF3deTVuwtVnAwxVRIDYfd7dNBeWbh8A1vOecQew0JZnv1O+iBKU 3NjHoBJHWMB73lqr4Qzb5TDejsliEPZ/zKLrhHDH2jl0A/s8Jq214QlbO32ICoW34bvC TjrA== X-Forwarded-Encrypted: i=1; AJvYcCWd5VAr8MI+/8mPwxYBy/AuabbC47+/XZGzYKG3DUSVYMieApwpGfkNjgdZTrifk+7GF8YqS8XPnngeMN0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2ap4mV2dJG76EEuW14frZaJ0QuTLogeQmK7NCaqWsUWNQm8l6 mTYxCNpvh52kuJ3xHbwOUQ/otBPz3zdP1RdATQBnBSLf9nFfww7R/5OjaE8nyi7nXnMCAYkJVGf nmKrmk122FGzGcLgxiM2AEiJI4eQJZKn75GIEmqRRWzlgoNgPkR5HOH+PXrlBcpY6cTc= X-Gm-Gg: ATEYQzyny9pHF3acXEvw/J1eLWrCPxguaMM72TVJelgQvIAFJp9/UY+NbZP+Bf83q7+ OoP3nv4QBet/SrJMs26BgfIXNJHJvn13DiG53ez5aEnBc0gXszAGef7uM882bTaAnOHjNtMCt2o GDWpCzw5SAA2em5ppJCk/Zkcu9lks5VnsHwCXO2CllBX6T63vcDzeFzYZlnqDN1ZJqjYncATeCc ReF1WSrvzMHXGoo7Ry69MwLcOrwBIDUym18TaCUKV9At7YUzmpt5DsJNx66nVJcBf1hJ6tt5UPV FcWi50av5Q2mn2Ywuh9P2GE47RidVE3QlcIIcFBarwCBLOVGajGrIrTnfKrx25WCxJHFfd0EeMs hdHLg7YvUX2J/Z34jvKfmaWth16LiA97s2YzXJnM+LZebC1+O+iPVBQ== X-Received: by 2002:a05:6a00:3c87:b0:81f:be3c:9c9e with SMTP id d2e1a72fcca58-82ce89975dfmr5757627b3a.33.1775108979376; Wed, 01 Apr 2026 22:49:39 -0700 (PDT) X-Received: by 2002:a05:6a00:3c87:b0:81f:be3c:9c9e with SMTP id d2e1a72fcca58-82ce89975dfmr5757597b3a.33.1775108978879; Wed, 01 Apr 2026 22:49:38 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b5fb22sm2167747b3a.26.2026.04.01.22.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 22:49:38 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, andersson@kernel.org, konrad.dybcio@oss.qualcomm.com Subject: [PATCH v7 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Thu, 2 Apr 2026 11:19:21 +0530 Message-Id: <20260402054923.3061925-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> References: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: upsl7RBXN3hTTO1TIQRemswrHT-N-IiB X-Authority-Analysis: v=2.4 cv=VY36/Vp9 c=1 sm=1 tr=0 ts=69ce0374 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=HL6mAI18knL3XnPGOeUA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: upsl7RBXN3hTTO1TIQRemswrHT-N-IiB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA0OCBTYWx0ZWRfX/qG8mCkXybZy CIVWe6TFas9jNZibuqiEkV4c5aMf6QWAzTufb/bQqeqxIN2oL6XTjl4pSjttOnryG0Wd6AOcKHx BROUnjop2UoZ1lx2iRC5rDlZmpZOjWUwK49n1CJxUqXGJmpJb12O8mZf6Ywx4PK4Qzhneyif1ar TauuyIxKv6Fav2vwTNDTrYIQJxmmxQqlHkY8ZRuIJz9FcsZHVHsjMnM5iJqrAutm/tHAwgijmCC g5UPk/W7P5Mag3K58ObGWft1zzPcGs5s6x5G56isiE5gparJ8sa2K0Cix+R/rPiqNPRneiRxFQy YZj2rZqaO3VC9EnxCIZ23FvcMSiskGHha1gA/dOkxeIQbj9Gk5yRrU1J4I0YXvUPUkCdCa9QMj6 eEtw5z3uXqzzV4Ttpyx0EzOgyGX2UDX9I0OdR9F4KDiskiM/ubF5S9RzI6jM2GS5HXLrKqqAPl9 WvlAewKBJm3phrDfwzA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020048 Content-Type: text/plain; charset="utf-8" Replace the hardcoded context ID mask (0xFF0) with GENMASK(11, 4) to improve readability and follow kernel bitfield conventions. Use FIELD_PREP and FIELD_GET instead of manual shifts for setting and extracting ctxid values. Reviewed-by: Konrad Dybcio Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 11f4ae749e51..ce4874b9480e 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -23,6 +23,7 @@ #include #include #include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -37,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK (0xFF0) +#define FASTRPC_CTXID_MASK GENMASK(11, 4) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" @@ -515,7 +516,7 @@ static void fastrpc_context_free(struct kref *ref) fastrpc_buf_free(ctx->buf); =20 spin_lock_irqsave(&cctx->lock, flags); - idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); + idr_remove(&cctx->ctx_idr, FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)); spin_unlock_irqrestore(&cctx->lock, flags); =20 kfree(ctx->maps); @@ -649,7 +650,7 @@ static struct fastrpc_invoke_ctx *fastrpc_context_alloc( spin_unlock_irqrestore(&cctx->lock, flags); goto err_idr; } - ctx->ctxid =3D ret << 4; + ctx->ctxid =3D FIELD_PREP(FASTRPC_CTXID_MASK, ret); spin_unlock_irqrestore(&cctx->lock, flags); =20 kref_init(&ctx->refcount); @@ -2505,7 +2506,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, if (len < sizeof(*rsp)) return -EINVAL; =20 - ctxid =3D ((rsp->ctx & FASTRPC_CTXID_MASK) >> 4); + ctxid =3D FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx); =20 spin_lock_irqsave(&cctx->lock, flags); ctx =3D idr_find(&cctx->ctx_idr, ctxid); --=20 2.34.1