From nobody Thu Apr 2 23:54:51 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979D42FE582 for ; Thu, 2 Apr 2026 05:49:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775108978; cv=none; b=J+G0r3U0xzj3x823TMhsFz4epsOimF/EbRtcPTJ+RuUo/r6tJAba05FLUV3AyBsgUxQVAkzENKxjvcivXedNJHQKO+i8DmTR1QDMncBYaMxxapdYM+VzPlEFK1Chrcq9cUPunrxBkJvh+jbb7XNqmXRl9assVVkMnCGSEaqff4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775108978; c=relaxed/simple; bh=uzqUI8UkTFwiu4DmC/RQnQacWKtYbJXj7rczp6GuGB4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=K6QGUkhoXu/q6qFHnUh47mZpR4JurgjNyxW3YUs8NCZnY21aJdO+GtnmEbXolEd0aMvJAASpSg6t5oC91frzWoXqcb/OPUEdH7QXyC1v/E+oH/PyN4bBtzPwILulC7lGphn+u/FKOmB8kbXyJ+It6QK/YNwy9BcgJizU+DqlnaY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aT62KUIC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gm25prLS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aT62KUIC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gm25prLS" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 631M40Mu547094 for ; Thu, 2 Apr 2026 05:49:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=gW0pzUiuvZ7 Sy5PEGDehzgCXNgTwqsOcea/DS5PsqFU=; b=aT62KUICq4vixdMgPXJtK+9K2vq ErzhBqMcEVqEKt7wXoGByUuPzG/ep3EP1Jnrj5Zni+3Fel/+K1buR25XI/rPDPK5 bIXwGNr7qtwFxgBRLGg4zI0BNSK6sWYq+qCOZr6mffX1kVW32gNL4JbpZJ2kFud+ 668rMEp1r0z8QvrRRzXZ/60sq66S1FCDm4jQcbNf+xwaSkqNG7MmcAt6amXxtaRY 6dHLNvmG5rwupiqnnNNpgK7nQvZyMN3Jjy9R09sjCs+FqJHsnFoS+0S8eIfPskP2 N+kUjtgg8NZSiYBFd5JvUpQ1gjP5M9OgSR4JCYo3sv+S5UOFG4J7P4kV8fA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d94vvk4sr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 05:49:36 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82c714cb672so304773b3a.0 for ; Wed, 01 Apr 2026 22:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775108975; x=1775713775; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gW0pzUiuvZ7Sy5PEGDehzgCXNgTwqsOcea/DS5PsqFU=; b=gm25prLSI8vuOIPVNuzqYq8zhTlE28jh+rnlV8mH3FwXl0xENQH96cqFN+Vpu/Cdl3 ZThd3SMe5y4JWUVzz5jnLmZDj4OaolmBHI6O5dASnf5H5Up5OtBdRR+inkx4wjTf4mKu b7vvUt9GhdEdrt1ZVURTjek2etN9aMZ93Qor6FCiMNn8WRMXgxmwMd1LVEbu75srWmiU n59fXBOHrdlTNYC0mxGjVTzbL8g5Z80lxmSv9ShyGnj57JI+eHO8s55/G/0UIfRpyaSz nqcV1jaex7qoYmGqIUoDPMF31yYilbTWDzem6/inlRW0jMJqXDXycF0RhE9WFmEYVzSs 8TCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775108975; x=1775713775; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gW0pzUiuvZ7Sy5PEGDehzgCXNgTwqsOcea/DS5PsqFU=; b=DCOUqoSTPFKS+KysMSfZj1s1lmybMfjd0boSPNStjsGBOzDUp4cYgNeFIRt2Dovsdk IvsiM+14c90MwdDezalgZvGMEYMtyC8iA+4WwIAOCqBkBM+4jCmu/q3gE0mjGyFwhmLQ h59n3Uhce8/w3aV2ybW4hOrBFC0sikRo/NBpdAM4vY/v82PA5Jg+1vCr1A5KcWFNrIPl 8VvsdA2YxT7EB0bXiAho2r9s0bYvm7bnEi5Ro+XTKbu/d9UTil5aiQBO3KAwehGE1CmM P83RNm1qoBcrf3EgHifamrgLaMj6WrzoCND+gLbhe8EqGvZD6bwSqVUcL0DfQU09d7+v rpFQ== X-Forwarded-Encrypted: i=1; AJvYcCVulDyjuP6jWz+b3/grjNd6KvOvZAT/2PFkRwcgYQd/dvtZRrSQJy5ARWZqjEiNwPvPuQk9gJZ7iqDBQ94=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0XIGlwV1V+GaavhhSa5oyhvWWiEEm0+YP/F3BT5GMsLAQZZyG IWv4Zv5ZA4j5zp/hOrnewIeXVAAdktJEUS7Byj31hwrPTz7YEZv+a01KODc5C63RRYFwpWEMYa1 ZyCgOuJEHMT8GsF6RN9CSiUFVh0ViAf5AA/2XjjcP2LqoeRRHZGz1usGXY4PX5ncI0lU= X-Gm-Gg: ATEYQzzeRWp9tZ90e1YPmR1GNWpOTt/2hSTTVYUcDXSMkiflWIUCWWlpIv38NMI52du 1LjrAGTV19GZVOAz3A6j/6+U67pgQqWY2KVHG0G93BZa3iDZvs5BF04E9xAsccgMdhyDhe7SiB8 LCCkpRze+TuYy7MTJUpeuvtnSt4lKPR9SKq+tYQZ0Xjy5wjbgHhW5mQYStWfHk5dzPe1fgM7YuB ixAPsHQf2B0CwLnA5lWUJnfwRsrxskLz7EUClVPCr4QRrM4M0gISILxzwuM8SmA2T+aT6NfhPcl ToHP48oatMwzjpyc9wihQ/I6/UluCfb2fBCMww3rH9FZynnJeIExGY2+IfHTk1vjZexkToPotCl UbdwRKaH9z3nEJhH3obFwJf67YaYVzRUpx8/4ho1vWB5kvHVZ4ErqMg== X-Received: by 2002:a05:6a00:1d86:b0:82c:212a:906a with SMTP id d2e1a72fcca58-82ce89b8e11mr5803982b3a.36.1775108975491; Wed, 01 Apr 2026 22:49:35 -0700 (PDT) X-Received: by 2002:a05:6a00:1d86:b0:82c:212a:906a with SMTP id d2e1a72fcca58-82ce89b8e11mr5803953b3a.36.1775108975015; Wed, 01 Apr 2026 22:49:35 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b5fb22sm2167747b3a.26.2026.04.01.22.49.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 22:49:34 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, andersson@kernel.org, konrad.dybcio@oss.qualcomm.com Subject: [PATCH v7 1/4] misc: fastrpc: Move fdlist to invoke context structure Date: Thu, 2 Apr 2026 11:19:20 +0530 Message-Id: <20260402054923.3061925-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> References: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA0OCBTYWx0ZWRfX1rtHeDAlkoEA ej7CgdBteoSiZGqiy5T9iqKNUQgqoGHyggzCaeAQp2iqoBU6SfidJVmWWGTK92AQGZZ2ntZ3+Pt 3Hlb8ciCaDGGn4NCbz3mPeQ83/EyR+zV+FGyqjI2T6+tD62ShjAno+nd9muYqOfZMvir/UVcjUf b9VFn21d6XbYydvmzYABiOWQU5od+KhQiEy3akE7MCe529qDdJOrqRDhcBYhNbwXt33SdtJa7jc b/3DLKm09Ae5jUqf8Z5xyqGJ/WjLCIxzLs2/jmYVb/5LLLmqYuGUWg3xAMJ9Kn/a3EHbbNrjVar Ev+VVhGKCy7dhytoxJ5Y1b0VSvuWTiyXXtPj6wwE3HEs5J4JeIu82DWknzlY+r3e0tfcK6g3bn5 0kfkOjeRW4BiOVX4t5GwR9jPGZWi23Pxa14RygkUuxnENVzTiQ1Mw+69wx8/ldGWJE63XynHIxX VRnVYeCzBLHypiI2iUA== X-Authority-Analysis: v=2.4 cv=DJSCIiNb c=1 sm=1 tr=0 ts=69ce0370 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=IPuuj3Sbi4WKP8RQR18A:9 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-ORIG-GUID: 0QroVwMQZeZPoTkoDpClHTC4ZcqMAhpD X-Proofpoint-GUID: 0QroVwMQZeZPoTkoDpClHTC4ZcqMAhpD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020048 Content-Type: text/plain; charset="utf-8" The fdlist is currently part of the meta buffer which is set during fastrpc_get_args(), this fdlist is getting recalculated during fastrpc_put_args(). Move fdlist to the invoke context structure to improve maintainability and reduce redundancy. This centralizes its handling and simplifies meta buffer preparation and reading logic. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 47356a5d5804..11f4ae749e51 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -233,6 +233,7 @@ struct fastrpc_invoke_ctx { int pid; int client_id; u32 sc; + u64 *fdlist; u32 *crc; u64 ctxid; u64 msg_sz; @@ -1016,6 +1017,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrp= c_invoke_ctx *ctx) rpra =3D ctx->buf->virt; list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); + ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1118,18 +1120,11 @@ static int fastrpc_put_args(struct fastrpc_invoke_c= tx *ctx, union fastrpc_remote_arg *rpra =3D ctx->rpra; struct fastrpc_user *fl =3D ctx->fl; struct fastrpc_map *mmap =3D NULL; - struct fastrpc_invoke_buf *list; - struct fastrpc_phy_page *pages; - u64 *fdlist; - int i, inbufs, outbufs, handles; + u64 *fdlist =3D ctx->fdlist; + int i, inbufs; int ret =3D 0; =20 inbufs =3D REMOTE_SCALARS_INBUFS(ctx->sc); - outbufs =3D REMOTE_SCALARS_OUTBUFS(ctx->sc); - handles =3D REMOTE_SCALARS_INHANDLES(ctx->sc) + REMOTE_SCALARS_OUTHANDLES= (ctx->sc); - list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); - pages =3D fastrpc_phy_page_start(list, ctx->nscalars); - fdlist =3D (uint64_t *)(pages + inbufs + outbufs + handles); =20 for (i =3D inbufs; i < ctx->nbufs; ++i) { if (!ctx->maps[i]) { --=20 2.34.1 From nobody Thu Apr 2 23:54:51 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE557309F09 for ; Thu, 2 Apr 2026 05:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775108982; cv=none; b=jRroCZFRlKis6cfZxUZvcpuztP/tu+j+D2QbEIONjMz99TFcPd9ULokAFfMyo+aNDTkarOXxfQ26fYKwY23rO8ujjYzEZK4GDlg/ysp5IbwsIGhJXC98XD4Bk1HrvHTWYObmYG4zdDqByu8NeCotYZynjqJVLjlDDT2tk7VsfZw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775108982; c=relaxed/simple; bh=GcJa7Pz0PPXt0b9IVULyqmwnNI0VqYsX73C2BhOipgE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=bk50xVHJuy9yGgS7QjTXILgUS7z+g8I2IAoflit9x2ngAgIW97Fh0ZYWcs6s7B9ooIFpobg3CjTmZlSYvtlwNEV/Op0gVMu44VARzHGucfH5MOWgwWI1xI9Ycf+i9qvsCJgVxTb2o9hRI5ZagHoB116YCJ4m/g0lXCAMAgb7+SQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gGYVLTx7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ftp8GT5/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gGYVLTx7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ftp8GT5/" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6324Qs1J1551690 for ; Thu, 2 Apr 2026 05:49:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=f3tzm5JBMwO w31Vut+2DEjfXxJ0rtenkMsmzXkmycbw=; b=gGYVLTx7Zby8UkIW7dM1Jd/DZuA ainZAqX99Czs+QMXlZ2RKPUQfWTbnC7gBnlVSRdTCXeST1wwu97JyZMfpYgmox3u UxrPWmTaabx54Y7xDNLw34Eyf/3DhHhWTKKnW91tgHgZg77JplFu2/aSQK6B02PV Erlzr9b+BDvDePtV/sy/OEdn8Df5ZHeW9bzUKCKqzRTWDJmzAbklrmwkNeZvmnvp M/3Tf87Mg0rcbq6cX6r3+prYc20NXp5VYWliw8+EqT/YGvctJbyP8KjqYQ8Hrh3h 6LD0ojrMwM14IfqPwX8p+8alH30EPTjc7N9H9flLNHNGXCtppqzTWF1khJQ== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d9heer8ae-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 05:49:40 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c7691378914so235584a12.0 for ; Wed, 01 Apr 2026 22:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775108979; x=1775713779; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=f3tzm5JBMwOw31Vut+2DEjfXxJ0rtenkMsmzXkmycbw=; b=Ftp8GT5/RSO+Tz9s1juoydKXzp83KTFNurgUjBAvNLYskj1axrq6YJGOSr5BgcHCiR LMOhOsQAo6a8Kgd3O9HVBBzkV0AoXVOlUOdGcaiYZLPM04T+KqFKfA5+M3Y/dAYufsj1 zbWqm5sB9H57CqdWogiNS4DNQa4ESs3BO7KxH96woXbNpT47NViHeC1bb4hFsmza+c03 sglJXwydefL85eCeckksLmbVIOjtz6pwZ6kyS5LR0EVKWde9MNAAyLKRIjU4Af9guKHW pZgo8w6RlrY4ZEzct7hynB+hxiGtcVelH/mV/0UqPJMfTKULipM3LDGqqwG3aqhnmUy+ pBJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775108979; x=1775713779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=f3tzm5JBMwOw31Vut+2DEjfXxJ0rtenkMsmzXkmycbw=; b=iQTAlUC+T0+NSsk6i2cDulia3YyUhc4lYDbdD+yDp5JpVHrCHXsTrezcLocQtPwLnL /pgj5Nic7rHjG6cVZiHsmozW2ObHIC+s+u2LQbYBxDTKDoEe5oM3Kka7R30alqO5LukO IWiBGuE3RKegmIolw6igEaMTfn5aJb85eI7uWlEe8Eb0lVZk9H+3zbNKxADvoVKw0fOM zEfTXIJ2Odh9xjFOJF3deTVuwtVnAwxVRIDYfd7dNBeWbh8A1vOecQew0JZnv1O+iBKU 3NjHoBJHWMB73lqr4Qzb5TDejsliEPZ/zKLrhHDH2jl0A/s8Jq214QlbO32ICoW34bvC TjrA== X-Forwarded-Encrypted: i=1; AJvYcCWd5VAr8MI+/8mPwxYBy/AuabbC47+/XZGzYKG3DUSVYMieApwpGfkNjgdZTrifk+7GF8YqS8XPnngeMN0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2ap4mV2dJG76EEuW14frZaJ0QuTLogeQmK7NCaqWsUWNQm8l6 mTYxCNpvh52kuJ3xHbwOUQ/otBPz3zdP1RdATQBnBSLf9nFfww7R/5OjaE8nyi7nXnMCAYkJVGf nmKrmk122FGzGcLgxiM2AEiJI4eQJZKn75GIEmqRRWzlgoNgPkR5HOH+PXrlBcpY6cTc= X-Gm-Gg: ATEYQzyny9pHF3acXEvw/J1eLWrCPxguaMM72TVJelgQvIAFJp9/UY+NbZP+Bf83q7+ OoP3nv4QBet/SrJMs26BgfIXNJHJvn13DiG53ez5aEnBc0gXszAGef7uM882bTaAnOHjNtMCt2o GDWpCzw5SAA2em5ppJCk/Zkcu9lks5VnsHwCXO2CllBX6T63vcDzeFzYZlnqDN1ZJqjYncATeCc ReF1WSrvzMHXGoo7Ry69MwLcOrwBIDUym18TaCUKV9At7YUzmpt5DsJNx66nVJcBf1hJ6tt5UPV FcWi50av5Q2mn2Ywuh9P2GE47RidVE3QlcIIcFBarwCBLOVGajGrIrTnfKrx25WCxJHFfd0EeMs hdHLg7YvUX2J/Z34jvKfmaWth16LiA97s2YzXJnM+LZebC1+O+iPVBQ== X-Received: by 2002:a05:6a00:3c87:b0:81f:be3c:9c9e with SMTP id d2e1a72fcca58-82ce89975dfmr5757627b3a.33.1775108979376; Wed, 01 Apr 2026 22:49:39 -0700 (PDT) X-Received: by 2002:a05:6a00:3c87:b0:81f:be3c:9c9e with SMTP id d2e1a72fcca58-82ce89975dfmr5757597b3a.33.1775108978879; Wed, 01 Apr 2026 22:49:38 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b5fb22sm2167747b3a.26.2026.04.01.22.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 22:49:38 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, andersson@kernel.org, konrad.dybcio@oss.qualcomm.com Subject: [PATCH v7 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Thu, 2 Apr 2026 11:19:21 +0530 Message-Id: <20260402054923.3061925-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> References: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: upsl7RBXN3hTTO1TIQRemswrHT-N-IiB X-Authority-Analysis: v=2.4 cv=VY36/Vp9 c=1 sm=1 tr=0 ts=69ce0374 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=HL6mAI18knL3XnPGOeUA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: upsl7RBXN3hTTO1TIQRemswrHT-N-IiB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA0OCBTYWx0ZWRfX/qG8mCkXybZy CIVWe6TFas9jNZibuqiEkV4c5aMf6QWAzTufb/bQqeqxIN2oL6XTjl4pSjttOnryG0Wd6AOcKHx BROUnjop2UoZ1lx2iRC5rDlZmpZOjWUwK49n1CJxUqXGJmpJb12O8mZf6Ywx4PK4Qzhneyif1ar TauuyIxKv6Fav2vwTNDTrYIQJxmmxQqlHkY8ZRuIJz9FcsZHVHsjMnM5iJqrAutm/tHAwgijmCC g5UPk/W7P5Mag3K58ObGWft1zzPcGs5s6x5G56isiE5gparJ8sa2K0Cix+R/rPiqNPRneiRxFQy YZj2rZqaO3VC9EnxCIZ23FvcMSiskGHha1gA/dOkxeIQbj9Gk5yRrU1J4I0YXvUPUkCdCa9QMj6 eEtw5z3uXqzzV4Ttpyx0EzOgyGX2UDX9I0OdR9F4KDiskiM/ubF5S9RzI6jM2GS5HXLrKqqAPl9 WvlAewKBJm3phrDfwzA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 spamscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020048 Content-Type: text/plain; charset="utf-8" Replace the hardcoded context ID mask (0xFF0) with GENMASK(11, 4) to improve readability and follow kernel bitfield conventions. Use FIELD_PREP and FIELD_GET instead of manual shifts for setting and extracting ctxid values. Reviewed-by: Konrad Dybcio Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 11f4ae749e51..ce4874b9480e 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -23,6 +23,7 @@ #include #include #include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -37,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK (0xFF0) +#define FASTRPC_CTXID_MASK GENMASK(11, 4) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" @@ -515,7 +516,7 @@ static void fastrpc_context_free(struct kref *ref) fastrpc_buf_free(ctx->buf); =20 spin_lock_irqsave(&cctx->lock, flags); - idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); + idr_remove(&cctx->ctx_idr, FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)); spin_unlock_irqrestore(&cctx->lock, flags); =20 kfree(ctx->maps); @@ -649,7 +650,7 @@ static struct fastrpc_invoke_ctx *fastrpc_context_alloc( spin_unlock_irqrestore(&cctx->lock, flags); goto err_idr; } - ctx->ctxid =3D ret << 4; + ctx->ctxid =3D FIELD_PREP(FASTRPC_CTXID_MASK, ret); spin_unlock_irqrestore(&cctx->lock, flags); =20 kref_init(&ctx->refcount); @@ -2505,7 +2506,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, if (len < sizeof(*rsp)) return -EINVAL; =20 - ctxid =3D ((rsp->ctx & FASTRPC_CTXID_MASK) >> 4); + ctxid =3D FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx); =20 spin_lock_irqsave(&cctx->lock, flags); ctx =3D idr_find(&cctx->ctx_idr, ctxid); --=20 2.34.1 From nobody Thu Apr 2 23:54:51 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B740337C0FD for ; Thu, 2 Apr 2026 05:49:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775108985; cv=none; b=nw+AWuws9aNvl+iS5+ucfFJo/KRC8c8iTOB2Grq4Z+DDsrsRA6FjHH4ZDuC88Hq+cQaXWiKsKzznDsDZQ2jR0Yckrm6ZNKqC9LPk1BDJZIwZekispnUEaAuXXGYgprRcJoNE/0ABB12bjZkmkl66tOAhgRAGggKI8c117kMitqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775108985; c=relaxed/simple; bh=6pn8QZUNZuwIwx7rZw79zRlJEi07RuDoGlQrFWIxmfw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gAx7EiVEBA7IeDV3IcKKrlPbvwyFIV0ztZNJQEkCYsU0ncRmSFoMq47ZY0VQPDu3CWbdyHIcQ+hKW2B4iuJbRYhVNmoDNQCo1vq+dICCwpBTyT/6KLIEuj8GybOqcZw+CB51AVhsD6cCy6H4q/i3v69u/UxNR3MCI95o8pYEtDE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wa2GWInY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Nafu+4TD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wa2GWInY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Nafu+4TD" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 631M3xf43745869 for ; Thu, 2 Apr 2026 05:49:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=c9KwVpO67WV x6EkOZYSJykEVM2NVlk46JFPzeGImNfQ=; b=Wa2GWInYmj6Sq/K7Q2dnbkVFAeS jztO22SyUfCCAWXoo7dmciJnXxq1/HGkfv81uU2bQDTZPc5sNeXgWZDLf/Wymfeo 6Xxgs3OONaYqKVVkqdQdc8/07Vu9hOSZdOEzVVibwCNpTbPk60Neobg5Hf2m9TbZ lD98koylv4eGOC56KBjIf22bH3XrPjWUak2V1W/QSHZ+UeGDLeW6ab1w6M7N4HBN yxVXtn6CB8qNc94SuQ2RBvWTmx7ZMhjcOdy/RfhSoSpn6sTxcbNXgI9T7y6xeSeL Mqvoya5DRN6IZxUHi8GwBvH6tu7PY5KAnO6qIrhWZ1gDywHgM055HikSXfg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d9324kkge-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 05:49:43 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b6097ca315bso925198a12.3 for ; Wed, 01 Apr 2026 22:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775108983; x=1775713783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c9KwVpO67WVx6EkOZYSJykEVM2NVlk46JFPzeGImNfQ=; b=Nafu+4TD1O4MQl6eG5pUKV8Mo3xHmbUhAcH8QWIE8aE5wg1MTLrD+x/k5BxzN/ikqP OJQ3pilSce63hZyPVnNTZPo7JKFcOxt8Wdk/QEfeNXEOKpQLCTuE8N7Rd+0gBeaLShko YwLJbRZ4my8SuzfJSzlHMTjEf0sDajersJESEBc7hsmPjlNo6alclDfLx1mmnB63FHOE WRxjVv89mcY1+a6nevCPIgIxIETp72n0YTaeJMwMbS5Z9uxJMEaE8qho3BFos2s3AYaQ PT3/L29cNoFem6zWnyvMPEq/3eKEHs1zPr3mANiCH/kEJPg4pVthyqCm1yQIUhHlU2cW VtnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775108983; x=1775713783; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=c9KwVpO67WVx6EkOZYSJykEVM2NVlk46JFPzeGImNfQ=; b=Klov95iSH51Yimt3SHBHcjx54e2aJUlFxi5OJvXgI59GesvQObs046pJx2edmlsuHW h6BGJfRoaM8UoXe/c7d/HE6uyeaJUDxYhbV9kcLikMXtPSGTKxWd+6QDyMZaMkO1T6nn LbXkSCsJKqqZKRArOFGGm2RSpLcVa+xLvAdCrvJjsAMlG+P0hleKOwXMOR0/sPbEVdwL iUhUwJvjS7JxDLC9BofeIs632hzqdsQ9hg/JPYhKFNH9+5/ofAhxcWuuN/q5aNtEmuVf TzhQB1yK/rEYalgBkIgFZ1LZiJPJYReSYySpGYvn07rwChmJQxQzgFGPSzyWQlt/P3ew ocMQ== X-Forwarded-Encrypted: i=1; AJvYcCXEcg1UbB0enQgGDn0iIXzEH9yyufYTO9cTmLx7yR6hThRVr5PhAt4BREoHrhx4EB+1xBDlSnga3qo5lPE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1nXjfFU/noz4r22aIDMFYTarWT++Je8AsLU1oRm0fUte0wdEQ 6QijRvOWQwaTYZyqZY2GpRxZ9LFPYOZecQANykONqjvk+tHJnpLnZaNEG7illxELpXSSHPrEQsG wdEYhqcM58crOAmbh/enoYZO+2LNPB1USaB1KGfr4Y1UDtJaspv+HQ95Ymd/AiEEM7Mg= X-Gm-Gg: ATEYQzymBl23qB7Vwea3wrlTMv3mrI/Ge4GwiP2/FjFUaxn3jaVz4rHB4Isj0AxvQJx eKK+Lp8kQcCUmex/2cYeJpiiTjqQVur3R6LLNi+h+QFl5KwlE9CkASbAO3m7BCzqp1ljIirsVna N057el7RAhxjRh7tjSiKg5pganeRpKh0C/rx/0ZsZwYUnoAMpi5y6HYhGIapyqCn1nChboPn2ga VFPgijUA2eHTVP60s5+fTUgzG8ItRDHDZBF8m0B1/oHvkyq2SgAIMwQiN4Iri5cczOtg/X+kCze r/eItnrbtVksnFzwjxhW74JHVAUNUbEEUpvRzcaO+0yx+8j+CK+0XjngCLpZvbwNAW3QIYZf03k AspEj0JC9DDg90iHWQ4wmZC/qKUUI93k2lVAPu8NIrvZClydprzYx5g== X-Received: by 2002:a05:6a00:a111:b0:82a:1044:3563 with SMTP id d2e1a72fcca58-82cfb886170mr2551869b3a.23.1775108983186; Wed, 01 Apr 2026 22:49:43 -0700 (PDT) X-Received: by 2002:a05:6a00:a111:b0:82a:1044:3563 with SMTP id d2e1a72fcca58-82cfb886170mr2551846b3a.23.1775108982724; Wed, 01 Apr 2026 22:49:42 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b5fb22sm2167747b3a.26.2026.04.01.22.49.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 22:49:42 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, andersson@kernel.org, konrad.dybcio@oss.qualcomm.com Subject: [PATCH v7 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Date: Thu, 2 Apr 2026 11:19:22 +0530 Message-Id: <20260402054923.3061925-4-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> References: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: F7R1gB0V-Gj3J4K2R0rsybd56AQmbhbn X-Authority-Analysis: v=2.4 cv=TKBIilla c=1 sm=1 tr=0 ts=69ce0377 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=JTa3dIKMUYn8LlmgGFYA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA0OCBTYWx0ZWRfX8rfy5EMNPz2+ yEimvKEnbu3Tlj/lhO/wUTe1A5M4btPz6kmdaK1HpEfKOWB0b/MZnFlSi/cZAhdIX5kNGfIvQiR yomhZcFNoIOjknBtpKCNR71ITBGCR5tSPro0/tq5GIFWz/o1b3RlzWYpYiTbxuxYJEjpUp0x1d7 V3NGUyWZ4WQ157XC17gqqz1s+h/Gwjj2FUwUR/zpZ7F7etLMc2vPlk622Lc9A8QrezeQ+/do+5e 1gI0iHX7jxDbBX5J9caL2R5mUEos/WOoDuzFT+8Xt8bF1NfV4snFXMoViQsGFqWu/EmoqcKpRhI RtCVqKp74sIpYy5i+3Po7D59NdmzQwY/zRGaLvc6MfwROMt7EmBad502uLRAjZqLCzJrnlwma/p lqBd8K9ixij8GxhJTMcX1aWTXt91fLnFZEN1N8Ei/oHdlT5IQfsP5dc3Vpe5Qn77mQE8jv7fDEj 6fQfNao56MmDNXh6dKA== X-Proofpoint-ORIG-GUID: F7R1gB0V-Gj3J4K2R0rsybd56AQmbhbn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 spamscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020048 Content-Type: text/plain; charset="utf-8" Current FastRPC context uses a 12-bit mask: [ID(8 bits)][PD type(4 bits)] =3D GENMASK(11, 4) This works for normal calls but fails for DSP polling mode. Polling mode expects a 16-bit layout: [15:8] =3D context ID (8 bits) [7:5] =3D reserved [4] =3D async mode bit [3:0] =3D PD type (4 bits) If async bit (bit 4) is set, DSP disables polling. With current mask, odd IDs can set this bit, causing DSP to skip poll updates. Update FASTRPC_CTXID_MASK to GENMASK(15, 8) so IDs occupy upper byte and lower byte is left for DSP flags and PD type. Reserved bits remain unused. This change is compatible with polling mode and does not break non-polling behavior. Bit layout: [15:8] =3D CCCCCCCC (context ID) [7:5] =3D xxx (reserved) [4] =3D A (async mode) [3:0] =3D PPPP (PD type) Reviewed-by: Dmitry Baryshkov Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index ce4874b9480e..4363e0cc296b 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -38,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK GENMASK(11, 4) +#define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" --=20 2.34.1 From nobody Thu Apr 2 23:54:51 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C783237C11F for ; Thu, 2 Apr 2026 05:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775108990; cv=none; b=QYu8vyRM1u52Og8bGN8n75mIPii0YnAIomojUcOM2l7yt7Ibi5m6oAJYQDaPwKl3HIFFu54ISh1JipiSzwYDjywptt7tuOn9sVhZhc51zNN9NGYVNGdmoqnUNN9DiJiSHpQvvojLgvkowz9/TsHhgkDPTz1CMSHHfH7BLkCJe7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775108990; c=relaxed/simple; bh=X6VY0q9L+uUtnqFcREzObboFHxTVQ0lMp1x19HwGxis=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Z1sgBpbKWLSsIVxYS+/ajEDw76tQClModCCRq36JIylgmS2ck/ADtRFzM7HP8UsKjVVrgCwaRI+ea5Ubx85l5fifXi3Jugj+NOv99jktaeJAvya7BJUDZlD11u1zFZ5rfXpPhC/SxUVM7dvi34Lr64ujkrle+zAr8/qAvsCinGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Eu4yUDoR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DrZ+Vd46; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Eu4yUDoR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DrZ+Vd46" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 631M49lG1965112 for ; Thu, 2 Apr 2026 05:49:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=7oB02y7DFV4 f1UWHYqajk1w575aCaNpMNr02LPqXAcI=; b=Eu4yUDoRtYt7fCso2YhZMhuz9Iq WMd1xwGL0ebWGKctydfo25iZKUU66w9s8XmZxv4SUIOqzR6zwMdHy3QVxY1khflX pBc6S3OboAI0Au2rvHxWmTbIWuHsayu9nzgi/9ij7hTibffVatkEHctpoRzvirD+ FNQca2Fj+QLy5iMQ/edMTSszHuIqUawOhbnrkIn5vk7V4cQDRYUpKTXhQdQXp+Rg +Z1b4Mz6RgXBSF738Ttv2j1/MhGatNPNwCEp486KixIFa5YBjR7vxNIJTo/YUFkG We+SiackFMR2M8rAKsMux8sDulXYD4Pidb7uqAM83yO9pNLylEQ1iCkLY4w== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d9b9h1de6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Apr 2026 05:49:48 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-82ce0a9e558so402275b3a.1 for ; Wed, 01 Apr 2026 22:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775108987; x=1775713787; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7oB02y7DFV4f1UWHYqajk1w575aCaNpMNr02LPqXAcI=; b=DrZ+Vd4620+EC0DnMZk344EfjnNp49OCto5gZyRHhUbF5Bf92IDMgeBxpdn5fhX5cV o0aQ41EDnwbzPbN6C6h4+ZbpiOmDYWnB3hBA7lxg5w3mi6u1f5+a1dX1IWfkU1Sd5wE5 5mwP2k7fLsBejrkU10FcRX2f3uBGUm9LkPfH8tSZkOV3Vnk9d5vUlrE9Zduu9/cNp7kW mi7NqxpR1UK5q56bK/Kh1lWbjZFt5SCUubnM2Z5JV8iA2vEKbNQpGPYOh8rDWn1HYADZ zPu1B8Wy/TK+f+uxXAqj4iLy+7Bd0pBaBKGBBKlwSggN72hQZmNDXjq6LGcR4Xz+ArQP ZFzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775108987; x=1775713787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7oB02y7DFV4f1UWHYqajk1w575aCaNpMNr02LPqXAcI=; b=ExIB6s7gY0OhL80H4r2jctSfBHyogg1VmSW1BhjuzheGPardrUcOeqxV8Q2e9V6DW2 aUIv/60KTKe353Lpu0UYnfOOHszhGnz28V8l3qXTXKcVaECUtVKhKFxGRzR+pZw6FwB7 31UfVXyEOULkR0gnNM7nFnGfK+B9zRl04cBuk4WohLY7soA6tCKCuhZFQTR7WAzntSZM RdQUCt0pwYxCgq+JIIw3ctekKX5geEGUry7yPuwnIMBs7DQ3RVhoKGGfeC8Dxokd3TLI 5iZu06LpNZcndansIIvJi5dtKM9cPyj544PrQQOnP/NCia7Mf6moQ3FmtZL0oSkZ2LV6 9UJw== X-Forwarded-Encrypted: i=1; AJvYcCXRbyeywpYnsFNFO2FovPXors7vYBR8VPNSPKFeYAbkTr9GBTy5KY4GE7bM/4OJfwifWiQuOgLxWbT+k6I=@vger.kernel.org X-Gm-Message-State: AOJu0YyTqNZAJ0ixWjqdQ6/qaBtXh+SW5VY+kVHNdceURRwP6pFDt5hb 070ywuf3Pduw0ZLB1ZtOjMx09/aoJ4Ta7V61HPT6UWgbOFnwqpHjnJiFZZALEmcUuhdrNDxWw16 2Fs4NvI3avHiIaLu8pV26FFo7Q2UWzJPPY2mkXw9g+B5MKMFYZWVfpw44mAbLBDPMqoGiCioRpC 8= X-Gm-Gg: ATEYQzwx82Pxs0mUnIua8QyeZC6nnuV23ZdQHaUnCoWQllllKde7DOewkTKk1djutlS p79VfXE1+5L3wL0MhMqs6HzdwylZ+w+TzrKs7TFBDXXn22U/gHeVYoDjv9/SPEW64Wei/Ey0BOv EirdhjQZri0uvJCfY95LgxGDa7tSfh5kJBR9MTE4jwnC9wO0Il7aerIXEhpJBctri9mpIIFIhy/ 8onXSkstGAlu/pGIoVfjdeimDIVwOHmVqtnOkl4ll3hH2GdpNI180VwIgjrJgRHQNtm032E//vW bxPCFsw9/a0TwmhsLrozdMKj10C2PJjMV9ydz6jxvHflUhegxtdA99cskQvv/MqOK9Tmf44phNI RTKmvlPht6QvDMrB3BbYCvLCCNTjsXXGfMDv7a4D4WEmNLj0ODwjpeQ== X-Received: by 2002:a05:6a00:1c84:b0:82c:e76b:c68c with SMTP id d2e1a72fcca58-82ce86e2e62mr7119026b3a.0.1775108987072; Wed, 01 Apr 2026 22:49:47 -0700 (PDT) X-Received: by 2002:a05:6a00:1c84:b0:82c:e76b:c68c with SMTP id d2e1a72fcca58-82ce86e2e62mr7119003b3a.0.1775108986562; Wed, 01 Apr 2026 22:49:46 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b5fb22sm2167747b3a.26.2026.04.01.22.49.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 22:49:46 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, andersson@kernel.org, konrad.dybcio@oss.qualcomm.com Subject: [PATCH v7 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Date: Thu, 2 Apr 2026 11:19:23 +0530 Message-Id: <20260402054923.3061925-5-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> References: <20260402054923.3061925-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=TqLrRTXh c=1 sm=1 tr=0 ts=69ce037c cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=TEHdEMHTk_fMHrPBF0kA:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-ORIG-GUID: ntCSw_S0KuWRc4J0gg54CKmhh67kn3FQ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAyMDA0OCBTYWx0ZWRfX00SdMNt8yiPd DuiELAi5yDmd6a3h/LPcCY9Eeisd4FWqd+Jxw/tTIpbonpnEf9TOTzlZVALnNq1cSd568wJH4pS 5CpQwekfgJvAuoYaUEE7QVdMg+H0WpaDrQLVCW+MOSmZ8DvvIkz7nFWLkvicGrAkrbkFJLxfAqh cIMbPvjXH4UuYCKrCpMD2olAtqzi2p/SGc5kFDs+pL36r3GngUb4W98GmAyZqaBo37KHjvWlKkz UWF6bNYJP6AzZsLjOzAwJAggoWMM2A59x6eNDnY7fhzpbpsxhBGrwUGDQW8Elco9GafiNH5s8x0 jNPgEeatYiUzkBwe0XpA/5LDvxtHShvqXe9oCOf2gXbthElad5zFcDUO8aH5krHi2a2VEXt0XMj R38oMbUiMHsYJ72acpXUzr+XacBrs/5pShY1/Fh8r5t0zvUYPfLTQoeJL8wECood5L6MmT8B8FH OtCYQvcfdVjya7nxXGQ== X-Proofpoint-GUID: ntCSw_S0KuWRc4J0gg54CKmhh67kn3FQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-02_01,2026-04-01_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604020048 Content-Type: text/plain; charset="utf-8" For any remote call to DSP, after sending an invocation message, fastRPC driver waits for glink response and during this time the CPU can go into low power modes. This adds latency to overall fastrpc call as CPU wakeup and scheduling latencies are included. Add polling mode support with which fastRPC driver will poll continuously on a memory after sending a message to remote subsystem which will eliminate CPU wakeup and scheduling latencies and reduce fastRPC overhead. In case poll timeout happens, the call will fallback to normal RPC mode. Poll mode can be enabled by user by using FASTRPC_IOCTL_SET_OPTION ioctl request with FASTRPC_POLL_MODE request id. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 132 ++++++++++++++++++++++++++++++++++-- include/uapi/misc/fastrpc.h | 10 +++ 2 files changed, 135 insertions(+), 7 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 4363e0cc296b..25f385f4704d 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -24,6 +24,8 @@ #include #include #include +#include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -38,6 +40,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 +#define FASTRPC_MAX_STATIC_HANDLE (20) #define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) @@ -106,6 +109,12 @@ =20 #define miscdev_to_fdevice(d) container_of(d, struct fastrpc_device, miscd= ev) =20 +/* Poll response number from remote processor for call completion */ +#define FASTRPC_POLL_RESPONSE (0xdecaf) + +/* Polling mode timeout limit */ +#define FASTRPC_POLL_MAX_TIMEOUT_US (10000) + struct fastrpc_phy_page { dma_addr_t addr; /* dma address */ u64 size; /* size of contiguous region */ @@ -236,8 +245,14 @@ struct fastrpc_invoke_ctx { u32 sc; u64 *fdlist; u32 *crc; + /* Poll memory that DSP updates */ + u32 *poll; u64 ctxid; u64 msg_sz; + /* work done status flag */ + bool is_work_done; + /* process updates poll memory instead of glink response */ + bool is_polled; struct kref refcount; struct list_head node; /* list of ctxs */ struct completion work; @@ -308,6 +323,8 @@ struct fastrpc_user { int client_id; int pd; bool is_secure_dev; + /* Flags poll mode state */ + bool poll_mode; /* Lock for lists */ spinlock_t lock; /* lock for allocations */ @@ -923,7 +940,8 @@ static int fastrpc_get_meta_size(struct fastrpc_invoke_= ctx *ctx) sizeof(struct fastrpc_invoke_buf) + sizeof(struct fastrpc_phy_page)) * ctx->nscalars + sizeof(u64) * FASTRPC_MAX_FDLIST + - sizeof(u32) * FASTRPC_MAX_CRCLIST; + sizeof(u32) * FASTRPC_MAX_CRCLIST + + sizeof(u32); =20 return size; } @@ -1019,6 +1037,9 @@ static int fastrpc_get_args(u32 kernel, struct fastrp= c_invoke_ctx *ctx) list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); + ctx->poll =3D (u32 *)((uintptr_t)ctx->fdlist + sizeof(u64) * FASTRPC_MAX_= FDLIST + + sizeof(u32) * FASTRPC_MAX_CRCLIST); + args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1188,6 +1209,74 @@ static int fastrpc_invoke_send(struct fastrpc_sessio= n_ctx *sctx, =20 } =20 +static inline u32 fastrpc_poll_op(void *p) +{ + struct fastrpc_invoke_ctx *ctx =3D p; + + dma_rmb(); + return READ_ONCE(*ctx->poll); +} + +static int poll_for_remote_response(struct fastrpc_invoke_ctx *ctx) +{ + u32 val; + int ret; + + /* + * Poll until DSP writes FASTRPC_POLL_RESPONSE into *ctx->poll + * or until another path marks the work done. + */ + ret =3D read_poll_timeout_atomic(fastrpc_poll_op, val, + (val =3D=3D FASTRPC_POLL_RESPONSE) || ctx->is_work_done, 1, + FASTRPC_POLL_MAX_TIMEOUT_US, false, ctx); + + if (!ret && val =3D=3D FASTRPC_POLL_RESPONSE) { + ctx->is_work_done =3D true; + ctx->retval =3D 0; + } + + if (ret =3D=3D -ETIMEDOUT) + ret =3D -EIO; + + return ret; +} + +static inline int fastrpc_wait_for_response(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err =3D 0; + + if (kernel) { + if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) + err =3D -ETIMEDOUT; + } else { + err =3D wait_for_completion_interruptible(&ctx->work); + } + + return err; +} + +static int fastrpc_wait_for_completion(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err; + + do { + if (ctx->is_polled) { + err =3D poll_for_remote_response(ctx); + /* If polling timed out, move to normal response mode */ + if (err) + ctx->is_polled =3D false; + } else { + err =3D fastrpc_wait_for_response(ctx, kernel); + if (err) + return err; + } + } while (!ctx->is_work_done); + + return 0; +} + static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel, u32 handle, u32 sc, struct fastrpc_invoke_args *args) @@ -1223,13 +1312,14 @@ static int fastrpc_internal_invoke(struct fastrpc_u= ser *fl, u32 kernel, if (err) goto bail; =20 - if (kernel) { - if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) - err =3D -ETIMEDOUT; - } else { - err =3D wait_for_completion_interruptible(&ctx->work); - } + /* + * Set message context as polled if the call is for a user PD + * dynamic module and user has enabled poll mode. + */ + if (handle > FASTRPC_MAX_STATIC_HANDLE && fl->pd =3D=3D USER_PD && fl->po= ll_mode) + ctx->is_polled =3D true; =20 + err =3D fastrpc_wait_for_completion(ctx, kernel); if (err) goto bail; =20 @@ -1812,6 +1902,30 @@ static int fastrpc_get_info_from_kernel(struct fastr= pc_ioctl_capability *cap, return 0; } =20 +static int fastrpc_set_option(struct fastrpc_user *fl, char __user *argp) +{ + struct fastrpc_ioctl_set_option opt =3D {0}; + int i; + + if (copy_from_user(&opt, argp, sizeof(opt))) + return -EFAULT; + + for (i =3D 0; i < ARRAY_SIZE(opt.reserved); i++) { + if (opt.reserved[i] !=3D 0) + return -EINVAL; + } + + if (opt.req !=3D FASTRPC_POLL_MODE) + return -EINVAL; + + if (opt.value) + fl->poll_mode =3D true; + else + fl->poll_mode =3D false; + + return 0; +} + static int fastrpc_get_dsp_info(struct fastrpc_user *fl, char __user *argp) { struct fastrpc_ioctl_capability cap =3D {0}; @@ -2167,6 +2281,9 @@ static long fastrpc_device_ioctl(struct file *file, u= nsigned int cmd, case FASTRPC_IOCTL_MEM_UNMAP: err =3D fastrpc_req_mem_unmap(fl, argp); break; + case FASTRPC_IOCTL_SET_OPTION: + err =3D fastrpc_set_option(fl, argp); + break; case FASTRPC_IOCTL_GET_DSP_INFO: err =3D fastrpc_get_dsp_info(fl, argp); break; @@ -2518,6 +2635,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, } =20 ctx->retval =3D rsp->retval; + ctx->is_work_done =3D true; complete(&ctx->work); =20 /* diff --git a/include/uapi/misc/fastrpc.h b/include/uapi/misc/fastrpc.h index c6e2925f47e6..c37e24a764ae 100644 --- a/include/uapi/misc/fastrpc.h +++ b/include/uapi/misc/fastrpc.h @@ -16,6 +16,7 @@ #define FASTRPC_IOCTL_INIT_CREATE_STATIC _IOWR('R', 9, struct fastrpc_init= _create_static) #define FASTRPC_IOCTL_MEM_MAP _IOWR('R', 10, struct fastrpc_mem_map) #define FASTRPC_IOCTL_MEM_UNMAP _IOWR('R', 11, struct fastrpc_mem_unmap) +#define FASTRPC_IOCTL_SET_OPTION _IOWR('R', 12, struct fastrpc_ioctl_set_o= ption) #define FASTRPC_IOCTL_GET_DSP_INFO _IOWR('R', 13, struct fastrpc_ioctl_cap= ability) =20 /** @@ -67,6 +68,9 @@ enum fastrpc_proc_attr { /* Fastrpc attribute for memory protection of buffers */ #define FASTRPC_ATTR_SECUREMAP (1) =20 +/* Set option request ID to enable poll mode */ +#define FASTRPC_POLL_MODE (1) + struct fastrpc_invoke_args { __u64 ptr; __u64 length; @@ -133,6 +137,12 @@ struct fastrpc_mem_unmap { __s32 reserved[5]; }; =20 +struct fastrpc_ioctl_set_option { + __u32 req; /* request id */ + __u32 value; /* value */ + __s32 reserved[6]; +}; + struct fastrpc_ioctl_capability { __u32 unused; /* deprecated, ignored by the kernel */ __u32 attribute_id; --=20 2.34.1