From nobody Thu Apr 2 21:49:47 2026 Received: from mail-dy1-f175.google.com (mail-dy1-f175.google.com [74.125.82.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5777635AC07 for ; Thu, 2 Apr 2026 03:24:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775100271; cv=none; b=YKUN6iHYR6ZrItrxNNY5DGKG9Ty6G6ywBF9/F4J48U/m7OMOWTmq3otRUg05HxvUxSPPSbBeWu330/aAZlGnOHEUgbjj+YNnzVtl41KJ3P+BwFtw/Kafde9lCzyKAlsqPt0CtE5wGyBXTMHkPL8cB9N4P0PxgXk5qK4mmYntRp8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775100271; c=relaxed/simple; bh=A5nBMBkWkafHNY7USWwQbGA1Gg3Rjn8l3CkT7z4RWhQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BPPagICWj/8EMNOyh3HwjshVp6WD+jZDfWsujwMW32w91+4NrcyUOhtYhIVyKSI4X3tVHuXEZfGFDygjwmM6yheAAQV+iLGFxVzCUQXF5ozJu5Dln715ECGYAyno/Fmfy0sZvmaiymGsDrrmy7MnCoy+JzxoaZDdOZS40sXH7Xc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dNAW4O35; arc=none smtp.client-ip=74.125.82.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dNAW4O35" Received: by mail-dy1-f175.google.com with SMTP id 5a478bee46e88-2ba895adfeaso560954eec.0 for ; Wed, 01 Apr 2026 20:24:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775100269; x=1775705069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c2sfsoM3eXXD/i3TYQHRzXUhUiniPGPfrTop9I4lCjo=; b=dNAW4O35mDqpTCwXTOG7pfCw+iGJOU3lcU6WaSTwP0059mhHp3DQPUGswdbzI7JdWh Ez1NX9EH7+xZMUyaIpDqU92AbMbNJhlYG16HfIucU82ZL1XBWUuB/lJhTH0F0vOy2klC roIQaj9WSqoeL5nxmUZ4MeePCkoiCQaEGRpwXCUHWU4ockIvULGOQX7ifyNzCK+WABi+ f93WlZLZszOJvKq6dpr1o4Ixzn9FOkpUW8XK5KC8WOojhDXkNOSArbh2xucKRg1ULJf4 mFMYoTDXT8SnXmjUUWQpOrJSLzFG77kNW6p80YoIxXSne2eb4XEJJLFSo6qq0J8dEtXs HbLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775100270; x=1775705070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=c2sfsoM3eXXD/i3TYQHRzXUhUiniPGPfrTop9I4lCjo=; b=LDq4giyWKPSetvFhMVyEAvi0mW1ZP8Yi742xXQ5Tnrp3rtaQxgvtXVU14IW2cTvpKR PCTpNFfYyfmQZOG2feyi40u+hKRIsezyCxjKDHgEsxQBOo5uzMfcSflw4Def5tlfN/fd XXRJSevs1VssQMUo3+23N0qARswxT5ddC0WcdaOS+sW7NwX2w+i2BFEAIhjGE6wBubVn izaBmumfdJDwnbo8618Q0PndTkDsZbXvXtuT/yPFHvy6bBaec4y8Yxad9X4YooE/muCT PuqCMeSajjLRuKZSC7AxGnVHP46+1Cz/X5IfxbWJtt8WRI2JVMwqAgdiCNFmb54koq1N vO3A== X-Forwarded-Encrypted: i=1; AJvYcCWWjWh8Kete5y4x8xXVCc56CIW5PRGCaeFKV5FOgkHHdO9kfZC+vJAHSd7yLowGKyDp9PRuYvj2Xe1eQZE=@vger.kernel.org X-Gm-Message-State: AOJu0YxRoXnQuGIE7yKJFjCJO5WWP6dKYAujpZHOzFwIDdwrAZ++Rn2H ojQxFRoNRskCHHXKa4XRnXhcvyQBr1WBsl7j2hwljLb1KNu2PyE15wGda6yanA== X-Gm-Gg: ATEYQzyGEaxT5Jn007GXd68srygKykvBRR2posNBNF83MHRSn3qpI8bHp4VQeAH/Csa t0/KjWA+5bdwp4DGZkpMBcu44+GwfErgpISM8hDI+idQpGmuNQhxEFxpOhJKU0en0M8yiXuYoln /A5ZLgV7gKzdT/SxMmvbMpMUj2w3Y6RJcCK+3Q7qklkT7iImTtgAZalgtDd8joOM74Ebhb3drRm P77bTTwozVblc8Psjzk7qR2f+/SnB2X8BiKZcA+XHqQL77P9x9c9LUU5rpZvrWHIzdq0DRo2dij yWotrl4WLUfD9w7yDHtFdwd47HlAA6ZYkazMdQB3ibDUtKm5jWFBRWDnDNsJv6TagdmK2QDDU50 NbNPbsy8/xxTu74XG9gJH8x+VVsotPDBtYnXBV7wtGcxS2xG6zwcQyzcPDdL07B+KaZ+S8HiPez x66xBzQFdvge5m1v+50q0dJDZTpIRf25i2gugGbJo/69tqmWEN3bHvclFY+pPzrW+o+8uHBHUqh OlZ X-Received: by 2002:a05:7300:6413:b0:2c0:dc7e:ed17 with SMTP id 5a478bee46e88-2c93116f5d6mr3146575eec.10.1775100269336; Wed, 01 Apr 2026 20:24:29 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca7cae9e9esm1265981eec.23.2026.04.01.20.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 20:24:29 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v7 03/16] platform/x86: lenovo-wmi-other: Balance component bind and unbind Date: Thu, 2 Apr 2026 03:24:11 +0000 Message-ID: <20260402032424.678528-4-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260402032424.678528-1-derekjohn.clark@gmail.com> References: <20260402032424.678528-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Rong Zhang When lwmi_om_master_bind() fails, the master device's components are left bound, with the aggregate device destroyed due to the failure (found by sashiko.dev [1]). Balance calls to component_bind_all() and component_unbind_all() when an error is propagated to the component framework. No functional change intended. Fixes: edc4b183b794 ("platform/x86: Add Lenovo Other Mode WMI Driver") Cc: stable@vger.kernel.org Link: https://sashiko.dev/#/patchset/20260331181208.421552-1-derekjohn.clar= k%40gmail.com [1] Signed-off-by: Rong Zhang --- drivers/platform/x86/lenovo/wmi-other.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86= /lenovo/wmi-other.c index b47418df099f..4b47b5886e33 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -1068,8 +1068,11 @@ static int lwmi_om_master_bind(struct device *dev) =20 priv->cd00_list =3D binder.cd00_list; priv->cd01_list =3D binder.cd01_list; - if (!priv->cd00_list || !priv->cd01_list) + if (!priv->cd00_list || !priv->cd01_list) { + component_unbind_all(dev, NULL); + return -ENODEV; + } =20 lwmi_om_fan_info_collect_cd00(priv); =20 --=20 2.53.0