From nobody Thu Apr 2 22:05:28 2026 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E65AD35504D for ; Thu, 2 Apr 2026 03:24:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775100270; cv=none; b=sMdcihDKeOx1SoSSyQ/zyglBN4VdzcJcORsO4/Hc+Hvy3YgCa87asp5LdKksXFn7zTQ2jAnNrnB74hPLAac45BbsHoE8KknV0xTMu7QPG1FI9JsA9bcza7PEBi023WQNHMrxactMLUYmCIATa5RHJCWuQq8gRxnKkgcAuQ0l5ps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775100270; c=relaxed/simple; bh=xoAxyd23RUHtYfq932MDE3PcTF7vl72cZnWGDgo18cE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CgIXcX2fYfvJaqmX6p4gu18f8H+6CuN6r/LxgjXYQDmekdMtLcdnem2iUCw2e4FKAv1sp6K9XguhyUn6OVuMLtuvqmCZbXqg07usH5V2yyaSxv4qk06z9c2ynDkwewBtMNP4ohBHO171o4D55YQ24/fNACCPDed+BiqDi/LdeUM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JJNVdau+; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JJNVdau+" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2ca4ff720ccso556376eec.0 for ; Wed, 01 Apr 2026 20:24:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775100268; x=1775705068; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7lNuuLOzmr03xq4m1O8HQgZGp2bHbRJpd3HGUaao6ag=; b=JJNVdau+RMHXLBNoH8a91Zz51IwaIMqy1HBvhcsaDi1TwTREuROK3cMTAXSMcgHHS+ B01dkgpVIpCyxFHFaHmd5igJAYqxNSK2iVYAtV1nuQCbO/WwAJ8xHKizVGBQPJudOsPh a40bEeEEueyekxgzUaMkLSBhbIoOrHIU/+arJbyzdQ8pREScDY3GTU3IJo8Nx9tloyrB Gx+rHr0LidAYM4eWFi5OmVg6r/Yv5zfyDcKYiY8zWB+grCdTERRgLA/lSYAkT4W0rs1z eHWaS5XvXG2A1WF8A3tKLev3R7ywIZZ820/NjFfpvd4CgQhbe+8dnQKArYoh6tNvFcFJ 60lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775100268; x=1775705068; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7lNuuLOzmr03xq4m1O8HQgZGp2bHbRJpd3HGUaao6ag=; b=fgcJuPDgJVtEh5Th1LX4UYhW7TgCEGcBqbeLMSCsTKNivZSdkSW1TIZM7bHhU/OZ7g 2l335sG5PEfe4nRRqGBM3rRcprxpvcpu2z9c8tQTpQWaO5tC0ynUlbYI35/DXRRm+k0E KViBwH2k7UkJx7CHS3g0p6YvZMboKxf60TNedDg+650igve8PX4DQkZylmiTOeka5wUg hMMekHot2B/cdLKPA7gqUpMF53Cie+h+Je77igRubDMDKBPqVFTY5OgpcT4lyUPMimL8 53ukYeNLlhZUvvXYXVi7J8D6d2smqR+NE5iGMXllxA6SrFn+O9HRyJvOKKSqCLm3azQA JIcg== X-Forwarded-Encrypted: i=1; AJvYcCXJdt5Hl+JnXDmUH4uP63T1iQpvFakUXKZlMPK+fPPJ5VtV8TlbfwCpDr2SDs89A6AnO+PximvJCBYXf6k=@vger.kernel.org X-Gm-Message-State: AOJu0YwwVTrcDbD9/+dLWD3FPto4pF+psWsbeRTDwixVepBFOhTrHyiA dyasq9PO3wDp8HwZNZdzXMzKR5gOBCTvxU8XKdsYCvGVF5U6Qo98vsKZ X-Gm-Gg: ATEYQzxEB02TeDmyk1SsOjfQRbpWieXJ7YAuhAD1Y9uPA1aw4e/iH4btmQLmdoLsosM s3lbuGIyW/Xa379cHIFaA0odE9vyk+Do84vTjewSGQCBqBQ58hw6oy5VPwrghaenpbjkOuV/AaG wQMGw80vFW3OH/7d0+IYRK/LmNmiGc/1kxXTwydKHy4K0aaUsmuODygoSHELnknPsU/aBLIesOF k3+H0yN4YoUX+/mTolyJgTObSLTwWXEXctXurSA2TYnt0vhPXa8OraeDPZzdVwlk8SIlmYTi81C 4mphM4RO6A7QEv4JDmRqovy1g3Kz6jkMLjAykpbdVqdZRz3gUtMNXXVp08mXhvCn8wdNCJhbd58 5wPo4nl7m5buiutjYy1OCCqvlW6W9iP25PBNDy0Ap/pZIXvsCG23F61TYXXxD4sPlRL9aNYhLRl 6HSKNhFqZC6EF92nGcHIguC5x+M+DPHSyocfSiEJJ3t2fijCN2AKhNgDM3qtW+PJrpqwhtvW1rc 7VW3yh+KGAOzmE= X-Received: by 2002:a05:7300:a483:b0:2c1:1d6b:1698 with SMTP id 5a478bee46e88-2cad67a8282mr332104eec.5.1775100267985; Wed, 01 Apr 2026 20:24:27 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca7cae9e9esm1265981eec.23.2026.04.01.20.24.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 20:24:27 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v7 01/16] platform/x86: lenovo-wmi-helpers: Fix memory leak in lwmi_dev_evaluate_int() Date: Thu, 2 Apr 2026 03:24:09 +0000 Message-ID: <20260402032424.678528-2-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260402032424.678528-1-derekjohn.clark@gmail.com> References: <20260402032424.678528-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Rong Zhang lwmi_dev_evaluate_int() leaks output.pointer when retval =3D=3D NULL (found by sashiko.dev [1]). Fix it by moving `ret_obj =3D output.pointer' outside of the `if (retval)' block so that it is always freed by the __free cleanup callback. No functional change intended. Fixes: e521d16e76cd ("platform/x86: Add lenovo-wmi-helpers") Cc: stable@vger.kernel.org Link: https://sashiko.dev/#/patchset/20260331181208.421552-1-derekjohn.clar= k%40gmail.com [1] Signed-off-by: Rong Zhang --- drivers/platform/x86/lenovo/wmi-helpers.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/lenovo/wmi-helpers.c b/drivers/platform/x= 86/lenovo/wmi-helpers.c index 7379defac500..80021f59d1ef 100644 --- a/drivers/platform/x86/lenovo/wmi-helpers.c +++ b/drivers/platform/x86/lenovo/wmi-helpers.c @@ -55,8 +55,9 @@ int lwmi_dev_evaluate_int(struct wmi_device *wdev, u8 ins= tance, u32 method_id, if (ACPI_FAILURE(status)) return -EIO; =20 + ret_obj =3D output.pointer; + if (retval) { - ret_obj =3D output.pointer; if (!ret_obj) return -ENODATA; =20 --=20 2.53.0