From nobody Mon Apr 6 10:43:35 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D31E390210 for ; Thu, 2 Apr 2026 09:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775122101; cv=none; b=dyS0wgvSRgRWqe2DYc9S8+OVx1mbgdANqRun5Wfr6RbOZ+XVZUW84SQr7NIE8eZVXIzX+aZCYVuaSxzDmkLfoyzhWxFjyLUyTjSjK3auHJ9nAAqpjLO+A+bJZGsKO6kVtLO5FqJYIQw1zlpIsWnxyajC/CpVF0OL2/nWIUFJ/S4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775122101; c=relaxed/simple; bh=DGkZabpVSfCZx4qVU8GLozjN/+Zh0JyHCyPpQLjan0k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ImsQId4MCwWCAmWamkiZYRMB2PG4NS8cxmgF6CKqdQpqK/sNkH9CoFLmuzhXGvE5gjMSXjr2HvHnw3lbFdJO+O1if++2G3/nDlthnxYYc7ZR9IPKi1NuP50TubH510C2T/x0a8KO2ogesJjsb8p8Gk0KrPhDVnZ/Z1LE6lsmZD8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=bkTvVYUR; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="bkTvVYUR" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 1CC61C5997A; Thu, 2 Apr 2026 09:28:43 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id AD22C5FDEB; Thu, 2 Apr 2026 09:28:11 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id ED5B910450A10; Thu, 2 Apr 2026 11:27:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1775122089; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=2J+9TG/VyHLnCiKQu2dJ+E2QJC0b8CpVuopBw9nld/w=; b=bkTvVYURYUu2zNWtCug8/esLmZziFcEBaT4+fvEoQ1Lf3RKJ1TlfgvYq8SNDRFkAB4xoug 8VnWf32ovVeFb8rSpT/SHhM0ZP2QIcU9a8jiswcpxMXbcKqbvmf3ZYWo9lzUkHpMN7RaC1 uDjKZNdGpTWuatFV0xEJrYONAsgtGcihxZBZRV6YpXdYVDZBkZ7wf38Gz1rWE/2k5vmIqz ljUq8dAR5zL5gzjiBpiyXpXre66fdQXeTiHxnKhLGxObcGNg4kRPYWfDJGNgSz1ZJ8tUaT BXs8nxEJkllMh53B1510PLvNM5F4t6/rw8bk/T2AFDRUESCPO3ZJAl0+6DFz4w== From: Luca Ceresoli Date: Thu, 02 Apr 2026 11:25:57 +0200 Subject: [PATCH v3 02/11] drm/mxsfb/lcdif: simplify ep pointer management using __free Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260402-drm-lcdif-dbanc-v3-2-27cd247a0847@bootlin.com> References: <20260402-drm-lcdif-dbanc-v3-0-27cd247a0847@bootlin.com> In-Reply-To: <20260402-drm-lcdif-dbanc-v3-0-27cd247a0847@bootlin.com> To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Liu Ying , Rob Herring , Saravana Kannan Cc: Damon Ding , "Kory Maincent (TI.com)" , =?utf-8?q?Herv=C3=A9_Codina?= , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adam Ford , Alexander Stein , Christopher Obbard , Daniel Scally , Emanuele Ghidoli , Fabio Estevam , Francesco Dolcini , Frieder Schrempf , Gilles Talis , =?utf-8?q?Goran_Ra=C4=91enovi=C4=87?= , Heiko Schocher , Josua Mayer , Kieran Bingham , Marco Felsch , Martyn Welch , Oleksij Rempel , Peng Fan , Richard Hu , Shengjiu Wang , Stefan Eichenberger , Vitor Soares , Luca Ceresoli X-Mailer: b4 0.15.1 X-Last-TLS-Session-Version: TLSv1.3 Putting the ep device_node reference requires a of_node_put(ep) in many return points. Use a cleanup action to simplify the code. Reviewed-by: Liu Ying Signed-off-by: Luca Ceresoli --- This patch is new in v2 --- drivers/gpu/drm/mxsfb/lcdif_drv.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lcdi= f_drv.c index 7719629487da..8da8a265c05c 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c @@ -49,7 +49,7 @@ static const struct drm_encoder_funcs lcdif_encoder_funcs= =3D { static int lcdif_attach_bridge(struct lcdif_drm_private *lcdif) { struct device *dev =3D lcdif->drm->dev; - struct device_node *ep; + struct device_node *ep __free(device_node) =3D NULL; struct drm_bridge *bridge; int ret; =20 @@ -65,23 +65,19 @@ static int lcdif_attach_bridge(struct lcdif_drm_private= *lcdif) ret =3D of_graph_parse_endpoint(ep, &of_ep); if (ret < 0) { dev_err(dev, "Failed to parse endpoint %pOF\n", ep); - of_node_put(ep); return ret; } =20 bridge =3D devm_drm_of_get_bridge(dev, dev->of_node, 0, of_ep.id); - if (IS_ERR(bridge)) { - of_node_put(ep); + if (IS_ERR(bridge)) return dev_err_probe(dev, PTR_ERR(bridge), "Failed to get bridge for endpoint%u\n", of_ep.id); - } =20 encoder =3D devm_kzalloc(dev, sizeof(*encoder), GFP_KERNEL); if (!encoder) { dev_err(dev, "Failed to allocate encoder for endpoint%u\n", of_ep.id); - of_node_put(ep); return -ENOMEM; } =20 @@ -91,17 +87,14 @@ static int lcdif_attach_bridge(struct lcdif_drm_private= *lcdif) if (ret) { dev_err(dev, "Failed to initialize encoder for endpoint%u: %d\n", of_ep.id, ret); - of_node_put(ep); return ret; } =20 ret =3D drm_bridge_attach(encoder, bridge, NULL, 0); - if (ret) { - of_node_put(ep); + if (ret) return dev_err_probe(dev, ret, "Failed to attach bridge for endpoint%u\n", of_ep.id); - } } =20 return 0; --=20 2.53.0