From nobody Thu Apr 2 20:23:46 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 891C3327C08 for ; Thu, 2 Apr 2026 01:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775093368; cv=none; b=ttbE8EdNnAM/z/tc0WICLWZLDq8S3SnWaOVVCFnPUuyWnAsdvoNFWPmVhxrSJNCDD6UCVxnvsNEcem9luycxRL8sUhK7RmDusF7rtbOEApFNNza38ZR7QOc/XZY9sVziEbeRrwpQWkm/OweEgRz1DlW26jjnctwg1468P4pqgRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775093368; c=relaxed/simple; bh=OGjx/rpqLanYJw8wyMx1GZX57lDgWW7QcL/E9ij2zVU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lh34AsqSxd3Wfmc8qLByjacB3FKrD/jDAcRLsphTL988yQ0U0fbgWOGEW3jjBIhFCSgNTULKhBW7wydaUsLyY6GftgRi/XimaPHnkazamFtaoRGUtT0Xv60d9bJr6du6ENc1yQTHO68cfW0w08NXYwrM8rMH1m0W2QFIAQGHZfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=inventec.com; spf=pass smtp.mailfrom=inventec.com; dkim=pass (2048-bit key) header.d=inventec.com header.i=@inventec.com header.b=ElUlyySR; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=inventec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inventec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=inventec.com header.i=@inventec.com header.b="ElUlyySR" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2b0ba3bfe16so11813575ad.1 for ; Wed, 01 Apr 2026 18:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventec.com; s=google; t=1775093367; x=1775698167; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Z3ThBxdaxluBFioSVhIDwm332ADtoHWnIdue1Mw0j4g=; b=ElUlyySR0d7RbBjdILXAGsXqeR2aFEYn3Bu2DHUvIjEXXr2QNt+Cg8wq9TfspCqRCf TcoVJvfV1sjRKqbzdmgriUi7oj9QyBaKOoZf7Ow1c4h+oSwmUbdfv+in2MHNeA4iyfU7 GYcbqgWLLKDeuT4emTWmQRQ+LoDSWhPZuYH3TDzncXzMtAllCkcGuWEA+xsKYUNgoUAs Axz2HHWBKPn1poG+YXnesGhQo59iGV0rZS+uWVgALNgkLYJaf/HgTkphK4omQ11HmCDa 1i4kmCpIdQde1gMqaFywLeEOWKVi+F99Xg/fczMhQ2eQKuePSZVrPqb++EzqkuGc4I00 RI+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775093367; x=1775698167; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Z3ThBxdaxluBFioSVhIDwm332ADtoHWnIdue1Mw0j4g=; b=SQUZB/sGEV6HgClm50B9XM1uKlVKTStZLEKCQqSl3r4t6bN0sJFRYPobVc24UhQ33U HDsRvEfX2pJ+RRbI8T9FeVMu5+n3+LIEndEETJ6iljPWZtKGMPfA77xmibNeXwfolnuU Np2Hspt8U8wjwes1HfDNFCIezhelB1EWw/4lsm5vbZEKWnZukXbDr2CNbxuNuazfVytQ 82X7b+K34KqnWPzSRbXBtfKbIyOTMgzXHp53LTl1W00+ME4LERtzE5CfFd7aQe32nuv1 XcRmaYLtzPpZOd5lZUMIZsr4Mgok16Mht3Mvt0L/CTL08fydeTvDvMZ4bk+RBY0HlU8P 6bLg== X-Forwarded-Encrypted: i=1; AJvYcCWPr95lvWhi4/7dJZI4bTo2J8V/FD9TWKyhQCRUEvEb7L2l81U1iKq3wIOhKJ+llJVMmkGTvY80Or3xpAY=@vger.kernel.org X-Gm-Message-State: AOJu0YxvoFUpFPJSPanTRewudmRTlrfR1skB1Wvan6W49IgJ5VojVHLO aVHb5/V5FniBSPckkk1ECSpNcxd3vzNtKUh8tZ3TonrsBz+uqmKMKTJCSLcrhCa+yqVD0kEL7sU +jX/B X-Gm-Gg: ATEYQzw1tts+r/dKvrHVZJN9mb9BL6xuSj8ZQbSz3HNQhvw3pJYJ1rdcYAbOU36TKmw AP3XH1RUVoSbTmy8GBgfVPrdx84xee3Q8LpD+fCL9UZgDS4m9/EZh77NnGtv/h0EKQ/7F+dsCaL zy3/gcDYVn4GhfaEYRPzD5rDIp0bkwuYRvNJ4uwO4VonG0LFPm/PCQ5xfm+Bbt2x8CMfZ9cpc6A pgol+nYWxkOXB6GRMecuDUxUvn4GyOsXpPXO0gTMEyDnnb8hf80BuW0nxC4XcO1BMjnQ28NHy0o u6HBUryPOfAT+ycofFxd+vTif8lngVghGDUeunuxeSffYwyOH+yJIXsrZ7B07U3VXFKUpkPzsZ1 8H9nInTbSHoluAXAeI3Jcf+ODew1OQdtP5qb9xhlMroT7FANudcTNR1NYTQSFiAJTGPsEXMfTro +E1YIYdWKHD9rM+C4oKd8X96OseTnoRx0mwk+lKN0G X-Received: by 2002:a17:903:388e:b0:2b0:4c68:283f with SMTP id d9443c01a7336-2b277d8bf91mr5015175ad.5.1775093366906; Wed, 01 Apr 2026 18:29:26 -0700 (PDT) Received: from [127.0.1.1] ([123.51.235.216]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af47sm12045755ad.42.2026.04.01.18.29.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 18:29:26 -0700 (PDT) From: Brian Chiang Date: Thu, 02 Apr 2026 01:29:16 +0000 Subject: [PATCH v3 1/2] dt-bindings: trivial: Add q50sn12072 and q54sn120a1 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260402-add-support-for-q50sn12072-and-q54sn120a1-v3-1-67a5184e93b8@inventec.com> References: <20260402-add-support-for-q50sn12072-and-q54sn120a1-v3-0-67a5184e93b8@inventec.com> In-Reply-To: <20260402-add-support-for-q50sn12072-and-q54sn120a1-v3-0-67a5184e93b8@inventec.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Jack Cheng , Brian Chiang , Jack Cheng X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775093362; l=1150; i=chiang.brian@inventec.com; s=20260316; h=from:subject:message-id; bh=371ndBFO++Ux/UDUOyIuv35ZzqLJAZsYGZPm32hIp6Q=; b=+1TERg8IgQlcSbA/nW1hjD0FwzdV88At/ivwWfOE6Bj4sS8nJhuH6GgNrr+ekwh+voiUG6Onz caThKMgHusLDCXixwXWJgy+N3URTSjyi1SNHJJchSuEvmUEbPyzwwim X-Developer-Key: i=chiang.brian@inventec.com; a=ed25519; pk=q+NqJYuJbGpA9KS9941D7f+8PVVW+k7DvaGgFykBiUc= From: Jack Cheng Add support for the Delta Electronics q50sn12072 and q54sn120a1 1/4 Brick DC/DC Regulated Power Modules. Signed-off-by: Jack Cheng Acked-by: Rob Herring (Arm) --- Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Docum= entation/devicetree/bindings/trivial-devices.yaml index a482aeadcd44..d4b78154df82 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -96,7 +96,11 @@ properties: # Delta Electronics DPS920AB 920W 54V Power Supply - delta,dps920ab # 1/4 Brick DC/DC Regulated Power Module + - delta,q50sn12072 + # 1/4 Brick DC/DC Regulated Power Module - delta,q54sj108a2 + # 1/4 Brick DC/DC Regulated Power Module + - delta,q54sn120a1 # Devantech SRF02 ultrasonic ranger in I2C mode - devantech,srf02 # Devantech SRF08 ultrasonic ranger --=20 2.43.0 From nobody Thu Apr 2 20:23:46 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA255333442 for ; Thu, 2 Apr 2026 01:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775093371; cv=none; b=u9sYoTEvi1QXwtnY2N4yWXZh6Uz9TpIxPVJkvT3rC7o3EhDWfgw1yxmWVM6BN0z5loeuf8RlxiyEuk6qV+pc5QHOBGCvBfrYq4YJo6lWVvZcoLFCM07VIgBkWbvKYPfe9biPTYPiY7GZSCwfX9ATeOubDHe+7yAoT5juYdS3csA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775093371; c=relaxed/simple; bh=CsfW3BwwYGLnUZ+e/OghcBhl2NSqpFnhwKam8gfIPzY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J9ros1dcrlX0V3rArwnxHEMdn+l1GbVcBRr/ewPjyNfOr5jtebiXdUBN3O+ZZ8r0PIP9dFWtt5cjLq7h+5aQNZF4Uu0B9KxGpJz9H7FcFnCnNf1KtkXkBauKa50RTU7sevht/ZetlQuXiLwUxu0AAtFINKQIZ5bDQZCaZuvtYJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=inventec.com; spf=pass smtp.mailfrom=inventec.com; dkim=pass (2048-bit key) header.d=inventec.com header.i=@inventec.com header.b=VMVCRfTk; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=inventec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=inventec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=inventec.com header.i=@inventec.com header.b="VMVCRfTk" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2ad9516a653so1279965ad.0 for ; Wed, 01 Apr 2026 18:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventec.com; s=google; t=1775093369; x=1775698169; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VUZAjJRP4sO1PB3+dGNH9Uy0ZMDh1NqY84nowwFaq5k=; b=VMVCRfTkBP5+Gh1OMisilk55iKKqL9FB4MciFyNfq9rJIFaqe3Wr2z4Sn6Zju9oeuk F6P0aWosmmwvanNHfDr/rbfPjZYDL5sHmjzCz8u9yPlqDNG4M+m3JsJvO0igt3DeCNcq 1X6QzVTPNXsZz3uuaEJkJcIR493m9RdsQ5hWk7caaW+QGISVt+ZyvJ0VS32/qL4KMbEI 6uAeNAasYxdBfimM4Ounv1tQTa4YDvog0E+3NdGUS2mL+EuFcJGy+sM3tTjhYglsL3Fb ++jLNY86iOJJvuyhEozV8dNUpURoyffJ9QchodvBrUPXg4rIto6J4N46qTRFSWQ6Qo7K oTGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775093369; x=1775698169; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VUZAjJRP4sO1PB3+dGNH9Uy0ZMDh1NqY84nowwFaq5k=; b=UyVrJF+iyEZQru0iEKAzZibNHJ8YoJ95b9x/7nWC8OJavU+j0FH4yD19LtzGvo+sB6 3BNrJLiLnbV54HkVamLGjjKIPIcQQ2pbOkzBTdtyPa59GHazUZ/qsY1ooXuE1ONKNtwk e1Q/kz51xtmMWv3DKvTI4XPMhwgPb142C8ivo1ShVj7/BJCRAOlAPFgLoz83NT3ST7DW qnZUWDj3NsPkWyeKEz6EbEZm6prblKTCp4CFgdAMqQpf0nK+nQvG3kKY+ekhMbBtEhgq fBIGWj96jQlMpiZqRT7VmaexM+wjjW4b4ACpcWMccrXXx7TkfspuIzCOAN7mT+OvSI93 st5w== X-Forwarded-Encrypted: i=1; AJvYcCUuK6bes5lcU/VKprkYOFOP1EmUpDAvLhJlpaEuuSvVxNzxOKSOoL3Hp0edLyapsEOrdeOiq4gq4PlGG/U=@vger.kernel.org X-Gm-Message-State: AOJu0YzWNlPBpFbvMzF4KK1Y/glfh2OWyI3lrr1gK/nCYE8xRFuqtO+h ovd+PYkHL83XZJXfmMwnDd3OoLT6xXUk6RDxABRJCdw/8fNPpyjedGTpdWYPvKhBA2o= X-Gm-Gg: ATEYQzyd2vYnsvA8sbAeHWXaPvzi0QJ5hG1OY2xO6ZITYip88rT/gQ102VFcxWv0Rmn 9eqaTxZ6DHxg+xIopYvHoLxIp6fDo1FTukgZ234GbRsWX8NqWKKJWBFvMxkTAI8s8UQ/CCDI1Dt cSXXORQR1abCLhK8NZn+YU36jwiT6XMfQc4qIwocgzl3vuFIM1Uh+0HWfnXdAHTJOxb3fi94lsq g4Gxfspotyp0opHoQO550cnfMkIoaua0GE1NHmAG3euTB/zLyyBHC2mJPs7pIkHGU7fb02vZK6g O+qkt7JxTD6poIBn3A2JXnUKMVUVEiexUpPDu8lmSm6EGJIXbWZuaqFiaX43F4BPrxB51uQF+8L S4Lx0YrS6Rh0ZXZRcrOPgkmaDaKkmJtww0JF/mZ2IyYpBG6aGR3Cg5BRqY6aFZk3FPXiB9vR6xs IFTrxV5RQLkXfssfUmUZyEjTR00Plfxg== X-Received: by 2002:a17:903:3c4c:b0:2ae:826f:2c50 with SMTP id d9443c01a7336-2b269aa6173mr56537015ad.12.1775093369367; Wed, 01 Apr 2026 18:29:29 -0700 (PDT) Received: from [127.0.1.1] ([123.51.235.216]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b27497af47sm12045755ad.42.2026.04.01.18.29.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 18:29:28 -0700 (PDT) From: Brian Chiang Date: Thu, 02 Apr 2026 01:29:17 +0000 Subject: [PATCH v3 2/2] hwmon: (pmbus/q54sj108a2) Add support for q50sn12072 and q54sn120a1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260402-add-support-for-q50sn12072-and-q54sn120a1-v3-2-67a5184e93b8@inventec.com> References: <20260402-add-support-for-q50sn12072-and-q54sn120a1-v3-0-67a5184e93b8@inventec.com> In-Reply-To: <20260402-add-support-for-q50sn12072-and-q54sn120a1-v3-0-67a5184e93b8@inventec.com> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, Jack Cheng , Brian Chiang , Jack Cheng X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775093362; l=8310; i=chiang.brian@inventec.com; s=20260316; h=from:subject:message-id; bh=S4/XsmyGUDzrdBSYUibIUvc4yRKoXHPodJLnp1gi6gI=; b=XXABQe9Ik68zUyFy4X347/0ziN/VxdgAdGAykowqQUpLfGieefKbQedyUZ9LU6dwGfUqhbTWf l9Si6WFL+mNBPGqoMzAXTpjRGcYSIbHpD1rb8klKSexxKyTyET8B5bK X-Developer-Key: i=chiang.brian@inventec.com; a=ed25519; pk=q+NqJYuJbGpA9KS9941D7f+8PVVW+k7DvaGgFykBiUc= From: Jack Cheng The Q50SN12072 and Q54SN120A1 are high-efficiency, high-density DC-DC power module from Delta Power Modules. The Q50SN12072, quarter brick, single output 12V. This product provides up to 1200 watts of output power at 38~60V. The Q50SN12072 offers peak efficiency up to 98.3%@54Vin. The Q54SN120A1, quarter brick, single output 12V. This product provides up to 1300 watts of output power at 40~60V. The Q54SN120A1 offers peak efficiency up to 98.1%@54Vin. Add support for them to q54sj108a2 driver. Signed-off-by: Jack Cheng Co-developed-by: Brian Chiang Signed-off-by: Brian Chiang --- drivers/hwmon/pmbus/q54sj108a2.c | 103 +++++++++++++++++++++++++++--------= ---- 1 file changed, 71 insertions(+), 32 deletions(-) diff --git a/drivers/hwmon/pmbus/q54sj108a2.c b/drivers/hwmon/pmbus/q54sj10= 8a2.c index d5d60a9af8c5..ba55fc993d97 100644 --- a/drivers/hwmon/pmbus/q54sj108a2.c +++ b/drivers/hwmon/pmbus/q54sj108a2.c @@ -22,7 +22,9 @@ #define PMBUS_FLASH_KEY_WRITE 0xEC =20 enum chips { - q54sj108a2 + q50sn12072, + q54sj108a2, + q54sn120a1 }; =20 enum { @@ -55,10 +57,24 @@ struct q54sj108a2_data { #define to_psu(x, y) container_of((x), struct q54sj108a2_data, debugfs_ent= ries[(y)]) =20 static struct pmbus_driver_info q54sj108a2_info[] =3D { - [q54sj108a2] =3D { + [q50sn12072] =3D { .pages =3D 1, + /* Source : Delta Q50SN12072 */ + .format[PSC_VOLTAGE_OUT] =3D linear, + .format[PSC_TEMPERATURE] =3D linear, + .format[PSC_VOLTAGE_IN] =3D linear, + .format[PSC_CURRENT_OUT] =3D linear, =20 + .func[0] =3D PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | + PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | + PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP | + PMBUS_HAVE_STATUS_INPUT | PMBUS_HAVE_POUT, + }, + [q54sj108a2] =3D { + .pages =3D 1, /* Source : Delta Q54SJ108A2 */ + .format[PSC_VOLTAGE_OUT] =3D linear, .format[PSC_TEMPERATURE] =3D linear, .format[PSC_VOLTAGE_IN] =3D linear, .format[PSC_CURRENT_OUT] =3D linear, @@ -69,6 +85,20 @@ static struct pmbus_driver_info q54sj108a2_info[] =3D { PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP | PMBUS_HAVE_STATUS_INPUT, }, + [q54sn120a1] =3D { + .pages =3D 1, + /* Source : Delta Q54SN120A1 */ + .format[PSC_VOLTAGE_OUT] =3D linear, + .format[PSC_TEMPERATURE] =3D linear, + .format[PSC_VOLTAGE_IN] =3D linear, + .format[PSC_CURRENT_OUT] =3D linear, + + .func[0] =3D PMBUS_HAVE_VIN | PMBUS_HAVE_IIN | PMBUS_HAVE_PIN | + PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | + PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | + PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP | + PMBUS_HAVE_STATUS_INPUT | PMBUS_HAVE_POUT, + }, }; =20 static ssize_t q54sj108a2_debugfs_read(struct file *file, char __user *buf, @@ -270,7 +300,9 @@ static const struct file_operations q54sj108a2_fops =3D= { }; =20 static const struct i2c_device_id q54sj108a2_id[] =3D { + { "q50sn12072", q50sn12072 }, { "q54sj108a2", q54sj108a2 }, + { "q54sn120a1", q54sn120a1 }, { }, }; =20 @@ -280,6 +312,7 @@ static int q54sj108a2_probe(struct i2c_client *client) { struct device *dev =3D &client->dev; u8 buf[I2C_SMBUS_BLOCK_MAX + 1]; + const struct i2c_device_id *mid; enum chips chip_id; int ret, i; struct dentry *debugfs; @@ -292,14 +325,9 @@ static int q54sj108a2_probe(struct i2c_client *client) I2C_FUNC_SMBUS_BLOCK_DATA)) return -ENODEV; =20 - if (client->dev.of_node) - chip_id =3D (enum chips)(unsigned long)of_device_get_match_data(dev); - else - chip_id =3D i2c_match_id(q54sj108a2_id, client)->driver_data; - ret =3D i2c_smbus_read_block_data(client, PMBUS_MFR_ID, buf); if (ret < 0) { - dev_err(&client->dev, "Failed to read Manufacturer ID\n"); + dev_err(dev, "Failed to read Manufacturer ID\n"); return ret; } if (ret !=3D 6 || strncmp(buf, "DELTA", 5)) { @@ -308,19 +336,25 @@ static int q54sj108a2_probe(struct i2c_client *client) return -ENODEV; } =20 - /* - * The chips support reading PMBUS_MFR_MODEL. - */ ret =3D i2c_smbus_read_block_data(client, PMBUS_MFR_MODEL, buf); if (ret < 0) { dev_err(dev, "Failed to read Manufacturer Model\n"); return ret; } - if (ret !=3D 14 || strncmp(buf, "Q54SJ108A2", 10)) { + for (mid =3D q54sj108a2_id; mid->name[0]; mid++) { + if (!strncasecmp(mid->name, buf, strlen(mid->name))) + break; + } + if (!mid->name[0]) { buf[ret] =3D '\0'; dev_err(dev, "Unsupported Manufacturer Model '%s'\n", buf); return -ENODEV; } + chip_id =3D mid->driver_data; + + if (strcmp(client->name, mid->name) !=3D 0) + dev_notice(dev, "Device mismatch: Configured %s, detected %s\n", + client->name, mid->name); =20 ret =3D i2c_smbus_read_block_data(client, PMBUS_MFR_REVISION, buf); if (ret < 0) { @@ -341,6 +375,7 @@ static int q54sj108a2_probe(struct i2c_client *client) if (!psu) return 0; =20 + psu->chip =3D chip_id; psu->client =3D client; =20 debugfs =3D pmbus_get_debugfs_dir(client); @@ -359,9 +394,6 @@ static int q54sj108a2_probe(struct i2c_client *client) debugfs_create_file("write_protect", 0444, q54sj108a2_dir, &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_WRITEPROTECT], &q54sj108a2_fops); - debugfs_create_file("store_default", 0200, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_STOREDEFAULT], - &q54sj108a2_fops); debugfs_create_file("vo_ov_response", 0644, q54sj108a2_dir, &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_VOOV_RESPONSE], &q54sj108a2_fops); @@ -383,27 +415,34 @@ static int q54sj108a2_probe(struct i2c_client *client) debugfs_create_file("mfr_location", 0444, q54sj108a2_dir, &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_MFR_LOCATION], &q54sj108a2_fops); - debugfs_create_file("blackbox_erase", 0200, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_ERASE], - &q54sj108a2_fops); - debugfs_create_file("blackbox_read_offset", 0444, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_READ_OFFSET], - &q54sj108a2_fops); - debugfs_create_file("blackbox_set_offset", 0200, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_SET_OFFSET], - &q54sj108a2_fops); - debugfs_create_file("blackbox_read", 0444, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_READ], - &q54sj108a2_fops); - debugfs_create_file("flash_key", 0444, q54sj108a2_dir, - &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_FLASH_KEY], - &q54sj108a2_fops); + if (psu->chip =3D=3D q54sj108a2) { + debugfs_create_file("store_default", 0200, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_STOREDEFAULT], + &q54sj108a2_fops); + debugfs_create_file("blackbox_erase", 0200, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_ERASE], + &q54sj108a2_fops); + debugfs_create_file("blackbox_read_offset", 0444, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_READ_OFFSET], + &q54sj108a2_fops); + debugfs_create_file("blackbox_read", 0444, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_READ], + &q54sj108a2_fops); + debugfs_create_file("blackbox_set_offset", 0200, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_BLACKBOX_SET_OFFSET], + &q54sj108a2_fops); + debugfs_create_file("flash_key", 0444, q54sj108a2_dir, + &psu->debugfs_entries[Q54SJ108A2_DEBUGFS_FLASH_KEY], + &q54sj108a2_fops); + } =20 return 0; } =20 static const struct of_device_id q54sj108a2_of_match[] =3D { - { .compatible =3D "delta,q54sj108a2", .data =3D (void *)q54sj108a2 }, + { .compatible =3D "delta,q50sn12072" }, + { .compatible =3D "delta,q54sj108a2" }, + { .compatible =3D "delta,q54sn120a1" }, { }, }; =20 @@ -421,6 +460,6 @@ static struct i2c_driver q54sj108a2_driver =3D { module_i2c_driver(q54sj108a2_driver); =20 MODULE_AUTHOR("Xiao.Ma "); -MODULE_DESCRIPTION("PMBus driver for Delta Q54SJ108A2 series modules"); +MODULE_DESCRIPTION("PMBus driver for Delta Q54SJ108A2 and compatibles"); MODULE_LICENSE("GPL"); MODULE_IMPORT_NS("PMBUS"); --=20 2.43.0